[jira] [Commented] (SLING-3661) ftp server should support resumable file uploads
[ https://issues.apache.org/jira/browse/SLING-3661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14044010#comment-14044010 ] Felix Meschberger commented on SLING-3661: -- [~amitgupt], [~alexander.klimetschek] I think we cannot and probably should reuse the chunked upload stuff. This case is much simpler in that essentially a restart just appends to what's already there. The only safety net here is that the retry specifies the offset and we verify that the offset is the same as the existing file size. If this number does not match, the retry fails. ftp server should support resumable file uploads Key: SLING-3661 URL: https://issues.apache.org/jira/browse/SLING-3661 Project: Sling Issue Type: Improvement Components: Extensions Reporter: Amrit Verma Assignee: Felix Meschberger Fix For: FTP Server 1.0.0 Attachments: SLING-3661-fmeschbe.patch, resumeUploadDiff.txt The ftp server should support resuming file uploads. Steps: 1. Connect to ftp server and start file upload. 2. Terminate file upload in the middle. 3. Try resuming the upload. Issue: The server sends 551 error code. It only supports overwriting the existing file. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (SLING-3661) ftp server should support resumable file uploads
[ https://issues.apache.org/jira/browse/SLING-3661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14044216#comment-14044216 ] Alexander Klimetschek commented on SLING-3661: -- Gotcha, makes sense. ftp server should support resumable file uploads Key: SLING-3661 URL: https://issues.apache.org/jira/browse/SLING-3661 Project: Sling Issue Type: Improvement Components: Extensions Reporter: Amrit Verma Assignee: Felix Meschberger Fix For: FTP Server 1.0.0 Attachments: SLING-3661-fmeschbe.patch, resumeUploadDiff.txt The ftp server should support resuming file uploads. Steps: 1. Connect to ftp server and start file upload. 2. Terminate file upload in the middle. 3. Try resuming the upload. Issue: The server sends 551 error code. It only supports overwriting the existing file. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (SLING-3661) ftp server should support resumable file uploads
[ https://issues.apache.org/jira/browse/SLING-3661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14033692#comment-14033692 ] Amit Gupta commented on SLING-3661: --- How does that supposed to work, FTP STORE, RESTART commands (http://www.w3.org/Protocols/rfc959/4_FileTransfer.html) dont support the spec https://cwiki.apache.org/confluence/display/SLING/Chunked+File+Upload+Support So, I am not sure if it can use the same. In case of FTP, it is not known in advance that it is a chunked upload, so temporary chunk content creation is not possible IMO ftp server should support resumable file uploads Key: SLING-3661 URL: https://issues.apache.org/jira/browse/SLING-3661 Project: Sling Issue Type: Improvement Components: Extensions Reporter: Amrit Verma Attachments: resumeUploadDiff.txt The ftp server should support resuming file uploads. Steps: 1. Connect to ftp server and start file upload. 2. Terminate file upload in the middle. 3. Try resuming the upload. Issue: The server sends 551 error code. It only supports overwriting the existing file. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (SLING-3661) ftp server should support resumable file uploads
[ https://issues.apache.org/jira/browse/SLING-3661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14034197#comment-14034197 ] Alexander Klimetschek commented on SLING-3661: -- Hmm, ok, but the sling chunked file support should also be aware of suddenly stopping/disconnected requests. If you expect them, you have to write into a temporary content structure that you can later update. ftp server should support resumable file uploads Key: SLING-3661 URL: https://issues.apache.org/jira/browse/SLING-3661 Project: Sling Issue Type: Improvement Components: Extensions Reporter: Amrit Verma Attachments: resumeUploadDiff.txt The ftp server should support resuming file uploads. Steps: 1. Connect to ftp server and start file upload. 2. Terminate file upload in the middle. 3. Try resuming the upload. Issue: The server sends 551 error code. It only supports overwriting the existing file. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (SLING-3661) ftp server should support resumable file uploads
[ https://issues.apache.org/jira/browse/SLING-3661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14032901#comment-14032901 ] Alexander Klimetschek commented on SLING-3661: -- There already is a chunked upload implementation for the sling POST servlet, it should reuse the same mechanism and (temporary) chunk content structure. SLING-2707 and SLING-3036 ftp server should support resumable file uploads Key: SLING-3661 URL: https://issues.apache.org/jira/browse/SLING-3661 Project: Sling Issue Type: Improvement Components: Extensions Reporter: Amrit Verma Attachments: resumeUploadDiff.txt The ftp server should support resuming file uploads. Steps: 1. Connect to ftp server and start file upload. 2. Terminate file upload in the middle. 3. Try resuming the upload. Issue: The server sends 551 error code. It only supports overwriting the existing file. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (SLING-3661) ftp server should support resumable file uploads
[ https://issues.apache.org/jira/browse/SLING-3661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14029068#comment-14029068 ] Amrit Verma commented on SLING-3661: One way to solve this could be to merge the input streams from existing node (which contains partial content) and from client (which contains new data) and write the data into new file. After that we could read data from new file, put it back to old file and delete the new file. Attached a patch for this approach. ftp server should support resumable file uploads Key: SLING-3661 URL: https://issues.apache.org/jira/browse/SLING-3661 Project: Sling Issue Type: Improvement Components: Extensions Reporter: Amrit Verma Attachments: resumeUploadDiff.txt The ftp server should support resuming file uploads. Steps: 1. Connect to ftp server and start file upload. 2. Terminate file upload in the middle. 3. Try resuming the upload. Issue: The server sends 551 error code. It only supports overwriting the existing file. -- This message was sent by Atlassian JIRA (v6.2#6252)
