[jira] [Commented] (SLING-4207) Add notifications upon tenant changes
[
https://issues.apache.org/jira/browse/SLING-4207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15764328#comment-15764328
]
Timothee Maret commented on SLING-4207:
---
[~fmeschbe] I suggest we close this issue to {{Later}}. wdyt ?
> Add notifications upon tenant changes
> -
>
> Key: SLING-4207
> URL: https://issues.apache.org/jira/browse/SLING-4207
> Project: Sling
> Issue Type: Improvement
> Components: Extensions
>Affects Versions: Tenant 1.0.2
>Reporter: Timothee Maret
>Assignee: Felix Meschberger
> Fix For: Tenant 1.1.0
>
> Attachments: SLING-4207.patch, SLING-4207.patch, SLING-4207.patch
>
>
> Currently, there is no clean way to detect when a tenant has been
> added/removed/modified.
> We may detect when a change is required by implementing the TenantCustomizer
> interface, however, it tells nothing about the actual completion of the
> change.
> We may listen for OSGI events under /etc/tenants but this requires the user
> to know where the tenants are located (which afaik, currently is not exposed).
> In order to allow apps reacting on tenant changes, I propose to either:
> I. extend the current SPI with an interface TenantEventListener that users
> can implement ; or
> II. send OSGI events form the current implementation.
> In both cases, the events should cover
> * Tenant added
> * Tenant removed
> * Property added
> * Property removed
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (SLING-4207) Add notifications upon tenant changes
[ https://issues.apache.org/jira/browse/SLING-4207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14231443#comment-14231443 ] Timothee Maret commented on SLING-4207: --- Attaching a new patch, taking into account [~fmeschbe] suggestions on the list and pre-patch. Add notifications upon tenant changes - Key: SLING-4207 URL: https://issues.apache.org/jira/browse/SLING-4207 Project: Sling Issue Type: Improvement Components: Extensions Affects Versions: Tenant 1.0.2 Reporter: Timothee Maret Assignee: Felix Meschberger Fix For: Tenant 1.0.4 Attachments: SLING-4207.patch, SLING-4207.patch, SLING-4207.patch Currently, there is no clean way to detect when a tenant has been added/removed/modified. We may detect when a change is required by implementing the TenantCustomizer interface, however, it tells nothing about the actual completion of the change. We may listen for OSGI events under /etc/tenants but this requires the user to know where the tenants are located (which afaik, currently is not exposed). In order to allow apps reacting on tenant changes, I propose to either: I. extend the current SPI with an interface TenantEventListener that users can implement ; or II. send OSGI events form the current implementation. In both cases, the events should cover * Tenant added * Tenant removed * Property added * Property removed -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (SLING-4207) Add notifications upon tenant changes
[ https://issues.apache.org/jira/browse/SLING-4207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14228340#comment-14228340 ] Felix Meschberger commented on SLING-4207: -- A note to bug handlers: As discussed on the list (http://markmail.org/thread/xv7mlkcn4k6wxca3) we should be using OSGi Events and not build yet another listener handling and message passing mechanism. Add notifications upon tenant changes - Key: SLING-4207 URL: https://issues.apache.org/jira/browse/SLING-4207 Project: Sling Issue Type: Improvement Components: Extensions Affects Versions: Tenant 1.0.2 Reporter: Timothee Maret Fix For: Tenant 1.0.4 Attachments: SLING-4207.patch Currently, there is no clean way to detect when a tenant has been added/removed/modified. We may detect when a change is required by implementing the TenantCustomizer interface, however, it tells nothing about the actual completion of the change. We may listen for OSGI events under /etc/tenants but this requires the user to know where the tenants are located (which afaik, currently is not exposed). In order to allow apps reacting on tenant changes, I propose to either: I. extend the current SPI with an interface TenantEventListener that users can implement ; or II. send OSGI events form the current implementation. In both cases, the events should cover * Tenant added * Tenant removed * Property added * Property removed -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (SLING-4207) Add notifications upon tenant changes
[ https://issues.apache.org/jira/browse/SLING-4207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14228365#comment-14228365 ] ASF GitHub Bot commented on SLING-4207: --- GitHub user tmaret opened a pull request: https://github.com/apache/sling/pull/50 SLING-4207 - Add notifications upon tenant changes * Add API TenantConstants that defines the string constants to process the events. * Send events when tenant is added/removed or tenant properties are set/removed from the implementation * Increase minor package version You can merge this pull request into a Git repository by running: $ git pull https://github.com/tmaret/sling SLING-4184-events Alternatively you can review and apply these changes as the patch at: https://github.com/apache/sling/pull/50.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #50 commit d1fe265d6446594f5fbc6890eebc810cbd6b055e Author: tmaret tma...@adobe.com Date: 2014-11-28T16:06:53Z SLING-4207 - Add notifications upon tenant changes * Add API TenantConstants that defines the string constants to process the events. * Send events when tenant is added/removed or tenant properties are set/removed from the implementation * Increase minor package version Add notifications upon tenant changes - Key: SLING-4207 URL: https://issues.apache.org/jira/browse/SLING-4207 Project: Sling Issue Type: Improvement Components: Extensions Affects Versions: Tenant 1.0.2 Reporter: Timothee Maret Fix For: Tenant 1.0.4 Attachments: SLING-4207.patch Currently, there is no clean way to detect when a tenant has been added/removed/modified. We may detect when a change is required by implementing the TenantCustomizer interface, however, it tells nothing about the actual completion of the change. We may listen for OSGI events under /etc/tenants but this requires the user to know where the tenants are located (which afaik, currently is not exposed). In order to allow apps reacting on tenant changes, I propose to either: I. extend the current SPI with an interface TenantEventListener that users can implement ; or II. send OSGI events form the current implementation. In both cases, the events should cover * Tenant added * Tenant removed * Property added * Property removed -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (SLING-4207) Add notifications upon tenant changes
[ https://issues.apache.org/jira/browse/SLING-4207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14228368#comment-14228368 ] Timothee Maret commented on SLING-4207: --- Thanks [~fmeschbe], as discussed I opened a new PR with the event approach, see https://github.com/apache/sling/pull/50 patch at https://github.com/apache/sling/pull/50.diff The patch introduces the TenantConstants API that contains the list of event relevant strings. I put it here and not in SlingConstants since the tenant support seems to be optional (in extensions). Add notifications upon tenant changes - Key: SLING-4207 URL: https://issues.apache.org/jira/browse/SLING-4207 Project: Sling Issue Type: Improvement Components: Extensions Affects Versions: Tenant 1.0.2 Reporter: Timothee Maret Fix For: Tenant 1.0.4 Attachments: SLING-4207.patch Currently, there is no clean way to detect when a tenant has been added/removed/modified. We may detect when a change is required by implementing the TenantCustomizer interface, however, it tells nothing about the actual completion of the change. We may listen for OSGI events under /etc/tenants but this requires the user to know where the tenants are located (which afaik, currently is not exposed). In order to allow apps reacting on tenant changes, I propose to either: I. extend the current SPI with an interface TenantEventListener that users can implement ; or II. send OSGI events form the current implementation. In both cases, the events should cover * Tenant added * Tenant removed * Property added * Property removed -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (SLING-4207) Add notifications upon tenant changes
[ https://issues.apache.org/jira/browse/SLING-4207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14228369#comment-14228369 ] ASF GitHub Bot commented on SLING-4207: --- Github user tmaret closed the pull request at: https://github.com/apache/sling/pull/49 Add notifications upon tenant changes - Key: SLING-4207 URL: https://issues.apache.org/jira/browse/SLING-4207 Project: Sling Issue Type: Improvement Components: Extensions Affects Versions: Tenant 1.0.2 Reporter: Timothee Maret Fix For: Tenant 1.0.4 Attachments: SLING-4207.patch Currently, there is no clean way to detect when a tenant has been added/removed/modified. We may detect when a change is required by implementing the TenantCustomizer interface, however, it tells nothing about the actual completion of the change. We may listen for OSGI events under /etc/tenants but this requires the user to know where the tenants are located (which afaik, currently is not exposed). In order to allow apps reacting on tenant changes, I propose to either: I. extend the current SPI with an interface TenantEventListener that users can implement ; or II. send OSGI events form the current implementation. In both cases, the events should cover * Tenant added * Tenant removed * Property added * Property removed -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (SLING-4207) Add notifications upon tenant changes
[ https://issues.apache.org/jira/browse/SLING-4207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14227924#comment-14227924 ] ASF GitHub Bot commented on SLING-4207: --- GitHub user tmaret opened a pull request: https://github.com/apache/sling/pull/49 SLING-4207 - Add notifications upon tenant changes * Add API TenantEventListener that contains the methods invoked in case a tenant is added/removed or tenant properties are set/removed * Support the TenantEventListener API in the implementation * Increase minor package version You can merge this pull request into a Git repository by running: $ git pull https://github.com/tmaret/sling SLING-4207 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/sling/pull/49.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #49 commit e7927dea10d1754a80da062e4c8969a1a80b7594 Author: tmaret tma...@adobe.com Date: 2014-11-27T19:29:29Z SLING-4207 - Add notifications upon tenant changes * Add API TenantEventListener that contains the methods invoked in case a tenant is added/removed or tenant properties are set/removed * Support the TenantEventListener API in the implementation * Increase minor package version Add notifications upon tenant changes - Key: SLING-4207 URL: https://issues.apache.org/jira/browse/SLING-4207 Project: Sling Issue Type: Improvement Components: Extensions Affects Versions: Tenant 1.0.2 Reporter: Timothee Maret Fix For: Tenant 1.0.4 Currently, there is no clean way to detect when a tenant has been added/removed/modified. We may detect when a change is required by implementing the TenantCustomizer interface, however, it tells nothing about the actual completion of the change. We may listen for OSGI events under /etc/tenants but this requires the user to know where the tenants are located (which afaik, currently is not exposed). In order to allow apps reacting on tenant changes, I propose to either: I. extend the current SPI with an interface TenantEventListener that users can implement ; or II. send OSGI events form the current implementation. In both cases, the events should cover * Tenant added * Tenant removed * Property added * Property removed -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (SLING-4207) Add notifications upon tenant changes
[ https://issues.apache.org/jira/browse/SLING-4207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14227925#comment-14227925 ] Timothee Maret commented on SLING-4207: --- Opened PR with implementation using TenantEventListener API in https://github.com/apache/sling/pull/49 Add notifications upon tenant changes - Key: SLING-4207 URL: https://issues.apache.org/jira/browse/SLING-4207 Project: Sling Issue Type: Improvement Components: Extensions Affects Versions: Tenant 1.0.2 Reporter: Timothee Maret Fix For: Tenant 1.0.4 Currently, there is no clean way to detect when a tenant has been added/removed/modified. We may detect when a change is required by implementing the TenantCustomizer interface, however, it tells nothing about the actual completion of the change. We may listen for OSGI events under /etc/tenants but this requires the user to know where the tenants are located (which afaik, currently is not exposed). In order to allow apps reacting on tenant changes, I propose to either: I. extend the current SPI with an interface TenantEventListener that users can implement ; or II. send OSGI events form the current implementation. In both cases, the events should cover * Tenant added * Tenant removed * Property added * Property removed -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (SLING-4207) Add notifications upon tenant changes
[ https://issues.apache.org/jira/browse/SLING-4207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14227928#comment-14227928 ] Timothee Maret commented on SLING-4207: --- Patch is at https://github.com/apache/sling/pull/49.patch Add notifications upon tenant changes - Key: SLING-4207 URL: https://issues.apache.org/jira/browse/SLING-4207 Project: Sling Issue Type: Improvement Components: Extensions Affects Versions: Tenant 1.0.2 Reporter: Timothee Maret Fix For: Tenant 1.0.4 Currently, there is no clean way to detect when a tenant has been added/removed/modified. We may detect when a change is required by implementing the TenantCustomizer interface, however, it tells nothing about the actual completion of the change. We may listen for OSGI events under /etc/tenants but this requires the user to know where the tenants are located (which afaik, currently is not exposed). In order to allow apps reacting on tenant changes, I propose to either: I. extend the current SPI with an interface TenantEventListener that users can implement ; or II. send OSGI events form the current implementation. In both cases, the events should cover * Tenant added * Tenant removed * Property added * Property removed -- This message was sent by Atlassian JIRA (v6.3.4#6332)
