[jira] [Commented] (SLING-4665) Provide a Helper class to compare topology views
[
https://issues.apache.org/jira/browse/SLING-4665?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14518971#comment-14518971
]
Stefan Egli commented on SLING-4665:
[~marett], committed your patch in http://svn.apache.org/r1676687 - many thanks!
Provide a Helper class to compare topology views
Key: SLING-4665
URL: https://issues.apache.org/jira/browse/SLING-4665
Project: Sling
Issue Type: Improvement
Components: Extensions
Reporter: Timothee Maret
Assignee: Stefan Egli
Fix For: Discovery Commons 1.0.0
Attachments: SLING-4665.patch
As discussed in SLING-4627, the Sling discovery would benefit from having a
helper class that allow applications to compare two different topology views.
As suggested by [~egli] this could be developed in a new bundle
{code}
groupIdorg.apache.sling/groupId
artifactIdorg.apache.sling.discovery.commons/artifactId
{code}
The issue has no component/version assigned as it may require creating a new
one for discovery.common.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (SLING-4665) Provide a Helper class to compare topology views
[
https://issues.apache.org/jira/browse/SLING-4665?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14519014#comment-14519014
]
ASF GitHub Bot commented on SLING-4665:
---
Github user tmaret closed the pull request at:
https://github.com/apache/sling/pull/87
Provide a Helper class to compare topology views
Key: SLING-4665
URL: https://issues.apache.org/jira/browse/SLING-4665
Project: Sling
Issue Type: Improvement
Components: Extensions
Reporter: Timothee Maret
Assignee: Stefan Egli
Fix For: Discovery Commons 1.0.0
Attachments: SLING-4665.patch
As discussed in SLING-4627, the Sling discovery would benefit from having a
helper class that allow applications to compare two different topology views.
As suggested by [~egli] this could be developed in a new bundle
{code}
groupIdorg.apache.sling/groupId
artifactIdorg.apache.sling.discovery.commons/artifactId
{code}
The issue has no component/version assigned as it may require creating a new
one for discovery.common.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (SLING-4665) Provide a Helper class to compare topology views
[
https://issues.apache.org/jira/browse/SLING-4665?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14518488#comment-14518488
]
ASF GitHub Bot commented on SLING-4665:
---
GitHub user tmaret opened a pull request:
https://github.com/apache/sling/pull/87
SLING-4665 - Provide a Helper class to compare topology views
* add commons module
* add class that allows to combine and filter two collection of
InstanceDescription instances
* add unit test
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tmaret/sling SLING-4665
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/sling/pull/87.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #87
commit 438c9be8336e5f1bfdd09d55e74e30884316d182
Author: tmaret tma...@adobe.com
Date: 2015-04-29T00:56:20Z
SLING-4665 - Provide a Helper class to compare topology views
* add commons module
* add class that allows to combine and filter two collection of
InstanceDescription instances
* add unit test
Provide a Helper class to compare topology views
Key: SLING-4665
URL: https://issues.apache.org/jira/browse/SLING-4665
Project: Sling
Issue Type: Improvement
Components: Extensions
Reporter: Timothee Maret
Fix For: Discovery Commons 1.0.0
As discussed in SLING-4627, the Sling discovery would benefit from having a
helper class that allow applications to compare two different topology views.
As suggested by [~egli] this could be developed in a new bundle
{code}
groupIdorg.apache.sling/groupId
artifactIdorg.apache.sling.discovery.commons/artifactId
{code}
The issue has no component/version assigned as it may require creating a new
one for discovery.common.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (SLING-4665) Provide a Helper class to compare topology views
[
https://issues.apache.org/jira/browse/SLING-4665?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14516604#comment-14516604
]
Stefan Egli commented on SLING-4665:
slingIds must be unique throughout the topology. There is no mechanism that
guarantees or establishes this however. While the slingIds are auto-generated
(when they don't exist) - you can't prevent someone from copying an instance
and thus also copy the slingId (although we have explicit documentation stating
that the slingid file must be deleted when doing such a copy).
So for discovery.impl there are checks (SLING-2892, SLING-2901) that at least
detect if in a particular deployment duplicate slingIds can be found.
I'd suggest to do this for all discovery implementations if possible.
So based on this I guess the helper could be slingId based (while doing
paranoia checks at construction time eg)
Provide a Helper class to compare topology views
Key: SLING-4665
URL: https://issues.apache.org/jira/browse/SLING-4665
Project: Sling
Issue Type: Improvement
Components: Extensions
Reporter: Timothee Maret
Fix For: Discovery Commons 1.0.0
As discussed in SLING-4627, the Sling discovery would benefit from having a
helper class that allow applications to compare two different topology views.
As suggested by [~egli] this could be developed in a new bundle
{code}
groupIdorg.apache.sling/groupId
artifactIdorg.apache.sling.discovery.commons/artifactId
{code}
The issue has no component/version assigned as it may require creating a new
one for discovery.common.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (SLING-4665) Provide a Helper class to compare topology views
[
https://issues.apache.org/jira/browse/SLING-4665?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14515061#comment-14515061
]
Timothee Maret commented on SLING-4665:
---
[~egli] Generally, given two instances in the same TopologyView, can we assume
that no two instances will have the same Sling id ?
If we can assume that (Sling id is unique across the whole topology), then we
could build the helper using a comparison on the Sling id and dealing with sets
of instances. Uniquely identifying instances would also allow to filter by
properties (if they match or not).
In the other hand, if there could be two instances in the same topology with
the same sling id, then the helper would need to be design in a way that it
deal with collections of instances. with this version, and filtering by
properties may be removed since we wouldn't know which instances to compare.
Which one of the two approach seems more correct given the Discovery API and
impl ?
Provide a Helper class to compare topology views
Key: SLING-4665
URL: https://issues.apache.org/jira/browse/SLING-4665
Project: Sling
Issue Type: Improvement
Components: Extensions
Reporter: Timothee Maret
Fix For: Discovery Commons 1.0.0
As discussed in SLING-4627, the Sling discovery would benefit from having a
helper class that allow applications to compare two different topology views.
As suggested by [~egli] this could be developed in a new bundle
{code}
groupIdorg.apache.sling/groupId
artifactIdorg.apache.sling.discovery.commons/artifactId
{code}
The issue has no component/version assigned as it may require creating a new
one for discovery.common.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
