[jira] [Commented] (SLING-4934) Sling Mock: Embed transitive dependencies
[ https://issues.apache.org/jira/browse/SLING-4934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14695419#comment-14695419 ] Stefan Seifert commented on SLING-4934: --- i'm not sure if this is a good idea, see my mail thread post http://apache-sling.73963.n3.nabble.com/Sling-JCR-Mocks-testing-dependencies-and-imported-ranges-tp4051852p4053698.html Sling Mock: Embed transitive dependencies - Key: SLING-4934 URL: https://issues.apache.org/jira/browse/SLING-4934 Project: Sling Issue Type: Bug Components: Testing Affects Versions: Testing Sling Mock 1.4.0 Reporter: Konrad Windszus Attachments: SLING-4934-v01.patch, SLING-4934-v02.patch If you are using a DependencyManagement section in your pom refererencing a newer version of a dependency being also used by sling-mock, it will also influence the version of that transitive dependency of sling-mock at runtime. That may lead to issues like SLING-4392. Therefore I would suggest to also embed jcr.resource along with all other transitive dependencies within sling-mock, similar to what was done in SLING-4827 for sling-mock-jackrabbit. A related discussion can be found at http://www.mail-archive.com/dev%40sling.apache.org/msg47007.html, but that was not mentioning the problem with dependency management. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (SLING-4934) Sling Mock: Embed transitive dependencies
[ https://issues.apache.org/jira/browse/SLING-4934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14679672#comment-14679672 ] Konrad Windszus commented on SLING-4934: The size of the {{org.apache.sling.testing.sling-mock-1.4.1-SNAPSHOT.jar}} increased from 85 KB to 871 KB with that change. Sling Mock: Embed transitive dependencies - Key: SLING-4934 URL: https://issues.apache.org/jira/browse/SLING-4934 Project: Sling Issue Type: Bug Components: Testing Affects Versions: Testing Sling Mock 1.4.0 Reporter: Konrad Windszus Attachments: SLING-4934-v01.patch If you are using a DependencyManagement section in your pom refererencing a newer version of a dependency being also used by sling-mock, it will also influence the version of that transitive dependency of sling-mock at runtime. That may lead to issues like SLING-4392. Therefore I would suggest to also embed jcr.resource along with all other transitive dependencies within sling-mock, similar to what was done in SLING-4827 for sling-mock-jackrabbit. A related discussion can be found at http://www.mail-archive.com/dev%40sling.apache.org/msg47007.html, but that was not mentioning the problem with dependency management. -- This message was sent by Atlassian JIRA (v6.3.4#6332)