[jira] [Commented] (SLING-4937) Drop namespace mapping support
[ https://issues.apache.org/jira/browse/SLING-4937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15151789#comment-15151789 ] Carsten Ziegeler commented on SLING-4937: - As the issue title says, its about to remove namespace mapping support, but not the support for the Sling-Namespace bundle header. I'll make this a little bit more clear in the title > Drop namespace mapping support > -- > > Key: SLING-4937 > URL: https://issues.apache.org/jira/browse/SLING-4937 > Project: Sling > Issue Type: Improvement > Components: JCR >Reporter: Carsten Ziegeler >Assignee: Carsten Ziegeler > Fix For: JCR Jackrabbit Server 2.3.0, JCR Base 2.3.0, JCR Oak > Server 1.0.0 > > > I think we should support the support for namespace mapping from our jcr > base module (and therefore from the jcr server implementations). > The namespace support parses the Sling-Namespaces header of bundles and > ensures that every session has namespace prefix mapping based on these > headers ensuring a stable mapping. The main reason why we added this in > the first place is, is that in theory one could map e.g. the sling > namespace prefix to some own non Sling url. Which obviously would break > all applications. Of course, no one really does this and even with this > mapping behavuíour in place, I'm pretty sure apps would break if someone > does crazy mappings as we only cover the part where the Sling API is > used. Defaulting to the JCR API will probably use the wrong mapping. > As implementing this mapping creates proxy objects for the session which > is kind of heavy and I really think that this feature was never really > useful, I think we should drop it. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (SLING-4937) Drop namespace mapping support
[ https://issues.apache.org/jira/browse/SLING-4937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15151473#comment-15151473 ] Justin Edelson commented on SLING-4937: --- Was the intention of this issue to remove support for the Sling-Namespaces bundle header entirely? My understanding (perhaps incorrect) was that it was just to remove support for per-session namespace mappings. IMHO, we should still support (global) registration of a namespace mapping via a bundle header. > Drop namespace mapping support > -- > > Key: SLING-4937 > URL: https://issues.apache.org/jira/browse/SLING-4937 > Project: Sling > Issue Type: Improvement > Components: JCR >Reporter: Carsten Ziegeler >Assignee: Carsten Ziegeler > Fix For: JCR Jackrabbit Server 2.3.0, JCR Base 2.3.0, JCR Oak > Server 1.0.0 > > > I think we should support the support for namespace mapping from our jcr > base module (and therefore from the jcr server implementations). > The namespace support parses the Sling-Namespaces header of bundles and > ensures that every session has namespace prefix mapping based on these > headers ensuring a stable mapping. The main reason why we added this in > the first place is, is that in theory one could map e.g. the sling > namespace prefix to some own non Sling url. Which obviously would break > all applications. Of course, no one really does this and even with this > mapping behavuíour in place, I'm pretty sure apps would break if someone > does crazy mappings as we only cover the part where the Sling API is > used. Defaulting to the JCR API will probably use the wrong mapping. > As implementing this mapping creates proxy objects for the session which > is kind of heavy and I really think that this feature was never really > useful, I think we should drop it. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (SLING-4937) Drop namespace mapping support
[
https://issues.apache.org/jira/browse/SLING-4937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15151434#comment-15151434
]
Stefan Seifert commented on SLING-4937:
---
it seems this change broke the support for the {{Sling-Nodetypes}} bundle
header as well, see SLING-5531.
> Drop namespace mapping support
> --
>
> Key: SLING-4937
> URL: https://issues.apache.org/jira/browse/SLING-4937
> Project: Sling
> Issue Type: Improvement
> Components: JCR
>Reporter: Carsten Ziegeler
>Assignee: Carsten Ziegeler
> Fix For: JCR Jackrabbit Server 2.3.0, JCR Base 2.3.0, JCR Oak
> Server 1.0.0
>
>
> I think we should support the support for namespace mapping from our jcr
> base module (and therefore from the jcr server implementations).
> The namespace support parses the Sling-Namespaces header of bundles and
> ensures that every session has namespace prefix mapping based on these
> headers ensuring a stable mapping. The main reason why we added this in
> the first place is, is that in theory one could map e.g. the sling
> namespace prefix to some own non Sling url. Which obviously would break
> all applications. Of course, no one really does this and even with this
> mapping behavuíour in place, I'm pretty sure apps would break if someone
> does crazy mappings as we only cover the part where the Sling API is
> used. Defaulting to the JCR API will probably use the wrong mapping.
> As implementing this mapping creates proxy objects for the session which
> is kind of heavy and I really think that this feature was never really
> useful, I think we should drop it.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (SLING-4937) Drop namespace mapping support
[
https://issues.apache.org/jira/browse/SLING-4937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14997921#comment-14997921
]
Alexander Klimetschek commented on SLING-4937:
--
It also helps with performance A LOT. The call
{{NamespaceMappingSupport#getNamespaceAwareSession}} tends to be comparatively
slow under high traffic with lots of concurrency in my tests. E.g. the actual
repo login takes way less than 0.5 ms (if optimized), but the
getNamespaceAwareSession has a high variance up to 40 ms, being the largest
part of the authentication phase in our sling app.
AFAICS, in commit
https://github.com/apache/sling/commit/75594f9e2cd2c57ea8111935a41d1066dfe86813
(not linked here) it has been removed from AbstractSlingRepository2 eventually.
> Drop namespace mapping support
> --
>
> Key: SLING-4937
> URL: https://issues.apache.org/jira/browse/SLING-4937
> Project: Sling
> Issue Type: Improvement
> Components: JCR
>Reporter: Carsten Ziegeler
>Assignee: Carsten Ziegeler
> Fix For: JCR Jackrabbit Server 2.3.0, JCR Base 2.3.0, JCR Oak
> Server 1.0.0
>
>
> I think we should support the support for namespace mapping from our jcr
> base module (and therefore from the jcr server implementations).
> The namespace support parses the Sling-Namespaces header of bundles and
> ensures that every session has namespace prefix mapping based on these
> headers ensuring a stable mapping. The main reason why we added this in
> the first place is, is that in theory one could map e.g. the sling
> namespace prefix to some own non Sling url. Which obviously would break
> all applications. Of course, no one really does this and even with this
> mapping behavuíour in place, I'm pretty sure apps would break if someone
> does crazy mappings as we only cover the part where the Sling API is
> used. Defaulting to the JCR API will probably use the wrong mapping.
> As implementing this mapping creates proxy objects for the session which
> is kind of heavy and I really think that this feature was never really
> useful, I think we should drop it.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
