[jira] [Commented] (SLING-6780) org.apache.sling.scripting.sightly.js.provider does not declare a version range for the org.mozilla.javascript import
[
https://issues.apache.org/jira/browse/SLING-6780?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15967426#comment-15967426
]
Radu Cotescu commented on SLING-6780:
-
Switched to depending on the {{org.apache.servicemix.bundles.rhino}} bundle, so
that {{bnd}} defines the correct imports in
[r1791227|https://svn.apache.org/r1791227].
> org.apache.sling.scripting.sightly.js.provider does not declare a version
> range for the org.mozilla.javascript import
> -
>
> Key: SLING-6780
> URL: https://issues.apache.org/jira/browse/SLING-6780
> Project: Sling
> Issue Type: Bug
> Components: Scripting
>Affects Versions: Scripting Sightly JS Use Provider 1.0.10
>Reporter: Vlad Bailescu
>Assignee: Radu Cotescu
> Fix For: Scripting HTL JS Use Provider 1.0.22
>
>
> The {{org.apache.sling.scripting.sightly.js.provider}} bundle is not
> declaring a version range for the {{org.mozilla.javascript}} import in its
> manifest. This can become a problem when someone installs an incompatible
> version. The solution is simple: make sure we declare a correct version range
> for {{org.mozilla.javascript}} import.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (SLING-6780) org.apache.sling.scripting.sightly.js.provider does not declare a version range for the org.mozilla.javascript import
[
https://issues.apache.org/jira/browse/SLING-6780?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15967358#comment-15967358
]
Konrad Windszus commented on SLING-6780:
As written in https://github.com/apache/sling/pull/213#discussion_r111349248 I
don't agree with the import range. This should IMHO be [1.7,2) and I would
prefer to automatically generate through bnd, by exchanging the dependency
Rhino in
https://github.com/vladbailescu/sling/blob/0ec63ac17191b8b2ad839924d39c11e32435192e/bundles/scripting/sightly/js-use-provider/pom.xml#L174
with the service mix bundle (added in SLING-6668).
> org.apache.sling.scripting.sightly.js.provider does not declare a version
> range for the org.mozilla.javascript import
> -
>
> Key: SLING-6780
> URL: https://issues.apache.org/jira/browse/SLING-6780
> Project: Sling
> Issue Type: Bug
> Components: Scripting
>Affects Versions: Scripting Sightly JS Use Provider 1.0.10
>Reporter: Vlad Bailescu
>Assignee: Radu Cotescu
> Fix For: Scripting HTL JS Use Provider 1.0.22
>
>
> The {{org.apache.sling.scripting.sightly.js.provider}} bundle is not
> declaring a version range for the {{org.mozilla.javascript}} import in its
> manifest. This can become a problem when someone installs an incompatible
> version. The solution is simple: make sure we declare a correct version range
> for {{org.mozilla.javascript}} import.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (SLING-6780) org.apache.sling.scripting.sightly.js.provider does not declare a version range for the org.mozilla.javascript import
[
https://issues.apache.org/jira/browse/SLING-6780?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15967354#comment-15967354
]
ASF GitHub Bot commented on SLING-6780:
---
Github user vladbailescu closed the pull request at:
https://github.com/apache/sling/pull/213
> org.apache.sling.scripting.sightly.js.provider does not declare a version
> range for the org.mozilla.javascript import
> -
>
> Key: SLING-6780
> URL: https://issues.apache.org/jira/browse/SLING-6780
> Project: Sling
> Issue Type: Bug
> Components: Scripting
>Affects Versions: Scripting Sightly JS Use Provider 1.0.10
>Reporter: Vlad Bailescu
>Assignee: Radu Cotescu
> Fix For: Scripting HTL JS Use Provider 1.0.22
>
>
> The {{org.apache.sling.scripting.sightly.js.provider}} bundle is not
> declaring a version range for the {{org.mozilla.javascript}} import in its
> manifest. This can become a problem when someone installs an incompatible
> version. The solution is simple: make sure we declare a correct version range
> for {{org.mozilla.javascript}} import.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (SLING-6780) org.apache.sling.scripting.sightly.js.provider does not declare a version range for the org.mozilla.javascript import
[
https://issues.apache.org/jira/browse/SLING-6780?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15967266#comment-15967266
]
Vlad Bailescu commented on SLING-6780:
--
[~olli], thanks for your input. Already discussed with [~radu.cotescu] and
agreed we should add the version range manually and not rely on the dependency,
please see the updated PR: https://github.com/apache/sling/pull/213
> org.apache.sling.scripting.sightly.js.provider does not declare a version
> range for the org.mozilla.javascript import
> -
>
> Key: SLING-6780
> URL: https://issues.apache.org/jira/browse/SLING-6780
> Project: Sling
> Issue Type: Bug
> Components: Scripting
>Affects Versions: Scripting Sightly JS Use Provider 1.0.10
>Reporter: Vlad Bailescu
>Assignee: Radu Cotescu
> Fix For: Scripting HTL JS Use Provider 1.0.22
>
>
> The {{org.apache.sling.scripting.sightly.js.provider}} bundle is not
> declaring a version range for the {{org.mozilla.javascript}} import in its
> manifest. This can become a problem when someone installs an incompatible
> version. The solution is simple: make sure we declare a correct version range
> for {{org.mozilla.javascript}} import.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (SLING-6780) org.apache.sling.scripting.sightly.js.provider does not declare a version range for the org.mozilla.javascript import
[
https://issues.apache.org/jira/browse/SLING-6780?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15966362#comment-15966362
]
Oliver Lietz commented on SLING-6780:
-
[~radu.cotescu], [~vladb]: Do *not* depend on
{{org.apache.sling.scripting.javascript}} when
{{org.apache.sling.scripting.sightly.js.provider}} depends in fact on
{{org.mozilla.javascript}}, see SLING-5731 and SLING-6668.
> org.apache.sling.scripting.sightly.js.provider does not declare a version
> range for the org.mozilla.javascript import
> -
>
> Key: SLING-6780
> URL: https://issues.apache.org/jira/browse/SLING-6780
> Project: Sling
> Issue Type: Bug
> Components: Scripting
>Affects Versions: Scripting Sightly JS Use Provider 1.0.10
>Reporter: Vlad Bailescu
>Assignee: Radu Cotescu
> Fix For: Scripting HTL JS Use Provider 1.0.22
>
>
> The {{org.apache.sling.scripting.sightly.js.provider}} bundle is not
> declaring a version range for the {{org.mozilla.javascript}} import in its
> manifest. This can become a problem when someone installs an incompatible
> version. The solution is simple: declare an explicit dependency on
> {{org.apache.sling.scripting.javascript}} so that the bundle plugin can pick
> up the correct version range.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
