[jira] [Commented] (SLING-7950) Fix ITs with Oak 1.8

2018-10-16 Thread Robert Munteanu (JIRA)


[ 
https://issues.apache.org/jira/browse/SLING-7950?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16651472#comment-16651472
 ] 

Robert Munteanu commented on SLING-7950:


[~jebailey] - sorry for the noise, I was somehow using an older version of the 
integration tests. All is fine now with the rendering tests.

> Fix ITs with Oak 1.8
> 
>
> Key: SLING-7950
> URL: https://issues.apache.org/jira/browse/SLING-7950
> Project: Sling
>  Issue Type: Sub-task
>  Components: Launchpad, Oak, Testing
>Reporter: Robert Munteanu
>Assignee: Robert Munteanu
>Priority: Major
> Fix For: Starter 11
>
>
> Updating to Oak 1.8.7 results in the following failures:
> {noformat}[ERROR] Failures: 
> [ERROR]   AnonymousAccessTest.testAnonymousContent:99->assertContent:85 
> Expected status 200 for 
> http://localhost:41000/ANON_CAN_READ/AnonymousAccessTest/789235c4-d3b2-43b3-a163-aadb95cdd56b/test_text_789235c4_d.txt
>  (content=) expected:<200> but was:<401>
> [ERROR]   AnonymousAccessTest.testAnonymousContent:101 Expecting status 404 
> when testing outside of anonymous access subtree expected:<404> but was:<401>
> [ERROR]   
> AuthRequestLoginTest.testForcedLogin:40->HttpTestBase.getContent:419->HttpTestBase.getContent:424->HttpTestBase.getContent:432->HttpTestBase.getContent:457
>  Expected status 200 for 
> http://localhost:41000/system/sling/info.sessionInfo.json (content=) 
> expected:<200> but was:<401>
> [ERROR]   RedirectOnLogoutTest.testRedirectToResourceAfterLogout:70 Expected 
> redirect expected:<302> but was:<401>
> [ERROR] Errors: 
> [ERROR]   DavExDisabledAnonAccessTest>DavExIntegrationTest.setUp:47 » 
> NoClassDefFound or...
> [ERROR]   DavExDisabledAnonAccessTest>DavExIntegrationTest.setUp:47 » 
> NoClassDefFound or...
> [ERROR]   DavExIntegrationTest.setUp:47 » NoClassDefFound 
> org/apache/jackrabbit/webdav/c...
> [ERROR]   DavExIntegrationTest.setUp:47 » NoClassDefFound 
> org/apache/jackrabbit/webdav/c...
> [INFO] 
> [ERROR] Tests run: 655, Failures: 4, Errors: 4, Skipped: 1{noformat}
> The changes that support this are at 
> https://github.com/apache/sling-org-apache-sling-starter/tree/feature/oak-1.8



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (SLING-7950) Fix ITs with Oak 1.8

2018-10-15 Thread Jason E Bailey (JIRA)


[ 
https://issues.apache.org/jira/browse/SLING-7950?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16650530#comment-16650530
 ] 

Jason E Bailey commented on SLING-7950:
---

[~rombert] I pushed a fix for the null pointer exception that was occurring 
after the session information was written out. That may resolve this

> Fix ITs with Oak 1.8
> 
>
> Key: SLING-7950
> URL: https://issues.apache.org/jira/browse/SLING-7950
> Project: Sling
>  Issue Type: Sub-task
>  Components: Launchpad, Oak, Testing
>Reporter: Robert Munteanu
>Assignee: Robert Munteanu
>Priority: Major
> Fix For: Starter 11
>
>
> Updating to Oak 1.8.7 results in the following failures:
> {noformat}[ERROR] Failures: 
> [ERROR]   AnonymousAccessTest.testAnonymousContent:99->assertContent:85 
> Expected status 200 for 
> http://localhost:41000/ANON_CAN_READ/AnonymousAccessTest/789235c4-d3b2-43b3-a163-aadb95cdd56b/test_text_789235c4_d.txt
>  (content=) expected:<200> but was:<401>
> [ERROR]   AnonymousAccessTest.testAnonymousContent:101 Expecting status 404 
> when testing outside of anonymous access subtree expected:<404> but was:<401>
> [ERROR]   
> AuthRequestLoginTest.testForcedLogin:40->HttpTestBase.getContent:419->HttpTestBase.getContent:424->HttpTestBase.getContent:432->HttpTestBase.getContent:457
>  Expected status 200 for 
> http://localhost:41000/system/sling/info.sessionInfo.json (content=) 
> expected:<200> but was:<401>
> [ERROR]   RedirectOnLogoutTest.testRedirectToResourceAfterLogout:70 Expected 
> redirect expected:<302> but was:<401>
> [ERROR] Errors: 
> [ERROR]   DavExDisabledAnonAccessTest>DavExIntegrationTest.setUp:47 » 
> NoClassDefFound or...
> [ERROR]   DavExDisabledAnonAccessTest>DavExIntegrationTest.setUp:47 » 
> NoClassDefFound or...
> [ERROR]   DavExIntegrationTest.setUp:47 » NoClassDefFound 
> org/apache/jackrabbit/webdav/c...
> [ERROR]   DavExIntegrationTest.setUp:47 » NoClassDefFound 
> org/apache/jackrabbit/webdav/c...
> [INFO] 
> [ERROR] Tests run: 655, Failures: 4, Errors: 4, Skipped: 1{noformat}
> The changes that support this are at 
> https://github.com/apache/sling-org-apache-sling-starter/tree/feature/oak-1.8



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (SLING-7950) Fix ITs with Oak 1.8

2018-10-15 Thread Robert Munteanu (JIRA)


[ 
https://issues.apache.org/jira/browse/SLING-7950?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16650460#comment-16650460
 ] 

Robert Munteanu commented on SLING-7950:


... but I get the feeling that these are caused by recent changes to the 
servlets.get bundle

{noformat}[ERROR] 
testNtUnstructured(org.apache.sling.launchpad.webapp.integrationtest.NodeTypeBasedRenderingTest)
  Time elapsed: 0.048 s  <<< FAILURE!
junit.framework.AssertionFailedError: 
Content does not contain 'dumped by HtmlRendererServlet' (content=
http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd;>
http://www.w3.org/1999/xhtml; xml:lang="en">


Resource dumped by HtmlRenderer
Resource path: /testing/NodeTypeBasedRenderingTest/test_7
Resource metadata: {sling.modificationTime=-1, 
sling.characterEncoding=null, sling.parameterMap={}, sling.contentType=null, 
sling.creationTime=-1, sling.contentLength=-1, 
sling.resolutionPath=/testing/NodeTypeBasedRenderingTest/test_7, 
sling.resolutionPathInfo=.html}
Resource type: nt:unstructured
Resource super type: -
Resource properties

jcr:primaryType: nt:unstructured


)
at 
org.apache.sling.launchpad.webapp.integrationtest.NodeTypeBasedRenderingTest.testSpecificNodeType(NodeTypeBasedRenderingTest.java:68)
at 
org.apache.sling.launchpad.webapp.integrationtest.NodeTypeBasedRenderingTest.testNtUnstructured(NodeTypeBasedRenderingTest.java:89)
{noformat}

The test is looking for _dumped by HtmlRenderer*Servlet*_ but the output 
contains _dumped by HtmlRenderer_. Might be a case of an overspecifying test.

[~jebailey] - does this change in behaviour sound familiar to you?

> Fix ITs with Oak 1.8
> 
>
> Key: SLING-7950
> URL: https://issues.apache.org/jira/browse/SLING-7950
> Project: Sling
>  Issue Type: Sub-task
>  Components: Launchpad, Oak, Testing
>Reporter: Robert Munteanu
>Assignee: Robert Munteanu
>Priority: Major
> Fix For: Starter 11
>
>
> Updating to Oak 1.8.7 results in the following failures:
> {noformat}[ERROR] Failures: 
> [ERROR]   AnonymousAccessTest.testAnonymousContent:99->assertContent:85 
> Expected status 200 for 
> http://localhost:41000/ANON_CAN_READ/AnonymousAccessTest/789235c4-d3b2-43b3-a163-aadb95cdd56b/test_text_789235c4_d.txt
>  (content=) expected:<200> but was:<401>
> [ERROR]   AnonymousAccessTest.testAnonymousContent:101 Expecting status 404 
> when testing outside of anonymous access subtree expected:<404> but was:<401>
> [ERROR]   
> AuthRequestLoginTest.testForcedLogin:40->HttpTestBase.getContent:419->HttpTestBase.getContent:424->HttpTestBase.getContent:432->HttpTestBase.getContent:457
>  Expected status 200 for 
> http://localhost:41000/system/sling/info.sessionInfo.json (content=) 
> expected:<200> but was:<401>
> [ERROR]   RedirectOnLogoutTest.testRedirectToResourceAfterLogout:70 Expected 
> redirect expected:<302> but was:<401>
> [ERROR] Errors: 
> [ERROR]   DavExDisabledAnonAccessTest>DavExIntegrationTest.setUp:47 » 
> NoClassDefFound or...
> [ERROR]   DavExDisabledAnonAccessTest>DavExIntegrationTest.setUp:47 » 
> NoClassDefFound or...
> [ERROR]   DavExIntegrationTest.setUp:47 » NoClassDefFound 
> org/apache/jackrabbit/webdav/c...
> [ERROR]   DavExIntegrationTest.setUp:47 » NoClassDefFound 
> org/apache/jackrabbit/webdav/c...
> [INFO] 
> [ERROR] Tests run: 655, Failures: 4, Errors: 4, Skipped: 1{noformat}
> The changes that support this are at 
> https://github.com/apache/sling-org-apache-sling-starter/tree/feature/oak-1.8



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (SLING-7950) Fix ITs with Oak 1.8

2018-10-15 Thread Robert Munteanu (JIRA)


[ 
https://issues.apache.org/jira/browse/SLING-7950?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16650456#comment-16650456
 ] 

Robert Munteanu commented on SLING-7950:


[~olli] - I am running the tests in the following manner:

* {{mvn clean install}} from 
https://github.com/apache/sling-org-apache-sling-starter/tree/feature/oak-1.8
* {{mvn clean verify}} from 
https://github.com/apache/sling-org-apache-sling-launchpad-testing

I managed to solve the _DavEx_ issues by upgrading the dependency to 
jackrabbit-jcr2dav in org.apache.sling.launchpad.integration-tests .

{noformat}diff --git a/pom.xml b/pom.xml
index 3e90be1..8f3f0e6 100644
--- a/pom.xml
+++ b/pom.xml
@@ -177,7 +177,7 @@
 
   org.apache.jackrabbit
   jackrabbit-jcr2dav
-  2.7.1
+  2.16.3
   compile
 
{noformat}

However, I still get lots of failures related to rendering that I can't make 
any sense of.

> Fix ITs with Oak 1.8
> 
>
> Key: SLING-7950
> URL: https://issues.apache.org/jira/browse/SLING-7950
> Project: Sling
>  Issue Type: Sub-task
>  Components: Launchpad, Oak, Testing
>Reporter: Robert Munteanu
>Assignee: Robert Munteanu
>Priority: Major
> Fix For: Starter 11
>
>
> Updating to Oak 1.8.7 results in the following failures:
> {noformat}[ERROR] Failures: 
> [ERROR]   AnonymousAccessTest.testAnonymousContent:99->assertContent:85 
> Expected status 200 for 
> http://localhost:41000/ANON_CAN_READ/AnonymousAccessTest/789235c4-d3b2-43b3-a163-aadb95cdd56b/test_text_789235c4_d.txt
>  (content=) expected:<200> but was:<401>
> [ERROR]   AnonymousAccessTest.testAnonymousContent:101 Expecting status 404 
> when testing outside of anonymous access subtree expected:<404> but was:<401>
> [ERROR]   
> AuthRequestLoginTest.testForcedLogin:40->HttpTestBase.getContent:419->HttpTestBase.getContent:424->HttpTestBase.getContent:432->HttpTestBase.getContent:457
>  Expected status 200 for 
> http://localhost:41000/system/sling/info.sessionInfo.json (content=) 
> expected:<200> but was:<401>
> [ERROR]   RedirectOnLogoutTest.testRedirectToResourceAfterLogout:70 Expected 
> redirect expected:<302> but was:<401>
> [ERROR] Errors: 
> [ERROR]   DavExDisabledAnonAccessTest>DavExIntegrationTest.setUp:47 » 
> NoClassDefFound or...
> [ERROR]   DavExDisabledAnonAccessTest>DavExIntegrationTest.setUp:47 » 
> NoClassDefFound or...
> [ERROR]   DavExIntegrationTest.setUp:47 » NoClassDefFound 
> org/apache/jackrabbit/webdav/c...
> [ERROR]   DavExIntegrationTest.setUp:47 » NoClassDefFound 
> org/apache/jackrabbit/webdav/c...
> [INFO] 
> [ERROR] Tests run: 655, Failures: 4, Errors: 4, Skipped: 1{noformat}
> The changes that support this are at 
> https://github.com/apache/sling-org-apache-sling-starter/tree/feature/oak-1.8



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (SLING-7950) Fix ITs with Oak 1.8

2018-09-25 Thread Oliver Lietz (JIRA)


[ 
https://issues.apache.org/jira/browse/SLING-7950?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16627025#comment-16627025
 ] 

Oliver Lietz commented on SLING-7950:
-

[~rombert], I don't think the tests fail because of Oak 1.8. I adjusted some 
repoinit statements last evening in [Sling's Karaf Launchpad Integration 
Tests|https://github.com/apache/sling-org-apache-sling-karaf-launchpad-oak-tar-integration-tests/commit/fce157ab2e55ec004a5ff2b3fb2bdaf76a9a3489]
 and now I see only failures related to rendering. How did you run the tests?

> Fix ITs with Oak 1.8
> 
>
> Key: SLING-7950
> URL: https://issues.apache.org/jira/browse/SLING-7950
> Project: Sling
>  Issue Type: Sub-task
>  Components: Launchpad, Oak, Testing
>Reporter: Robert Munteanu
>Priority: Major
> Fix For: Starter 11
>
>
> Updating to Oak 1.8.7 results in the following failures:
> {noformat}[ERROR] Failures: 
> [ERROR]   AnonymousAccessTest.testAnonymousContent:99->assertContent:85 
> Expected status 200 for 
> http://localhost:41000/ANON_CAN_READ/AnonymousAccessTest/789235c4-d3b2-43b3-a163-aadb95cdd56b/test_text_789235c4_d.txt
>  (content=) expected:<200> but was:<401>
> [ERROR]   AnonymousAccessTest.testAnonymousContent:101 Expecting status 404 
> when testing outside of anonymous access subtree expected:<404> but was:<401>
> [ERROR]   
> AuthRequestLoginTest.testForcedLogin:40->HttpTestBase.getContent:419->HttpTestBase.getContent:424->HttpTestBase.getContent:432->HttpTestBase.getContent:457
>  Expected status 200 for 
> http://localhost:41000/system/sling/info.sessionInfo.json (content=) 
> expected:<200> but was:<401>
> [ERROR]   RedirectOnLogoutTest.testRedirectToResourceAfterLogout:70 Expected 
> redirect expected:<302> but was:<401>
> [ERROR] Errors: 
> [ERROR]   DavExDisabledAnonAccessTest>DavExIntegrationTest.setUp:47 » 
> NoClassDefFound or...
> [ERROR]   DavExDisabledAnonAccessTest>DavExIntegrationTest.setUp:47 » 
> NoClassDefFound or...
> [ERROR]   DavExIntegrationTest.setUp:47 » NoClassDefFound 
> org/apache/jackrabbit/webdav/c...
> [ERROR]   DavExIntegrationTest.setUp:47 » NoClassDefFound 
> org/apache/jackrabbit/webdav/c...
> [INFO] 
> [ERROR] Tests run: 655, Failures: 4, Errors: 4, Skipped: 1{noformat}
> The changes that support this are at 
> https://github.com/apache/sling-org-apache-sling-starter/tree/feature/oak-1.8



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (SLING-7950) Fix ITs with Oak 1.8

2018-09-24 Thread Robert Munteanu (JIRA)


[ 
https://issues.apache.org/jira/browse/SLING-7950?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16626088#comment-16626088
 ] 

Robert Munteanu commented on SLING-7950:


[~olli], [~ch...@die-schneider.net] - since you worked on the Oak 1.8 upgrade, 
maybe you have an idea about the test failures?

> Fix ITs with Oak 1.8
> 
>
> Key: SLING-7950
> URL: https://issues.apache.org/jira/browse/SLING-7950
> Project: Sling
>  Issue Type: Sub-task
>  Components: Launchpad, Oak, Testing
>Reporter: Robert Munteanu
>Priority: Major
> Fix For: Starter 11
>
>
> Updating to Oak 1.8.7 results in the following failures:
> {noformat}[ERROR] Failures: 
> [ERROR]   AnonymousAccessTest.testAnonymousContent:99->assertContent:85 
> Expected status 200 for 
> http://localhost:41000/ANON_CAN_READ/AnonymousAccessTest/789235c4-d3b2-43b3-a163-aadb95cdd56b/test_text_789235c4_d.txt
>  (content=) expected:<200> but was:<401>
> [ERROR]   AnonymousAccessTest.testAnonymousContent:101 Expecting status 404 
> when testing outside of anonymous access subtree expected:<404> but was:<401>
> [ERROR]   
> AuthRequestLoginTest.testForcedLogin:40->HttpTestBase.getContent:419->HttpTestBase.getContent:424->HttpTestBase.getContent:432->HttpTestBase.getContent:457
>  Expected status 200 for 
> http://localhost:41000/system/sling/info.sessionInfo.json (content=) 
> expected:<200> but was:<401>
> [ERROR]   RedirectOnLogoutTest.testRedirectToResourceAfterLogout:70 Expected 
> redirect expected:<302> but was:<401>
> [ERROR] Errors: 
> [ERROR]   DavExDisabledAnonAccessTest>DavExIntegrationTest.setUp:47 » 
> NoClassDefFound or...
> [ERROR]   DavExDisabledAnonAccessTest>DavExIntegrationTest.setUp:47 » 
> NoClassDefFound or...
> [ERROR]   DavExIntegrationTest.setUp:47 » NoClassDefFound 
> org/apache/jackrabbit/webdav/c...
> [ERROR]   DavExIntegrationTest.setUp:47 » NoClassDefFound 
> org/apache/jackrabbit/webdav/c...
> [INFO] 
> [ERROR] Tests run: 655, Failures: 4, Errors: 4, Skipped: 1{noformat}
> The changes that support this are at 
> https://github.com/apache/sling-org-apache-sling-starter/tree/feature/oak-1.8



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)