[jira] [Commented] (SLING-8116) ValueMap - implement default methods using OSGI Converter
[
https://issues.apache.org/jira/browse/SLING-8116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16980300#comment-16980300
]
Radu Cotescu commented on SLING-8116:
-
{{org.apache.sling.resourceresolver}} needs to also be released, due to its
narrow import for {{org.apache.sling.api.resource}}.
> ValueMap - implement default methods using OSGI Converter
> -
>
> Key: SLING-8116
> URL: https://issues.apache.org/jira/browse/SLING-8116
> Project: Sling
> Issue Type: Improvement
> Components: API
>Reporter: Jason E Bailey
>Assignee: Radu Cotescu
>Priority: Major
> Fix For: Resource Resolver 1.6.16, API 2.21.0
>
> Time Spent: 3h 20m
> Remaining Estimate: 0h
>
> Implement default methods in the ValueMap interface that leverages the OSGi
> Converter
> see
> [https://osgi.org/specification/osgi.cmpn/7.0.0/util.converter.html]
> Once this is implemented, custom implementations of the ValueMap interface
> can start being removed, where appropriate, so that a consistent and
> comprehensive conversion of properties occur. We can then add new Rules to
> the Converter to allow features to be populated to all ValueMap
> implementations.
>
> To implement this, the following will also need to happen
> * The Converter bundle will need to be added as a required bundle
> ** Various scripts that define the minimum needed set of bundles will need
> to be updated
> * Communication on the difference in behaviour between the current ValueMap
> and the ValueMap with Converter
> * Although not within the Maven definition. org.osgi.util.Function needs to
> be available as well for the Converter to initiate correctly.
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (SLING-8116) ValueMap - implement default methods using OSGI Converter
[ https://issues.apache.org/jira/browse/SLING-8116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16974280#comment-16974280 ] Radu Cotescu commented on SLING-8116: - With [commit 6362381|https://github.com/apache/sling-org-apache-sling-api/commit/6362381] and [commit 47f1f47|https://github.com/apache/sling-org-apache-sling-api/commit/47f1f47] I think this issue can be marked as resolved. > ValueMap - implement default methods using OSGI Converter > - > > Key: SLING-8116 > URL: https://issues.apache.org/jira/browse/SLING-8116 > Project: Sling > Issue Type: Improvement > Components: API >Reporter: Jason E Bailey >Assignee: Jason E Bailey >Priority: Major > Fix For: API 2.21.0 > > Time Spent: 3h 20m > Remaining Estimate: 0h > > Implement default methods in the ValueMap interface that leverages the OSGi > Converter > see > [https://osgi.org/specification/osgi.cmpn/7.0.0/util.converter.html] > Once this is implemented, custom implementations of the ValueMap interface > can start being removed, where appropriate, so that a consistent and > comprehensive conversion of properties occur. We can then add new Rules to > the Converter to allow features to be populated to all ValueMap > implementations. > > To implement this, the following will also need to happen > * The Converter bundle will need to be added as a required bundle > ** Various scripts that define the minimum needed set of bundles will need > to be updated > * Communication on the difference in behaviour between the current ValueMap > and the ValueMap with Converter > * Although not within the Maven definition. org.osgi.util.Function needs to > be available as well for the Converter to initiate correctly. > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (SLING-8116) ValueMap - implement default methods using OSGI Converter
[ https://issues.apache.org/jira/browse/SLING-8116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16691968#comment-16691968 ] Jason E Bailey commented on SLING-8116: --- Changes that are occurring Will return null when converting an existing array to an unsupported Type. Support the autoboxing to primitive arrays during conversion Will return a null when converting a missing property to an array Will return true for a conversion of a char or number that is not '0' to a Boolean Will return false for any value that can not be converted to Boolean.TRUE Will return false for a null property > ValueMap - implement default methods using OSGI Converter > - > > Key: SLING-8116 > URL: https://issues.apache.org/jira/browse/SLING-8116 > Project: Sling > Issue Type: Improvement >Reporter: Jason E Bailey >Priority: Major > > Implement default methods in the ValueMap interface that leverages the OSGi > Converter > see > [https://osgi.org/specification/osgi.cmpn/7.0.0/util.converter.html] > Once this is implemented, custom implementations of the ValueMap interface > can start being removed, where appropriate, so that a consistent and > comprehensive conversion of properties occur. We can then add new Rules to > the Converter to allow features to be populated to all ValueMap > implementations. > > To implement this, the following will also need to happen > * The Converter bundle will need to be added as a required bundle > ** Various scripts that define the minimum needed set of bundles will need > to be updated > * Communication on the difference in behaviour between the current ValueMap > and the ValueMap with Converter > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
