[jira] [Resolved] (SLING-4219) [Sightly] Unrecognised operators in expressions are not properly reported as syntax errors

2014-12-05 Thread Felix Meschberger (JIRA) 

 [ 
https://issues.apache.org/jira/browse/SLING-4219?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Felix Meschberger resolved SLING-4219.
--
Resolution: Fixed

Thanks for providing the patch. I have applied it in Rev. 1643248

For the core problem of the SlingException I have created SLING-4220

 [Sightly] Unrecognised operators in expressions are not properly reported as 
 syntax errors
 --

 Key: SLING-4219
 URL: https://issues.apache.org/jira/browse/SLING-4219
 Project: Sling
  Issue Type: Bug
  Components: Scripting
Reporter: Radu Cotescu
Assignee: Felix Meschberger
Priority: Minor
 Fix For: Scripting Sightly Engine 1.0.0

 Attachments: SLING-4219.patch


 The 
 {{org.apache.sling.scripting.sightly.impl.compiler.frontend.SightlyParserErrorListener}}
  handles ANTLR parsing errors, in order to provide more detailed and easier 
 to understand error reporting for Sightly scripts.
 For the cases when ANTLR doesn't provide a {{RecognitionException}}, although 
 the listener still throws an error, the error is because the 
 {{SightlyParsingException}} is instantiated with a {{null}} cause.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Resolved] (SLING-4219) [Sightly] Unrecognised operators in expressions are not properly reported as syntax errors

2014-12-05 Thread Bertrand Delacretaz (JIRA) 

 [ 
https://issues.apache.org/jira/browse/SLING-4219?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Bertrand Delacretaz resolved SLING-4219.

Resolution: Invalid
  Assignee: Bertrand Delacretaz  (was: Felix Meschberger)

I have applied your second patch in revision 1643357, thanks!

 [Sightly] Unrecognised operators in expressions are not properly reported as 
 syntax errors
 --

 Key: SLING-4219
 URL: https://issues.apache.org/jira/browse/SLING-4219
 Project: Sling
  Issue Type: Bug
  Components: Scripting
Reporter: Radu Cotescu
Assignee: Bertrand Delacretaz
Priority: Minor
 Fix For: Scripting Sightly Engine 1.0.0

 Attachments: SLING-4219-2.patch, SLING-4219.patch


 The 
 {{org.apache.sling.scripting.sightly.impl.compiler.frontend.SightlyParserErrorListener}}
  handles ANTLR parsing errors, in order to provide more detailed and easier 
 to understand error reporting for Sightly scripts.
 For the cases when ANTLR doesn't provide a {{RecognitionException}}, although 
 the listener still throws an error, the error is because the 
 {{SightlyParsingException}} is instantiated with a {{null}} cause.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)