[jira] [Updated] (SLING-4219) [Sightly] Unrecognised operators in expressions are not properly reported as syntax errors

2014-12-05 Thread Radu Cotescu (JIRA)

 [ 
https://issues.apache.org/jira/browse/SLING-4219?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Radu Cotescu updated SLING-4219:

Summary: [Sightly] Unrecognised operators in expressions are not properly 
reported as syntax errors  (was: [Sightly] Unrecognised operators in exceptions 
are not properly handled)

 [Sightly] Unrecognised operators in expressions are not properly reported as 
 syntax errors
 --

 Key: SLING-4219
 URL: https://issues.apache.org/jira/browse/SLING-4219
 Project: Sling
  Issue Type: Bug
  Components: Scripting
Reporter: Radu Cotescu
Priority: Minor
 Fix For: Scripting Sightly Engine 1.0.0


 The 
 {{org.apache.sling.scripting.sightly.impl.compiler.frontend.SightlyParserErrorListener}}
  handles ANTLR parsing errors, in order to provide more detailed and easier 
 to understand error reporting for Sightly scripts.
 For the cases when ANTLR doesn't provide a {{RecognitionException}}, although 
 the listener still throws an error, the error is because the 
 {{SightlyParsingException}} is instantiated with a {{null}} cause.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (SLING-4219) [Sightly] Unrecognised operators in expressions are not properly reported as syntax errors

2014-12-05 Thread Radu Cotescu (JIRA)

 [ 
https://issues.apache.org/jira/browse/SLING-4219?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Radu Cotescu updated SLING-4219:

Attachment: SLING-4219.patch

The attached patch does the following:

* improves error reporting by not setting a null cause for the 
SightlyParsingException in SightlyParserErrorListener
* adds more details to the parsing error's message

 [Sightly] Unrecognised operators in expressions are not properly reported as 
 syntax errors
 --

 Key: SLING-4219
 URL: https://issues.apache.org/jira/browse/SLING-4219
 Project: Sling
  Issue Type: Bug
  Components: Scripting
Reporter: Radu Cotescu
Priority: Minor
 Fix For: Scripting Sightly Engine 1.0.0

 Attachments: SLING-4219.patch


 The 
 {{org.apache.sling.scripting.sightly.impl.compiler.frontend.SightlyParserErrorListener}}
  handles ANTLR parsing errors, in order to provide more detailed and easier 
 to understand error reporting for Sightly scripts.
 For the cases when ANTLR doesn't provide a {{RecognitionException}}, although 
 the listener still throws an error, the error is because the 
 {{SightlyParsingException}} is instantiated with a {{null}} cause.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (SLING-4219) [Sightly] Unrecognised operators in expressions are not properly reported as syntax errors

2014-12-05 Thread Radu Cotescu (JIRA)

 [ 
https://issues.apache.org/jira/browse/SLING-4219?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Radu Cotescu updated SLING-4219:

Attachment: SLING-4219-2.patch

The second patch ([^SLING-4219-2.patch]) increases the verbosity of the 
reported parsing errors in {{UnitLoader}}.

 [Sightly] Unrecognised operators in expressions are not properly reported as 
 syntax errors
 --

 Key: SLING-4219
 URL: https://issues.apache.org/jira/browse/SLING-4219
 Project: Sling
  Issue Type: Bug
  Components: Scripting
Reporter: Radu Cotescu
Assignee: Felix Meschberger
Priority: Minor
 Fix For: Scripting Sightly Engine 1.0.0

 Attachments: SLING-4219-2.patch, SLING-4219.patch


 The 
 {{org.apache.sling.scripting.sightly.impl.compiler.frontend.SightlyParserErrorListener}}
  handles ANTLR parsing errors, in order to provide more detailed and easier 
 to understand error reporting for Sightly scripts.
 For the cases when ANTLR doesn't provide a {{RecognitionException}}, although 
 the listener still throws an error, the error is because the 
 {{SightlyParsingException}} is instantiated with a {{null}} cause.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)