[jira] Commented: (SLING-1560) Improve and clean up code

2010-08-24 Thread Carsten Ziegeler (JIRA)

[ 
https://issues.apache.org/jira/browse/SLING-1560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12901921#action_12901921
 ] 

Carsten Ziegeler commented on SLING-1560:
-

I've done another minor update: move most of the activation stuff into the run 
method and removed a local instance variable for clarification in revision 
988593

 Improve and clean up code
 -

 Key: SLING-1560
 URL: https://issues.apache.org/jira/browse/SLING-1560
 Project: Sling
  Issue Type: Improvement
  Components: Installer
Affects Versions: OSGi Installer 3.0.0, JCR Installer 3.0.0
Reporter: Carsten Ziegeler
Assignee: Carsten Ziegeler
 Fix For: OSGi Installer 3.0.0, JCR Installer 3.0.0


 In order to fix some outstanding bugs and to add new features, a code review 
 and clean up seems to be a good idea :)
 This bug will keep track of all changes to the code that don't add new 
 features

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (SLING-1560) Improve and clean up code

2010-08-18 Thread Carsten Ziegeler (JIRA)

[ 
https://issues.apache.org/jira/browse/SLING-1560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12899762#action_12899762
 ] 

Carsten Ziegeler commented on SLING-1560:
-

Removed the statistics interface and the counters in revision 986583

 Improve and clean up code
 -

 Key: SLING-1560
 URL: https://issues.apache.org/jira/browse/SLING-1560
 Project: Sling
  Issue Type: Improvement
  Components: Installer
Affects Versions: OSGi Installer 3.0.0, JCR Installer 3.0.0
Reporter: Carsten Ziegeler
Assignee: Carsten Ziegeler
 Fix For: OSGi Installer 3.0.0, JCR Installer 3.0.0


 In order to fix some outstanding bugs and to add new features, a code review 
 and clean up seems to be a good idea :)
 This bug will keep track of all changes to the code that don't add new 
 features

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (SLING-1560) Improve and clean up code

2010-08-18 Thread Carsten Ziegeler (JIRA)

[ 
https://issues.apache.org/jira/browse/SLING-1560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12899825#action_12899825
 ] 

Carsten Ziegeler commented on SLING-1560:
-

Simplified the osgi installer task interface and the task generation in 
revision 986645

 Improve and clean up code
 -

 Key: SLING-1560
 URL: https://issues.apache.org/jira/browse/SLING-1560
 Project: Sling
  Issue Type: Improvement
  Components: Installer
Affects Versions: OSGi Installer 3.0.0, JCR Installer 3.0.0
Reporter: Carsten Ziegeler
Assignee: Carsten Ziegeler
 Fix For: OSGi Installer 3.0.0, JCR Installer 3.0.0


 In order to fix some outstanding bugs and to add new features, a code review 
 and clean up seems to be a good idea :)
 This bug will keep track of all changes to the code that don't add new 
 features

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (SLING-1560) Improve and clean up code

2010-08-18 Thread Justin Edelson (JIRA)

[ 
https://issues.apache.org/jira/browse/SLING-1560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12899924#action_12899924
 ] 

Justin Edelson commented on SLING-1560:
---

fixed failing IT in r986813

 Improve and clean up code
 -

 Key: SLING-1560
 URL: https://issues.apache.org/jira/browse/SLING-1560
 Project: Sling
  Issue Type: Improvement
  Components: Installer
Affects Versions: OSGi Installer 3.0.0, JCR Installer 3.0.0
Reporter: Carsten Ziegeler
Assignee: Carsten Ziegeler
 Fix For: OSGi Installer 3.0.0, JCR Installer 3.0.0


 In order to fix some outstanding bugs and to add new features, a code review 
 and clean up seems to be a good idea :)
 This bug will keep track of all changes to the code that don't add new 
 features

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (SLING-1560) Improve and clean up code

2010-08-13 Thread Carsten Ziegeler (JIRA)

[ 
https://issues.apache.org/jira/browse/SLING-1560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12898197#action_12898197
 ] 

Carsten Ziegeler commented on SLING-1560:
-

Merge installer impl and thread, make registered resources comparable

 Improve and clean up code
 -

 Key: SLING-1560
 URL: https://issues.apache.org/jira/browse/SLING-1560
 Project: Sling
  Issue Type: Improvement
  Components: Installer
Affects Versions: OSGi Installer 3.0.0, JCR Installer 3.0.0
Reporter: Carsten Ziegeler
Assignee: Carsten Ziegeler
 Fix For: OSGi Installer 3.0.0, JCR Installer 3.0.0


 In order to fix some outstanding bugs and to add new features, a code review 
 and clean up seems to be a good idea :)
 This bug will keep track of all changes to the code that don't add new 
 features

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (SLING-1560) Improve and clean up code

2010-08-12 Thread Carsten Ziegeler (JIRA)

[ 
https://issues.apache.org/jira/browse/SLING-1560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12897599#action_12897599
 ] 

Carsten Ziegeler commented on SLING-1560:
-

Changes in revision 984660
Remove unused Sling API reference from tests in jcr install

 Improve and clean up code
 -

 Key: SLING-1560
 URL: https://issues.apache.org/jira/browse/SLING-1560
 Project: Sling
  Issue Type: Improvement
  Components: Installer
Affects Versions: OSGi Installer 3.0.0, JCR Installer 3.0.0
Reporter: Carsten Ziegeler
Assignee: Carsten Ziegeler
 Fix For: OSGi Installer 3.0.0, JCR Installer 3.0.0


 In order to fix some outstanding bugs and to add new features, a code review 
 and clean up seems to be a good idea :)
 This bug will keep track of all changes to the code that don't add new 
 features

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (SLING-1560) Improve and clean up code

2010-08-12 Thread Carsten Ziegeler (JIRA)

[ 
https://issues.apache.org/jira/browse/SLING-1560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12897668#action_12897668
 ] 

Carsten Ziegeler commented on SLING-1560:
-

Changes in revision 984709
Further reduce the installer context - this will make it easier to make it 
public for pluggable tasks
Removed most of the stuff from the installer itself - we can now merge the 
installer and the thread

 Improve and clean up code
 -

 Key: SLING-1560
 URL: https://issues.apache.org/jira/browse/SLING-1560
 Project: Sling
  Issue Type: Improvement
  Components: Installer
Affects Versions: OSGi Installer 3.0.0, JCR Installer 3.0.0
Reporter: Carsten Ziegeler
Assignee: Carsten Ziegeler
 Fix For: OSGi Installer 3.0.0, JCR Installer 3.0.0


 In order to fix some outstanding bugs and to add new features, a code review 
 and clean up seems to be a good idea :)
 This bug will keep track of all changes to the code that don't add new 
 features

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (SLING-1560) Improve and clean up code

2010-08-11 Thread Carsten Ziegeler (JIRA)

[ 
https://issues.apache.org/jira/browse/SLING-1560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12897155#action_12897155
 ] 

Carsten Ziegeler commented on SLING-1560:
-

Changes in revision: 984304
Further reduce the usage of the installer context

 Improve and clean up code
 -

 Key: SLING-1560
 URL: https://issues.apache.org/jira/browse/SLING-1560
 Project: Sling
  Issue Type: Improvement
  Components: Installer
Affects Versions: OSGi Installer 3.0.0, JCR Installer 3.0.0
Reporter: Carsten Ziegeler
Assignee: Carsten Ziegeler
 Fix For: OSGi Installer 3.0.0, JCR Installer 3.0.0


 In order to fix some outstanding bugs and to add new features, a code review 
 and clean up seems to be a good idea :)
 This bug will keep track of all changes to the code that don't add new 
 features

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (SLING-1560) Improve and clean up code

2010-08-11 Thread Carsten Ziegeler (JIRA)

[ 
https://issues.apache.org/jira/browse/SLING-1560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12897266#action_12897266
 ] 

Carsten Ziegeler commented on SLING-1560:
-

Changes in revision 984405
Do counter handling internally and tasks should not throw an exception

 Improve and clean up code
 -

 Key: SLING-1560
 URL: https://issues.apache.org/jira/browse/SLING-1560
 Project: Sling
  Issue Type: Improvement
  Components: Installer
Affects Versions: OSGi Installer 3.0.0, JCR Installer 3.0.0
Reporter: Carsten Ziegeler
Assignee: Carsten Ziegeler
 Fix For: OSGi Installer 3.0.0, JCR Installer 3.0.0


 In order to fix some outstanding bugs and to add new features, a code review 
 and clean up seems to be a good idea :)
 This bug will keep track of all changes to the code that don't add new 
 features

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (SLING-1560) Improve and clean up code

2010-08-11 Thread Carsten Ziegeler (JIRA)

[ 
https://issues.apache.org/jira/browse/SLING-1560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12897318#action_12897318
 ] 

Carsten Ziegeler commented on SLING-1560:
-

Changes in revision: 984451
The installable resource factory detects now only known types - this allows for 
pluggable formats.

 Improve and clean up code
 -

 Key: SLING-1560
 URL: https://issues.apache.org/jira/browse/SLING-1560
 Project: Sling
  Issue Type: Improvement
  Components: Installer
Affects Versions: OSGi Installer 3.0.0, JCR Installer 3.0.0
Reporter: Carsten Ziegeler
Assignee: Carsten Ziegeler
 Fix For: OSGi Installer 3.0.0, JCR Installer 3.0.0


 In order to fix some outstanding bugs and to add new features, a code review 
 and clean up seems to be a good idea :)
 This bug will keep track of all changes to the code that don't add new 
 features

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (SLING-1560) Improve and clean up code

2010-08-11 Thread Carsten Ziegeler (JIRA)

[ 
https://issues.apache.org/jira/browse/SLING-1560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12897361#action_12897361
 ] 

Carsten Ziegeler commented on SLING-1560:
-

Changs in revision 984500
Removed the installable resources factory again and converted the installable 
resource to a class; this makes it easier for clients of the osgi installer.

 Improve and clean up code
 -

 Key: SLING-1560
 URL: https://issues.apache.org/jira/browse/SLING-1560
 Project: Sling
  Issue Type: Improvement
  Components: Installer
Affects Versions: OSGi Installer 3.0.0, JCR Installer 3.0.0
Reporter: Carsten Ziegeler
Assignee: Carsten Ziegeler
 Fix For: OSGi Installer 3.0.0, JCR Installer 3.0.0


 In order to fix some outstanding bugs and to add new features, a code review 
 and clean up seems to be a good idea :)
 This bug will keep track of all changes to the code that don't add new 
 features

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (SLING-1560) Improve and clean up code

2010-08-10 Thread Carsten Ziegeler (JIRA)

[ 
https://issues.apache.org/jira/browse/SLING-1560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12896926#action_12896926
 ] 

Carsten Ziegeler commented on SLING-1560:
-

Changes in revision 983998:

Removed the input stream support for dictionaries from the osgi installer - 
reading configurations is up to the providers like jcr install. By removing 
this we can reduce the complexity of the installer.
Moved logging to a Logger class to avoid passing around the installer context 
just for logging
Moved statistics methods to own interface as this is just used for testing and 
should not be part of the public api
Cleaned up installable resource factory
Changed type of installable resource from enum to String in order to provide 
pluggable installers in the future

 Improve and clean up code
 -

 Key: SLING-1560
 URL: https://issues.apache.org/jira/browse/SLING-1560
 Project: Sling
  Issue Type: Improvement
  Components: Installer
Affects Versions: OSGi Installer 3.0.0, JCR Installer 3.0.0
Reporter: Carsten Ziegeler
Assignee: Carsten Ziegeler
 Fix For: OSGi Installer 3.0.0, JCR Installer 3.0.0


 In order to fix some outstanding bugs and to add new features, a code review 
 and clean up seems to be a good idea :)
 This bug will keep track of all changes to the code that don't add new 
 features

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (SLING-1560) Improve and clean up code

2010-08-10 Thread Carsten Ziegeler (JIRA)

[ 
https://issues.apache.org/jira/browse/SLING-1560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12897076#action_12897076
 ] 

Carsten Ziegeler commented on SLING-1560:
-

Changes in revision 984254:
Move all config admin related stuff into config admin package - the config 
support must be optional (VIP)
Reduce usage of installer context (VIP)

 Improve and clean up code
 -

 Key: SLING-1560
 URL: https://issues.apache.org/jira/browse/SLING-1560
 Project: Sling
  Issue Type: Improvement
  Components: Installer
Affects Versions: OSGi Installer 3.0.0, JCR Installer 3.0.0
Reporter: Carsten Ziegeler
Assignee: Carsten Ziegeler
 Fix For: OSGi Installer 3.0.0, JCR Installer 3.0.0


 In order to fix some outstanding bugs and to add new features, a code review 
 and clean up seems to be a good idea :)
 This bug will keep track of all changes to the code that don't add new 
 features

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (SLING-1560) Improve and clean up code

2010-06-18 Thread Carsten Ziegeler (JIRA)

[ 
https://issues.apache.org/jira/browse/SLING-1560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12880096#action_12880096
 ] 

Carsten Ziegeler commented on SLING-1560:
-

Converted InstallableResource to an interface again and created factory service 
- this gives us more flexibility if we extend the installer at some point.
Changes in revision 955865 and 955867
I'm not 100% about the factory interface yet, it might change a little bit

 Improve and clean up code
 -

 Key: SLING-1560
 URL: https://issues.apache.org/jira/browse/SLING-1560
 Project: Sling
  Issue Type: Improvement
  Components: Installer
Affects Versions: JCR Installer 3.0.0, OSGi Installer 3.0.0
Reporter: Carsten Ziegeler
Assignee: Carsten Ziegeler
 Fix For: JCR Installer 3.0.0, OSGi Installer 3.0.0


 In order to fix some outstanding bugs and to add new features, a code review 
 and clean up seems to be a good idea :)
 This bug will keep track of all changes to the code that don't add new 
 features

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (SLING-1560) Improve and clean up code

2010-06-18 Thread Carsten Ziegeler (JIRA)

[ 
https://issues.apache.org/jira/browse/SLING-1560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12880099#action_12880099
 ] 

Carsten Ziegeler commented on SLING-1560:
-

Moved the DigestUtil stuff into private package in revision 955872

 Improve and clean up code
 -

 Key: SLING-1560
 URL: https://issues.apache.org/jira/browse/SLING-1560
 Project: Sling
  Issue Type: Improvement
  Components: Installer
Affects Versions: JCR Installer 3.0.0, OSGi Installer 3.0.0
Reporter: Carsten Ziegeler
Assignee: Carsten Ziegeler
 Fix For: JCR Installer 3.0.0, OSGi Installer 3.0.0


 In order to fix some outstanding bugs and to add new features, a code review 
 and clean up seems to be a good idea :)
 This bug will keep track of all changes to the code that don't add new 
 features

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (SLING-1560) Improve and clean up code

2010-06-18 Thread Bertrand Delacretaz (JIRA)

[ 
https://issues.apache.org/jira/browse/SLING-1560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12880118#action_12880118
 ] 

Bertrand Delacretaz commented on SLING-1560:


Justin, maybe you mean SLING-1489 about JCR 2?

Found it starred in my email inbox, didn't find time to work on that yet...

 Improve and clean up code
 -

 Key: SLING-1560
 URL: https://issues.apache.org/jira/browse/SLING-1560
 Project: Sling
  Issue Type: Improvement
  Components: Installer
Affects Versions: JCR Installer 3.0.0, OSGi Installer 3.0.0
Reporter: Carsten Ziegeler
Assignee: Carsten Ziegeler
 Fix For: JCR Installer 3.0.0, OSGi Installer 3.0.0


 In order to fix some outstanding bugs and to add new features, a code review 
 and clean up seems to be a good idea :)
 This bug will keep track of all changes to the code that don't add new 
 features

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (SLING-1560) Improve and clean up code

2010-06-18 Thread Carsten Ziegeler (JIRA)

[ 
https://issues.apache.org/jira/browse/SLING-1560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12880140#action_12880140
 ] 

Carsten Ziegeler commented on SLING-1560:
-

Remove unused StartLevelTracker in 955906

 Improve and clean up code
 -

 Key: SLING-1560
 URL: https://issues.apache.org/jira/browse/SLING-1560
 Project: Sling
  Issue Type: Improvement
  Components: Installer
Affects Versions: JCR Installer 3.0.0, OSGi Installer 3.0.0
Reporter: Carsten Ziegeler
Assignee: Carsten Ziegeler
 Fix For: JCR Installer 3.0.0, OSGi Installer 3.0.0


 In order to fix some outstanding bugs and to add new features, a code review 
 and clean up seems to be a good idea :)
 This bug will keep track of all changes to the code that don't add new 
 features

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (SLING-1560) Improve and clean up code

2010-06-18 Thread Carsten Ziegeler (JIRA)

[ 
https://issues.apache.org/jira/browse/SLING-1560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12880143#action_12880143
 ] 

Carsten Ziegeler commented on SLING-1560:
-

Move all tracker code into service to hide implementation details
Don't throw an exception on shutdown
Revision 955916

 Improve and clean up code
 -

 Key: SLING-1560
 URL: https://issues.apache.org/jira/browse/SLING-1560
 Project: Sling
  Issue Type: Improvement
  Components: Installer
Affects Versions: JCR Installer 3.0.0, OSGi Installer 3.0.0
Reporter: Carsten Ziegeler
Assignee: Carsten Ziegeler
 Fix For: JCR Installer 3.0.0, OSGi Installer 3.0.0


 In order to fix some outstanding bugs and to add new features, a code review 
 and clean up seems to be a good idea :)
 This bug will keep track of all changes to the code that don't add new 
 features

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (SLING-1560) Improve and clean up code

2010-06-18 Thread Justin Edelson (JIRA)

[ 
https://issues.apache.org/jira/browse/SLING-1560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12880167#action_12880167
 ] 

Justin Edelson commented on SLING-1560:
---

Bertrand - IIRC, I created that issue more as a reminder to figure out how to 
respond to a NODE_MOVED event. 

 Improve and clean up code
 -

 Key: SLING-1560
 URL: https://issues.apache.org/jira/browse/SLING-1560
 Project: Sling
  Issue Type: Improvement
  Components: Installer
Affects Versions: JCR Installer 3.0.0, OSGi Installer 3.0.0
Reporter: Carsten Ziegeler
Assignee: Carsten Ziegeler
 Fix For: JCR Installer 3.0.0, OSGi Installer 3.0.0


 In order to fix some outstanding bugs and to add new features, a code review 
 and clean up seems to be a good idea :)
 This bug will keep track of all changes to the code that don't add new 
 features

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (SLING-1560) Improve and clean up code

2010-06-17 Thread Justin Edelson (JIRA)

[ 
https://issues.apache.org/jira/browse/SLING-1560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12879884#action_12879884
 ] 

Justin Edelson commented on SLING-1560:
---

not to add more to your workload, but could you look at upgrading to JCR 2 as 
part of this issue? I'd started to as part of SLING-1488, but got bogged down 
by some timing issues.

 Improve and clean up code
 -

 Key: SLING-1560
 URL: https://issues.apache.org/jira/browse/SLING-1560
 Project: Sling
  Issue Type: Improvement
  Components: Installer
Affects Versions: JCR Installer 3.0.0, OSGi Installer 3.0.0
Reporter: Carsten Ziegeler
Assignee: Carsten Ziegeler
 Fix For: JCR Installer 3.0.0, OSGi Installer 3.0.0


 In order to fix some outstanding bugs and to add new features, a code review 
 and clean up seems to be a good idea :)
 This bug will keep track of all changes to the code that don't add new 
 features

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (SLING-1560) Improve and clean up code

2010-06-17 Thread Carsten Ziegeler (JIRA)

[ 
https://issues.apache.org/jira/browse/SLING-1560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12879896#action_12879896
 ] 

Carsten Ziegeler commented on SLING-1560:
-

I'm not sure what you exactly mean - I think it would be fine if the installer 
would still work with JCR 1.x - I see atm no need to tie it to JCR 2

 Improve and clean up code
 -

 Key: SLING-1560
 URL: https://issues.apache.org/jira/browse/SLING-1560
 Project: Sling
  Issue Type: Improvement
  Components: Installer
Affects Versions: JCR Installer 3.0.0, OSGi Installer 3.0.0
Reporter: Carsten Ziegeler
Assignee: Carsten Ziegeler
 Fix For: JCR Installer 3.0.0, OSGi Installer 3.0.0


 In order to fix some outstanding bugs and to add new features, a code review 
 and clean up seems to be a good idea :)
 This bug will keep track of all changes to the code that don't add new 
 features

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (SLING-1560) Improve and clean up code

2010-06-17 Thread Carsten Ziegeler (JIRA)

[ 
https://issues.apache.org/jira/browse/SLING-1560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12879902#action_12879902
 ] 

Carsten Ziegeler commented on SLING-1560:
-

To clean up the InstallableResource I've created an interface and two 
implementations in revision 955699
In revision I changed this back again to a single implementation - I've added 
an enum type for the various resource types to InstallableResource
Next will be a detection mechanism for the resource type - this is currently a 
little bit spread around

 Improve and clean up code
 -

 Key: SLING-1560
 URL: https://issues.apache.org/jira/browse/SLING-1560
 Project: Sling
  Issue Type: Improvement
  Components: Installer
Affects Versions: JCR Installer 3.0.0, OSGi Installer 3.0.0
Reporter: Carsten Ziegeler
Assignee: Carsten Ziegeler
 Fix For: JCR Installer 3.0.0, OSGi Installer 3.0.0


 In order to fix some outstanding bugs and to add new features, a code review 
 and clean up seems to be a good idea :)
 This bug will keep track of all changes to the code that don't add new 
 features

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (SLING-1560) Improve and clean up code

2010-06-17 Thread Justin Edelson (JIRA)

[ 
https://issues.apache.org/jira/browse/SLING-1560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12879901#action_12879901
 ] 

Justin Edelson commented on SLING-1560:
---

I had to look at the code to remember what happened here. I slightly mispoke.

The change I failed to make was to upgrade the version of commons.testing being 
used. In SLING-1488, I extracted a test helper class from jcr.install 
(EventHelper) into commons.testing. When I went to delete this class from the 
jcr.install source and have jcr.install refer to the trunk version of  
commons.testing, two tests started failing. Those failures, I believe, were 
resulting from testing under Jackrabbit 2.

So the upgrade is actually to commons.testing 2.0.5-SNAPSHOT, which also will 
bring in JR 2 and JCR 2 as (test-scoped) dependencies.

I could have sworn I posted something to the mailing list about it when it 
happened, but perhaps I forgot to.

 Improve and clean up code
 -

 Key: SLING-1560
 URL: https://issues.apache.org/jira/browse/SLING-1560
 Project: Sling
  Issue Type: Improvement
  Components: Installer
Affects Versions: JCR Installer 3.0.0, OSGi Installer 3.0.0
Reporter: Carsten Ziegeler
Assignee: Carsten Ziegeler
 Fix For: JCR Installer 3.0.0, OSGi Installer 3.0.0


 In order to fix some outstanding bugs and to add new features, a code review 
 and clean up seems to be a good idea :)
 This bug will keep track of all changes to the code that don't add new 
 features

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (SLING-1560) Improve and clean up code

2010-06-17 Thread Carsten Ziegeler (JIRA)

[ 
https://issues.apache.org/jira/browse/SLING-1560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12879904#action_12879904
 ] 

Carsten Ziegeler commented on SLING-1560:
-

@Justin : I ok, now I got it :) I'll have a look at that as well

 Improve and clean up code
 -

 Key: SLING-1560
 URL: https://issues.apache.org/jira/browse/SLING-1560
 Project: Sling
  Issue Type: Improvement
  Components: Installer
Affects Versions: JCR Installer 3.0.0, OSGi Installer 3.0.0
Reporter: Carsten Ziegeler
Assignee: Carsten Ziegeler
 Fix For: JCR Installer 3.0.0, OSGi Installer 3.0.0


 In order to fix some outstanding bugs and to add new features, a code review 
 and clean up seems to be a good idea :)
 This bug will keep track of all changes to the code that don't add new 
 features

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.