Re: [DISCUSS] Registering filters with Sling
+1 On 9/7/10 9:49 AM, Felix Meschberger wrote: Hi all, Traditionally javax.servlet.Filter services were picked up by the Sling Main Servlet and used as filters regardless of any service registration properties. The filter.scope property could optionally be used to define a scope for the filter (request or component before SLING-1213, now also INCLUDE, FORWARD, and ERROR). To not pick up filters destined for the Apache Felix Http Service (registered with the pattern service property) we explicitly xclude those. I would like to go a step further and * define a new service property sling.filter.scope * deprecate the old filter.scope property * require services to either have the sling.filter.scope or the filter.scope (backwards compatibility) property set * optionally: support for a configuration option to cause filters without a scope property to still be picked up I consider renaming the official name to prevent any name collisions. WDYT ? Regards Felix
Re: [DISCUSS] Registering filters with Sling
Ian Boston wrote On 7 Sep 2010, at 14:49, Felix Meschberger wrote: Hi all, Traditionally javax.servlet.Filter services were picked up by the Sling Main Servlet and used as filters regardless of any service registration properties. The filter.scope property could optionally be used to define a scope for the filter (request or component before SLING-1213, now also INCLUDE, FORWARD, and ERROR). To not pick up filters destined for the Apache Felix Http Service (registered with the pattern service property) we explicitly xclude those. I would like to go a step further and * define a new service property sling.filter.scope * deprecate the old filter.scope property * require services to either have the sling.filter.scope or the filter.scope (backwards compatibility) property set * optionally: support for a configuration option to cause filters without a scope property to still be picked up I consider renaming the official name to prevent any name collisions. WDYT ? Yes, makes sense to me. Might reqiure some patches for those downstream but it will be minor, and will generate a better distinction between Sling filters and httpservice filters. Sounds ok to me, but if we rename the scope prop we should rename the order prop as well to avoid collisions. Carsten -- Carsten Ziegeler cziege...@apache.org
Re: [DISCUSS] Registering filters with Sling
Felix Meschberger wrote The order property has already been deprecated in favor of the OSGi standard service.ranking property (as of FELIX-1213). Perfect :) Carsten -- Carsten Ziegeler cziege...@apache.org
Re: [DISCUSS] Registering filters with Sling
Hi all, Thanks for the feedback so far. I have created SLING-1734 [1] to track this change. Regards Felix [1] https://issues.apache.org/jira/browse/SLING-1734 On 07.09.2010 15:49, Felix Meschberger wrote: Hi all, Traditionally javax.servlet.Filter services were picked up by the Sling Main Servlet and used as filters regardless of any service registration properties. The filter.scope property could optionally be used to define a scope for the filter (request or component before SLING-1213, now also INCLUDE, FORWARD, and ERROR). To not pick up filters destined for the Apache Felix Http Service (registered with the pattern service property) we explicitly xclude those. I would like to go a step further and * define a new service property sling.filter.scope * deprecate the old filter.scope property * require services to either have the sling.filter.scope or the filter.scope (backwards compatibility) property set * optionally: support for a configuration option to cause filters without a scope property to still be picked up I consider renaming the official name to prevent any name collisions. WDYT ? Regards Felix
