Re: [GitHub] sling pull request: Pull Request for Eclipse Independent Resource ...

2016-03-19 Thread Andreas Schaefer Sr. 
Created a JIRA ticket for this:

https://issues.apache.org/jira/browse/SLING-5618 


Cheers - Andy Schaefer

> On Mar 16, 2016, at 10:06 PM, schaefa  wrote:
> 
> GitHub user schaefa opened a pull request:
> 
>https://github.com/apache/sling/pull/130
> 
>Pull Request for Eclipse Independent Resource Change Command Factory
> 
>This pull request provides the New Resource Change Command Factory, its 
> support class and some test classes copied from eclipse-test module. It also 
> contains a fix for the RAT plugin to exclude IntelliJ module files (.iml).
> 
> You can merge this pull request into a Git repository by running:
> 
>$ git pull https://github.com/headwirecom/sling trunk
> 
> Alternatively you can review and apply these changes as the patch at:
> 
>https://github.com/apache/sling/pull/130.patch
> 
> To close this pull request, make a commit to your master/trunk branch
> with (at least) the following in the commit message:
> 
>This closes #130
> 
> 
> commit dfdd8990270e355cf0130815ad5c702232888447
> Author: Andreas Schaefer 
> Date:   2016-03-15T00:11:53Z
> 
>Merge remote-tracking branch 'upstream/trunk' into trunk
> 
> commit 6224be4bb05e6348da0f9fc584e1869f7d2416ed
> Author: Andreas Schaefer 
> Date:   2016-03-15T16:51:05Z
> 
>Merge remote-tracking branch 'upstream/trunk' into trunk
> 
> commit 69fb47a67b80a67bf5cad52fc49ee52998fb2deb
> Author: Andreas Schaefer 
> Date:   2016-03-15T18:19:46Z
> 
>Merge remote-tracking branch 'upstream/trunk' into trunk
> 
> commit c99ad2c9a89d141f6071ad1db6ca7a9f8b4279b3
> Author: Andreas Schaefer 
> Date:   2016-03-16T21:46:56Z
> 
>Merge remote-tracking branch 'upstream/trunk' into trunk
> 
> commit 5b1bf0f11b7f2c3ee18cc5907279a97f0deb4a40
> Author: Andreas Schaefer 
> Date:   2016-03-17T05:01:45Z
> 
>Merge my 1.0.10 fork into the trunk.
> 
>This includes the Eclipse Inpendent Resource Change Command Factory, its 
> test classes and a fix to the RAT plugin to exclude IntelliJ module files 
> (.iml).
> 
>Signed-off-by: Andreas Schaefer 
> 
> 
> 
> 
> ---
> If your project is set up for it, you can reply to this email and have your
> reply appear on GitHub as well. If your project does not have this feature
> enabled and wishes so, or if the feature is enabled but not working, please
> contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
> with INFRA.
> ---

Re: [GitHub] sling pull request: Pull Request for Eclipse Independent Resource ...

2016-03-18 Thread Robert Munteanu 
On Thu, 2016-03-17 at 08:35 -0700, Andreas Schaefer Sr. wrote:
> Created a JIRA ticket for this:
> 
> https://issues.apache.org/jira/browse/SLING-5618
> 

Great, thanks! I already started to look at it and I think I'll have
some comments tomorrow.

Robert

> 
> Cheers - Andy Schaefer
> 
> > 
> > On Mar 16, 2016, at 10:06 PM, schaefa  wrote:
> > 
> > GitHub user schaefa opened a pull request:
> > 
> >    https://github.com/apache/sling/pull/130
> > 
> >    Pull Request for Eclipse Independent Resource Change Command
> > Factory
> > 
> >    This pull request provides the New Resource Change Command
> > Factory, its support class and some test classes copied from
> > eclipse-test module. It also contains a fix for the RAT plugin to
> > exclude IntelliJ module files (.iml).
> > 
> > You can merge this pull request into a Git repository by running:
> > 
> >    $ git pull https://github.com/headwirecom/sling trunk
> > 
> > Alternatively you can review and apply these changes as the patch
> > at:
> > 
> >    https://github.com/apache/sling/pull/130.patch
> > 
> > To close this pull request, make a commit to your master/trunk
> > branch
> > with (at least) the following in the commit message:
> > 
> >    This closes #130
> > 
> > 
> > commit dfdd8990270e355cf0130815ad5c702232888447
> > Author: Andreas Schaefer 
> > Date:   2016-03-15T00:11:53Z
> > 
> >    Merge remote-tracking branch 'upstream/trunk' into trunk
> > 
> > commit 6224be4bb05e6348da0f9fc584e1869f7d2416ed
> > Author: Andreas Schaefer 
> > Date:   2016-03-15T16:51:05Z
> > 
> >    Merge remote-tracking branch 'upstream/trunk' into trunk
> > 
> > commit 69fb47a67b80a67bf5cad52fc49ee52998fb2deb
> > Author: Andreas Schaefer 
> > Date:   2016-03-15T18:19:46Z
> > 
> >    Merge remote-tracking branch 'upstream/trunk' into trunk
> > 
> > commit c99ad2c9a89d141f6071ad1db6ca7a9f8b4279b3
> > Author: Andreas Schaefer 
> > Date:   2016-03-16T21:46:56Z
> > 
> >    Merge remote-tracking branch 'upstream/trunk' into trunk
> > 
> > commit 5b1bf0f11b7f2c3ee18cc5907279a97f0deb4a40
> > Author: Andreas Schaefer 
> > Date:   2016-03-17T05:01:45Z
> > 
> >    Merge my 1.0.10 fork into the trunk.
> > 
> >    This includes the Eclipse Inpendent Resource Change Command
> > Factory, its test classes and a fix to the RAT plugin to exclude
> > IntelliJ module files (.iml).
> > 
> >    Signed-off-by: Andreas Schaefer 
> > 
> > 
> > 
> > 
> > ---
> > If your project is set up for it, you can reply to this email and
> > have your
> > reply appear on GitHub as well. If your project does not have this
> > feature
> > enabled and wishes so, or if the feature is enabled but not
> > working, please
> > contact infrastructure at infrastruct...@apache.org or file a JIRA
> > ticket
> > with INFRA.
> > ---