Re: Updating our parent pom

[venkatesha murthy]

I have been following supporting Thymeleaf as an additional scripting
engine supported by Sling. I just wanted to understand the difference
between sightly (AEM HTL) with this scripting support and  what is the
difference PRIMARY between these two scripting languages?.

Any help is really appreciated.

Regards
Venky

On Mon, Jul 18, 2016 at 6:34 AM, Oliver Lietz  wrote:

> On Monday 18 July 2016 11:11:25 Carsten Ziegeler wrote:
> > > On Thursday 14 July 2016 21:43:45 Carsten Ziegeler wrote:
> [...]
> >
> > I've updated the parent pom as outlined above, including #11.
> >
> > It would be great if everyone can have a look before we start a release
>
> LGTM, building Scripting Thymeleaf (which is uses R6 features) with 27-
> SNAPSHOT results in same output except import range for Servlets.
>
> How about adding javax.inject to parent?
>
> Do we still need the plugin configuration for maven-bundle-plugin?
>
> O.
>
> > Thanks
> >
> >  Carsten
>
>

Re: Updating our parent pom

[Oliver Lietz]

On Monday 18 July 2016 11:11:25 Carsten Ziegeler wrote:
> > On Thursday 14 July 2016 21:43:45 Carsten Ziegeler wrote:
[...]
> 
> I've updated the parent pom as outlined above, including #11.
> 
> It would be great if everyone can have a look before we start a release

LGTM, building Scripting Thymeleaf (which is uses R6 features) with 27-
SNAPSHOT results in same output except import range for Servlets.

How about adding javax.inject to parent?

Do we still need the plugin configuration for maven-bundle-plugin?

O.

> Thanks
> 
>  Carsten

Re: Updating our parent pom

[Konrad Windszus]

> On 14 Jul 2016, at 21:43, Carsten Ziegeler  wrote:
> 
> Hi,
> 
> looking at our parent pom, we have there some really really old
> dependencies. The reasoning behind this is that we usually try to use
> the minimal possible version for a dependency. However, for some things
> newer versions are out for some time and are the de-facto standard.
> 
> I think we should
> 
> 1. Update the default java version for modules from 6 to 7
> 2. Update the dependency to OSGi Core from 4.1.0 to R6
> 3. Update the dependency to OSGi Cmpn from 4.1.0 to R6
> 4. Update the servlet api dependency from 2.4 to 3.0.1 or even 3.1.0
>   (Unfortunately this will break modules as the mvn coordinates have
> changed, but we can easily update those if we update the parent pom in
> those modules)
> 5. Update the jcr dependency to 2.0
> 6. Update the slf4j-api dependency from 1.5.2 to 1.7.6
> 7. Add the dependency for the OSGi annotations (@Version, @ProviderType,
> @ConsumerType)
> 8. Add the dependency for the OSGi DS and metatype annotations
> 9. Add the bnd maven plugin 3.2.0
> (see https://github.com/bndtools/bnd/tree/master/maven/bnd-maven-plugin)
> This plugin is newer than the maven bundle plugin and closer to bnd
> change. So we can start using this in our modules.
> 10. Maybe change the required maven version from 3.0.5 to 3.3.x
The fix being applied to https://issues.apache.org/jira/browse/SLING-5860 
 is not working. You must use 
the maven-enforcer-plugin for build requirements.

> 
> WDYT?
> 
> Regards
> Carsten
> -- 
> Carsten Ziegeler
> Adobe Research Switzerland
> cziege...@apache.org

Re: Updating our parent pom

[Robert Munteanu]

On Mon, 2016-07-18 at 11:23 +0200, Carsten Ziegeler wrote:
> > 
> > On Mon, 2016-07-18 at 11:11 +0200, Carsten Ziegeler wrote:
> > > > 
> > > > On Thursday 14 July 2016 21:43:45 Carsten Ziegeler wrote:
> > > > > Hi,
> > > > > 
> > > > > looking at our parent pom, we have there some really really
> > > > > old
> > > > > dependencies. The reasoning behind this is that we usually
> > > > > try to
> > > > > use
> > > > > the minimal possible version for a dependency. However, for
> > > > > some
> > > > > things
> > > > > newer versions are out for some time and are the de-facto
> > > > > standard.
> > > > > 
> > > > > I think we should
> > > > > 
> > > > > 1. Update the default java version for modules from 6 to 7
> > > > > 2. Update the dependency to OSGi Core from 4.1.0 to R6
> > > > > 3. Update the dependency to OSGi Cmpn from 4.1.0 to R6
> > > > > 4. Update the servlet api dependency from 2.4 to 3.0.1 or
> > > > > even
> > > > > 3.1.0
> > > > >    (Unfortunately this will break modules as the mvn
> > > > > coordinates
> > > > > have
> > > > > changed, but we can easily update those if we update the
> > > > > parent
> > > > > pom in
> > > > > those modules)
> > > > > 5. Update the jcr dependency to 2.0
> > > > > 6. Update the slf4j-api dependency from 1.5.2 to 1.7.6
> > > > > 7. Add the dependency for the OSGi annotations (@Version,
> > > > > @ProviderType,
> > > > > @ConsumerType)
> > > > > 8. Add the dependency for the OSGi DS and metatype
> > > > > annotations
> > > > > 9. Add the bnd maven plugin 3.2.0
> > > > > (see https://github.com/bndtools/bnd/tree/master/maven/bnd-ma
> > > > > ven-
> > > > > plugin)
> > > > > This plugin is newer than the maven bundle plugin and closer
> > > > > to
> > > > > bnd
> > > > > change. So we can start using this in our modules.
> > > > > 10. Maybe change the required maven version from 3.0.5 to
> > > > > 3.3.x
> > > > 
> > > > 11. Update maven-bundle-plugin to 3.2.0
> > > > 
> > > I've updated the parent pom as outlined above, including #11.
> > > 
> > > It would be great if everyone can have a look before we start a
> > > release
> > 
> > I'd like to quickly check if we can remove the check-memory-task
> > executions which notify the user about the memory requirements for
> > building Sling.
> > 
> > Since we now require Maven 3.3 and that picks up the
> > .mvn/jvm.config
> > file we should not need them any longer.
> > 
> +1
> 

Done. Also a quick smoke test with the JSON bundle confirms the
findings from SLING-5851

Robert

Re: Updating our parent pom

[Carsten Ziegeler]

>> On Thursday 14 July 2016 21:43:45 Carsten Ziegeler wrote:
>>> Hi,
>>>
>>> looking at our parent pom, we have there some really really old
>>> dependencies. The reasoning behind this is that we usually try to use
>>> the minimal possible version for a dependency. However, for some things
>>> newer versions are out for some time and are the de-facto standard.
>>>
>>> I think we should
>>>
>>> 1. Update the default java version for modules from 6 to 7
>>> 2. Update the dependency to OSGi Core from 4.1.0 to R6
>>> 3. Update the dependency to OSGi Cmpn from 4.1.0 to R6
>>> 4. Update the servlet api dependency from 2.4 to 3.0.1 or even 3.1.0
>>>(Unfortunately this will break modules as the mvn coordinates have
>>> changed, but we can easily update those if we update the parent pom in
>>> those modules)
>>> 5. Update the jcr dependency to 2.0
>>> 6. Update the slf4j-api dependency from 1.5.2 to 1.7.6
>>> 7. Add the dependency for the OSGi annotations (@Version, @ProviderType,
>>> @ConsumerType)
>>> 8. Add the dependency for the OSGi DS and metatype annotations
>>> 9. Add the bnd maven plugin 3.2.0
>>> (see https://github.com/bndtools/bnd/tree/master/maven/bnd-maven-plugin)
>>> This plugin is newer than the maven bundle plugin and closer to bnd
>>> change. So we can start using this in our modules.
>>> 10. Maybe change the required maven version from 3.0.5 to 3.3.x
>>
>> 11. Update maven-bundle-plugin to 3.2.0
>>
> I've updated the parent pom as outlined above, including #11.
> 
> It would be great if everyone can have a look before we start a release
> 

I've also created https://issues.apache.org/jira/browse/SLING-5851
which lists changes we must do for a module to update to parent pom 27.

Carsten

 

-- 
Carsten Ziegeler
Adobe Research Switzerland
cziege...@apache.org

Re: Updating our parent pom

[Carsten Ziegeler]

> On Mon, 2016-07-18 at 11:11 +0200, Carsten Ziegeler wrote:
>>>
>>> On Thursday 14 July 2016 21:43:45 Carsten Ziegeler wrote:
 Hi,

 looking at our parent pom, we have there some really really old
 dependencies. The reasoning behind this is that we usually try to
 use
 the minimal possible version for a dependency. However, for some
 things
 newer versions are out for some time and are the de-facto
 standard.

 I think we should

 1. Update the default java version for modules from 6 to 7
 2. Update the dependency to OSGi Core from 4.1.0 to R6
 3. Update the dependency to OSGi Cmpn from 4.1.0 to R6
 4. Update the servlet api dependency from 2.4 to 3.0.1 or even
 3.1.0
(Unfortunately this will break modules as the mvn coordinates
 have
 changed, but we can easily update those if we update the parent
 pom in
 those modules)
 5. Update the jcr dependency to 2.0
 6. Update the slf4j-api dependency from 1.5.2 to 1.7.6
 7. Add the dependency for the OSGi annotations (@Version,
 @ProviderType,
 @ConsumerType)
 8. Add the dependency for the OSGi DS and metatype annotations
 9. Add the bnd maven plugin 3.2.0
 (see https://github.com/bndtools/bnd/tree/master/maven/bnd-maven-
 plugin)
 This plugin is newer than the maven bundle plugin and closer to
 bnd
 change. So we can start using this in our modules.
 10. Maybe change the required maven version from 3.0.5 to 3.3.x
>>>
>>> 11. Update maven-bundle-plugin to 3.2.0
>>>
>> I've updated the parent pom as outlined above, including #11.
>>
>> It would be great if everyone can have a look before we start a
>> release
> 
> I'd like to quickly check if we can remove the check-memory-task
> executions which notify the user about the memory requirements for
> building Sling.
> 
> Since we now require Maven 3.3 and that picks up the .mvn/jvm.config
> file we should not need them any longer.
> 
+1


 

-- 
Carsten Ziegeler
Adobe Research Switzerland
cziege...@apache.org

Re: Updating our parent pom

[Robert Munteanu]

On Mon, 2016-07-18 at 11:11 +0200, Carsten Ziegeler wrote:
> > 
> > On Thursday 14 July 2016 21:43:45 Carsten Ziegeler wrote:
> > > Hi,
> > > 
> > > looking at our parent pom, we have there some really really old
> > > dependencies. The reasoning behind this is that we usually try to
> > > use
> > > the minimal possible version for a dependency. However, for some
> > > things
> > > newer versions are out for some time and are the de-facto
> > > standard.
> > > 
> > > I think we should
> > > 
> > > 1. Update the default java version for modules from 6 to 7
> > > 2. Update the dependency to OSGi Core from 4.1.0 to R6
> > > 3. Update the dependency to OSGi Cmpn from 4.1.0 to R6
> > > 4. Update the servlet api dependency from 2.4 to 3.0.1 or even
> > > 3.1.0
> > >    (Unfortunately this will break modules as the mvn coordinates
> > > have
> > > changed, but we can easily update those if we update the parent
> > > pom in
> > > those modules)
> > > 5. Update the jcr dependency to 2.0
> > > 6. Update the slf4j-api dependency from 1.5.2 to 1.7.6
> > > 7. Add the dependency for the OSGi annotations (@Version,
> > > @ProviderType,
> > > @ConsumerType)
> > > 8. Add the dependency for the OSGi DS and metatype annotations
> > > 9. Add the bnd maven plugin 3.2.0
> > > (see https://github.com/bndtools/bnd/tree/master/maven/bnd-maven-
> > > plugin)
> > > This plugin is newer than the maven bundle plugin and closer to
> > > bnd
> > > change. So we can start using this in our modules.
> > > 10. Maybe change the required maven version from 3.0.5 to 3.3.x
> > 
> > 11. Update maven-bundle-plugin to 3.2.0
> > 
> I've updated the parent pom as outlined above, including #11.
> 
> It would be great if everyone can have a look before we start a
> release

I'd like to quickly check if we can remove the check-memory-task
executions which notify the user about the memory requirements for
building Sling.

Since we now require Maven 3.3 and that picks up the .mvn/jvm.config
file we should not need them any longer.

Robert

Re: Updating our parent pom

[Carsten Ziegeler]

> On Thursday 14 July 2016 21:43:45 Carsten Ziegeler wrote:
>> Hi,
>>
>> looking at our parent pom, we have there some really really old
>> dependencies. The reasoning behind this is that we usually try to use
>> the minimal possible version for a dependency. However, for some things
>> newer versions are out for some time and are the de-facto standard.
>>
>> I think we should
>>
>> 1. Update the default java version for modules from 6 to 7
>> 2. Update the dependency to OSGi Core from 4.1.0 to R6
>> 3. Update the dependency to OSGi Cmpn from 4.1.0 to R6
>> 4. Update the servlet api dependency from 2.4 to 3.0.1 or even 3.1.0
>>(Unfortunately this will break modules as the mvn coordinates have
>> changed, but we can easily update those if we update the parent pom in
>> those modules)
>> 5. Update the jcr dependency to 2.0
>> 6. Update the slf4j-api dependency from 1.5.2 to 1.7.6
>> 7. Add the dependency for the OSGi annotations (@Version, @ProviderType,
>> @ConsumerType)
>> 8. Add the dependency for the OSGi DS and metatype annotations
>> 9. Add the bnd maven plugin 3.2.0
>> (see https://github.com/bndtools/bnd/tree/master/maven/bnd-maven-plugin)
>> This plugin is newer than the maven bundle plugin and closer to bnd
>> change. So we can start using this in our modules.
>> 10. Maybe change the required maven version from 3.0.5 to 3.3.x
> 
> 11. Update maven-bundle-plugin to 3.2.0
> 
I've updated the parent pom as outlined above, including #11.

It would be great if everyone can have a look before we start a release

Thanks

 Carsten

-- 
Carsten Ziegeler
Adobe Research Switzerland
cziege...@apache.org

Re: Updating our parent pom

[Robert Munteanu]

On Fri, 2016-07-15 at 10:34 +0200, Bertrand Delacretaz wrote:
> On Thu, Jul 14, 2016 at 9:43 PM, Carsten Ziegeler  rg> wrote:
> > ...looking at our parent pom, we have there some really really old
> > dependencies
> 
> +1 for the updates that you mentioned, as long as our full build with
> integration tests still works after that.

Our builds are unstable ATM, so any new errors might be missed since
tests are already failing.

Robert

Re: Updating our parent pom

[Oliver Lietz]

On Thursday 14 July 2016 21:43:45 Carsten Ziegeler wrote:
> Hi,
> 
> looking at our parent pom, we have there some really really old
> dependencies. The reasoning behind this is that we usually try to use
> the minimal possible version for a dependency. However, for some things
> newer versions are out for some time and are the de-facto standard.
> 
> I think we should
> 
> 1. Update the default java version for modules from 6 to 7
> 2. Update the dependency to OSGi Core from 4.1.0 to R6
> 3. Update the dependency to OSGi Cmpn from 4.1.0 to R6
> 4. Update the servlet api dependency from 2.4 to 3.0.1 or even 3.1.0
>(Unfortunately this will break modules as the mvn coordinates have
> changed, but we can easily update those if we update the parent pom in
> those modules)
> 5. Update the jcr dependency to 2.0
> 6. Update the slf4j-api dependency from 1.5.2 to 1.7.6
> 7. Add the dependency for the OSGi annotations (@Version, @ProviderType,
> @ConsumerType)
> 8. Add the dependency for the OSGi DS and metatype annotations
> 9. Add the bnd maven plugin 3.2.0
> (see https://github.com/bndtools/bnd/tree/master/maven/bnd-maven-plugin)
> This plugin is newer than the maven bundle plugin and closer to bnd
> change. So we can start using this in our modules.
> 10. Maybe change the required maven version from 3.0.5 to 3.3.x

11. Update maven-bundle-plugin to 3.2.0

O.

> WDYT?
> 
> Regards
> Carsten

Re: Updating our parent pom

[Carsten Ziegeler]

> On Thu, Jul 14, 2016 at 9:43 PM, Carsten Ziegeler  
> wrote:
>> ...looking at our parent pom, we have there some really really old
>> dependencies
> 
> +1 for the updates that you mentioned, as long as our full build with
> integration tests still works after that.
> 
That's of course the goal, but I think I need to rely on everyone to
help with fixing if things break without an apparent reason.

 Carsten

-- 
Carsten Ziegeler
Adobe Research Switzerland
cziege...@apache.org

Re: Updating our parent pom

[Bertrand Delacretaz]

On Thu, Jul 14, 2016 at 9:43 PM, Carsten Ziegeler  wrote:
> ...looking at our parent pom, we have there some really really old
> dependencies

+1 for the updates that you mentioned, as long as our full build with
integration tests still works after that.

-Bertrand

Re: Updating our parent pom

[Carsten Ziegeler]

Hi,

>> 9. Add the bnd maven plugin 3.2.0
>> (see https://github.com/bndtools/bnd/tree/master/maven/bnd-maven-plugin)
>> This plugin is newer than the maven bundle plugin and closer to bnd
>> change. So we can start using this in our modules.
> 
> we should make clear how to use bnd.bnd files. Do you have a sample project 
> which is close to our bundles regarding to bundle settings?
> 

No, and having a base definition in the parent pom for that plugin does
currently only work if your parent pom is part of your reactor.
I'm planning to provide a patch for this soon.

For now, I'm thinking of just adding that plugin, so we can explore it
easier and hopefully with version 3.3.0 it has all the features we need
and we can start using it for real.

Of course we could explore it without adding it to the parent pom, but I
would like to give it a little bit more visibility.

 Carsten

-- 
Carsten Ziegeler
Adobe Research Switzerland
cziege...@apache.org

Re: Updating our parent pom

[Oliver Lietz]

On Thursday 14 July 2016 21:43:45 Carsten Ziegeler wrote:
> Hi,

Hi Carsten,

> looking at our parent pom, we have there some really really old
> dependencies. The reasoning behind this is that we usually try to use
> the minimal possible version for a dependency. However, for some things
> newer versions are out for some time and are the de-facto standard.
> 
> I think we should
> 
> 1. Update the default java version for modules from 6 to 7
> 2. Update the dependency to OSGi Core from 4.1.0 to R6
> 3. Update the dependency to OSGi Cmpn from 4.1.0 to R6
> 4. Update the servlet api dependency from 2.4 to 3.0.1 or even 3.1.0
>(Unfortunately this will break modules as the mvn coordinates have
> changed, but we can easily update those if we update the parent pom in
> those modules)
> 5. Update the jcr dependency to 2.0
> 6. Update the slf4j-api dependency from 1.5.2 to 1.7.6
> 7. Add the dependency for the OSGi annotations (@Version, @ProviderType,
> @ConsumerType)
> 8. Add the dependency for the OSGi DS and metatype annotations
> 9. Add the bnd maven plugin 3.2.0
> (see https://github.com/bndtools/bnd/tree/master/maven/bnd-maven-plugin)
> This plugin is newer than the maven bundle plugin and closer to bnd
> change. So we can start using this in our modules.

we should make clear how to use bnd.bnd files. Do you have a sample project 
which is close to our bundles regarding to bundle settings?

> 10. Maybe change the required maven version from 3.0.5 to 3.3.x
> 
> WDYT?

+1

O.

> Regards
> Carsten

RE: Updating our parent pom

[Stefan Seifert]

+1

>-Original Message-
>From: Carsten Ziegeler [mailto:cziege...@apache.org]
>Sent: Thursday, July 14, 2016 9:44 PM
>To: Sling Developers
>Subject: Updating our parent pom
>
>Hi,
>
>looking at our parent pom, we have there some really really old
>dependencies. The reasoning behind this is that we usually try to use
>the minimal possible version for a dependency. However, for some things
>newer versions are out for some time and are the de-facto standard.
>
>I think we should
>
>1. Update the default java version for modules from 6 to 7
>2. Update the dependency to OSGi Core from 4.1.0 to R6
>3. Update the dependency to OSGi Cmpn from 4.1.0 to R6
>4. Update the servlet api dependency from 2.4 to 3.0.1 or even 3.1.0
>   (Unfortunately this will break modules as the mvn coordinates have
>changed, but we can easily update those if we update the parent pom in
>those modules)
>5. Update the jcr dependency to 2.0
>6. Update the slf4j-api dependency from 1.5.2 to 1.7.6
>7. Add the dependency for the OSGi annotations (@Version, @ProviderType,
>@ConsumerType)
>8. Add the dependency for the OSGi DS and metatype annotations
>9. Add the bnd maven plugin 3.2.0
>(see https://github.com/bndtools/bnd/tree/master/maven/bnd-maven-plugin)
>This plugin is newer than the maven bundle plugin and closer to bnd
>change. So we can start using this in our modules.
>10. Maybe change the required maven version from 3.0.5 to 3.3.x
>
>WDYT?
>
>Regards
>Carsten
>--
>Carsten Ziegeler
>Adobe Research Switzerland
>cziege...@apache.org

Updating our parent pom

[Carsten Ziegeler]

Hi,

looking at our parent pom, we have there some really really old
dependencies. The reasoning behind this is that we usually try to use
the minimal possible version for a dependency. However, for some things
newer versions are out for some time and are the de-facto standard.

I think we should

1. Update the default java version for modules from 6 to 7
2. Update the dependency to OSGi Core from 4.1.0 to R6
3. Update the dependency to OSGi Cmpn from 4.1.0 to R6
4. Update the servlet api dependency from 2.4 to 3.0.1 or even 3.1.0
   (Unfortunately this will break modules as the mvn coordinates have
changed, but we can easily update those if we update the parent pom in
those modules)
5. Update the jcr dependency to 2.0
6. Update the slf4j-api dependency from 1.5.2 to 1.7.6
7. Add the dependency for the OSGi annotations (@Version, @ProviderType,
@ConsumerType)
8. Add the dependency for the OSGi DS and metatype annotations
9. Add the bnd maven plugin 3.2.0
(see https://github.com/bndtools/bnd/tree/master/maven/bnd-maven-plugin)
This plugin is newer than the maven bundle plugin and closer to bnd
change. So we can start using this in our modules.
10. Maybe change the required maven version from 3.0.5 to 3.3.x

WDYT?

Regards
Carsten
-- 
Carsten Ziegeler
Adobe Research Switzerland
cziege...@apache.org