[jira] Resolved: (SLING-1595) Add a jcr:path property to JcrPropertyMap
[ https://issues.apache.org/jira/browse/SLING-1595?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justin Edelson resolved SLING-1595. --- Resolution: Won't Fix Add a jcr:path property to JcrPropertyMap - Key: SLING-1595 URL: https://issues.apache.org/jira/browse/SLING-1595 Project: Sling Issue Type: Improvement Components: JCR Reporter: Justin Edelson Fix For: JCR Resource 2.0.8 Although it can be computed, it would be nice to always have access to a jcr:path property via the ValueMap. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (SLING-1595) Add a jcr:path property to JcrPropertyMap
[ https://issues.apache.org/jira/browse/SLING-1595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12888299#action_12888299 ] Justin Edelson commented on SLING-1595: --- Hmmm. OK. The problem I'm running in to is that the JSON representation of a resource doesn't have the path in it. So downstream consumers need two bits of data: the JSON object and the requested path. These are very valid concerns, so I'll look for another solution, probably by enabling more customization in the GET servlet. Add a jcr:path property to JcrPropertyMap - Key: SLING-1595 URL: https://issues.apache.org/jira/browse/SLING-1595 Project: Sling Issue Type: Improvement Components: JCR Reporter: Justin Edelson Fix For: JCR Resource 2.0.8 Although it can be computed, it would be nice to always have access to a jcr:path property via the ValueMap. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Resolved: (SLING-1531) Upgrade to Jackrabbit 2.1
[ https://issues.apache.org/jira/browse/SLING-1531?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justin Edelson resolved SLING-1531. --- Fix Version/s: Launchpad Webapp 6 Launchpad Bundles 6 Launchpad App 6 JCR Webdav 2.0.10 JCR Jackrabbit Server 2.0.8 Resolution: Fixed done in r964876 Upgrade to Jackrabbit 2.1 - Key: SLING-1531 URL: https://issues.apache.org/jira/browse/SLING-1531 Project: Sling Issue Type: Task Components: JCR Reporter: Justin Edelson Assignee: Justin Edelson Fix For: Launchpad Webapp 6, Launchpad Bundles 6, Launchpad App 6, JCR Webdav 2.0.10, JCR Jackrabbit Server 2.0.8 -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Assigned: (SLING-1531) Upgrade to Jackrabbit 2.1
[ https://issues.apache.org/jira/browse/SLING-1531?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justin Edelson reassigned SLING-1531: - Assignee: Justin Edelson Upgrade to Jackrabbit 2.1 - Key: SLING-1531 URL: https://issues.apache.org/jira/browse/SLING-1531 Project: Sling Issue Type: Task Components: JCR Reporter: Justin Edelson Assignee: Justin Edelson -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (SLING-1604) Upgrade GWT Extension to 2.0.4
[ https://issues.apache.org/jira/browse/SLING-1604?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12889859#action_12889859 ] Justin Edelson commented on SLING-1604: --- done in r965472 Upgrade GWT Extension to 2.0.4 -- Key: SLING-1604 URL: https://issues.apache.org/jira/browse/SLING-1604 Project: Sling Issue Type: Improvement Components: Extensions Reporter: Justin Edelson Assignee: Justin Edelson Fix For: GWT Support 3.0.0 -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Resolved: (SLING-1604) Upgrade GWT Extension to 2.0.4
[ https://issues.apache.org/jira/browse/SLING-1604?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justin Edelson resolved SLING-1604. --- Resolution: Fixed Upgrade GWT Extension to 2.0.4 -- Key: SLING-1604 URL: https://issues.apache.org/jira/browse/SLING-1604 Project: Sling Issue Type: Improvement Components: Extensions Reporter: Justin Edelson Assignee: Justin Edelson Fix For: GWT Support 3.0.0 -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Resolved: (SLING-1608) unsafe cast in AbstractSlingPostOperation
[ https://issues.apache.org/jira/browse/SLING-1608?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justin Edelson resolved SLING-1608. --- Resolution: Fixed unsafe cast in AbstractSlingPostOperation - Key: SLING-1608 URL: https://issues.apache.org/jira/browse/SLING-1608 Project: Sling Issue Type: Bug Components: Servlets Reporter: Justin Edelson Assignee: Justin Edelson Fix For: Servlets Post 2.0.6 AbstractSlingPostOperation.checkin() assumes that the paths it gets are node paths when they can be property paths as well. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Resolved: (SLING-1609) ImportOperation fails on non-default workspace path
[ https://issues.apache.org/jira/browse/SLING-1609?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justin Edelson resolved SLING-1609. --- Resolution: Fixed ImportOperation fails on non-default workspace path --- Key: SLING-1609 URL: https://issues.apache.org/jira/browse/SLING-1609 Project: Sling Issue Type: Bug Components: Servlets Reporter: Justin Edelson Assignee: Justin Edelson Fix For: Servlets Post 2.0.6 node generation assumes path is in the default workspace -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (SLING-1608) unsafe cast in AbstractSlingPostOperation
unsafe cast in AbstractSlingPostOperation - Key: SLING-1608 URL: https://issues.apache.org/jira/browse/SLING-1608 Project: Sling Issue Type: Bug Components: Servlets Reporter: Justin Edelson Assignee: Justin Edelson Fix For: Servlets Post 2.0.6 AbstractSlingPostOperation.checkin() assumes that the paths it gets are node paths when they can be property paths as well. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (SLING-1609) ImportOperation fails on non-default workspace path
ImportOperation fails on non-default workspace path --- Key: SLING-1609 URL: https://issues.apache.org/jira/browse/SLING-1609 Project: Sling Issue Type: Bug Components: Servlets Reporter: Justin Edelson Assignee: Justin Edelson Fix For: Servlets Post 2.0.6 node generation assumes path is in the default workspace -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (SLING-1608) unsafe cast in AbstractSlingPostOperation
[ https://issues.apache.org/jira/browse/SLING-1608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12890775#action_12890775 ] Justin Edelson commented on SLING-1608: --- done in r966266 unsafe cast in AbstractSlingPostOperation - Key: SLING-1608 URL: https://issues.apache.org/jira/browse/SLING-1608 Project: Sling Issue Type: Bug Components: Servlets Reporter: Justin Edelson Assignee: Justin Edelson Fix For: Servlets Post 2.0.6 AbstractSlingPostOperation.checkin() assumes that the paths it gets are node paths when they can be property paths as well. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Resolved: (SLING-1610) StreamRendererServlet creates endless redirect for non-default workspace root node
[ https://issues.apache.org/jira/browse/SLING-1610?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justin Edelson resolved SLING-1610. --- Resolution: Fixed StreamRendererServlet creates endless redirect for non-default workspace root node -- Key: SLING-1610 URL: https://issues.apache.org/jira/browse/SLING-1610 Project: Sling Issue Type: Bug Components: Servlets Reporter: Justin Edelson Assignee: Justin Edelson Fix For: Servlets Get 2.0.10 if you request the root node of a non-default workspace, Sling create an endless redirect loop. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (SLING-1610) StreamRendererServlet creates endless redirect for non-default workspace root node
[ https://issues.apache.org/jira/browse/SLING-1610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12890886#action_12890886 ] Justin Edelson commented on SLING-1610: --- fixed in r966412 StreamRendererServlet creates endless redirect for non-default workspace root node -- Key: SLING-1610 URL: https://issues.apache.org/jira/browse/SLING-1610 Project: Sling Issue Type: Bug Components: Servlets Reporter: Justin Edelson Assignee: Justin Edelson Fix For: Servlets Get 2.0.10 if you request the root node of a non-default workspace, Sling create an endless redirect loop. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (SLING-1531) Upgrade to Jackrabbit 2.1
[ https://issues.apache.org/jira/browse/SLING-1531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12892287#action_12892287 ] Justin Edelson commented on SLING-1531: --- You have a third option - submit a patch to Jackrabbit. Upgrade to Jackrabbit 2.1 - Key: SLING-1531 URL: https://issues.apache.org/jira/browse/SLING-1531 Project: Sling Issue Type: Task Components: JCR Reporter: Justin Edelson Assignee: Justin Edelson Fix For: Launchpad Webapp 6, Launchpad Bundles 6, Launchpad App 6, JCR Webdav 2.0.10, JCR Jackrabbit Server 2.0.8 -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (SLING-1531) Upgrade to Jackrabbit 2.1
[ https://issues.apache.org/jira/browse/SLING-1531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12892292#action_12892292 ] Justin Edelson commented on SLING-1531: --- well, it doesn't look like these bundles are going to be released in the next two weeks, so you're going to be using timestamped snapshots of something from Sling either way personally, I prefer timestamped snapshots to forks. Upgrade to Jackrabbit 2.1 - Key: SLING-1531 URL: https://issues.apache.org/jira/browse/SLING-1531 Project: Sling Issue Type: Task Components: JCR Reporter: Justin Edelson Assignee: Justin Edelson Fix For: Launchpad Webapp 6, Launchpad Bundles 6, Launchpad App 6, JCR Webdav 2.0.10, JCR Jackrabbit Server 2.0.8 -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (SLING-1611) Add OSGi JMX support
Add OSGi JMX support Key: SLING-1611 URL: https://issues.apache.org/jira/browse/SLING-1611 Project: Sling Issue Type: Improvement Components: Launchpad Reporter: Justin Edelson Assignee: Justin Edelson Fix For: Launchpad Webapp 6, Launchpad Bundles 6, Launchpad Base 2.2.2 Discussion in SLING-1476 reminded me that I'd been wanting to add the JMX support bundles from Aries to Launchpad. These provide an implmentation of the JMX Management Model Specification from the OSGI r4 Enterprise spec. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Resolved: (SLING-1611) Add OSGi JMX support
[ https://issues.apache.org/jira/browse/SLING-1611?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justin Edelson resolved SLING-1611. --- Resolution: Fixed Add OSGi JMX support Key: SLING-1611 URL: https://issues.apache.org/jira/browse/SLING-1611 Project: Sling Issue Type: Improvement Components: Launchpad Reporter: Justin Edelson Assignee: Justin Edelson Fix For: Launchpad Webapp 6, Launchpad Bundles 6, Launchpad Base 2.2.2 Discussion in SLING-1476 reminded me that I'd been wanting to add the JMX support bundles from Aries to Launchpad. These provide an implmentation of the JMX Management Model Specification from the OSGI r4 Enterprise spec. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (SLING-1611) Add OSGi JMX support
[ https://issues.apache.org/jira/browse/SLING-1611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12892317#action_12892317 ] Justin Edelson commented on SLING-1611: --- done in r979292 Add OSGi JMX support Key: SLING-1611 URL: https://issues.apache.org/jira/browse/SLING-1611 Project: Sling Issue Type: Improvement Components: Launchpad Reporter: Justin Edelson Assignee: Justin Edelson Fix For: Launchpad Webapp 6, Launchpad Bundles 6, Launchpad Base 2.2.2 Discussion in SLING-1476 reminded me that I'd been wanting to add the JMX support bundles from Aries to Launchpad. These provide an implmentation of the JMX Management Model Specification from the OSGI r4 Enterprise spec. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (SLING-1612) create servlet to get effective access control list
create servlet to get effective access control list --- Key: SLING-1612 URL: https://issues.apache.org/jira/browse/SLING-1612 Project: Sling Issue Type: Improvement Components: JCR Reporter: Justin Edelson Assignee: Justin Edelson /path.acl.json - returns the declared ACL, if any /path.eacl.json - returns the effective ACL -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Resolved: (SLING-1612) create servlet to get effective access control list
[ https://issues.apache.org/jira/browse/SLING-1612?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justin Edelson resolved SLING-1612. --- Fix Version/s: JCR Jackrabbit Access Manager 2.0.6 Resolution: Fixed done in r979311 create servlet to get effective access control list --- Key: SLING-1612 URL: https://issues.apache.org/jira/browse/SLING-1612 Project: Sling Issue Type: Improvement Components: JCR Reporter: Justin Edelson Assignee: Justin Edelson Fix For: JCR Jackrabbit Access Manager 2.0.6 /path.acl.json - returns the declared ACL, if any /path.eacl.json - returns the effective ACL -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (SLING-1338) sling.properties should be trimmed when reading
[ https://issues.apache.org/jira/browse/SLING-1338?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justin Edelson updated SLING-1338: -- Component/s: Launchpad (was: Engine) sling.properties should be trimmed when reading --- Key: SLING-1338 URL: https://issues.apache.org/jira/browse/SLING-1338 Project: Sling Issue Type: Bug Components: Launchpad Affects Versions: Launchpad Base 2.1.0 Reporter: Bertrand Delacretaz Priority: Minor Values from sling.properties are not trimmed when read by the org.apache.sling.launchpad.base.impl.Sling class. This can lead to hard to diagnose problems, and I don't think we need to have leading or trailing spaces in any of those values. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (SLING-1338) sling.properties should be trimmed when reading
[ https://issues.apache.org/jira/browse/SLING-1338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12893227#action_12893227 ] Justin Edelson commented on SLING-1338: --- fixing component sling.properties should be trimmed when reading --- Key: SLING-1338 URL: https://issues.apache.org/jira/browse/SLING-1338 Project: Sling Issue Type: Bug Components: Launchpad Affects Versions: Launchpad Base 2.1.0 Reporter: Bertrand Delacretaz Priority: Minor Values from sling.properties are not trimmed when read by the org.apache.sling.launchpad.base.impl.Sling class. This can lead to hard to diagnose problems, and I don't think we need to have leading or trailing spaces in any of those values. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Resolved: (SLING-1616) Wrong dependency version for gwt servlet in /contrib/extensions/gwt/sample/pom.xml
[ https://issues.apache.org/jira/browse/SLING-1616?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justin Edelson resolved SLING-1616. --- Assignee: Justin Edelson Resolution: Fixed done in r980122. will switch to 3.0.0 once the vote is passed (I hope) Wrong dependency version for gwt servlet in /contrib/extensions/gwt/sample/pom.xml -- Key: SLING-1616 URL: https://issues.apache.org/jira/browse/SLING-1616 Project: Sling Issue Type: Bug Components: Extensions Reporter: Pontus Amberg Assignee: Justin Edelson Priority: Minor The GWT sample project ( /contrib/extensions/gwt/sample/pom.xml ) has a dependency on org.apache.sling.extensions.gwt.servlet version 3.0.0-SNAPSHOT but the version in /contrib/extensions/gwt/servlet/pom.xml is 3.0.1-SNAPSHOT. This will lead to build failure when building contrib and the user never has built 3.0.0-SNAPSHOT previously. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (SLING-1419) Remove dependency to JCR
[ https://issues.apache.org/jira/browse/SLING-1419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12893387#action_12893387 ] Justin Edelson commented on SLING-1419: --- It seems like this issue should be retitled as make JCR dependency optional as we can't really remove the dependency completely. assuming this is agreeable, this patch should do it: http://codereview.appspot.com/1884045 Remove dependency to JCR Key: SLING-1419 URL: https://issues.apache.org/jira/browse/SLING-1419 Project: Sling Issue Type: Improvement Components: Commons Affects Versions: Commons Auth 1.0.0 Reporter: Carsten Ziegeler Fix For: Commons Auth 1.0.0 The commons auth module as independent functionality wrt to JCR therefore we should make it work without JCR With SLING-1262 implemented, we can use the ResourceResolverFactory to login instead of going through the SlingRepository. In addition we should: - drop the setter and getter methods for credentials in the AuthenticationInfo - we keep the constant though - drop the setter and getter method for the workspace in the AuthenticationInfo - we keep the constant We make the import to the jcr packages optional as these are required for compatibility support of the old engine packages. If someone wants to use this support he'll need the jcr api anyway. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Issue Comment Edited: (SLING-1419) Remove dependency to JCR
[ https://issues.apache.org/jira/browse/SLING-1419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12893387#action_12893387 ] Justin Edelson edited comment on SLING-1419 at 7/28/10 9:15 PM: It seems like this issue should be retitled as make JCR dependency optional as we can't really remove the dependency completely. assuming this is agreeable, this patch should do it: http://codereview.appspot.com/1731055 was (Author: justinedelson): It seems like this issue should be retitled as make JCR dependency optional as we can't really remove the dependency completely. assuming this is agreeable, this patch should do it: hhttp://codereview.appspot.com/1731055 Remove dependency to JCR Key: SLING-1419 URL: https://issues.apache.org/jira/browse/SLING-1419 Project: Sling Issue Type: Improvement Components: Commons Affects Versions: Commons Auth 1.0.0 Reporter: Carsten Ziegeler Fix For: Commons Auth 1.0.0 The commons auth module as independent functionality wrt to JCR therefore we should make it work without JCR With SLING-1262 implemented, we can use the ResourceResolverFactory to login instead of going through the SlingRepository. In addition we should: - drop the setter and getter methods for credentials in the AuthenticationInfo - we keep the constant though - drop the setter and getter method for the workspace in the AuthenticationInfo - we keep the constant We make the import to the jcr packages optional as these are required for compatibility support of the old engine packages. If someone wants to use this support he'll need the jcr api anyway. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Issue Comment Edited: (SLING-1419) Remove dependency to JCR
[ https://issues.apache.org/jira/browse/SLING-1419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12893387#action_12893387 ] Justin Edelson edited comment on SLING-1419 at 7/28/10 9:15 PM: It seems like this issue should be retitled as make JCR dependency optional as we can't really remove the dependency completely. assuming this is agreeable, this patch should do it: hhttp://codereview.appspot.com/1731055 was (Author: justinedelson): It seems like this issue should be retitled as make JCR dependency optional as we can't really remove the dependency completely. assuming this is agreeable, this patch should do it: http://codereview.appspot.com/1884045 Remove dependency to JCR Key: SLING-1419 URL: https://issues.apache.org/jira/browse/SLING-1419 Project: Sling Issue Type: Improvement Components: Commons Affects Versions: Commons Auth 1.0.0 Reporter: Carsten Ziegeler Fix For: Commons Auth 1.0.0 The commons auth module as independent functionality wrt to JCR therefore we should make it work without JCR With SLING-1262 implemented, we can use the ResourceResolverFactory to login instead of going through the SlingRepository. In addition we should: - drop the setter and getter methods for credentials in the AuthenticationInfo - we keep the constant though - drop the setter and getter method for the workspace in the AuthenticationInfo - we keep the constant We make the import to the jcr packages optional as these are required for compatibility support of the old engine packages. If someone wants to use this support he'll need the jcr api anyway. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Reopened: (SLING-1193) Extend Resource interface and provide AbstractResource base class
[ https://issues.apache.org/jira/browse/SLING-1193?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justin Edelson reopened SLING-1193: --- this has broken some integration tests due to not having changed the resource implementation in jackrabbit-usermanager Extend Resource interface and provide AbstractResource base class - Key: SLING-1193 URL: https://issues.apache.org/jira/browse/SLING-1193 Project: Sling Issue Type: New Feature Components: API, Engine, JCR, Scripting, Servlets Affects Versions: Servlets Resolver 2.0.8, Scripting Core 2.0.10, JCR Resource 2.0.6, Engine 2.0.6, API 2.0.8 Reporter: Felix Meschberger Assignee: Felix Meschberger Fix For: Servlets Resolver 2.0.10, Scripting Core 2.0.12, JCR Resource 2.0.8, Engine 2.1.0, API 2.1.0 Currently the Resource interface has only bare bones API to access its own local attributes, like getPath() or getResourceType(). Accessing the resource in the context of its parent or its children is not currently possible and doing so requires getting the resource resolver out of the resource and asking the resource resolver. For convenience, we should add the following methods: getParent() -- returns the parent resource (same as ResourceUtil.getParent(this)) getName() -- returns the name of the resource (same as ResourceUtil.getName(this)) listChildren() -- same as getResourceResolver().listChildren(this) getChild(String) -- same as getResourceResolver().getResource(this, path) isResourceType(String) -- same as ResourceUtil.isA(this, String) The new AbstractResource class will implement these methods as indicated. Implementors of the Resource interface are then advised to actually extend from the AbstractResource interface, which in the future will provide default implementations of any methods added to the Resource interface, if it makes sense. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Resolved: (SLING-1193) Extend Resource interface and provide AbstractResource base class
[ https://issues.apache.org/jira/browse/SLING-1193?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justin Edelson resolved SLING-1193. --- Resolution: Fixed usermanager module updated in r980292 Extend Resource interface and provide AbstractResource base class - Key: SLING-1193 URL: https://issues.apache.org/jira/browse/SLING-1193 Project: Sling Issue Type: New Feature Components: API, Engine, JCR, Scripting, Servlets Affects Versions: Servlets Resolver 2.0.8, Scripting Core 2.0.10, JCR Resource 2.0.6, Engine 2.0.6, API 2.0.8 Reporter: Felix Meschberger Assignee: Felix Meschberger Fix For: Servlets Resolver 2.0.10, Scripting Core 2.0.12, JCR Resource 2.0.8, Engine 2.1.0, API 2.1.0 Currently the Resource interface has only bare bones API to access its own local attributes, like getPath() or getResourceType(). Accessing the resource in the context of its parent or its children is not currently possible and doing so requires getting the resource resolver out of the resource and asking the resource resolver. For convenience, we should add the following methods: getParent() -- returns the parent resource (same as ResourceUtil.getParent(this)) getName() -- returns the name of the resource (same as ResourceUtil.getName(this)) listChildren() -- same as getResourceResolver().listChildren(this) getChild(String) -- same as getResourceResolver().getResource(this, path) isResourceType(String) -- same as ResourceUtil.isA(this, String) The new AbstractResource class will implement these methods as indicated. Implementors of the Resource interface are then advised to actually extend from the AbstractResource interface, which in the future will provide default implementations of any methods added to the Resource interface, if it makes sense. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (SLING-1419) Remove dependency to JCR
[ https://issues.apache.org/jira/browse/SLING-1419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12893590#action_12893590 ] Justin Edelson commented on SLING-1419: --- But the JCR API could be installed at any time, right? Remove dependency to JCR Key: SLING-1419 URL: https://issues.apache.org/jira/browse/SLING-1419 Project: Sling Issue Type: Improvement Components: Commons Affects Versions: Commons Auth 1.0.0 Reporter: Carsten Ziegeler Fix For: Commons Auth 1.0.0 The commons auth module as independent functionality wrt to JCR therefore we should make it work without JCR With SLING-1262 implemented, we can use the ResourceResolverFactory to login instead of going through the SlingRepository. In addition we should: - drop the setter and getter methods for credentials in the AuthenticationInfo - we keep the constant though - drop the setter and getter method for the workspace in the AuthenticationInfo - we keep the constant We make the import to the jcr packages optional as these are required for compatibility support of the old engine packages. If someone wants to use this support he'll need the jcr api anyway. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (SLING-1615) When importing content all the nodes to the parent node must exists, whereas a Sling POST creates the node.
[ https://issues.apache.org/jira/browse/SLING-1615?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justin Edelson updated SLING-1615: -- Fix Version/s: Servlets Post 2.0.6 (was: JCR ContentLoader 2.0.8) Affects Version/s: (was: JCR Contentloader 2.0.6) Component/s: Servlets (was: JCR) When importing content all the nodes to the parent node must exists, whereas a Sling POST creates the node. --- Key: SLING-1615 URL: https://issues.apache.org/jira/browse/SLING-1615 Project: Sling Issue Type: Bug Components: Servlets Reporter: Ian Boston Assignee: Ian Boston Fix For: Servlets Post 2.0.6 If a POST with a that invokes the import operation is made to a path where the resource does not exist a 404 results. But if I do a normal Sling POST the node is created. This is inconsistent and requires http clients to make 2 posts where one would have worked. Perhaps the Import Operation should check to see of the resource is a NonExstingResource and create the path if not, at about line 88 of ImportOperation ? -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (SLING-1419) Remove dependency to JCR
[ https://issues.apache.org/jira/browse/SLING-1419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12893597#action_12893597 ] Justin Edelson commented on SLING-1419: --- OK. Makes sense. I don't use optional imports very frequently. Remove dependency to JCR Key: SLING-1419 URL: https://issues.apache.org/jira/browse/SLING-1419 Project: Sling Issue Type: Improvement Components: Commons Affects Versions: Commons Auth 1.0.0 Reporter: Carsten Ziegeler Fix For: Commons Auth 1.0.0 The commons auth module as independent functionality wrt to JCR therefore we should make it work without JCR With SLING-1262 implemented, we can use the ResourceResolverFactory to login instead of going through the SlingRepository. In addition we should: - drop the setter and getter methods for credentials in the AuthenticationInfo - we keep the constant though - drop the setter and getter method for the workspace in the AuthenticationInfo - we keep the constant We make the import to the jcr packages optional as these are required for compatibility support of the old engine packages. If someone wants to use this support he'll need the jcr api anyway. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (SLING-1619) attempting to automatically set a protected property shouldn't cause a failure
attempting to automatically set a protected property shouldn't cause a failure -- Key: SLING-1619 URL: https://issues.apache.org/jira/browse/SLING-1619 Project: Sling Issue Type: Improvement Components: Servlets Reporter: Justin Edelson Assignee: Justin Edelson Fix For: Servlets Post 2.0.6 this: curl -u admin:admin -Fjcr:created=doit -Fjcr:primaryType=sling:Folder http://localhost:9888/test/content/folder currently returns an error because jcr:created is a protected property in nt:hierarchyNode. We should just skip this property -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (SLING-1619) attempting to automatically set a protected property shouldn't cause a failure
[ https://issues.apache.org/jira/browse/SLING-1619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12894085#action_12894085 ] Justin Edelson commented on SLING-1619: --- but jcr:created is in fact being set, it is just being set by the repository, not Sling. The user shouldn't care who set it. attempting to automatically set a protected property shouldn't cause a failure -- Key: SLING-1619 URL: https://issues.apache.org/jira/browse/SLING-1619 Project: Sling Issue Type: Improvement Components: Servlets Reporter: Justin Edelson Assignee: Justin Edelson Fix For: Servlets Post 2.0.6 this: curl -u admin:admin -Fjcr:created=doit -Fjcr:primaryType=sling:Folder http://localhost:9888/test/content/folder currently returns an error because jcr:created is a protected property in nt:hierarchyNode. We should just skip this property -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (SLING-1619) attempting to automatically set a protected property shouldn't cause a failure
[ https://issues.apache.org/jira/browse/SLING-1619?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justin Edelson updated SLING-1619: -- Description: this: curl -u admin:admin -Fjcr:created= -Fjcr:primaryType=sling:Folder http://localhost:/test/content/folder currently returns an error because jcr:created is a protected property in nt:hierarchyNode. We should just skip this property was: this: curl -u admin:admin -Fjcr:created=doit -Fjcr:primaryType=sling:Folder http://localhost:9888/test/content/folder currently returns an error because jcr:created is a protected property in nt:hierarchyNode. We should just skip this property OK... shouldn't have had a property value in there for jcr:created attempting to automatically set a protected property shouldn't cause a failure -- Key: SLING-1619 URL: https://issues.apache.org/jira/browse/SLING-1619 Project: Sling Issue Type: Improvement Components: Servlets Reporter: Justin Edelson Assignee: Justin Edelson Fix For: Servlets Post 2.0.6 this: curl -u admin:admin -Fjcr:created= -Fjcr:primaryType=sling:Folder http://localhost:/test/content/folder currently returns an error because jcr:created is a protected property in nt:hierarchyNode. We should just skip this property -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Resolved: (SLING-1619) attempting to automatically set a protected property shouldn't cause a failure
[ https://issues.apache.org/jira/browse/SLING-1619?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justin Edelson resolved SLING-1619. --- Resolution: Fixed attempting to automatically set a protected property shouldn't cause a failure -- Key: SLING-1619 URL: https://issues.apache.org/jira/browse/SLING-1619 Project: Sling Issue Type: Improvement Components: Servlets Reporter: Justin Edelson Assignee: Justin Edelson Fix For: Servlets Post 2.0.6 this: curl -u admin:admin -Fjcr:created= -Fjcr:primaryType=sling:Folder http://localhost:/test/content/folder currently returns an error because jcr:created is a protected property in nt:hierarchyNode. We should just skip this property -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (SLING-1619) attempting to automatically set a protected property shouldn't cause a failure
[ https://issues.apache.org/jira/browse/SLING-1619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12894145#action_12894145 ] Justin Edelson commented on SLING-1619: --- done in r980958 attempting to automatically set a protected property shouldn't cause a failure -- Key: SLING-1619 URL: https://issues.apache.org/jira/browse/SLING-1619 Project: Sling Issue Type: Improvement Components: Servlets Reporter: Justin Edelson Assignee: Justin Edelson Fix For: Servlets Post 2.0.6 this: curl -u admin:admin -Fjcr:created= -Fjcr:primaryType=sling:Folder http://localhost:/test/content/folder currently returns an error because jcr:created is a protected property in nt:hierarchyNode. We should just skip this property -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (SLING-1356) Problem with non-ascii characters in uploaded files filname
[ https://issues.apache.org/jira/browse/SLING-1356?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justin Edelson updated SLING-1356: -- Affects Version/s: Servlets Post 2.0.4 (was: Launchpad Webapp 5) Problem with non-ascii characters in uploaded files filname --- Key: SLING-1356 URL: https://issues.apache.org/jira/browse/SLING-1356 Project: Sling Issue Type: Bug Components: Servlets Affects Versions: Servlets Post 2.0.4 Reporter: Claude Vedovini I use a simple form to upload files into Sling, such as this one: code form enctype=multipart/form-data action=/sling/notes/* method=POST textarea rows=5 cols=40 name=text/textarea labelPièce jointe:/label input type=file name=attachments/* class=input-text input type=hidden value=2010-02-05T16:08:06 name=created input type=hidden value=esg name=creator input type=hidden value=2010-02-05T16:08:06 name=modified input type=hidden value=esg name=editor input type=hidden value=esg/notes name=sling:resourceType input type=submit value=envoyer class=form-button /form /code Everything works fine, but when the filename contains non-ascii characters the name of the node ends up wrong. Example: In the file upload input field I specify a file which name is avé_un_assent.jpg The sling node ends up being: /sling/content/notes/2_1265383081005/attachments/avé_un_assent.jpg where it should be /sling/content/notes/2_1265383081005/attachments/avé_un_assent.jpg (or /sling/content/notes/2_1265383081005/attachments/av%C3%A9_un_assent.jpg) Using esp script the Node.getName() method also return an incorrect name I verified content headers (sent and returned) and the content encodings are properly set to utf-8 Thanks for your help -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] [Created] (SLING-2464) inject OSGi services into JSP tags
Justin Edelson created SLING-2464: - Summary: inject OSGi services into JSP tags Key: SLING-2464 URL: https://issues.apache.org/jira/browse/SLING-2464 Project: Sling Issue Type: New Feature Components: Scripting Reporter: Justin Edelson Somewhat similar to SLING-2237, JSP tags should support @Inject for the injection of OSGi services. Same collection use cases as SLING-2237 should be supported. Note - I believe there's already an AnnotationProcessor structure within jasper which can be used for this purpose. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SLING-2466) Add some well-known boot delegation packages
[ https://issues.apache.org/jira/browse/SLING-2466?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13271455#comment-13271455 ] Justin Edelson commented on SLING-2466: --- +1 Great idea Add some well-known boot delegation packages Key: SLING-2466 URL: https://issues.apache.org/jira/browse/SLING-2466 Project: Sling Issue Type: Improvement Components: Launchpad Affects Versions: Launchpad Base 2.3.0 Reporter: Felix Meschberger Assignee: Felix Meschberger Fix For: Launchpad Base 2.4.0 Due to mechanics of class loading and class hiding and interactions with XML factory loading mechanisms it is required to add boot delegation for certain well-known packages when running sling in application servers: # JBoss XML factory package sling.bootdelegation.jboss=__redirected # Oracle WebLogic XML factory support sling.bootdelegation.weblogic=weblogic.xml.* # IBM WebSphere XML factory support sling.bootdelegation.ibm=com.ibm.xml.* -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SLING-2467) Define Document-like node type with jcr:content child and default handling servlet
[ https://issues.apache.org/jira/browse/SLING-2467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13271882#comment-13271882 ] Justin Edelson commented on SLING-2467: --- I like this idea, but I'm concerned about using the term Document. That feels too much like an application-specific type, rather than an expression of the generic concept described here. I've seen people get tripped up by cq:Page, which is roughly similar to this proposal. In other words, I don't want to create the impression that this is _just_ for DMS applications. That said, I'm struggling to come up with an alternative. The best I can come up with is sling:Entity. Other thoughts: sling:Thing (sounds too much like a joke), sling:Content, sling:Node, and sling:ContentNode. Define Document-like node type with jcr:content child and default handling servlet -- Key: SLING-2467 URL: https://issues.apache.org/jira/browse/SLING-2467 Project: Sling Issue Type: New Feature Components: JCR Reporter: Felix Meschberger The JCR specification allows for nodes to have a dual nature: As part of a hierarchy containing documents (as a folder in a filesystem) and as a container for actual data (as a file in a filesystem). There are also two node types defined to reflect the filesystem notions: nt:folder for folders and nt:file for Files. The nt:file nodetype requries a child node jcr:content to provide the actual contents of the file. This child node defaults to be of type nt:resource but can actually be anything and as such provide structured data in addition to just plain binary data (in the jcr:data property). Yet, nt:file and nt:folder are just that: nt:file for file data not containing children and nt:file for folders but to not contain structured data. We should define a node type which can be used to really convey this dual nature as a data container (file) and document container (folder) at the same time. So I propose the following node types: [sling:Document] nt:hierarchyNode, sling:Resource - sling:resourcetype (String) = sling/document auto mandatory - * (undefined) - * (undefined) multiple + jcr:content (nt:base) = nt:unstructured mandatory + * (nt:base) = sling:Document version [sling:OrderedDocument] sling:Document orderable + * (nt:base) = sling:OrderedDocument version In addition we create default GET servlet for handling the sling/document resource type: if the resource has a jcr:content child then include jcr:content else sendError 404 -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SLING-2338) create integration tests for archetypes
[ https://issues.apache.org/jira/browse/SLING-2338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13288993#comment-13288993 ] Justin Edelson commented on SLING-2338: --- Just tried this on a Windows VM and it worked fine. create integration tests for archetypes --- Key: SLING-2338 URL: https://issues.apache.org/jira/browse/SLING-2338 Project: Sling Issue Type: Improvement Components: Maven Plugins and Archetypes Reporter: Justin Edelson Assignee: Justin Edelson The Maven Archetype plugin now has the ability to create simple integration tests for archetypes. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SLING-2338) create integration tests for archetypes
[ https://issues.apache.org/jira/browse/SLING-2338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13290129#comment-13290129 ] Justin Edelson commented on SLING-2338: --- in r1346871, added antrun plugin configuration to fix the line endings in the test resources before they are used for comparison. The issue seems to be related to the use of cygwin. create integration tests for archetypes --- Key: SLING-2338 URL: https://issues.apache.org/jira/browse/SLING-2338 Project: Sling Issue Type: Improvement Components: Maven Plugins and Archetypes Reporter: Justin Edelson Assignee: Justin Edelson The Maven Archetype plugin now has the ability to create simple integration tests for archetypes. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SLING-2441) AuthenticationInfo.put() throws if method is null
[ https://issues.apache.org/jira/browse/SLING-2441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13290131#comment-13290131 ] Justin Edelson commented on SLING-2441: --- OK. I'll revert and change the status of this issue. AuthenticationInfo.put() throws if method is null - Key: SLING-2441 URL: https://issues.apache.org/jira/browse/SLING-2441 Project: Sling Issue Type: Bug Components: Authentication Affects Versions: Auth Core 1.0.6 Reporter: Jeff Young Assignee: Justin Edelson Labels: newbie, patch Fix For: Auth Core 1.1.0 Attachments: auth_info_put.patch Historically the AUTH_TYPE of an AuthenitcationInfo had to be defined (ie: non-null), but we're now using it for anonymous access as well, with a null AUTH_TYPE. The put() method, however, throws if passed a null AUTH_TYPE. (This is triggered, for instance, by CQ's AuthenticationInfoPostProcessorBridge, which does a putAll().) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (SLING-2441) AuthenticationInfo.put() throws if method is null
[ https://issues.apache.org/jira/browse/SLING-2441?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justin Edelson resolved SLING-2441. --- Resolution: Won't Fix reverted change in r1346876 AuthenticationInfo.put() throws if method is null - Key: SLING-2441 URL: https://issues.apache.org/jira/browse/SLING-2441 Project: Sling Issue Type: Bug Components: Authentication Affects Versions: Auth Core 1.0.6 Reporter: Jeff Young Assignee: Justin Edelson Labels: newbie, patch Fix For: Auth Core 1.1.0 Attachments: auth_info_put.patch Historically the AUTH_TYPE of an AuthenitcationInfo had to be defined (ie: non-null), but we're now using it for anonymous access as well, with a null AUTH_TYPE. The put() method, however, throws if passed a null AUTH_TYPE. (This is triggered, for instance, by CQ's AuthenticationInfoPostProcessorBridge, which does a putAll().) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (SLING-1793) JSP Java Standard Tag Library support
[ https://issues.apache.org/jira/browse/SLING-1793?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justin Edelson reassigned SLING-1793: - Assignee: Justin Edelson JSP Java Standard Tag Library support - Key: SLING-1793 URL: https://issues.apache.org/jira/browse/SLING-1793 Project: Sling Issue Type: New Feature Components: Scripting Reporter: Róbert Csákány Assignee: Justin Edelson Attachments: jsp-taglib-jstl.zip Support JSTL in JSP scripts. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Comment Edited] (SLING-1793) JSP Java Standard Tag Library support
[ https://issues.apache.org/jira/browse/SLING-1793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13291493#comment-13291493 ] Justin Edelson edited comment on SLING-1793 at 6/8/12 1:52 AM: --- As Tomcat taglibs with OSGi manifest has still yet to be released, in r1347856, added a JSTL bundle project to Sling. Some tests to follow. was (Author: justinedelson): In r1347856, added a JSTL bundle project to Sling. Some tests to follow. JSP Java Standard Tag Library support - Key: SLING-1793 URL: https://issues.apache.org/jira/browse/SLING-1793 Project: Sling Issue Type: New Feature Components: Scripting Reporter: Róbert Csákány Assignee: Justin Edelson Attachments: jsp-taglib-jstl.zip Support JSTL in JSP scripts. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SLING-1793) JSP Java Standard Tag Library support
[ https://issues.apache.org/jira/browse/SLING-1793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13291493#comment-13291493 ] Justin Edelson commented on SLING-1793: --- In r1347856, added a JSTL bundle project to Sling. Some tests to follow. JSP Java Standard Tag Library support - Key: SLING-1793 URL: https://issues.apache.org/jira/browse/SLING-1793 Project: Sling Issue Type: New Feature Components: Scripting Reporter: Róbert Csákány Assignee: Justin Edelson Attachments: jsp-taglib-jstl.zip Support JSTL in JSP scripts. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (SLING-2512) content loader shouldn't allow the use of file elements when location isn't available
Justin Edelson created SLING-2512: - Summary: content loader shouldn't allow the use of file elements when location isn't available Key: SLING-2512 URL: https://issues.apache.org/jira/browse/SLING-2512 Project: Sling Issue Type: Bug Components: JCR Reporter: Justin Edelson Assignee: Justin Edelson Fix For: JCR ContentLoader 2.1.6 if the location of an XML import isn't available, the file support added in SLING-1161 should not take effect -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (SLING-2512) content loader shouldn't allow the use of file elements when location isn't available
[ https://issues.apache.org/jira/browse/SLING-2512?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justin Edelson resolved SLING-2512. --- Resolution: Fixed in r1351670, checking the location before importing files. logging a warning if the location isn't known content loader shouldn't allow the use of file elements when location isn't available - Key: SLING-2512 URL: https://issues.apache.org/jira/browse/SLING-2512 Project: Sling Issue Type: Bug Components: JCR Reporter: Justin Edelson Assignee: Justin Edelson Fix For: JCR ContentLoader 2.1.6 if the location of an XML import isn't available, the file support added in SLING-1161 should not take effect -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SLING-2513) ValueMap#get(java.lang.String name, T defaultValue) should support java.util.List for multivalue properties
[ https://issues.apache.org/jira/browse/SLING-2513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13397461#comment-13397461 ] Justin Edelson commented on SLING-2513: --- @Konrad/@Georg - Could you provide an example of what you think this should look like? ValueMap#get(java.lang.String name, T defaultValue) should support java.util.List for multivalue properties --- Key: SLING-2513 URL: https://issues.apache.org/jira/browse/SLING-2513 Project: Sling Issue Type: Improvement Components: JCR Affects Versions: JCR Resource 2.0.10 Reporter: Konrad Windszus Instead of just supporting arrays, the ValueMap used for JCR access should support java.util.List as well. I know that this is not supported by the JCR API, but it would be very useful, if that list would be extended afterwards. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SLING-2513) ValueMap#get(java.lang.String name, T defaultValue) should support java.util.List for multivalue properties
[ https://issues.apache.org/jira/browse/SLING-2513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13397499#comment-13397499 ] Justin Edelson commented on SLING-2513: --- But is it actually helpful to have an untyped List like this? You'd really want ListString list = values.get(propName, ListString.class); but AFAIK, this isn't possible due to erasure. ValueMap#get(java.lang.String name, T defaultValue) should support java.util.List for multivalue properties --- Key: SLING-2513 URL: https://issues.apache.org/jira/browse/SLING-2513 Project: Sling Issue Type: Improvement Components: JCR Affects Versions: JCR Resource 2.0.10 Reporter: Konrad Windszus Instead of just supporting arrays, the ValueMap used for JCR access should support java.util.List as well. I know that this is not supported by the JCR API, but it would be very useful, if that list would be extended afterwards. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SLING-2514) API Fragment Bundles not available in maven repositories
[ https://issues.apache.org/jira/browse/SLING-2514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13398454#comment-13398454 ] Justin Edelson commented on SLING-2514: --- Created SLING-2515 for the missing packages issue API Fragment Bundles not available in maven repositories Key: SLING-2514 URL: https://issues.apache.org/jira/browse/SLING-2514 Project: Sling Issue Type: Bug Components: General, Maven Plugins and Archetypes Reporter: James Phillpotts After creating a launchpad module using the standalone archetype, on running the resultant jar, I got errors for missing dependencies org.xml.sax and javax.xml.parsers. I was pointed in the direction of the fragment bundles, but as they are not in a maven repository, I had to roll my own instead. I think these should be released to a maven repository, and should also be automatically added to the list.xml by the webapp and standalone launchpad archetypes. It would be nice if there was page under the site/bundles.html page to explain how this works, too. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (SLING-2515) XML system extension fragment bundle is missing some org.w3c.dom subpackages
[ https://issues.apache.org/jira/browse/SLING-2515?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justin Edelson resolved SLING-2515. --- Resolution: Fixed added missing packages in r1352543 XML system extension fragment bundle is missing some org.w3c.dom subpackages Key: SLING-2515 URL: https://issues.apache.org/jira/browse/SLING-2515 Project: Sling Issue Type: Bug Reporter: Justin Edelson Assignee: Justin Edelson Fix For: Framework Extension Fragment XML 1.0.0 see SLING-2514 -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (SLING-2514) API Fragment Bundles not available in maven repositories
[ https://issues.apache.org/jira/browse/SLING-2514?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justin Edelson updated SLING-2514: -- Component/s: (was: General) (was: Maven Plugins and Archetypes) Extensions Fix Version/s: Framework Extension Fragment Activation 1.0.0 Framework Extension Fragment Transaction 1.0.0 Framework Extension Fragment XML 1.0.0 Framework Extension Fragment WS 1.0.0 Assignee: Justin Edelson API Fragment Bundles not available in maven repositories Key: SLING-2514 URL: https://issues.apache.org/jira/browse/SLING-2514 Project: Sling Issue Type: Bug Components: Extensions Reporter: James Phillpotts Assignee: Justin Edelson Fix For: Framework Extension Fragment WS 1.0.0, Framework Extension Fragment XML 1.0.0, Framework Extension Fragment Transaction 1.0.0, Framework Extension Fragment Activation 1.0.0 After creating a launchpad module using the standalone archetype, on running the resultant jar, I got errors for missing dependencies org.xml.sax and javax.xml.parsers. I was pointed in the direction of the fragment bundles, but as they are not in a maven repository, I had to roll my own instead. I think these should be released to a maven repository, and should also be automatically added to the list.xml by the webapp and standalone launchpad archetypes. It would be nice if there was page under the site/bundles.html page to explain how this works, too. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SLING-2514) API Fragment Bundles not available in maven repositories
[ https://issues.apache.org/jira/browse/SLING-2514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13398491#comment-13398491 ] Justin Edelson commented on SLING-2514: --- started vote on releases: http://sling.markmail.org/thread/75kbqyizvpxdhemp API Fragment Bundles not available in maven repositories Key: SLING-2514 URL: https://issues.apache.org/jira/browse/SLING-2514 Project: Sling Issue Type: Bug Components: Extensions Reporter: James Phillpotts Assignee: Justin Edelson Fix For: Framework Extension Fragment WS 1.0.0, Framework Extension Fragment XML 1.0.0, Framework Extension Fragment Transaction 1.0.0, Framework Extension Fragment Activation 1.0.0 After creating a launchpad module using the standalone archetype, on running the resultant jar, I got errors for missing dependencies org.xml.sax and javax.xml.parsers. I was pointed in the direction of the fragment bundles, but as they are not in a maven repository, I had to roll my own instead. I think these should be released to a maven repository, and should also be automatically added to the list.xml by the webapp and standalone launchpad archetypes. It would be nice if there was page under the site/bundles.html page to explain how this works, too. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (SLING-2509) [regression] Compiler generates incorrect debug information
[ https://issues.apache.org/jira/browse/SLING-2509?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justin Edelson updated SLING-2509: -- Fix Version/s: Commons Compiler 2.0.6 [regression] Compiler generates incorrect debug information --- Key: SLING-2509 URL: https://issues.apache.org/jira/browse/SLING-2509 Project: Sling Issue Type: Bug Components: Commons Affects Versions: Commons Compiler 2.0.2 Reporter: Stefan Guggisberg Assignee: Justin Edelson Fix For: Commons Compiler 2.0.6 Attachments: SLING-2509.patch as of SLING-1930, the class files generated by the the compiler contains incorrect debug information. the class file sourceFile attribute contains my.package.MyClass.java instead of MyClass.java. as a consequence debuggers can't resolve the correct source file when a break point is hit in such a class, i.e. debugging such classes in impossible. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (SLING-2509) [regression] Compiler generates incorrect debug information
[ https://issues.apache.org/jira/browse/SLING-2509?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justin Edelson resolved SLING-2509. --- Resolution: Fixed applied patch in r1352867. Thanks for the patch! [regression] Compiler generates incorrect debug information --- Key: SLING-2509 URL: https://issues.apache.org/jira/browse/SLING-2509 Project: Sling Issue Type: Bug Components: Commons Affects Versions: Commons Compiler 2.0.2 Reporter: Stefan Guggisberg Assignee: Justin Edelson Fix For: Commons Compiler 2.0.6 Attachments: SLING-2509.patch as of SLING-1930, the class files generated by the the compiler contains incorrect debug information. the class file sourceFile attribute contains my.package.MyClass.java instead of MyClass.java. as a consequence debuggers can't resolve the correct source file when a break point is hit in such a class, i.e. debugging such classes in impossible. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (SLING-2509) [regression] Compiler generates incorrect debug information
[ https://issues.apache.org/jira/browse/SLING-2509?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justin Edelson reassigned SLING-2509: - Assignee: Justin Edelson [regression] Compiler generates incorrect debug information --- Key: SLING-2509 URL: https://issues.apache.org/jira/browse/SLING-2509 Project: Sling Issue Type: Bug Components: Commons Affects Versions: Commons Compiler 2.0.2 Reporter: Stefan Guggisberg Assignee: Justin Edelson Fix For: Commons Compiler 2.0.6 Attachments: SLING-2509.patch as of SLING-1930, the class files generated by the the compiler contains incorrect debug information. the class file sourceFile attribute contains my.package.MyClass.java instead of MyClass.java. as a consequence debuggers can't resolve the correct source file when a break point is hit in such a class, i.e. debugging such classes in impossible. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (SLING-2109) Separate some system bundle provide packages into properties for easier overwrite
[ https://issues.apache.org/jira/browse/SLING-2109?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justin Edelson resolved SLING-2109. --- Resolution: Fixed Separate some system bundle provide packages into properties for easier overwrite - Key: SLING-2109 URL: https://issues.apache.org/jira/browse/SLING-2109 Project: Sling Issue Type: Improvement Components: Extensions Affects Versions: Launchpad Base 2.3.0 Reporter: Felix Meschberger Assignee: Felix Meschberger Fix For: Framework Extension Fragment XML 1.0.0, Framework Extension Fragment Transaction 1.0.0, Framework Extension Fragment Activation 1.0.0 Attachments: 110817_SLING-2109_activation.patch Currently a number of Java Extension packages are exported without a version from the system bundle; for example javax.transaction.*, or javax.xml,*. The problem with these packages is that some applications will not want to depend on these packages from the environment hence do not want them to be exported from the system bundle. Yet, in different contexts like the default Sling Launchpad build, we just want them available. To fix this issue, the following should be done: * Remove Activation, Transaction, and XML APIs from the System Bundle Export * Create two system extension fragment bundles: (1) for JTA and (2) for XML APIs The javax.activation API is problematic anyway and should probably not be used from the environment due to the extension loading mechanism employed by default. The JTA and XML API system extension fragment bundles can be replaced by real bundles. For example to use JAT inside the OSGi framework the Apache Aries Transaction Manager bundle can be deployed instead of the JTA system extension fragment. This is related to SLING-1958 which is about replacing the XML related exports from the system with bundles embedding the API in the framework itself and thus encapsulating from the environment. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (SLING-2514) API Fragment Bundles not available in maven repositories
[ https://issues.apache.org/jira/browse/SLING-2514?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justin Edelson resolved SLING-2514. --- Resolution: Fixed bundles have been released API Fragment Bundles not available in maven repositories Key: SLING-2514 URL: https://issues.apache.org/jira/browse/SLING-2514 Project: Sling Issue Type: Bug Components: Extensions Reporter: James Phillpotts Assignee: Justin Edelson Fix For: Framework Extension Fragment WS 1.0.0, Framework Extension Fragment XML 1.0.0, Framework Extension Fragment Transaction 1.0.0, Framework Extension Fragment Activation 1.0.0 After creating a launchpad module using the standalone archetype, on running the resultant jar, I got errors for missing dependencies org.xml.sax and javax.xml.parsers. I was pointed in the direction of the fragment bundles, but as they are not in a maven repository, I had to roll my own instead. I think these should be released to a maven repository, and should also be automatically added to the list.xml by the webapp and standalone launchpad archetypes. It would be nice if there was page under the site/bundles.html page to explain how this works, too. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (SLING-2522) Adapter web console plugin lists services which are not AdapterFactorys
Justin Edelson created SLING-2522: - Summary: Adapter web console plugin lists services which are not AdapterFactorys Key: SLING-2522 URL: https://issues.apache.org/jira/browse/SLING-2522 Project: Sling Issue Type: Bug Components: Extensions Reporter: Justin Edelson Assignee: Justin Edelson see http://markmail.org/message/zy4vsxxozteuspsg -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (SLING-2522) Adapter web console plugin lists services which are not AdapterFactorys
[ https://issues.apache.org/jira/browse/SLING-2522?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justin Edelson resolved SLING-2522. --- Resolution: Fixed Adapter web console plugin lists services which are not AdapterFactorys --- Key: SLING-2522 URL: https://issues.apache.org/jira/browse/SLING-2522 Project: Sling Issue Type: Bug Components: Extensions Reporter: Justin Edelson Assignee: Justin Edelson see http://markmail.org/message/zy4vsxxozteuspsg -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SLING-2522) Adapter web console plugin lists services which are not AdapterFactorys
[ https://issues.apache.org/jira/browse/SLING-2522?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13401564#comment-13401564 ] Justin Edelson commented on SLING-2522: --- fixed in r1354130. leaving fix version alone for now pending vote. Adapter web console plugin lists services which are not AdapterFactorys --- Key: SLING-2522 URL: https://issues.apache.org/jira/browse/SLING-2522 Project: Sling Issue Type: Bug Components: Extensions Reporter: Justin Edelson Assignee: Justin Edelson see http://markmail.org/message/zy4vsxxozteuspsg -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SLING-2516) Request Performance Analysis helper
[ https://issues.apache.org/jira/browse/SLING-2516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13402160#comment-13402160 ] Justin Edelson commented on SLING-2516: --- FYI - the RequestProgresssTracker data can already be dumped to a file by setting the log level on org.apache.sling.engine.impl.debug.RequestProgressTrackerLogFilter to DEBUG. Request Performance Analysis helper --- Key: SLING-2516 URL: https://issues.apache.org/jira/browse/SLING-2516 Project: Sling Issue Type: New Feature Components: Extensions Reporter: Felix Meschberger Assignee: Felix Meschberger To measure overall request performance, Sling has a RequestProgressTracker where each request is tracking progress as a request is processed. Normally this RequestProgressTracker is just collected but other than being presented in the Recent Requests page of the web console not further used. To track down generic bottle necks and processing peaks while doing load tests on a Sling system, it would be usefull if the RequestProgressTracker data could be dumped into a file which can later be displayed and analysed. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SLING-2516) Request Performance Analysis helper
[ https://issues.apache.org/jira/browse/SLING-2516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13402190#comment-13402190 ] Justin Edelson commented on SLING-2516: --- Understood and I definitely can see how this adds new capability. I just wanted to ensure that anyone stumbling onto this issue can see that there's a way to get the raw data. Request Performance Analysis helper --- Key: SLING-2516 URL: https://issues.apache.org/jira/browse/SLING-2516 Project: Sling Issue Type: New Feature Components: Extensions Reporter: Felix Meschberger Assignee: Felix Meschberger To measure overall request performance, Sling has a RequestProgressTracker where each request is tracking progress as a request is processed. Normally this RequestProgressTracker is just collected but other than being presented in the Recent Requests page of the web console not further used. To track down generic bottle necks and processing peaks while doing load tests on a Sling system, it would be usefull if the RequestProgressTracker data could be dumped into a file which can later be displayed and analysed. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SLING-2534) Strings of zero length on update in post servlet delete the property
[ https://issues.apache.org/jira/browse/SLING-2534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13416273#comment-13416273 ] Justin Edelson commented on SLING-2534: --- Patch isn't backwards compatible. I think you'll need to specify this behavior via an additional parameter, e.g. myStringProp@DeleteIfBlank=false Strings of zero length on update in post servlet delete the property Key: SLING-2534 URL: https://issues.apache.org/jira/browse/SLING-2534 Project: Sling Issue Type: Bug Components: Servlets Affects Versions: Servlets Post 2.1.2 Reporter: Endolf Attachments: blankstrings.patch According to JCR specs, for string type properties, a blank string should be a valid value. Currently the post servlet delets any property where 1 or less values are specifed and the 1 value has a 0 length. I think string properties with a zero length should be blanked instead of deleted. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Comment Edited] (SLING-2534) Strings of zero length on update in post servlet delete the property
[ https://issues.apache.org/jira/browse/SLING-2534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13416384#comment-13416384 ] Justin Edelson edited comment on SLING-2534 at 7/17/12 5:34 PM: bq. That parameter would be problematic as this is only valid for strings, all other types cannot have no value. I appreciate the backwards compatibility issue with the patch. How is this problematic? The parameter would just be ignored for non-string properties? bq. One solution would be to add a configuration switch to the post servlet where the current default behaviour can be changed to treat empty strings as empty strings. However, this would be a global switch. Or we could add a special request parameter like :deleteEmptyStringIfBlank=false which you could use on your requests? IMHO, applying this on the global or even request level is too coarse-grained. was (Author: justinedelson): bq. That parameter would be problematic as this is only valid for strings, all other types cannot have no value. I appreciate the backwards compatibility issue with the patch. How is this problematic? The parameter would just be ignored for non-string properties? bq. One solution would be to add a configuration switch to the post servlet where the current default behaviour can be changed to treat empty strings as empty strings. However, this would be a global switch. Or we could add a special request parameter like :deleteEmptyStringIfBlank=false which you could use on your requests? IMHO, applying this on the global or even request level is too course-grained. Strings of zero length on update in post servlet delete the property Key: SLING-2534 URL: https://issues.apache.org/jira/browse/SLING-2534 Project: Sling Issue Type: Bug Components: Servlets Affects Versions: Servlets Post 2.1.2 Reporter: Endolf Attachments: blankstrings.patch According to JCR specs, for string type properties, a blank string should be a valid value. Currently the post servlet delets any property where 1 or less values are specifed and the 1 value has a 0 length. I think string properties with a zero length should be blanked instead of deleted. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SLING-2534) Strings of zero length on update in post servlet delete the property
[ https://issues.apache.org/jira/browse/SLING-2534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13416384#comment-13416384 ] Justin Edelson commented on SLING-2534: --- bq. That parameter would be problematic as this is only valid for strings, all other types cannot have no value. I appreciate the backwards compatibility issue with the patch. How is this problematic? The parameter would just be ignored for non-string properties? bq. One solution would be to add a configuration switch to the post servlet where the current default behaviour can be changed to treat empty strings as empty strings. However, this would be a global switch. Or we could add a special request parameter like :deleteEmptyStringIfBlank=false which you could use on your requests? IMHO, applying this on the global or even request level is too course-grained. Strings of zero length on update in post servlet delete the property Key: SLING-2534 URL: https://issues.apache.org/jira/browse/SLING-2534 Project: Sling Issue Type: Bug Components: Servlets Affects Versions: Servlets Post 2.1.2 Reporter: Endolf Attachments: blankstrings.patch According to JCR specs, for string type properties, a blank string should be a valid value. Currently the post servlet delets any property where 1 or less values are specifed and the 1 value has a 0 length. I think string properties with a zero length should be blanked instead of deleted. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Comment Edited] (SLING-2534) Strings of zero length on update in post servlet delete the property
[ https://issues.apache.org/jira/browse/SLING-2534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13416384#comment-13416384 ] Justin Edelson edited comment on SLING-2534 at 7/17/12 5:35 PM: bq. That parameter would be problematic as this is only valid for strings, all other types cannot have no value. I appreciate the backwards compatibility issue with the patch. How is this problematic? The parameter would just be ignored for non-string properties? bq. One solution would be to add a configuration switch to the post servlet where the current default behaviour can be changed to treat empty strings as empty strings. However, this would be a global switch. Or we could add a special request parameter like :deleteEmptyStringIfBlank=false which you could use on your requests? IMHO, applying this on the global or even request level is too coarse-grained and would end up breaking application components which depend upon the current behavior. was (Author: justinedelson): bq. That parameter would be problematic as this is only valid for strings, all other types cannot have no value. I appreciate the backwards compatibility issue with the patch. How is this problematic? The parameter would just be ignored for non-string properties? bq. One solution would be to add a configuration switch to the post servlet where the current default behaviour can be changed to treat empty strings as empty strings. However, this would be a global switch. Or we could add a special request parameter like :deleteEmptyStringIfBlank=false which you could use on your requests? IMHO, applying this on the global or even request level is too coarse-grained. Strings of zero length on update in post servlet delete the property Key: SLING-2534 URL: https://issues.apache.org/jira/browse/SLING-2534 Project: Sling Issue Type: Bug Components: Servlets Affects Versions: Servlets Post 2.1.2 Reporter: Endolf Attachments: blankstrings.patch According to JCR specs, for string type properties, a blank string should be a valid value. Currently the post servlet delets any property where 1 or less values are specifed and the 1 value has a 0 length. I think string properties with a zero length should be blanked instead of deleted. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SLING-2542) Readd initial workspace support
[ https://issues.apache.org/jira/browse/SLING-2542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13420719#comment-13420719 ] Justin Edelson commented on SLING-2542: --- Both :) I thought the way it worked was that the request attribute was read and put into the authentication map. Readd initial workspace support --- Key: SLING-2542 URL: https://issues.apache.org/jira/browse/SLING-2542 Project: Sling Issue Type: Bug Components: JCR, ResourceResolver Reporter: Carsten Ziegeler Fix For: JCR Resource 2.1.2, Resource Resolver 1.0.0 With the split of the resolver from jcr we dropped the workspace support completeley. We had two ways: specifying the workspace through a request attribute or as a value inside the authentication map. Which one do we want to support? -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (SLING-2559) SlingHandlerManager uses setValue() on entries retrieved from a java.util.TreeMap
Justin Edelson created SLING-2559: - Summary: SlingHandlerManager uses setValue() on entries retrieved from a java.util.TreeMap Key: SLING-2559 URL: https://issues.apache.org/jira/browse/SLING-2559 Project: Sling Issue Type: Bug Components: JCR Affects Versions: JCR Webdav 2.1.0 Reporter: Justin Edelson Line 67 of org.apache.sling.jcr.webdav.impl.handler.SlingHandlerManager calls setValue() on a java.util.Map.Entry object retrieved from a TreeMap (indirectly through the entries collection). This is not allowed per the JavaDoc: http://docs.oracle.com/javase/6/docs/api/java/util/TreeMap.html All Map.Entry pairs returned by methods in this class and its views represent snapshots of mappings at the time they were produced. They do not support the Entry.setValue method. (Note however that it is possible to change mappings in the associated map using put.) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (SLING-2559) SlingHandlerManager uses setValue() on entries retrieved from a java.util.TreeMap
[ https://issues.apache.org/jira/browse/SLING-2559?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justin Edelson reassigned SLING-2559: - Assignee: Justin Edelson SlingHandlerManager uses setValue() on entries retrieved from a java.util.TreeMap - Key: SLING-2559 URL: https://issues.apache.org/jira/browse/SLING-2559 Project: Sling Issue Type: Bug Components: JCR Affects Versions: JCR Webdav 2.1.0 Reporter: Justin Edelson Assignee: Justin Edelson Line 67 of org.apache.sling.jcr.webdav.impl.handler.SlingHandlerManager calls setValue() on a java.util.Map.Entry object retrieved from a TreeMap (indirectly through the entries collection). This is not allowed per the JavaDoc: http://docs.oracle.com/javase/6/docs/api/java/util/TreeMap.html All Map.Entry pairs returned by methods in this class and its views represent snapshots of mappings at the time they were produced. They do not support the Entry.setValue method. (Note however that it is possible to change mappings in the associated map using put.) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (SLING-2559) SlingHandlerManager uses setValue() on entries retrieved from a java.util.TreeMap
[ https://issues.apache.org/jira/browse/SLING-2559?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justin Edelson resolved SLING-2559. --- Resolution: Fixed Fix Version/s: JCR Webdav 2.1.2 fixed in r1372539 SlingHandlerManager uses setValue() on entries retrieved from a java.util.TreeMap - Key: SLING-2559 URL: https://issues.apache.org/jira/browse/SLING-2559 Project: Sling Issue Type: Bug Components: JCR Affects Versions: JCR Webdav 2.1.0 Reporter: Justin Edelson Assignee: Justin Edelson Fix For: JCR Webdav 2.1.2 Line 67 of org.apache.sling.jcr.webdav.impl.handler.SlingHandlerManager calls setValue() on a java.util.Map.Entry object retrieved from a TreeMap (indirectly through the entries collection). This is not allowed per the JavaDoc: http://docs.oracle.com/javase/6/docs/api/java/util/TreeMap.html All Map.Entry pairs returned by methods in this class and its views represent snapshots of mappings at the time they were produced. They do not support the Entry.setValue method. (Note however that it is possible to change mappings in the associated map using put.) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (SLING-2561) add a configuration printer for JCR Repository Descriptors
Justin Edelson created SLING-2561: - Summary: add a configuration printer for JCR Repository Descriptors Key: SLING-2561 URL: https://issues.apache.org/jira/browse/SLING-2561 Project: Sling Issue Type: Improvement Components: JCR Reporter: Justin Edelson Assignee: Justin Edelson Fix For: JCR Web Console 1.0.2 This type of information is useful for troubleshooting. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (SLING-2561) add a configuration printer for JCR Repository Descriptors
[ https://issues.apache.org/jira/browse/SLING-2561?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justin Edelson resolved SLING-2561. --- Resolution: Fixed added in r1373694 add a configuration printer for JCR Repository Descriptors -- Key: SLING-2561 URL: https://issues.apache.org/jira/browse/SLING-2561 Project: Sling Issue Type: Improvement Components: JCR Reporter: Justin Edelson Assignee: Justin Edelson Fix For: JCR Web Console 1.0.2 This type of information is useful for troubleshooting. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (SLING-2563) when a thread pool is created without a label, the label should be generated using the class name requesting the thread pool
Justin Edelson created SLING-2563: - Summary: when a thread pool is created without a label, the label should be generated using the class name requesting the thread pool Key: SLING-2563 URL: https://issues.apache.org/jira/browse/SLING-2563 Project: Sling Issue Type: Improvement Components: Commons Reporter: Justin Edelson anonymous thread pools are hard to troubleshoot, so we shouldn't allow them :) If a class com.myco.FooImpl calls ThreadPoolManager.create(config) then the resulting thread pool's name should contain com.myco.FooImpl -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (SLING-2563) when a thread pool is created without a label, the label should be generated using the class name requesting the thread pool
[ https://issues.apache.org/jira/browse/SLING-2563?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justin Edelson updated SLING-2563: -- Attachment: SLING-2563.patch proposed patch when a thread pool is created without a label, the label should be generated using the class name requesting the thread pool Key: SLING-2563 URL: https://issues.apache.org/jira/browse/SLING-2563 Project: Sling Issue Type: Improvement Components: Commons Reporter: Justin Edelson Attachments: SLING-2563.patch anonymous thread pools are hard to troubleshoot, so we shouldn't allow them :) If a class com.myco.FooImpl calls ThreadPoolManager.create(config) then the resulting thread pool's name should contain com.myco.FooImpl -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (SLING-2564) expose MBeans for Sling Thread Pools
Justin Edelson created SLING-2564: - Summary: expose MBeans for Sling Thread Pools Key: SLING-2564 URL: https://issues.apache.org/jira/browse/SLING-2564 Project: Sling Issue Type: Improvement Components: Commons Reporter: Justin Edelson Each thread pool should be exposed via JMX. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (SLING-2564) expose MBeans for Sling Thread Pools
[ https://issues.apache.org/jira/browse/SLING-2564?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justin Edelson updated SLING-2564: -- Attachment: SLING-2564.patch patch attached is missing the bulk of the MBean definition and implementation, but I wanted to try to get some feedback on the overall registration logic as this isn't a part of the codebase I work in a lot. expose MBeans for Sling Thread Pools Key: SLING-2564 URL: https://issues.apache.org/jira/browse/SLING-2564 Project: Sling Issue Type: Improvement Components: Commons Reporter: Justin Edelson Attachments: SLING-2564.patch Each thread pool should be exposed via JMX. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (SLING-2563) when a thread pool is created without a label, the label should be generated using the class name requesting the thread pool
[ https://issues.apache.org/jira/browse/SLING-2563?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justin Edelson resolved SLING-2563. --- Resolution: Fixed Fix Version/s: Commons Threads 3.2.0 Assignee: Justin Edelson committed slightly modified patch in r1374422 when a thread pool is created without a label, the label should be generated using the class name requesting the thread pool Key: SLING-2563 URL: https://issues.apache.org/jira/browse/SLING-2563 Project: Sling Issue Type: Improvement Components: Commons Reporter: Justin Edelson Assignee: Justin Edelson Fix For: Commons Threads 3.2.0 Attachments: SLING-2563.patch anonymous thread pools are hard to troubleshoot, so we shouldn't allow them :) If a class com.myco.FooImpl calls ThreadPoolManager.create(config) then the resulting thread pool's name should contain com.myco.FooImpl -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (SLING-2521) Improve performance of sling:alias lookups and/or provide the ability to disable this feature
[ https://issues.apache.org/jira/browse/SLING-2521?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justin Edelson updated SLING-2521: -- Summary: Improve performance of sling:alias lookups and/or provide the ability to disable this feature (was: Allow disabling sling:alias support per configuration) Improve performance of sling:alias lookups and/or provide the ability to disable this feature - Key: SLING-2521 URL: https://issues.apache.org/jira/browse/SLING-2521 Project: Sling Issue Type: New Feature Components: JCR Affects Versions: JCR Resource 2.1.0 Reporter: Felix Meschberger Attachments: disabling-alias-performance.png The the JCR based ResourceResolver.resolve method currently support sling:alias properties on nodes to allow for resolution of translated URLs. This is potentially a very expensive operation particularly in the case of non existing resource. It should be analyzed whether (a) disabling sling:alias support has a measurable benefit on resource resolution (particularly when not finding a resource) and (b) whether it would be easy and simple to disable such support per configuration. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SLING-2521) Improve performance of sling:alias lookups and/or provide the ability to disable this feature
[ https://issues.apache.org/jira/browse/SLING-2521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13442652#comment-13442652 ] Justin Edelson commented on SLING-2521: --- Updated summary. The issue is not that this feature isn't desirable, but that the performance cost of it is too great. Improve performance of sling:alias lookups and/or provide the ability to disable this feature - Key: SLING-2521 URL: https://issues.apache.org/jira/browse/SLING-2521 Project: Sling Issue Type: New Feature Components: JCR Affects Versions: JCR Resource 2.1.0 Reporter: Felix Meschberger Attachments: disabling-alias-performance.png The the JCR based ResourceResolver.resolve method currently support sling:alias properties on nodes to allow for resolution of translated URLs. This is potentially a very expensive operation particularly in the case of non existing resource. It should be analyzed whether (a) disabling sling:alias support has a measurable benefit on resource resolution (particularly when not finding a resource) and (b) whether it would be easy and simple to disable such support per configuration. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (SLING-2311) Sling Performance Testing tool
[ https://issues.apache.org/jira/browse/SLING-2311?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justin Edelson reassigned SLING-2311: - Assignee: Justin Edelson Sling Performance Testing tool -- Key: SLING-2311 URL: https://issues.apache.org/jira/browse/SLING-2311 Project: Sling Issue Type: New Feature Components: Testing Reporter: Antonio Sanso Assignee: Justin Edelson Priority: Minor Attachments: ResolveWithManyAliasTest.java, ResolveWithManyVanityPath.png, SLING-2311-patch.txt As described/discussed in [0] it would be nice to have a performance test tool in Sling . This can be useful in different situations (e.g. micro benchmarks of a feature and so on). Patch to follow [0] http://sling.markmail.org/message/bz44im7aqeae4r57 -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (SLING-2521) Improve performance of sling:alias lookups and/or provide the ability to disable this feature
[ https://issues.apache.org/jira/browse/SLING-2521?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justin Edelson updated SLING-2521: -- Attachment: SLING-2521.patch This looks to be reasonably simple to fix - we just have to treat aliases like vanity paths, e.g. something where we store a cache of the values rather iterating through the node structure. Proposed patch attached. This is not 100% backwards compatible as the former behavior supported having multiple nodes with the same alias in the same path, e.g. /content/foo bar - sling:alias = test baz - sling:alias = test The resolved path for /content/foo/test would depend upon the node order of bar and baz. With this patch, the behavior would be non-deterministic (unless respectDocumentOrder was enabled in Jackrabbit). Improve performance of sling:alias lookups and/or provide the ability to disable this feature - Key: SLING-2521 URL: https://issues.apache.org/jira/browse/SLING-2521 Project: Sling Issue Type: New Feature Components: JCR Affects Versions: JCR Resource 2.1.0 Reporter: Felix Meschberger Attachments: disabling-alias-performance.png, SLING-2521.patch The the JCR based ResourceResolver.resolve method currently support sling:alias properties on nodes to allow for resolution of translated URLs. This is potentially a very expensive operation particularly in the case of non existing resource. It should be analyzed whether (a) disabling sling:alias support has a measurable benefit on resource resolution (particularly when not finding a resource) and (b) whether it would be easy and simple to disable such support per configuration. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SLING-2311) Sling Performance Testing tool
[ https://issues.apache.org/jira/browse/SLING-2311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13442681#comment-13442681 ] Justin Edelson commented on SLING-2311: --- I've added this in r1377819. Thanks for the contribution. I had to make a number of modifications. Chiefly is that since these tests rely on internal methods which change from release to release, the logic for constructing a ResourceResolver is encapsulated into a helper class (called TestHelper - don't love the name, but we can change it). Added more scenarios for the tests included based on node size, e.g. 1000 vanity paths, 5000 vanity paths, etc. One thing that I couldn't figure out is why a JcrResourceListener was being created, so I removed that bit. Antonio - please let me know if this needs to be there. Tests can be run for JCR Resource Resolver 2.0.10, 2.1.0, and 2.1.1-SNAPSHOT (which I'm calling 2.2.0 for the sake of argument). Sling Performance Testing tool -- Key: SLING-2311 URL: https://issues.apache.org/jira/browse/SLING-2311 Project: Sling Issue Type: New Feature Components: Testing Reporter: Antonio Sanso Assignee: Justin Edelson Priority: Minor Attachments: ResolveWithManyAliasTest.java, ResolveWithManyVanityPath.png, SLING-2311-patch.txt As described/discussed in [0] it would be nice to have a performance test tool in Sling . This can be useful in different situations (e.g. micro benchmarks of a feature and so on). Patch to follow [0] http://sling.markmail.org/message/bz44im7aqeae4r57 -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SLING-2311) Sling Performance Testing tool
[ https://issues.apache.org/jira/browse/SLING-2311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13442690#comment-13442690 ] Justin Edelson commented on SLING-2311: --- changes made for SLING-2579 required some slight tweaking. done in r1377828 Sling Performance Testing tool -- Key: SLING-2311 URL: https://issues.apache.org/jira/browse/SLING-2311 Project: Sling Issue Type: New Feature Components: Testing Reporter: Antonio Sanso Assignee: Justin Edelson Priority: Minor Attachments: ResolveWithManyAliasTest.java, ResolveWithManyVanityPath.png, SLING-2311-patch.txt As described/discussed in [0] it would be nice to have a performance test tool in Sling . This can be useful in different situations (e.g. micro benchmarks of a feature and so on). Patch to follow [0] http://sling.markmail.org/message/bz44im7aqeae4r57 -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SLING-2521) Improve performance of sling:alias lookups and/or provide the ability to disable this feature
[ https://issues.apache.org/jira/browse/SLING-2521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13442694#comment-13442694 ] Justin Edelson commented on SLING-2521: --- Perf test results: # ResolveWith1000AliasTest min 10% 50% 90% max jcr.resource-2.1.031 33 40 50 81 # ResolveWith5000AliasTest min 10% 50% 90% max jcr.resource-2.1.0 230 242 254 275 472 # ResolveWith1AliasTest min 10% 50% 90% max jcr.resource-2.1.0 459 459 536 804 804 # ResolveWith1000AliasTest min 10% 50% 90% max jcr.resource-2.2.041 43 52 77 132 # ResolveWith5000AliasTest min 10% 50% 90% max jcr.resource-2.2.0 278 279 294 440 459 # ResolveWith1AliasTest min 10% 50% 90% max jcr.resource-2.2.0 523 523 55411271127 # ResolveWith1000AliasTest min 10% 50% 90% max jcr.resource-2.2.0 (patched) 0 0 0 0 53 # ResolveWith5000AliasTest min 10% 50% 90% max jcr.resource-2.2.0 (patched) 0 0 0 0 15 # ResolveWith1AliasTest min 10% 50% 90% max jcr.resource-2.2.0 (patched) 0 0 0 0 77 Improve performance of sling:alias lookups and/or provide the ability to disable this feature - Key: SLING-2521 URL: https://issues.apache.org/jira/browse/SLING-2521 Project: Sling Issue Type: New Feature Components: JCR Affects Versions: JCR Resource 2.1.0 Reporter: Felix Meschberger Attachments: disabling-alias-performance.png, SLING-2521.patch The the JCR based ResourceResolver.resolve method currently support sling:alias properties on nodes to allow for resolution of translated URLs. This is potentially a very expensive operation particularly in the case of non existing resource. It should be analyzed whether (a) disabling sling:alias support has a measurable benefit on resource resolution (particularly when not finding a resource) and (b) whether it would be easy and simple to disable such support per configuration. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Comment Edited] (SLING-2521) Improve performance of sling:alias lookups and/or provide the ability to disable this feature
[ https://issues.apache.org/jira/browse/SLING-2521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13442694#comment-13442694 ] Justin Edelson edited comment on SLING-2521 at 8/28/12 7:31 AM: Perf test results: # ResolveWith1000AliasTest min 10% 50% 90% max jcr.resource-2.1.031 33 40 50 81 # ResolveWith5000AliasTest min 10% 50% 90% max jcr.resource-2.1.0 230 242 254 275 472 # ResolveWith1AliasTest min 10% 50% 90% max jcr.resource-2.1.0 459 459 536 804 804 # ResolveWith1000AliasTest min 10% 50% 90% max jcr.resource-2.2.041 43 52 77 132 # ResolveWith5000AliasTest min 10% 50% 90% max jcr.resource-2.2.0 278 279 294 440 459 # ResolveWith1AliasTest min 10% 50% 90% max jcr.resource-2.2.0 523 523 55411271127 # ResolveWith1000AliasTest min 10% 50% 90% max jcr.resource-2.2.0 (patched) 0 0 0 0 53 # ResolveWith5000AliasTest min 10% 50% 90% max jcr.resource-2.2.0 (patched) 0 0 0 0 15 # ResolveWith1AliasTest min 10% 50% 90% max jcr.resource-2.2.0 (patched) 0 0 0 0 77 was (Author: justinedelson): Perf test results: pre # ResolveWith1000AliasTest min 10% 50% 90% max jcr.resource-2.1.031 33 40 50 81 # ResolveWith5000AliasTest min 10% 50% 90% max jcr.resource-2.1.0 230 242 254 275 472 # ResolveWith1AliasTest min 10% 50% 90% max jcr.resource-2.1.0 459 459 536 804 804 # ResolveWith1000AliasTest min 10% 50% 90% max jcr.resource-2.2.041 43 52 77 132 # ResolveWith5000AliasTest min 10% 50% 90% max jcr.resource-2.2.0 278 279 294 440 459 # ResolveWith1AliasTest min 10% 50% 90% max jcr.resource-2.2.0 523 523 55411271127 # ResolveWith1000AliasTest min 10% 50% 90% max jcr.resource-2.2.0 (patched) 0 0 0 0 53 # ResolveWith5000AliasTest min 10% 50% 90% max jcr.resource-2.2.0 (patched) 0 0 0 0 15 # ResolveWith1AliasTest min 10% 50% 90% max jcr.resource-2.2.0 (patched) 0 0 0 0 77 /pre Improve performance of sling:alias lookups and/or provide the ability to disable this feature - Key: SLING-2521 URL: https://issues.apache.org/jira/browse/SLING-2521 Project: Sling Issue Type: New Feature Components: JCR Affects Versions: JCR Resource 2.1.0 Reporter: Felix Meschberger Attachments: disabling-alias-performance.png, SLING-2521.patch The the JCR based ResourceResolver.resolve method currently support sling:alias properties on nodes to allow for resolution of translated URLs. This is potentially a very expensive operation particularly in the case of non existing resource. It should be analyzed whether (a) disabling sling:alias support has a measurable benefit on resource resolution (particularly when not finding a resource) and (b) whether it would be easy and simple to disable such support per configuration. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Comment Edited] (SLING-2521) Improve performance of sling:alias lookups and/or provide the ability to disable this feature
[ https://issues.apache.org/jira/browse/SLING-2521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13442694#comment-13442694 ] Justin Edelson edited comment on SLING-2521 at 8/28/12 7:31 AM: Perf test results: pre # ResolveWith1000AliasTest min 10% 50% 90% max jcr.resource-2.1.031 33 40 50 81 # ResolveWith5000AliasTest min 10% 50% 90% max jcr.resource-2.1.0 230 242 254 275 472 # ResolveWith1AliasTest min 10% 50% 90% max jcr.resource-2.1.0 459 459 536 804 804 # ResolveWith1000AliasTest min 10% 50% 90% max jcr.resource-2.2.041 43 52 77 132 # ResolveWith5000AliasTest min 10% 50% 90% max jcr.resource-2.2.0 278 279 294 440 459 # ResolveWith1AliasTest min 10% 50% 90% max jcr.resource-2.2.0 523 523 55411271127 # ResolveWith1000AliasTest min 10% 50% 90% max jcr.resource-2.2.0 (patched) 0 0 0 0 53 # ResolveWith5000AliasTest min 10% 50% 90% max jcr.resource-2.2.0 (patched) 0 0 0 0 15 # ResolveWith1AliasTest min 10% 50% 90% max jcr.resource-2.2.0 (patched) 0 0 0 0 77 /pre was (Author: justinedelson): Perf test results: # ResolveWith1000AliasTest min 10% 50% 90% max jcr.resource-2.1.031 33 40 50 81 # ResolveWith5000AliasTest min 10% 50% 90% max jcr.resource-2.1.0 230 242 254 275 472 # ResolveWith1AliasTest min 10% 50% 90% max jcr.resource-2.1.0 459 459 536 804 804 # ResolveWith1000AliasTest min 10% 50% 90% max jcr.resource-2.2.041 43 52 77 132 # ResolveWith5000AliasTest min 10% 50% 90% max jcr.resource-2.2.0 278 279 294 440 459 # ResolveWith1AliasTest min 10% 50% 90% max jcr.resource-2.2.0 523 523 55411271127 # ResolveWith1000AliasTest min 10% 50% 90% max jcr.resource-2.2.0 (patched) 0 0 0 0 53 # ResolveWith5000AliasTest min 10% 50% 90% max jcr.resource-2.2.0 (patched) 0 0 0 0 15 # ResolveWith1AliasTest min 10% 50% 90% max jcr.resource-2.2.0 (patched) 0 0 0 0 77 Improve performance of sling:alias lookups and/or provide the ability to disable this feature - Key: SLING-2521 URL: https://issues.apache.org/jira/browse/SLING-2521 Project: Sling Issue Type: New Feature Components: JCR Affects Versions: JCR Resource 2.1.0 Reporter: Felix Meschberger Attachments: disabling-alias-performance.png, SLING-2521.patch The the JCR based ResourceResolver.resolve method currently support sling:alias properties on nodes to allow for resolution of translated URLs. This is potentially a very expensive operation particularly in the case of non existing resource. It should be analyzed whether (a) disabling sling:alias support has a measurable benefit on resource resolution (particularly when not finding a resource) and (b) whether it would be easy and simple to disable such support per configuration. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (SLING-2521) Improve performance of sling:alias lookups and/or provide the ability to disable this feature
[ https://issues.apache.org/jira/browse/SLING-2521?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justin Edelson updated SLING-2521: -- Attachment: SLING-2521-u1.patch forgot about the case where sling:alias is set on the jcr:content child node. fixed the patch. Improve performance of sling:alias lookups and/or provide the ability to disable this feature - Key: SLING-2521 URL: https://issues.apache.org/jira/browse/SLING-2521 Project: Sling Issue Type: New Feature Components: JCR Affects Versions: JCR Resource 2.1.0 Reporter: Felix Meschberger Attachments: disabling-alias-performance.png, SLING-2521.patch, SLING-2521-u1.patch The the JCR based ResourceResolver.resolve method currently support sling:alias properties on nodes to allow for resolution of translated URLs. This is potentially a very expensive operation particularly in the case of non existing resource. It should be analyzed whether (a) disabling sling:alias support has a measurable benefit on resource resolution (particularly when not finding a resource) and (b) whether it would be easy and simple to disable such support per configuration. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (SLING-2583) introduce MapConfigurationProvider introduce to help test MapEntries
Justin Edelson created SLING-2583: - Summary: introduce MapConfigurationProvider introduce to help test MapEntries Key: SLING-2583 URL: https://issues.apache.org/jira/browse/SLING-2583 Project: Sling Issue Type: Improvement Components: ResourceResolver Reporter: Justin Edelson Assignee: Justin Edelson Fix For: Resource Resolver 1.0.0 In trying to build out a unit test of MapEntries, it is helpful to have an extension of the ResourceResolverFactory interface which is more easily mocked than the ResourceResolverFactoryImpl class. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (SLING-2583) introduce MapConfigurationProvider introduce to help test MapEntries
[ https://issues.apache.org/jira/browse/SLING-2583?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justin Edelson resolved SLING-2583. --- Resolution: Fixed added in r1378260 introduce MapConfigurationProvider introduce to help test MapEntries Key: SLING-2583 URL: https://issues.apache.org/jira/browse/SLING-2583 Project: Sling Issue Type: Improvement Components: ResourceResolver Reporter: Justin Edelson Assignee: Justin Edelson Fix For: Resource Resolver 1.0.0 In trying to build out a unit test of MapEntries, it is helpful to have an extension of the ResourceResolverFactory interface which is more easily mocked than the ResourceResolverFactoryImpl class. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (SLING-2544) Restore tests included in the no longer existing JcrResourceResolverTest
[ https://issues.apache.org/jira/browse/SLING-2544?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justin Edelson reassigned SLING-2544: - Assignee: Justin Edelson Restore tests included in the no longer existing JcrResourceResolverTest - Key: SLING-2544 URL: https://issues.apache.org/jira/browse/SLING-2544 Project: Sling Issue Type: New Feature Components: ResourceResolver Reporter: Antonio Sanso Assignee: Justin Edelson Attachments: JcrResourceResolverTest.java, SynchronousJcrResourceListener.java With SLING-2396 almost all the testsincluded in the no longer existing JcrResourceResolverTest e.g. testResolveVirtualHostHttp80()/ testResolveResourceAlias()/ ... have been lost in translation. I think it would be really useful to restore them specially for regression detection -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SLING-2544) Restore tests included in the no longer existing JcrResourceResolverTest
[ https://issues.apache.org/jira/browse/SLING-2544?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13443439#comment-13443439 ] Justin Edelson commented on SLING-2544: --- We can't really run these in a launched instance because they involve some internals. But they still belong in the IT area of the project. Restore tests included in the no longer existing JcrResourceResolverTest - Key: SLING-2544 URL: https://issues.apache.org/jira/browse/SLING-2544 Project: Sling Issue Type: New Feature Components: ResourceResolver Reporter: Antonio Sanso Attachments: JcrResourceResolverTest.java, SynchronousJcrResourceListener.java With SLING-2396 almost all the testsincluded in the no longer existing JcrResourceResolverTest e.g. testResolveVirtualHostHttp80()/ testResolveResourceAlias()/ ... have been lost in translation. I think it would be really useful to restore them specially for regression detection -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SLING-2544) Restore tests included in the no longer existing JcrResourceResolverTest
[ https://issues.apache.org/jira/browse/SLING-2544?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13443703#comment-13443703 ] Justin Edelson commented on SLING-2544: --- added this test to the integration-tests module in r1378407. It gets run (like all ITs) in the testing and/or testing-war projects. Created a new package for this type of test: org.apache.sling.launchpad.local.integrationtest open issue is how to coordinate bundle versions with this test (to Carsten's point) Restore tests included in the no longer existing JcrResourceResolverTest - Key: SLING-2544 URL: https://issues.apache.org/jira/browse/SLING-2544 Project: Sling Issue Type: New Feature Components: ResourceResolver Reporter: Antonio Sanso Assignee: Justin Edelson Fix For: Launchpad Testing 7 Attachments: JcrResourceResolverTest.java, SynchronousJcrResourceListener.java With SLING-2396 almost all the testsincluded in the no longer existing JcrResourceResolverTest e.g. testResolveVirtualHostHttp80()/ testResolveResourceAlias()/ ... have been lost in translation. I think it would be really useful to restore them specially for regression detection -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (SLING-2544) Restore tests included in the no longer existing JcrResourceResolverTest
[ https://issues.apache.org/jira/browse/SLING-2544?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justin Edelson updated SLING-2544: -- Fix Version/s: Launchpad Testing 7 Restore tests included in the no longer existing JcrResourceResolverTest - Key: SLING-2544 URL: https://issues.apache.org/jira/browse/SLING-2544 Project: Sling Issue Type: New Feature Components: ResourceResolver Reporter: Antonio Sanso Assignee: Justin Edelson Fix For: Launchpad Testing 7 Attachments: JcrResourceResolverTest.java, SynchronousJcrResourceListener.java With SLING-2396 almost all the testsincluded in the no longer existing JcrResourceResolverTest e.g. testResolveVirtualHostHttp80()/ testResolveResourceAlias()/ ... have been lost in translation. I think it would be really useful to restore them specially for regression detection -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (SLING-2544) Restore tests included in the no longer existing JcrResourceResolverTest
[ https://issues.apache.org/jira/browse/SLING-2544?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justin Edelson resolved SLING-2544. --- Resolution: Fixed Restore tests included in the no longer existing JcrResourceResolverTest - Key: SLING-2544 URL: https://issues.apache.org/jira/browse/SLING-2544 Project: Sling Issue Type: New Feature Components: Launchpad, ResourceResolver, Testing Reporter: Antonio Sanso Assignee: Justin Edelson Fix For: Launchpad Testing 7 Attachments: JcrResourceResolverTest.java, SynchronousJcrResourceListener.java With SLING-2396 almost all the testsincluded in the no longer existing JcrResourceResolverTest e.g. testResolveVirtualHostHttp80()/ testResolveResourceAlias()/ ... have been lost in translation. I think it would be really useful to restore them specially for regression detection -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (SLING-2544) Restore tests included in the no longer existing JcrResourceResolverTest
[ https://issues.apache.org/jira/browse/SLING-2544?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justin Edelson updated SLING-2544: -- Component/s: Testing Launchpad Restore tests included in the no longer existing JcrResourceResolverTest - Key: SLING-2544 URL: https://issues.apache.org/jira/browse/SLING-2544 Project: Sling Issue Type: New Feature Components: Launchpad, ResourceResolver, Testing Reporter: Antonio Sanso Assignee: Justin Edelson Fix For: Launchpad Testing 7 Attachments: JcrResourceResolverTest.java, SynchronousJcrResourceListener.java With SLING-2396 almost all the testsincluded in the no longer existing JcrResourceResolverTest e.g. testResolveVirtualHostHttp80()/ testResolveResourceAlias()/ ... have been lost in translation. I think it would be really useful to restore them specially for regression detection -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (SLING-2584) have JcrResourceResolverTest reuse SynchronousJcrResourceListener from jcr.resource project
Justin Edelson created SLING-2584: - Summary: have JcrResourceResolverTest reuse SynchronousJcrResourceListener from jcr.resource project Key: SLING-2584 URL: https://issues.apache.org/jira/browse/SLING-2584 Project: Sling Issue Type: Improvement Components: Launchpad Reporter: Justin Edelson As part of SLING-2544, I had to duplicate the SynchronousJcrResourceListener class so it could be used in the JcrResourceResolverTest. This duplication should be removed. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (SLING-2585) remove dependency from JcrResourceResolverTest to org.apache.felix.framework.FilterImpl
Justin Edelson created SLING-2585: - Summary: remove dependency from JcrResourceResolverTest to org.apache.felix.framework.FilterImpl Key: SLING-2585 URL: https://issues.apache.org/jira/browse/SLING-2585 Project: Sling Issue Type: Improvement Reporter: Justin Edelson perhaps we could mock this... -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
