Re: svn commit: r106170 - /spamassassin/trunk/spamd/spamd.raw

2004-11-22 Thread Sidney Markowitz 
Daniel Quinlan wrote:
Please try to use the more standard perl formatting:
Do you see anything wrong other than two of the lines being more than 80 
 characters? I'll check in an update to fix that as soon as I finish 
running a make test on the change.

 -- sidney

Re: svn commit: r106170 - /spamassassin/trunk/spamd/spamd.raw

2004-11-22 Thread Justin Mason 
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1


Daniel Quinlan writes:
 [EMAIL PROTECTED] writes:
 
  [...]
   sub service_unavailable_error {
 my ($err) = @_;
 my $resp = EX_UNAVAILABLE;
  -  print $client SPAMD/1.0 $resphash{$resp} Service Unavailable: $err\r\n;
  +  syswrite( $client, SPAMD/1.0 $resphash{$resp} Service Unavailable: 
  $err\r\n );
 logmsg(service unavailable: $err);
   }
 
 Please try to use the more standard perl formatting:
 
   http://wiki.apache.org/spamassassin/CodingStyle
 
 Thanks!

ah, the foo( bar ) vs. foo(bar) style issue ;)

- --j.
-BEGIN PGP SIGNATURE-
Version: GnuPG v1.2.4 (GNU/Linux)
Comment: Exmh CVS

iD8DBQFBojZzMJF5cimLx9ARAnMvAKCBfg2Z0B/LDlRlnOW5eBXqkpJzgACbBiiB
TvayyMOJ8XHjvmhxmKZy1p4=
=NDK9
-END PGP SIGNATURE-

Re: svn commit: r106170 - /spamassassin/trunk/spamd/spamd.raw

2004-11-22 Thread Justin Mason 
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1


Sidney Markowitz writes:
 Daniel Quinlan wrote:
  Please try to use the more standard perl formatting:
 
 Do you see anything wrong other than two of the lines being more than 80 
   characters? I'll check in an update to fix that as soon as I finish 
 running a make test on the change.

Sidney -- I think it's the

foo( bar )

vs.

foo(bar)

style thing.  Daniel prefers the latter -- no extra spaces after the
bracket, and we've agreed to go with that. ;)

- --j.
-BEGIN PGP SIGNATURE-
Version: GnuPG v1.2.4 (GNU/Linux)
Comment: Exmh CVS

iD8DBQFBojbwMJF5cimLx9ARAq2sAJ9n90D3h0q567L1ZD4GO9Fy9g9LGwCgmOoh
k3AFTFQV8Z7dmCrpEbjDILE=
=HsD8
-END PGP SIGNATURE-

Re: svn commit: r106170 - /spamassassin/trunk/spamd/spamd.raw

2004-11-22 Thread Sidney Markowitz 
Justin Mason wrote:
Sidney -- I think it's the
foo( bar )
vs.
foo(bar)
I prefer that too. I copied the style that was already in the code, and 
I looked for something about that in the style guide and did not see any 
mention of it one way or the other. Unless it is there and I missed it, 
you or Daniel should add something about it on the wiki page.

 -- sidney

Re: svn commit: r106170 - /spamassassin/trunk/spamd/spamd.raw

2004-11-22 Thread Daniel Quinlan 
Sidney Markowitz [EMAIL PROTECTED] writes:

 I prefer that too. I copied the style that was already in the code, and 
 I looked for something about that in the style guide and did not see any 
 mention of it one way or the other. Unless it is there and I missed it, 
 you or Daniel should add something about it on the wiki page.

Oh, it's just part of the basic perlstyle document:

   *   No space between function name and its opening paren­
   thesis.

Daniel

-- 
Daniel Quinlan
http://www.pathname.com/~quinlan/

Re: svn commit: r106170 - /spamassassin/trunk/spamd/spamd.raw

2004-11-22 Thread Sidney Markowitz 
Daniel Quinlan wrote:
   *   No space between function name and its opening paren­
   thesis.
I did see that. That would allow foo( bar ) which is what I did. If you 
want foo(bar) as a preferred style it would have to be added to the wiki 
page.

 -- sidney

Re: svn commit: r106170 - /spamassassin/trunk/spamd/spamd.raw

2004-11-22 Thread Daniel Quinlan 
Sidney Markowitz [EMAIL PROTECTED] writes:

 I did see that. That would allow foo( bar ) which is what I did. If you 
 want foo(bar) as a preferred style it would have to be added to the wiki 
 page.

I will do.

-- 
Daniel Quinlan
http://www.pathname.com/~quinlan/