Re: [VOTE] Release Struts Annotations 1.0.0
The annotations module was setup from struts-archetype-blank, so I wonder if we should to add LICENSE and NOTICE files to the archetype to avoid such issues in future... - Rene Don Brown schrieb: I don't understand - all of the Struts jars are missing those files. The only place I see it added is in the assembly tarballs. Don Wendy Smoak wrote: On 1/24/07, Wendy Smoak [EMAIL PROTECTED] wrote: Struts Annotations 1.0.0 has been tagged and is available for testing ... Once you have had a chance to test this build, please vote on whether to release it to the central Maven repository. -1 -- The jar is missing LICENSE and NOTICE files. (It would also be nice to configure the jar plugin to add more info to the jar file manifest, it's nearly empty.) - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: Fast ValueStack
Oops, the numbers aren't quite as bad as I thought. The original numbers included the cost of compiling the OGNL expression. If you exclude the OGNL compilation the numbers are: Using OGNL expression: 15 ms Explicitly calling getText: 0 ms I knew that compiling the OGNL expression took a long time, but I didn't realize it was that long. I still think there is a benefit to updating the way the UIBean does key lookup. At a minimum it will make the Text and other UIBeans more consistent and there is a slight performance benefit. I'm glad you resolved your issue. I knew about the other property, but I normally don't set that one explicitly--so I didn't think to mention it. :) That definitely explains the huge numbers. Tom David H. DeWolf wrote: Nice, that seems in line with what I'm seeing as well now. I still think this is worth improving, as those 5ms can add up on larger forms. Tom Schneider wrote: Well, I guess I was feeling more ambitious than I thought. I wrote a simple junit test (below) that tests the 2 techniques for retrieving I18N text. My numbers for 100 iterations were: Using OGNL expression: 476 ms Explicitly calling getText: 0 ms Yikes!!! There is quite a difference between the two. The OGNL version takes 5 ms/request compared to almost nothing for the explicit call. It looks like it would be very beneficial to reimplement the UIBean key lookup code based on the Text component-style of text lookup. Agreed. I've created: https://issues.apache.org/struts/browse/WW-1681 - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: [VOTE] Release Struts Annotations 1.0.0
On 1/26/07, Wendy Smoak [EMAIL PROTECTED] wrote: The release manager for Struts 2.0.4 will need to add a profile to settings.xml so that Maven can find the struts-annotations jar: [untested] settings ... profiles profile idstruts-annotations-101-staging/id repositories repository idstruts-annotations-101-staging/id url http://people.apache.org/builds/struts/struts-annotations-1.0.1/m2-staging-repository /url snapshotsenabledfalse/enabled/snapshots releasesenabledtrue/enabled/releases /repository /repositories /profile ... /profiles activeProfiles activeProfilestruts-annotations-101-staging/activeProfile ... /activeProfiles /settings At the risk of complicating things, isn't bad form, if nothing else, to cut a release based on a transient repository location? One of the reasons to use Maven is to have a reproducible build, and a release is the kind of build which is more likely to need to be reproducible for some reason, and it seems fairly likely that the struts-annotations-101-staging repository will not be around for ever. I will allow that this may be more about formality than anything else, and I won't object to a build done this way, but it seemed worth mentioning. Maybe someone else feels more strongly about it. Joe -- Joe Germuska [EMAIL PROTECTED] * http://blog.germuska.com The truth is that we learned from João forever to be out of tune. -- Caetano Veloso
Re: [VOTE] Release Struts Annotations 1.0.0
On 1/27/07, Joe Germuska [EMAIL PROTECTED] wrote: At the risk of complicating things, isn't bad form, if nothing else, to cut a release based on a transient repository location? One of the reasons to use Maven is to have a reproducible build, and a release is the kind of build which is more likely to need to be reproducible for some reason, and it seems fairly likely that the struts-annotations-101-staging repository will not be around for ever. It's true that the staging repo will go away, but prior to that, the struts-annotations jar will be put into the central Maven repo. This does not affect the long term reproducibility of the struts 2.0.4 build. Nothing in the tagged/released struts poms will refer to the staging repo, it only goes in the release manager's settings.xml file temporarily. (Alternately, the RM could download and 'mvn install:install-file ...' the struts-annotations jar locally.) -- Wendy - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
