File upload interceptor/filter dispatcher temp file cleanup
Where are uploaded files currently cleaned up? The patch for WW-3490 [1] moved temp file deletion out of the interceptor into the dispatcher, but if the ng dispatcher is being used, when/how are the files deleted? I've dug a little bit and haven't seen it yet; at this point it's quicker to ask. Thanks, Dave [1] https://issues.apache.org/jira/browse/WW-3490
Re: File upload interceptor/filter dispatcher temp file cleanup
Anyone? So far it appears as though the patch only fixed the old filter and not those of the ng variety? Also, I'm wondering if we'd like to un-ng this, or barring that, at least re-package to something named better and put a subclass in ng and deprecate. Dave On Thu, Jun 21, 2012 at 6:14 AM, Dave Newton davelnew...@gmail.com wrote: Where are uploaded files currently cleaned up? The patch for WW-3490 [1] moved temp file deletion out of the interceptor into the dispatcher, but if the ng dispatcher is being used, when/how are the files deleted? I've dug a little bit and haven't seen it yet; at this point it's quicker to ask. Thanks, Dave [1] https://issues.apache.org/jira/browse/WW-3490
Re: File upload interceptor/filter dispatcher temp file cleanup
On Thu, Jun 21, 2012 at 12:05 PM, Dave Newton davelnew...@gmail.com wrote: Anyone? I am just guessing, but perhaps this? http://y.ahoo.it/Qzl2h -- Martin Cooper So far it appears as though the patch only fixed the old filter and not those of the ng variety? Also, I'm wondering if we'd like to un-ng this, or barring that, at least re-package to something named better and put a subclass in ng and deprecate. Dave On Thu, Jun 21, 2012 at 6:14 AM, Dave Newton davelnew...@gmail.com wrote: Where are uploaded files currently cleaned up? The patch for WW-3490 [1] moved temp file deletion out of the interceptor into the dispatcher, but if the ng dispatcher is being used, when/how are the files deleted? I've dug a little bit and haven't seen it yet; at this point it's quicker to ask. Thanks, Dave [1] https://issues.apache.org/jira/browse/WW-3490 - To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org For additional commands, e-mail: dev-h...@struts.apache.org
Re: File upload interceptor/filter dispatcher temp file cleanup
Hi Dave, I've changed a bit the whole cleanup idea, right now it's delegated to given implementation of MultiPartRequest, to the method cleanUp(). So a filter calls Dispatcher.cleanUpRequest(request) which delegate to MultiPartRequest.cleanUp() It works with old and with the new filters. Regards -- Łukasz mobile +48 606 323 122 http://www.lenart.org.pl/ Warszawa JUG conference - Confitura http://confitura.pl/ - To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org For additional commands, e-mail: dev-h...@struts.apache.org
Re: File upload interceptor/filter dispatcher temp file cleanup
On Thu, Jun 21, 2012 at 3:51 PM, Łukasz Lenart lukasz.len...@googlemail.com wrote: I've changed a bit the whole cleanup idea, right now it's delegated to given implementation of MultiPartRequest, to the method cleanUp(). So a filter calls Dispatcher.cleanUpRequest(request) which delegate to MultiPartRequest.cleanUp() It works with old and with the new filters. Ah, okay--cool :) I don't see it in the ng filter dispatcher, but I'll track it down later when I have a chance. Is there an elevator pitch for how the ng filter ends up calling it? Thanks, Dave
Re: File upload interceptor/filter dispatcher temp file cleanup
2012/6/21 Dave Newton davelnew...@gmail.com: Ah, okay--cool :) I don't see it in the ng filter dispatcher, but I'll track it down later when I have a chance. Is there an elevator pitch for how the ng filter ends up calling it? Take a look on the finally section of doFilter(), there is a call to Prepare.cleanupRequest(request); https://svn.apache.org/repos/asf/struts/struts2/trunk/core/src/main/java/org/apache/struts2/dispatcher/ng/filter/StrutsPrepareAndExecuteFilter.java https://svn.apache.org/repos/asf/struts/struts2/trunk/core/src/main/java/org/apache/struts2/dispatcher/ng/filter/StrutsPrepareFilter.java Regards -- Łukasz mobile +48 606 323 122 http://www.lenart.org.pl/ Warszawa JUG conference - Confitura http://confitura.pl/ - To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org For additional commands, e-mail: dev-h...@struts.apache.org
Re: File upload interceptor/filter dispatcher temp file cleanup
Woohoo, I get it now... I saw the PrepareOperations before but digging w/o an IDE is a pain. Sweet--thanks again. Dave On Thu, Jun 21, 2012 at 4:11 PM, Łukasz Lenart lukasz.len...@googlemail.com wrote: 2012/6/21 Dave Newton davelnew...@gmail.com: Ah, okay--cool :) I don't see it in the ng filter dispatcher, but I'll track it down later when I have a chance. Is there an elevator pitch for how the ng filter ends up calling it? Take a look on the finally section of doFilter(), there is a call to Prepare.cleanupRequest(request); https://svn.apache.org/repos/asf/struts/struts2/trunk/core/src/main/java/org/apache/struts2/dispatcher/ng/filter/StrutsPrepareAndExecuteFilter.java https://svn.apache.org/repos/asf/struts/struts2/trunk/core/src/main/java/org/apache/struts2/dispatcher/ng/filter/StrutsPrepareFilter.java Regards -- Łukasz mobile +48 606 323 122 http://www.lenart.org.pl/ Warszawa JUG conference - Confitura http://confitura.pl/
