DO NOT REPLY [Bug 30292] - Replacement of LookupDispatchAction
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=30292. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=30292 [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |RESOLVED Resolution||WONTFIX --- Additional Comments From [EMAIL PROTECTED] 2006-03-08 03:20 --- (In reply to comment #16) I removed my votes for this bugfix. The solution presented in bug #38343 is more compact and better thought out. I think that this bug should be closed in favor of bug #38343. OK Bug 38343 has been committed so closing as WONTFIX. -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 30292] - Replacement of LookupDispatchAction
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=30292. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=30292 --- Additional Comments From [EMAIL PROTECTED] 2006-02-10 02:51 --- I removed my votes for this bugfix. The solution presented in bug #38343 is more compact and better thought out. I think that this bug should be closed in favor of bug #38343. -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 30292] - Replacement of LookupDispatchAction
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=30292. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=30292 [EMAIL PROTECTED] changed: What|Removed |Added Attachment #15754|0 |1 is obsolete|| Attachment #15762|0 |1 is obsolete|| --- Additional Comments From [EMAIL PROTECTED] 2005-07-26 10:36 --- Created an attachment (id=15777) -- (http://issues.apache.org/bugzilla/attachment.cgi?id=15777action=view) SelectAction: uniformly works with pushbuttons, image buttons and links. Back to original design. Attachment 15762 contained Michael McGrady's code, this one, like previous ones, does not. * uses prefix to define an event; * allows to define default event for default submit case; * works with pushbuttons, image buttons and links; * compatible with standard DispatchAction if using parameter attribute; * uses event-to-method map, defined in the action (indirect method access seems more secure than referencing action method right in the HTML form). -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 30292] - Replacement of LookupDispatchAction
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=30292. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=30292 --- Additional Comments From [EMAIL PROTECTED] 2005-07-25 09:55 --- Created an attachment (id=15762) -- (http://issues.apache.org/bugzilla/attachment.cgi?id=15762action=view) Enhaced DispatchAction Includes Michael McGrady's dispatch code using .dispatch suffix. Works for buttons, links and image buttons. -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 30292] - Replacement of LookupDispatchAction
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=30292. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=30292 --- Additional Comments From [EMAIL PROTECTED] 2005-07-25 19:59 --- (In reply to comment #12) Created an attachment (id=15762) -- (http://issues.apache.org/bugzilla/attachment.cgi?id=15762action=view) [edit] Enhaced DispatchAction Includes Michael McGrady's dispatch code using .dispatch suffix. Works for buttons, links and image buttons. Michael J: Given the recent discussions on the struts-dev list, I am uncomfortable with your assertion that your patch includes Michael McGrady's dispatch code. Without his clear assignment of license, we would be ill-advised to commit that code to Struts. Unless you can make clear that you have the right to include his code in a patch and grant rights to that code to Apache, that attachment should be removed. -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 30292] - Replacement of LookupDispatchAction
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=30292. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=30292 --- Additional Comments From [EMAIL PROTECTED] 2005-07-25 20:10 --- (In reply to comment #13) (In reply to comment #12) Created an attachment (id=15762) -- (http://issues.apache.org/bugzilla/attachment.cgi?id=15762action=view) [edit] [edit] Enhaced DispatchAction Includes Michael McGrady's dispatch code using .dispatch suffix. Works for buttons, links and image buttons. Michael J: Given the recent discussions on the struts-dev list, I am uncomfortable with your assertion that your patch includes Michael McGrady's dispatch code. Without his clear assignment of license, we would be ill-advised to commit that code to Struts. Unless you can make clear that you have the right to include his code in a patch and grant rights to that code to Apache, that attachment should be removed. I agree, the last entry http://issues.apache.org/bugzilla/attachment.cgi?id=15762 should be removed. I don't know how to remove it or do not have enough permissions. Concerning previous entries, I stand that I did not copy any of McGrady's code despite his accusations. I borrowed the idea of stripping out .x suffixes, but turned out it was suggested by Ted Husted long before, in 2002. -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 30292] - Replacement of LookupDispatchAction
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=30292. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=30292 [EMAIL PROTECTED] changed: What|Removed |Added Attachment #15739|0 |1 is obsolete|| --- Additional Comments From [EMAIL PROTECTED] 2005-07-23 22:31 --- Created an attachment (id=15754) -- (http://issues.apache.org/bugzilla/attachment.cgi?id=15754action=view) SelectAction: uniformly works with pushbuttons, image buttons and links. Fixed a bug: replaced keyName with reqName. Should use one codebase... This is not a patchfile, since this file is not in Struts core. -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 30292] - Replacement of LookupDispatchAction
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=30292. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=30292 [EMAIL PROTECTED] changed: What|Removed |Added Attachment #14923|0 |1 is obsolete|| --- Additional Comments From [EMAIL PROTECTED] 2005-07-21 20:59 --- Created an attachment (id=15735) -- (http://issues.apache.org/bugzilla/attachment.cgi?id=15735action=view) SelectAction: uniformly works with pushbuttons, image buttons and links. Updated version of SelectAction (event key, javadocs, support for image buttons) -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 30292] - Replacement of LookupDispatchAction
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=30292. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=30292 [EMAIL PROTECTED] changed: What|Removed |Added Attachment #15735|0 |1 is obsolete|| --- Additional Comments From [EMAIL PROTECTED] 2005-07-21 21:03 --- Created an attachment (id=15736) -- (http://issues.apache.org/bugzilla/attachment.cgi?id=15736action=view) SelectAction: uniformly works with pushbuttons, image buttons and links. Corrected name in the licence. -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 30292] - Replacement of LookupDispatchAction
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=30292. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=30292 [EMAIL PROTECTED] changed: What|Removed |Added Attachment #15736|0 |1 is obsolete|| --- Additional Comments From [EMAIL PROTECTED] 2005-07-21 21:43 --- Created an attachment (id=15738) -- (http://issues.apache.org/bugzilla/attachment.cgi?id=15738action=view) SelectAction: uniformly works with pushbuttons, image buttons and links. What's up with me, wrong file. Now this one should be the proper. -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 30292] - Replacement of LookupDispatchAction
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=30292. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=30292 [EMAIL PROTECTED] changed: What|Removed |Added Attachment #15738|0 |1 is obsolete|| --- Additional Comments From [EMAIL PROTECTED] 2005-07-21 21:50 --- Created an attachment (id=15739) -- (http://issues.apache.org/bugzilla/attachment.cgi?id=15739action=view) SelectAction: uniformly works with pushbuttons, image buttons and links. Better late than never. Actually removed parameter usage. -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 30292] - Replacement of LookupDispatchAction
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=30292. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=30292 [EMAIL PROTECTED] changed: What|Removed |Added OtherBugsDependingO||34750 nThis|| -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 30292] - Replacement of LookupDispatchAction
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=30292. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=30292 --- Additional Comments From [EMAIL PROTECTED] 2005-05-04 01:59 --- Created an attachment (id=14923) -- (http://issues.apache.org/bugzilla/attachment.cgi?id=14923action=view) Different implementation of the same idea Attached is dispatch action, which uses 'name' attribute like ParameterDispatchAction submitted by Jean-Baptiste, but uses mapping like LookupDispatchAction, which provides level of indirection. The patch is not a diff, but a new class, extending DispatchAction. -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 30292] - Replacement of LookupDispatchAction
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=30292. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=30292 --- Additional Comments From [EMAIL PROTECTED] 2005-05-04 02:12 --- Created an attachment (id=14924) -- (http://issues.apache.org/bugzilla/attachment.cgi?id=14924action=view) LocalStrings.properties patchfile -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 30292] - Replacement of LookupDispatchAction
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=30292. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=30292 --- Additional Comments From [EMAIL PROTECTED] 2005-05-04 02:27 --- This enhancement is important, because it uses submit button name instead of value, allowing for arbitrary button caption. Niall, hoping for users to vote is imho not constructive. They don't vote, they whine that something (or everything) sucks. I don't think that majority of MS users browse MSDN every day and vote for enhancements. They just use ASP.NET because it provides easy-to-use environment and components. -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 30292] - Replacement of LookupDispatchAction
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=30292. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=30292 Replacement of LookupDispatchAction --- Additional Comments From [EMAIL PROTECTED] 2004-07-23 11:43 --- Created an attachment (id=12201) ParameterDispatchAction - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 30292] - Replacement of LookupDispatchAction
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=30292. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=30292 Replacement of LookupDispatchAction --- Additional Comments From [EMAIL PROTECTED] 2004-07-23 22:29 --- Niall. My code was inspired by the code of DispatchAction from the Struts 1.1 release. The execute method I overrode was basically cut'n pasted from this version of DispatchAction, and nothing in this version is related to cancel behavior. The method getMethodName() that you suggest to override doesn't exist in the 1.1 version of the DispatchAction either. Feel free to adapt my code to the newest version of DispatchAction, of course. Sorry also for the use of getParameterMap(). I looked for a @since entry in the javadoc of this method, and there is none so I assumed it was there from the beginning. The other obvious (but less performant) way to proceed is to loop through the enumeration of request parameters. Now for the question Is it really needed?. I think this technique is more powerful, easier to use, more flexible than the LookupDispatchAction, for all the reasons I've mentioned in the submitted javadoc. Is it really *needed*? No, because I could just use my own version of this class. But I think it provides a real enhancement over LookupDispatchAction. BTW, LookupDispatchAction just seems wrong to me: trying to get back a key from a value in internationalized properties files and asking the developer to provide a mapping from button text keys to method names just to select a method doesn't look right to me. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
