Re: About PR #363 and SYNCOPE-1665
On 07/09/22 18:03, Andrea Patricelli wrote: Hi, I've resumed the work on the issue. Hope to finish by friday or monday. Glad to hear this, Andrea! I think we can start planning for 3.0.0-M1 right afterwards. Regards. On 05/09/22 09:14, Andrea Patricelli wrote: Hi Francesco, no ATM I had no chance to work on it. The plan is to resume and finish the job this week. I'll update you on Wednesday in order to have an idea about the status of the work. Best regards, Andrea On 05/09/22 08:44, Francesco Chicchiriccò wrote: Hi Andrea, any update in the last two weeks, since your e-mail below? It would be nice to have such an improvement onboard for next 3.0.0-M1. Regards. On 23/08/22 09:53, Francesco Chicchiriccò wrote: On 22/08/22 16:34, Andrea Patricelli wrote: Hi, yes you're right. Basically the solution has been provided, but the PR needs some refactoring and to reuse already existing console modules like StatusPanel. This unfortunately is not trivial, because extracting some console classes into common is a waterfall of changes and refactorings that takes some time, and did not have the chance to finish this work, yet. At this point I see three solutions: 1. Keep this "embryonal" work as the actual solution and only make some graphical refinements. 2. Continue the work on using console modules, moving classes to common, etc. Hopefully I can resume and finish the work next week. 3. Move the issue to the next release since this is mainly an improvement and not a critical bugfix or new core feature. Thanks Andrea, no need to rush: I don't expect next release for Syncope 3.0 before a couple of weeks. Regards. On 22/08/22 16:05, Francesco Chicchiriccò wrote: Hi Andrea, I see that your PR #363 was not updated lately. I see also that SYNCOPE-1665 is set for Syncope 3.0.0 so I was wondering if you could provide an update about such work, thanks. Regards. [1] https://github.com/apache/syncope/pull/363 -- Francesco Chicchiriccò Tirasa - Open Source Excellence http://www.tirasa.net/ Member at The Apache Software Foundation Syncope, Cocoon, Olingo, CXF, OpenJPA, PonyMail http://home.apache.org/~ilgrosso/
[GitHub] [syncope] ilgrosso merged pull request #374: Task: one table per class + Preferring JSON arrays to @ElementCollection
ilgrosso merged PR #374: URL: https://github.com/apache/syncope/pull/374 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@syncope.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: About PR #363 and SYNCOPE-1665
Hi, I've resumed the work on the issue. Hope to finish by friday or monday. Best regards, Andrea On 05/09/22 09:14, Andrea Patricelli wrote: Hi Francesco, no ATM I had no chance to work on it. The plan is to resume and finish the job this week. I'll update you on Wednesday in order to have an idea about the status of the work. Best regards, Andrea On 05/09/22 08:44, Francesco Chicchiriccò wrote: Hi Andrea, any update in the last two weeks, since your e-mail below? It would be nice to have such an improvement onboard for next 3.0.0-M1. Regards. On 23/08/22 09:53, Francesco Chicchiriccò wrote: On 22/08/22 16:34, Andrea Patricelli wrote: Hi, yes you're right. Basically the solution has been provided, but the PR needs some refactoring and to reuse already existing console modules like StatusPanel. This unfortunately is not trivial, because extracting some console classes into common is a waterfall of changes and refactorings that takes some time, and did not have the chance to finish this work, yet. At this point I see three solutions: 1. Keep this "embryonal" work as the actual solution and only make some graphical refinements. 2. Continue the work on using console modules, moving classes to common, etc. Hopefully I can resume and finish the work next week. 3. Move the issue to the next release since this is mainly an improvement and not a critical bugfix or new core feature. Thanks Andrea, no need to rush: I don't expect next release for Syncope 3.0 before a couple of weeks. Regards. On 22/08/22 16:05, Francesco Chicchiriccò wrote: Hi Andrea, I see that your PR #363 was not updated lately. I see also that SYNCOPE-1665 is set for Syncope 3.0.0 so I was wondering if you could provide an update about such work, thanks. Regards. [1] https://github.com/apache/syncope/pull/363 -- Andrea Patricelli Tirasa - Open Source Excellence http://www.tirasa.net/ Member at The Apache Software Foundation Syncope
[GitHub] [syncope] github-code-scanning[bot] commented on a diff in pull request #374: Task: one table per class + Preferring JSON arrays to @ElementCollection
github-code-scanning[bot] commented on code in PR #374:
URL: https://github.com/apache/syncope/pull/374#discussion_r964871164
##
core/persistence-jpa/src/main/java/org/apache/syncope/core/persistence/jpa/validation/entity/ProvisioningTaskValidator.java:
##
@@ -22,19 +22,13 @@
import org.apache.syncope.common.lib.types.EntityViolationType;
import org.apache.syncope.core.persistence.api.entity.task.ProvisioningTask;
-public class ProvisioningTaskValidator extends
AbstractValidator {
+public class ProvisioningTaskValidator extends
AbstractValidator> {
-private final SchedTaskValidator schedV;
-
-public ProvisioningTaskValidator() {
-super();
-
-schedV = new SchedTaskValidator();
-}
+private final SchedTaskValidator schedTaskValidator = new
SchedTaskValidator();
@Override
-public boolean isValid(final ProvisioningTask task, final
ConstraintValidatorContext context) {
-boolean isValid = schedV.isValid(task, context);
+public boolean isValid(final ProvisioningTask task, final
ConstraintValidatorContext context) {
Review Comment:
## Log Injection
This user-provided value flows to a [log entry](1).
[Show more
details](https://github.com/apache/syncope/security/code-scanning/1156)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@syncope.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
