Re: Audit view improvements
On 12/09/22 16:06, Francesco Chicchiriccò wrote: On 12/09/22 16:01, Andrea Patricelli wrote: On 12/09/22 15:51, Francesco Chicchiriccò wrote: On 12/09/22 15:43, Andrea Patricelli wrote: Hi all, since audit, in some Syncope installations is (and must be) critically important and very often helps to understand the history of critical user data, I would like to suggest some improvements to the view in console: In the history section the diff should be between before and after, but now is always between before and now. The main goal here is to see who changed what in that specific audit event. This makes sense. Maybe even better if one can choose across which versions the diff shall be computed. Agree! ATM the history shows only a part of the events that can occur on the user, for example events coming from pull aren't shown as well. What do you mean? Events originated by Console / REST are audited under LOGIC, events originated by Pull are audited under PULL: when you enable both, you get audit for both. Yes, both are audited by the configured appenders, but only LOGIC events are visible in console. Some little but necessary changes are needed to the code to PULL events to the view, too. Ah, I see, you mean to adjust the Console code to get both LOGIC and PULL, or even not specifying anything, just the user key - which would require some minor changes on the REST side too. Yes, exactly. I'd suggest to open an issue to improve, at least, user, group and any object audit accessibility in console. WDYT Best regards, Andrea -- Andrea Patricelli Tirasa - Open Source Excellence http://www.tirasa.net/ Member at The Apache Software Foundation Syncope
Re: Audit view improvements
On 12/09/22 16:01, Andrea Patricelli wrote: On 12/09/22 15:51, Francesco Chicchiriccò wrote: On 12/09/22 15:43, Andrea Patricelli wrote: Hi all, since audit, in some Syncope installations is (and must be) critically important and very often helps to understand the history of critical user data, I would like to suggest some improvements to the view in console: In the history section the diff should be between before and after, but now is always between before and now. The main goal here is to see who changed what in that specific audit event. This makes sense. Maybe even better if one can choose across which versions the diff shall be computed. Agree! ATM the history shows only a part of the events that can occur on the user, for example events coming from pull aren't shown as well. What do you mean? Events originated by Console / REST are audited under LOGIC, events originated by Pull are audited under PULL: when you enable both, you get audit for both. Yes, both are audited by the configured appenders, but only LOGIC events are visible in console. Some little but necessary changes are needed to the code to PULL events to the view, too. Ah, I see, you mean to adjust the Console code to get both LOGIC and PULL, or even not specifying anything, just the user key - which would require some minor changes on the REST side too. I'd suggest to open an issue to improve, at least, user, group and any object audit accessibility in console. WDYT Best regards, Andrea -- Francesco Chicchiriccò Tirasa - Open Source Excellence http://www.tirasa.net/ Member at The Apache Software Foundation Syncope, Cocoon, Olingo, CXF, OpenJPA, PonyMail http://home.apache.org/~ilgrosso/
Re: Audit view improvements
On 12/09/22 15:51, Francesco Chicchiriccò wrote: On 12/09/22 15:43, Andrea Patricelli wrote: Hi all, since audit, in some Syncope installations is (and must be) critically important and very often helps to understand the history of critical user data, I would like to suggest some improvements to the view in console: In the history section the diff should be between before and after, but now is always between before and now. The main goal here is to see who changed what in that specific audit event. This makes sense. Maybe even better if one can choose across which versions the diff shall be computed. Agree! ATM the history shows only a part of the events that can occur on the user, for example events coming from pull aren't shown as well. What do you mean? Events originated by Console / REST are audited under LOGIC, events originated by Pull are audited under PULL: when you enable both, you get audit for both. Yes, both are audited by the configured appenders, but only LOGIC events are visible in console. Some little but necessary changes are needed to the code to PULL events to the view, too. I'd suggest to open an issue to improve, at least, user, group and any object audit accessibility in console. WDYT Best regards, Andrea -- Andrea Patricelli Tirasa - Open Source Excellence http://www.tirasa.net/ Member at The Apache Software Foundation Syncope
Re: Audit view improvements
On 12/09/22 15:43, Andrea Patricelli wrote: Hi all, since audit, in some Syncope installations is (and must be) critically important and very often helps to understand the history of critical user data, I would like to suggest some improvements to the view in console: In the history section the diff should be between before and after, but now is always between before and now. The main goal here is to see who changed what in that specific audit event. This makes sense. Maybe even better if one can choose across which versions the diff shall be computed. ATM the history shows only a part of the events that can occur on the user, for example events coming from pull aren't shown as well. What do you mean? Events originated by Console / REST are audited under LOGIC, events originated by Pull are audited under PULL: when you enable both, you get audit for both. I'd suggest to open an issue to improve, at least, user, group and any object audit accessibility in console. WDYT Best regards, Andrea -- Francesco Chicchiriccò Tirasa - Open Source Excellence http://www.tirasa.net/ Member at The Apache Software Foundation Syncope, Cocoon, Olingo, CXF, OpenJPA, PonyMail http://home.apache.org/~ilgrosso/
Audit view improvements
Hi all, since audit, in some Syncope installations is (and must be) critically important and very often helps to understand the history of critical user data, I would like to suggest some improvements to the view in console: In the history section the diff should be between before and after, but now is always between before and now. The main goal here is to see who changed what in that specific audit event. ATM the history shows only a part of the events that can occur on the user, for example events coming from pull aren't shown as well. I'd suggest to open an issue to improve, at least, user, group and any object audit accessibility in console. WDYT Best regards, Andrea -- Andrea Patricelli Tirasa - Open Source Excellence http://www.tirasa.net/ Member at The Apache Software Foundation Syncope
[jira] [Resolved] (SYNCOPE-1665) In enduser manage provisioning result on create/update and set feedback accordingly
[ https://issues.apache.org/jira/browse/SYNCOPE-1665?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrea Patricelli resolved SYNCOPE-1665. Resolution: Fixed > In enduser manage provisioning result on create/update and set feedback > accordingly > --- > > Key: SYNCOPE-1665 > URL: https://issues.apache.org/jira/browse/SYNCOPE-1665 > Project: Syncope > Issue Type: Improvement > Components: enduser >Affects Versions: 3.0.0-M0 >Reporter: Andrea Patricelli >Assignee: Andrea Patricelli >Priority: Major > Fix For: 3.0.0 > > > * Improve error management, giving a feedback based on propagation statuses > * Make some refactoring if possible > * Use notification panels instead redirect where needed -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (SYNCOPE-1665) In enduser manage provisioning result on create/update and set feedback accordingly
[ https://issues.apache.org/jira/browse/SYNCOPE-1665?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17602979#comment-17602979 ] ASF subversion and git services commented on SYNCOPE-1665: -- Commit f6735a83898d6a0d64ff8308e52534cb51d1976c in syncope's branch refs/heads/master from Andrea Patricelli [ https://gitbox.apache.org/repos/asf?p=syncope.git;h=f6735a8389 ] [SYNCOPE-1665] show error on propagation failure, made some refactoring (#363) * [SYNCOPE-1665] show error in enduser on propagation failure if enabled by configuration > In enduser manage provisioning result on create/update and set feedback > accordingly > --- > > Key: SYNCOPE-1665 > URL: https://issues.apache.org/jira/browse/SYNCOPE-1665 > Project: Syncope > Issue Type: Improvement > Components: enduser >Affects Versions: 3.0.0-M0 >Reporter: Andrea Patricelli >Assignee: Andrea Patricelli >Priority: Major > Fix For: 3.0.0 > > > * Improve error management, giving a feedback based on propagation statuses > * Make some refactoring if possible > * Use notification panels instead redirect where needed -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [syncope] andrea-patricelli merged pull request #363: [SYNCOPE-1665] show error on propagation failure, made some refactoring
andrea-patricelli merged PR #363: URL: https://github.com/apache/syncope/pull/363 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@syncope.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
