Re: [VOTE] Apache Syncope 3.0.0-M2
+1. Best regards, Andrea On 27/10/22 15:40, Francesco Chicchiriccò wrote: I've created a 3.0-0-M2 release, with the following artifacts up for a vote: GIT source tag (690dbfcaab): https://gitbox.apache.org/repos/asf?p=syncope.git;a=tag;h=690dbfcaab List of changes: https://gitbox.apache.org/repos/asf?p=syncope.git;a=blob_plain;f=CHANGES;hb=690dbfcaab Staging artifacts: https://dist.apache.org/repos/dist/dev/syncope/3.0.0-M2/ Maven staging repo: https://repository.apache.org/content/repositories/orgapachesyncope-1073/ Staging site: https://syncope.apache.org/3.0.0-M2/index.html PGP release keys (signed using 273DF287): http://www.apache.org/dist/syncope/KEYS Vote will be open for 72 hours. [ ] +1 approve [ ] +0 no opinion [ ] -1 disapprove (and reason why) Here's my +1 Regards. -- Andrea Patricelli Tirasa - Open Source Excellence http://www.tirasa.net/ Member at The Apache Software Foundation Syncope
Re: [VOTE] Apache Syncope 3.0.0-M2
+1 Regards On Thu, Oct 27, 2022 at 3:41 PM Francesco Chicchiriccò wrote: > > I've created a 3.0-0-M2 release, with the following artifacts up for a vote: > > GIT source tag (690dbfcaab): > https://gitbox.apache.org/repos/asf?p=syncope.git;a=tag;h=690dbfcaab > > List of changes: > https://gitbox.apache.org/repos/asf?p=syncope.git;a=blob_plain;f=CHANGES;hb=690dbfcaab > > Staging artifacts: > https://dist.apache.org/repos/dist/dev/syncope/3.0.0-M2/ > > Maven staging repo: > https://repository.apache.org/content/repositories/orgapachesyncope-1073/ > > Staging site: > https://syncope.apache.org/3.0.0-M2/index.html > > PGP release keys (signed using 273DF287): > http://www.apache.org/dist/syncope/KEYS > > Vote will be open for 72 hours. > > [ ] +1 approve > [ ] +0 no opinion > [ ] -1 disapprove (and reason why) > > Here's my +1 > Regards. > > -- > Francesco Chicchiriccò > > Tirasa - Open Source Excellence > http://www.tirasa.net/ > > Member at The Apache Software Foundation > Syncope, Cocoon, Olingo, CXF, OpenJPA, PonyMail > http://home.apache.org/~ilgrosso/ >
Re: [VOTE] Apache Syncope 3.0.0-M2
Hello everyone, Here's my +1. Best regards, Samuel Il 27/10/22 15:40, Francesco Chicchiriccò ha scritto: I've created a 3.0-0-M2 release, with the following artifacts up for a vote: GIT source tag (690dbfcaab): https://gitbox.apache.org/repos/asf?p=syncope.git;a=tag;h=690dbfcaab List of changes: https://gitbox.apache.org/repos/asf?p=syncope.git;a=blob_plain;f=CHANGES;hb=690dbfcaab Staging artifacts: https://dist.apache.org/repos/dist/dev/syncope/3.0.0-M2/ Maven staging repo: https://repository.apache.org/content/repositories/orgapachesyncope-1073/ Staging site: https://syncope.apache.org/3.0.0-M2/index.html PGP release keys (signed using 273DF287): http://www.apache.org/dist/syncope/KEYS Vote will be open for 72 hours. [ ] +1 approve [ ] +0 no opinion [ ] -1 disapprove (and reason why) Here's my +1 Regards.
[VOTE] Apache Syncope 3.0.0-M2
I've created a 3.0-0-M2 release, with the following artifacts up for a vote: GIT source tag (690dbfcaab): https://gitbox.apache.org/repos/asf?p=syncope.git;a=tag;h=690dbfcaab List of changes: https://gitbox.apache.org/repos/asf?p=syncope.git;a=blob_plain;f=CHANGES;hb=690dbfcaab Staging artifacts: https://dist.apache.org/repos/dist/dev/syncope/3.0.0-M2/ Maven staging repo: https://repository.apache.org/content/repositories/orgapachesyncope-1073/ Staging site: https://syncope.apache.org/3.0.0-M2/index.html PGP release keys (signed using 273DF287): http://www.apache.org/dist/syncope/KEYS Vote will be open for 72 hours. [ ] +1 approve [ ] +0 no opinion [ ] -1 disapprove (and reason why) Here's my +1 Regards. -- Francesco Chicchiriccò Tirasa - Open Source Excellence http://www.tirasa.net/ Member at The Apache Software Foundation Syncope, Cocoon, Olingo, CXF, OpenJPA, PonyMail http://home.apache.org/~ilgrosso/
[jira] [Resolved] (SYNCOPE-1705) Deprecate SchedulingPullActions
[
https://issues.apache.org/jira/browse/SYNCOPE-1705?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Francesco Chicchiriccò resolved SYNCOPE-1705.
-
Resolution: Fixed
> Deprecate SchedulingPullActions
> ---
>
> Key: SYNCOPE-1705
> URL: https://issues.apache.org/jira/browse/SYNCOPE-1705
> Project: Syncope
> Issue Type: Improvement
> Components: core
>Reporter: Francesco Chicchiriccò
>Assignee: Francesco Chicchiriccò
>Priority: Major
> Fix For: 3.0.0-M2
>
>
> The class {{SchedulingPullActions}} has been used so far when, at the end of
> a Pull Task's execution, some logic needed to be executed, which required the
> entities pulled to be flushed to the internal storage.
> Typical use case is
> [LDAPMembershipPullActions|https://github.com/apache/syncope/blob/syncope-3.0.0-M1/core/provisioning-java/src/main/java/org/apache/syncope/core/provisioning/java/pushpull/LDAPMembershipPullActions.java]
> which, in its {{afterAll()}} method, is scheduling
> [SetUMembershipsJob|https://github.com/apache/syncope/blob/syncope-3.0.0-M1/core/provisioning-java/src/main/java/org/apache/syncope/core/provisioning/java/job/SetUMembershipsJob.java]
> to update the pulled users so that they become members of the pulled groups,
> matching the similar relationships existing in LDAP.
> Such scheduling approach has proven to be problematic, especially because the
> job scheduled at the end of a pull task execution cannot be controlled.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (SYNCOPE-1705) Deprecate SchedulingPullActions
[
https://issues.apache.org/jira/browse/SYNCOPE-1705?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17625025#comment-17625025
]
ASF subversion and git services commented on SYNCOPE-1705:
--
Commit 49e013436f13856093548672105d79e5d6edb9a7 in syncope's branch
refs/heads/master from Francesco Chicchiriccò
[ https://gitbox.apache.org/repos/asf?p=syncope.git;h=49e013436f ]
[SYNCOPE-1705] Encapsulating each object processing into an inner transaction
(#383)
> Deprecate SchedulingPullActions
> ---
>
> Key: SYNCOPE-1705
> URL: https://issues.apache.org/jira/browse/SYNCOPE-1705
> Project: Syncope
> Issue Type: Improvement
> Components: core
>Reporter: Francesco Chicchiriccò
>Assignee: Francesco Chicchiriccò
>Priority: Major
> Fix For: 3.0.0-M2
>
>
> The class {{SchedulingPullActions}} has been used so far when, at the end of
> a Pull Task's execution, some logic needed to be executed, which required the
> entities pulled to be flushed to the internal storage.
> Typical use case is
> [LDAPMembershipPullActions|https://github.com/apache/syncope/blob/syncope-3.0.0-M1/core/provisioning-java/src/main/java/org/apache/syncope/core/provisioning/java/pushpull/LDAPMembershipPullActions.java]
> which, in its {{afterAll()}} method, is scheduling
> [SetUMembershipsJob|https://github.com/apache/syncope/blob/syncope-3.0.0-M1/core/provisioning-java/src/main/java/org/apache/syncope/core/provisioning/java/job/SetUMembershipsJob.java]
> to update the pulled users so that they become members of the pulled groups,
> matching the similar relationships existing in LDAP.
> Such scheduling approach has proven to be problematic, especially because the
> job scheduled at the end of a pull task execution cannot be controlled.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [syncope] ilgrosso merged pull request #383: [SYNCOPE-1705] Encapsulating each object processing into an inner transaction
ilgrosso merged PR #383: URL: https://github.com/apache/syncope/pull/383 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@syncope.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [syncope] github-code-scanning[bot] commented on a diff in pull request #383: [SYNCOPE-1705] Encapsulating each object processing into an inner transaction
github-code-scanning[bot] commented on code in PR #383:
URL: https://github.com/apache/syncope/pull/383#discussion_r1006691739
##
core/provisioning-api/src/main/java/org/apache/syncope/core/provisioning/api/pushpull/ProvisioningActions.java:
##
@@ -28,7 +28,7 @@
* @param profile provisioning profile
* @throws JobExecutionException in case of generic failure
*/
-default void beforeAll(final ProvisioningProfile profile) throws
JobExecutionException {
+default void beforeAll(ProvisioningProfile profile) throws
JobExecutionException {
Review Comment:
## Useless parameter
The parameter 'profile' is never used.
[Show more
details](https://github.com/apache/syncope/security/code-scanning/1189)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@syncope.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [syncope] github-code-scanning[bot] commented on a diff in pull request #383: [SYNCOPE-1705] Encapsulating each object processing into an inner transaction
github-code-scanning[bot] commented on code in PR #383:
URL: https://github.com/apache/syncope/pull/383#discussion_r1006548975
##
core/provisioning-java/src/main/java/org/apache/syncope/core/provisioning/java/pushpull/LDAPMembershipPullActions.java:
##
@@ -190,15 +212,49 @@
});
}
+@Transactional(propagation = Propagation.REQUIRES_NEW)
@Override
public void afterAll(final ProvisioningProfile profile) throws
JobExecutionException {
-Map jobMap = new HashMap<>();
-jobMap.put(SetUMembershipsJob.MEMBERSHIPS_BEFORE_KEY,
membershipsBefore);
-jobMap.put(SetUMembershipsJob.MEMBERSHIPS_AFTER_KEY, membershipsAfter);
-jobMap.put(JobManager.EXECUTOR_KEY, profile.getExecutor());
-jobMap.put(
-SetUMembershipsJob.CONTEXT,
-"PullTask " + profile.getTask().getKey() + " '" +
profile.getTask().getName() + "'");
-schedule(SetUMembershipsJob.class, jobMap);
+List updateReqs = new ArrayList<>();
+
+membershipsAfter.forEach((user, groups) -> {
+UserUR userUR = new UserUR();
+userUR.setKey(user);
+updateReqs.add(userUR);
+
+groups.stream().forEach(group -> {
+Set before = membershipsBefore.get(user);
+if (before == null || !before.contains(group)) {
+userUR.getMemberships().add(new
MembershipUR.Builder(group).
+operation(PatchOperation.ADD_REPLACE).
+build());
+}
+});
+});
+
+membershipsBefore.forEach((user, groups) -> {
+UserUR userUR = updateReqs.stream().
+filter(req -> user.equals(req.getKey())).findFirst().
+orElseGet(() -> {
+UserUR req = new UserUR.Builder(user).build();
+updateReqs.add(req);
+return req;
+});
+
+groups.forEach(group -> {
+Set after = membershipsAfter.get(user);
+if (after == null || !after.contains(group)) {
+userUR.getMemberships().add(new
MembershipUR.Builder(group).
+operation(PatchOperation.DELETE).
+build());
+}
+});
+});
+
+String context = "PullTask " + profile.getTask().getKey() + " '" +
profile.getTask().getName() + "'";
+updateReqs.stream().filter(req -> !req.isEmpty()).forEach(req -> {
+LOG.debug("About to update User {}", req);
Review Comment:
## Use of default toString()
Default toString(): UserUR inherits toString() from Object, and so is not
suitable for printing.
[Show more
details](https://github.com/apache/syncope/security/code-scanning/1188)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@syncope.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [syncope] ilgrosso opened a new pull request, #383: [SYNCOPE-1705] Encapsulating each object processing into an inner transaction
ilgrosso opened a new pull request, #383: URL: https://github.com/apache/syncope/pull/383 …nsaction -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@syncope.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
