Re: [VOTE] Apache Syncope 3.0.0
+1 (binding) Regards JB On Fri, Nov 11, 2022 at 10:22 AM Francesco Chicchiriccò wrote: > > I've created a 3.0-0 release, with the following artifacts up for a vote: > > GIT source tag (5e7d1667df): > https://gitbox.apache.org/repos/asf?p=syncope.git;a=tag;h=5e7d1667df > > List of changes: > https://gitbox.apache.org/repos/asf?p=syncope.git;a=blob_plain;f=CHANGES;hb=5e7d1667df > > Staging artifacts: > https://dist.apache.org/repos/dist/dev/syncope/3.0.0/ > > Maven staging repo: > https://repository.apache.org/content/repositories/orgapachesyncope-1074/ > > Staging site: > https://syncope.apache.org/3.0.0/index.html > > PGP release keys (signed using 273DF287): > http://www.apache.org/dist/syncope/KEYS > > Vote will be open for 72 hours. > > [ ] +1 approve > [ ] +0 no opinion > [ ] -1 disapprove (and reason why) > > Here's my +1 > Regards. > > -- > Francesco Chicchiriccò > > Tirasa - Open Source Excellence > http://www.tirasa.net/ > > Member at The Apache Software Foundation > Syncope, Cocoon, Olingo, CXF, OpenJPA, PonyMail > http://home.apache.org/~ilgrosso/ >
[GitHub] [syncope] ilgrosso commented on pull request #390: SYNCOPE-1709: Persist Jobs' current status in the database to support multi-node deployments
ilgrosso commented on PR #390: URL: https://github.com/apache/syncope/pull/390#issuecomment-1311768516 @mmoayyed one checkstyle issue left: ``` Error: src\test\java\org\apache\syncope\core\provisioning\java\job\JobStatusUpdaterTest.java:[30,1] (imports) ImportOrder: Wrong order for 'org.junit.jupiter.api.Assertions.assertNotNull' import. ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@syncope.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (SYNCOPE-1692) Incremental propagation
[ https://issues.apache.org/jira/browse/SYNCOPE-1692?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17632298#comment-17632298 ] ASF subversion and git services commented on SYNCOPE-1692: -- Commit a1668c2c86550abfd8ddeda3e7bc07dd969c1f8d in syncope's branch refs/heads/master from Francesco Chicchiriccò [ https://gitbox.apache.org/repos/asf?p=syncope.git;h=a1668c2c86 ] [SYNCOPE-1692] Skip attributeDeltas for operational attributes > Incremental propagation > --- > > Key: SYNCOPE-1692 > URL: https://issues.apache.org/jira/browse/SYNCOPE-1692 > Project: Syncope > Issue Type: New Feature > Components: console, core, documentation >Reporter: Francesco Chicchiriccò >Assignee: Francesco Chicchiriccò >Priority: Major > Fix For: 3.0.0-M1 > > > In case of propagation update, Syncope is currently invoking only ConnId's > full [update > operation|https://connid.tirasa.net/apidocs/1.5/org/identityconnectors/framework/api/operations/UpdateApiOp.html#update-org.identityconnectors.framework.common.objects.ObjectClass-org.identityconnectors.framework.common.objects.Uid-java.util.Set-org.identityconnectors.framework.common.objects.OperationOptions-]. > The ConnId framework, however, supports [incremental > updates|https://connid.tirasa.net/apidocs/1.5/org/identityconnectors/framework/api/operations/UpdateDeltaApiOp.html] > since quite some time, so we can take advantage of this if optionally > enabled in a Propagation Policy instance. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [syncope] ilgrosso commented on a diff in pull request #390: SYNCOPE-1709: Persist Jobs' current status in the database to support multi-node deployments
ilgrosso commented on code in PR #390:
URL: https://github.com/apache/syncope/pull/390#discussion_r1020137794
##
core/provisioning-java/src/main/java/org/apache/syncope/core/provisioning/java/job/report/UserReportlet.java:
##
@@ -363,11 +362,20 @@ protected int count() {
AnyTypeKind.USER);
}
+private void sleep() {
Review Comment:
...but also the calls to this method shall be removed altogether ;-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@syncope.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [VOTE] Apache Syncope 3.0.0
Here's my +1. Best regards, Il giorno ven 11 nov 2022 alle ore 10:23 Francesco Chicchiriccò < ilgro...@apache.org> ha scritto: > I've created a 3.0-0 release, with the following artifacts up for a vote: > > GIT source tag (5e7d1667df): > https://gitbox.apache.org/repos/asf?p=syncope.git;a=tag;h=5e7d1667df > > List of changes: > > https://gitbox.apache.org/repos/asf?p=syncope.git;a=blob_plain;f=CHANGES;hb=5e7d1667df > > Staging artifacts: > https://dist.apache.org/repos/dist/dev/syncope/3.0.0/ > > Maven staging repo: > https://repository.apache.org/content/repositories/orgapachesyncope-1074/ > > Staging site: > https://syncope.apache.org/3.0.0/index.html > > PGP release keys (signed using 273DF287): > http://www.apache.org/dist/syncope/KEYS > > Vote will be open for 72 hours. > > [ ] +1 approve > [ ] +0 no opinion > [ ] -1 disapprove (and reason why) > > Here's my +1 > Regards. > > -- > Francesco Chicchiriccò > > Tirasa - Open Source Excellence > http://www.tirasa.net/ > > Member at The Apache Software Foundation > Syncope, Cocoon, Olingo, CXF, OpenJPA, PonyMail > http://home.apache.org/~ilgrosso/ > > -- -- Lorenzo Di Cola Software Engineer @ Tirasa S.r.l. Viale Vittoria Colonna, 97 - 65127 Pescara Tel +39 0859116307 / FAX +39 085973http://www.tirasa.net Apache Syncope Committerhttp://people.apache.org/phonebook.html?uid=loredicola
Re: [VOTE] Apache Syncope 3.0.0
+1 Best regards, Samuel Il 11/11/22 10:22, Francesco Chicchiriccò ha scritto: I've created a 3.0-0 release, with the following artifacts up for a vote: GIT source tag (5e7d1667df): https://gitbox.apache.org/repos/asf?p=syncope.git;a=tag;h=5e7d1667df List of changes: https://gitbox.apache.org/repos/asf?p=syncope.git;a=blob_plain;f=CHANGES;hb=5e7d1667df Staging artifacts: https://dist.apache.org/repos/dist/dev/syncope/3.0.0/ Maven staging repo: https://repository.apache.org/content/repositories/orgapachesyncope-1074/ Staging site: https://syncope.apache.org/3.0.0/index.html PGP release keys (signed using 273DF287): http://www.apache.org/dist/syncope/KEYS Vote will be open for 72 hours. [ ] +1 approve [ ] +0 no opinion [ ] -1 disapprove (and reason why) Here's my +1 Regards.
Re: [VOTE] Apache Syncope 3.0.0
+1. Best regards, Andrea On 11/11/22 10:22, Francesco Chicchiriccò wrote: I've created a 3.0-0 release, with the following artifacts up for a vote: GIT source tag (5e7d1667df): https://gitbox.apache.org/repos/asf?p=syncope.git;a=tag;h=5e7d1667df List of changes: https://gitbox.apache.org/repos/asf?p=syncope.git;a=blob_plain;f=CHANGES;hb=5e7d1667df Staging artifacts: https://dist.apache.org/repos/dist/dev/syncope/3.0.0/ Maven staging repo: https://repository.apache.org/content/repositories/orgapachesyncope-1074/ Staging site: https://syncope.apache.org/3.0.0/index.html PGP release keys (signed using 273DF287): http://www.apache.org/dist/syncope/KEYS Vote will be open for 72 hours. [ ] +1 approve [ ] +0 no opinion [ ] -1 disapprove (and reason why) Here's my +1 Regards. -- Andrea Patricelli Tirasa - Open Source Excellence http://www.tirasa.net/ Member at The Apache Software Foundation Syncope
[GitHub] [syncope] ilgrosso commented on a diff in pull request #390: SYNCOPE-1709: Persist Jobs' current status in the database to support multi-node deployments
ilgrosso commented on code in PR #390:
URL: https://github.com/apache/syncope/pull/390#discussion_r1020090342
##
core/idrepo/logic/src/main/java/org/apache/syncope/core/logic/ReportLogic.java:
##
@@ -272,8 +274,8 @@ public void exportExecutionResult(
final ReportExecExportFormat format) {
// streaming SAX handler from a compressed byte array stream
-try (ByteArrayInputStream bais = new
ByteArrayInputStream(reportExec.getExecResult());
-ZipInputStream zis = new ZipInputStream(bais)) {
+try ( ByteArrayInputStream bais = new
ByteArrayInputStream(reportExec.getExecResult()); ZipInputStream zis =
Review Comment:
Please revert this formatting-only change.
This will also break checkstyle AFAICT.
##
core/provisioning-java/src/main/java/org/apache/syncope/core/provisioning/java/ProvisioningContext.java:
##
@@ -416,7 +434,7 @@ protected Transport connectTransport() throws
MessagingException {
if (provisioningProperties.getSmtp().isDebug()) {
session = mailSender.getSession();
session.setDebug(true);
-try (LogOutputStream los = new LogOutputStream(LOG)) {
+try ( LogOutputStream los = new LogOutputStream(LOG)) {
Review Comment:
Please revert this formatting-only change.
It will also break checkstyle AFAICT.
##
core/provisioning-java/src/main/java/org/apache/syncope/core/provisioning/java/job/report/UserReportlet.java:
##
@@ -363,11 +362,20 @@ protected int count() {
AnyTypeKind.USER);
}
+private void sleep() {
Review Comment:
This method must be removed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@syncope.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [syncope] mmoayyed opened a new pull request, #390: SYNCOPE-1709: Persist Jobs' current status in the database to support multi-node deployments
mmoayyed opened a new pull request, #390: URL: https://github.com/apache/syncope/pull/390 ## JIRA https://issues.apache.org/jira/browse/SYNCOPE-1709 I have tested this quite a lot. There are minor issues with the UI but I think most of what I found was the result of me introducing delays into the job execution. I have also included an extra unit test to ensure job status can be stored, found, and removed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@syncope.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[VOTE] Apache Syncope 3.0.0
I've created a 3.0-0 release, with the following artifacts up for a vote: GIT source tag (5e7d1667df): https://gitbox.apache.org/repos/asf?p=syncope.git;a=tag;h=5e7d1667df List of changes: https://gitbox.apache.org/repos/asf?p=syncope.git;a=blob_plain;f=CHANGES;hb=5e7d1667df Staging artifacts: https://dist.apache.org/repos/dist/dev/syncope/3.0.0/ Maven staging repo: https://repository.apache.org/content/repositories/orgapachesyncope-1074/ Staging site: https://syncope.apache.org/3.0.0/index.html PGP release keys (signed using 273DF287): http://www.apache.org/dist/syncope/KEYS Vote will be open for 72 hours. [ ] +1 approve [ ] +0 no opinion [ ] -1 disapprove (and reason why) Here's my +1 Regards. -- Francesco Chicchiriccò Tirasa - Open Source Excellence http://www.tirasa.net/ Member at The Apache Software Foundation Syncope, Cocoon, Olingo, CXF, OpenJPA, PonyMail http://home.apache.org/~ilgrosso/
