[jira] [Commented] (SYNCOPE-242) Resolve dependency cycles between persistence and the rest of syncope core
[ https://issues.apache.org/jira/browse/SYNCOPE-242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13536063#comment-13536063 ] Jean-Baptiste Onofré commented on SYNCOPE-242: -- Fixed on trunk: http://svn.apache.org/viewvc?view=revisionrevision=1423908 Resolve dependency cycles between persistence and the rest of syncope core -- Key: SYNCOPE-242 URL: https://issues.apache.org/jira/browse/SYNCOPE-242 Project: Syncope Issue Type: Improvement Affects Versions: 1.0.3-incubating Reporter: Christian Schneider Assignee: Jean-Baptiste Onofré Fix For: 1.1.0 Attachments: SYNCOPE-242-1.patch, SYNCOPE-242-2.patch, SYNCOPE-242-3.patch, SYNCOPE-242-fromtgz.patch, syncope_core_after.png, syncope_core_before.png, syncope.tgz When analysing if we could move the persistence and persistence impl into separate modules I found that there are a lot of dependency cycles in the syncope core module. I have added a structure 101 diagram of the cycles to the issue so you can take a look. Especially the cycles between persistence and the rest of core are important as they prevent us from moving these packages out of core. I have already done some experimentations how to solve the cycles and am pretty sure I can fix that. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SYNCOPE-242) Resolve dependency cycles between persistence and the rest of syncope core
[ https://issues.apache.org/jira/browse/SYNCOPE-242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13536076#comment-13536076 ] Christian Schneider commented on SYNCOPE-242: - Many thanks ... looks good Resolve dependency cycles between persistence and the rest of syncope core -- Key: SYNCOPE-242 URL: https://issues.apache.org/jira/browse/SYNCOPE-242 Project: Syncope Issue Type: Improvement Affects Versions: 1.0.3-incubating Reporter: Christian Schneider Assignee: Jean-Baptiste Onofré Fix For: 1.1.0 Attachments: SYNCOPE-242-1.patch, SYNCOPE-242-2.patch, SYNCOPE-242-3.patch, SYNCOPE-242-fromtgz.patch, syncope_core_after.png, syncope_core_before.png, syncope.tgz When analysing if we could move the persistence and persistence impl into separate modules I found that there are a lot of dependency cycles in the syncope core module. I have added a structure 101 diagram of the cycles to the issue so you can take a look. Especially the cycles between persistence and the rest of core are important as they prevent us from moving these packages out of core. I have already done some experimentations how to solve the cycles and am pretty sure I can fix that. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SYNCOPE-242) Resolve dependency cycles between persistence and the rest of syncope core
[ https://issues.apache.org/jira/browse/SYNCOPE-242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13536263#comment-13536263 ] Hudson commented on SYNCOPE-242: Integrated in Syncope-trunk #384 (See [https://builds.apache.org/job/Syncope-trunk/384/]) [SYNCOPE-242] Move SyncopeUserValidator back into validation.entity as it is referenced from the @SyncopeUserCheck annotation (Revision 1423908) Result = SUCCESS jbonofre : Files : * /syncope/trunk/core/src/main/java/org/apache/syncope/core/persistence/validation/entity/SyncopeUserCheck.java * /syncope/trunk/core/src/main/java/org/apache/syncope/core/persistence/validation/entity/SyncopeUserValidator.java * /syncope/trunk/core/src/main/java/org/apache/syncope/core/policy/AccountPolicyEnforcer.java * /syncope/trunk/core/src/main/java/org/apache/syncope/core/policy/PasswordPolicyEnforcer.java * /syncope/trunk/core/src/main/java/org/apache/syncope/core/policy/PolicyEnforceException.java * /syncope/trunk/core/src/main/java/org/apache/syncope/core/policy/impl * /syncope/trunk/core/src/main/java/org/apache/syncope/core/policy/impl/AccountPolicyEnforcerImpl.java * /syncope/trunk/core/src/main/java/org/apache/syncope/core/policy/impl/PasswordPolicyEnforcerImpl.java * /syncope/trunk/core/src/main/java/org/apache/syncope/core/validation/user/SyncopeUserValidator.java * /syncope/trunk/core/src/main/resources/persistenceContext.xml Resolve dependency cycles between persistence and the rest of syncope core -- Key: SYNCOPE-242 URL: https://issues.apache.org/jira/browse/SYNCOPE-242 Project: Syncope Issue Type: Improvement Affects Versions: 1.0.3-incubating Reporter: Christian Schneider Assignee: Jean-Baptiste Onofré Fix For: 1.1.0 Attachments: SYNCOPE-242-1.patch, SYNCOPE-242-2.patch, SYNCOPE-242-3.patch, SYNCOPE-242-fromtgz.patch, syncope_core_after.png, syncope_core_before.png, syncope.tgz When analysing if we could move the persistence and persistence impl into separate modules I found that there are a lot of dependency cycles in the syncope core module. I have added a structure 101 diagram of the cycles to the issue so you can take a look. Especially the cycles between persistence and the rest of core are important as they prevent us from moving these packages out of core. I have already done some experimentations how to solve the cycles and am pretty sure I can fix that. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SYNCOPE-242) Resolve dependency cycles between persistence and the rest of syncope core
[ https://issues.apache.org/jira/browse/SYNCOPE-242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13532345#comment-13532345 ] Jean-Baptiste Onofré commented on SYNCOPE-242: -- I reviewed the patch: - syntax looks good - design looks good as well It sounds fine for me. @Francesco, let me know if you want that I apply the patch. Resolve dependency cycles between persistence and the rest of syncope core -- Key: SYNCOPE-242 URL: https://issues.apache.org/jira/browse/SYNCOPE-242 Project: Syncope Issue Type: Improvement Affects Versions: 1.0.3-incubating Reporter: Christian Schneider Fix For: 1.1.0 Attachments: SYNCOPE-242-1.patch, SYNCOPE-242-2.patch, SYNCOPE-242-fromtgz.patch, syncope_core_after.png, syncope_core_before.png, syncope.tgz When analysing if we could move the persistence and persistence impl into separate modules I found that there are a lot of dependency cycles in the syncope core module. I have added a structure 101 diagram of the cycles to the issue so you can take a look. Especially the cycles between persistence and the rest of core are important as they prevent us from moving these packages out of core. I have already done some experimentations how to solve the cycles and am pretty sure I can fix that. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SYNCOPE-242) Resolve dependency cycles between persistence and the rest of syncope core
[ https://issues.apache.org/jira/browse/SYNCOPE-242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13532348#comment-13532348 ] Jean-Baptiste Onofré commented on SYNCOPE-242: -- OK, fine, I will. Thanks. Resolve dependency cycles between persistence and the rest of syncope core -- Key: SYNCOPE-242 URL: https://issues.apache.org/jira/browse/SYNCOPE-242 Project: Syncope Issue Type: Improvement Affects Versions: 1.0.3-incubating Reporter: Christian Schneider Assignee: Jean-Baptiste Onofré Fix For: 1.1.0 Attachments: SYNCOPE-242-1.patch, SYNCOPE-242-2.patch, SYNCOPE-242-fromtgz.patch, syncope_core_after.png, syncope_core_before.png, syncope.tgz When analysing if we could move the persistence and persistence impl into separate modules I found that there are a lot of dependency cycles in the syncope core module. I have added a structure 101 diagram of the cycles to the issue so you can take a look. Especially the cycles between persistence and the rest of core are important as they prevent us from moving these packages out of core. I have already done some experimentations how to solve the cycles and am pretty sure I can fix that. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SYNCOPE-242) Resolve dependency cycles between persistence and the rest of syncope core
[ https://issues.apache.org/jira/browse/SYNCOPE-242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13529839#comment-13529839 ] Christian Schneider commented on SYNCOPE-242: - I was not able to reproduce the problem with the enhancer and the Taks class. For mvn clean verify as well as mvn clean install work without any issues. Perhaps your ide was cleaning the classes at the same time as the enhancer was running. I agree with your suggestions about PasswordGenerator and the connutil package and will provide another patch with these changes. Resolve dependency cycles between persistence and the rest of syncope core -- Key: SYNCOPE-242 URL: https://issues.apache.org/jira/browse/SYNCOPE-242 Project: Syncope Issue Type: Improvement Affects Versions: 1.0.3-incubating Reporter: Christian Schneider Fix For: 1.1.0 Attachments: SYNCOPE-242-1.patch, syncope_core_after.png, syncope_core_before.png When analysing if we could move the persistence and persistence impl into separate modules I found that there are a lot of dependency cycles in the syncope core module. I have added a structure 101 diagram of the cycles to the issue so you can take a look. Especially the cycles between persistence and the rest of core are important as they prevent us from moving these packages out of core. I have already done some experimentations how to solve the cycles and am pretty sure I can fix that. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
Re: [jira] [Commented] (SYNCOPE-242) Resolve dependency cycles between persistence and the rest of syncope core
Hi Francesco, how have you been able to apply this patch? I tried to do the same but I ended up with about 10 svn hunks. Are you using a specific tool to apply this patch? Best regards. Jan Am 12.12.2012 11:21, schrieb Francesco Chicchiriccò (JIRA): [ https://issues.apache.org/jira/browse/SYNCOPE-242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13529805#comment-13529805 ] Francesco Chicchiriccò commented on SYNCOPE-242: After applying your patch to fresh trunk, when launching 'mvn clean verify' I get [ERROR] Failed to execute goal org.apache.openjpa:openjpa-maven-plugin:2.2.1:enhance (enhancer) on project syncope-core: Execution enhancer of goal org.apache.openjpa:openjpa-maven-plugin:2.2.1:enhance failed: java.lang.ClassNotFoundException: org.apache.syncope.core.persistence.beans.Task - [Help 1] Any clue? Resolve dependency cycles between persistence and the rest of syncope core -- Key: SYNCOPE-242 URL: https://issues.apache.org/jira/browse/SYNCOPE-242 Project: Syncope Issue Type: Improvement Affects Versions: 1.0.3-incubating Reporter: Christian Schneider Fix For: 1.1.0 Attachments: SYNCOPE-242-1.patch, syncope_core_after.png, syncope_core_before.png When analysing if we could move the persistence and persistence impl into separate modules I found that there are a lot of dependency cycles in the syncope core module. I have added a structure 101 diagram of the cycles to the issue so you can take a look. Especially the cycles between persistence and the rest of core are important as they prevent us from moving these packages out of core. I have already done some experimentations how to solve the cycles and am pretty sure I can fix that. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SYNCOPE-242) Resolve dependency cycles between persistence and the rest of syncope core
[ https://issues.apache.org/jira/browse/SYNCOPE-242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13529977#comment-13529977 ] Jan Bernhardt commented on SYNCOPE-242: --- Hi Christian, after downloading and running your code I get a lot of Injection of autowired dependencies failed exceptions during tests... Regards. Jan Resolve dependency cycles between persistence and the rest of syncope core -- Key: SYNCOPE-242 URL: https://issues.apache.org/jira/browse/SYNCOPE-242 Project: Syncope Issue Type: Improvement Affects Versions: 1.0.3-incubating Reporter: Christian Schneider Fix For: 1.1.0 Attachments: SYNCOPE-242-1.patch, SYNCOPE-242-2.patch, syncope_core_after.png, syncope_core_before.png, syncope.tgz When analysing if we could move the persistence and persistence impl into separate modules I found that there are a lot of dependency cycles in the syncope core module. I have added a structure 101 diagram of the cycles to the issue so you can take a look. Especially the cycles between persistence and the rest of core are important as they prevent us from moving these packages out of core. I have already done some experimentations how to solve the cycles and am pretty sure I can fix that. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
Re: [jira] [Commented] (SYNCOPE-242) Resolve dependency cycles between persistence and the rest of syncope core
Grazie! Now I could run all tests without exceptions. Regards. Jan Am 12.12.2012 15:27, schrieb Francesco Chicchiriccò (JIRA): [ https://issues.apache.org/jira/browse/SYNCOPE-242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13529978#comment-13529978 ] Francesco Chicchiriccò commented on SYNCOPE-242: Jan, same here: you need to change context:component-scan base-package=org.apache.syncope.core.conutil/ to context:component-scan base-package=org.apache.syncope.core.connid/ in core/src/main/resources/syncopeContext.xml Resolve dependency cycles between persistence and the rest of syncope core -- Key: SYNCOPE-242 URL: https://issues.apache.org/jira/browse/SYNCOPE-242 Project: Syncope Issue Type: Improvement Affects Versions: 1.0.3-incubating Reporter: Christian Schneider Fix For: 1.1.0 Attachments: SYNCOPE-242-1.patch, SYNCOPE-242-2.patch, syncope_core_after.png, syncope_core_before.png, syncope.tgz When analysing if we could move the persistence and persistence impl into separate modules I found that there are a lot of dependency cycles in the syncope core module. I have added a structure 101 diagram of the cycles to the issue so you can take a look. Especially the cycles between persistence and the rest of core are important as they prevent us from moving these packages out of core. I have already done some experimentations how to solve the cycles and am pretty sure I can fix that. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SYNCOPE-242) Resolve dependency cycles between persistence and the rest of syncope core
[ https://issues.apache.org/jira/browse/SYNCOPE-242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13529993#comment-13529993 ] Jan Bernhardt commented on SYNCOPE-242: --- Grazie! Now I could run all tests without exceptions. Regards. Jan Resolve dependency cycles between persistence and the rest of syncope core -- Key: SYNCOPE-242 URL: https://issues.apache.org/jira/browse/SYNCOPE-242 Project: Syncope Issue Type: Improvement Affects Versions: 1.0.3-incubating Reporter: Christian Schneider Fix For: 1.1.0 Attachments: SYNCOPE-242-1.patch, SYNCOPE-242-2.patch, syncope_core_after.png, syncope_core_before.png, syncope.tgz When analysing if we could move the persistence and persistence impl into separate modules I found that there are a lot of dependency cycles in the syncope core module. I have added a structure 101 diagram of the cycles to the issue so you can take a look. Especially the cycles between persistence and the rest of core are important as they prevent us from moving these packages out of core. I have already done some experimentations how to solve the cycles and am pretty sure I can fix that. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SYNCOPE-242) Resolve dependency cycles between persistence and the rest of syncope core
[ https://issues.apache.org/jira/browse/SYNCOPE-242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13530012#comment-13530012 ] Francesco Chicchiriccò commented on SYNCOPE-242: Ok, solved the problem of empty files after applying the patch. To summarize: Create patch with (Subversion 1.7+): svn diff --show-copies-as-adds ~/Downloads/SYNCOPE-242-fromtgz.patch Apply patch with: patch -E -p0 ~/Downloads/SYNCOPE-242-fromtgz.patch Resolve dependency cycles between persistence and the rest of syncope core -- Key: SYNCOPE-242 URL: https://issues.apache.org/jira/browse/SYNCOPE-242 Project: Syncope Issue Type: Improvement Affects Versions: 1.0.3-incubating Reporter: Christian Schneider Fix For: 1.1.0 Attachments: SYNCOPE-242-1.patch, SYNCOPE-242-2.patch, SYNCOPE-242-fromtgz.patch, syncope_core_after.png, syncope_core_before.png, syncope.tgz When analysing if we could move the persistence and persistence impl into separate modules I found that there are a lot of dependency cycles in the syncope core module. I have added a structure 101 diagram of the cycles to the issue so you can take a look. Especially the cycles between persistence and the rest of core are important as they prevent us from moving these packages out of core. I have already done some experimentations how to solve the cycles and am pretty sure I can fix that. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SYNCOPE-242) Resolve dependency cycles between persistence and the rest of syncope core
[ https://issues.apache.org/jira/browse/SYNCOPE-242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13530019#comment-13530019 ] Francesco Chicchiriccò commented on SYNCOPE-242: 'svn diff' ignores anything not managed by subversion, that's default behavior. Resolve dependency cycles between persistence and the rest of syncope core -- Key: SYNCOPE-242 URL: https://issues.apache.org/jira/browse/SYNCOPE-242 Project: Syncope Issue Type: Improvement Affects Versions: 1.0.3-incubating Reporter: Christian Schneider Fix For: 1.1.0 Attachments: SYNCOPE-242-1.patch, SYNCOPE-242-2.patch, SYNCOPE-242-fromtgz.patch, syncope_core_after.png, syncope_core_before.png, syncope.tgz When analysing if we could move the persistence and persistence impl into separate modules I found that there are a lot of dependency cycles in the syncope core module. I have added a structure 101 diagram of the cycles to the issue so you can take a look. Especially the cycles between persistence and the rest of core are important as they prevent us from moving these packages out of core. I have already done some experimentations how to solve the cycles and am pretty sure I can fix that. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
