[Bug 60208] New: Regression: Cookies whose names match the web application context are now missing from request.getCookies() result

2016-10-05 Thread bugzilla 
https://bz.apache.org/bugzilla/show_bug.cgi?id=60208

Bug ID: 60208
   Summary: Regression: Cookies whose names match the web
application context are now missing from
request.getCookies() result
   Product: Tomcat 8
   Version: 8.5.5
  Hardware: PC
OS: Linux
Status: NEW
  Severity: blocker
  Priority: P2
 Component: Catalina
  Assignee: dev@tomcat.apache.org
  Reporter: reda.housniala...@gmail.com

Suppose I have an application running at context path '/my-webapp'.
Then I create a basic cookie with name '/my-webapp'.

With Tomcat 8.0.33:
When I try to retrieve it from the application with request.getCookies(), the
cookie is present.

With Tomcat 8.5.5:
When I try to retrieve it from the application with request.getCookies(), the
cookie is missing.

All tests were run on Chrome and Firefox. Both browsers always send the wanted
cookie according to their developer panels.

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r1763479 - /tomcat/trunk/java/org/apache/catalina/storeconfig/StoreAppender.java

2016-10-05 Thread markt 
Author: markt
Date: Wed Oct  5 19:23:55 2016
New Revision: 1763479

URL: http://svn.apache.org/viewvc?rev=1763479=rev
Log:
FindBugs
pos doesn't need to be static.
It gets reset from indent at the beginning of every line and a StoreAppender 
instance is always responsible for an entire line so there is no need to share 
this between appender instances.

Modified:
tomcat/trunk/java/org/apache/catalina/storeconfig/StoreAppender.java

Modified: tomcat/trunk/java/org/apache/catalina/storeconfig/StoreAppender.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/storeconfig/StoreAppender.java?rev=1763479=1763478=1763479=diff
==
--- tomcat/trunk/java/org/apache/catalina/storeconfig/StoreAppender.java 
(original)
+++ tomcat/trunk/java/org/apache/catalina/storeconfig/StoreAppender.java Wed 
Oct  5 19:23:55 2016
@@ -41,7 +41,7 @@ public class StoreAppender {
 Float.class, Float.TYPE, Long.class, Long.TYPE, Short.class,
 Short.TYPE, InetAddress.class };
 
-private static int pos = 0;
+private int pos = 0;
 
 /**
  * Print the closing tag.



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r1763478 - /tomcat/trunk/res/findbugs/filter-false-positives.xml

2016-10-05 Thread markt 
Author: markt
Date: Wed Oct  5 18:54:11 2016
New Revision: 1763478

URL: http://svn.apache.org/viewvc?rev=1763478=rev
Log:
Fix FindBugs false positive

Modified:
tomcat/trunk/res/findbugs/filter-false-positives.xml

Modified: tomcat/trunk/res/findbugs/filter-false-positives.xml
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/res/findbugs/filter-false-positives.xml?rev=1763478=1763477=1763478=diff
==
--- tomcat/trunk/res/findbugs/filter-false-positives.xml (original)
+++ tomcat/trunk/res/findbugs/filter-false-positives.xml Wed Oct  5 18:54:11 
2016
@@ -172,6 +172,12 @@
 
   
   
+
+
+
+
+  
+  
 
 



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r1763477 - /tomcat/trunk/java/org/apache/catalina/tribes/tipis/AbstractReplicatedMap.java

2016-10-05 Thread markt 
Author: markt
Date: Wed Oct  5 18:53:48 2016
New Revision: 1763477

URL: http://svn.apache.org/viewvc?rev=1763477=rev
Log:
Fix NPE reported by FindBugs

Modified:

tomcat/trunk/java/org/apache/catalina/tribes/tipis/AbstractReplicatedMap.java

Modified: 
tomcat/trunk/java/org/apache/catalina/tribes/tipis/AbstractReplicatedMap.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/tribes/tipis/AbstractReplicatedMap.java?rev=1763477=1763476=1763477=diff
==
--- 
tomcat/trunk/java/org/apache/catalina/tribes/tipis/AbstractReplicatedMap.java 
(original)
+++ 
tomcat/trunk/java/org/apache/catalina/tribes/tipis/AbstractReplicatedMap.java 
Wed Oct  5 18:53:48 2016
@@ -412,6 +412,9 @@ public abstract class AbstractReplicated
 }
 
 public Member[] getMapMembersExcl(Member[] exclude) {
+if (exclude == null) {
+return null;
+}
 synchronized (mapMembers) {
 @SuppressWarnings("unchecked") // mapMembers has the correct type
 HashMap list = (HashMap)mapMembers.clone();



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r1763462 - /tomcat/trunk/java/org/apache/coyote/http11/Http11InputBuffer.java

2016-10-05 Thread violetagg 
Author: violetagg
Date: Wed Oct  5 15:57:05 2016
New Revision: 1763462

URL: http://svn.apache.org/viewvc?rev=1763462=rev
Log:
Use ByteBuffer.mark() to mark the position.

Modified:
tomcat/trunk/java/org/apache/coyote/http11/Http11InputBuffer.java

Modified: tomcat/trunk/java/org/apache/coyote/http11/Http11InputBuffer.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/coyote/http11/Http11InputBuffer.java?rev=1763462=1763461=1763462=diff
==
--- tomcat/trunk/java/org/apache/coyote/http11/Http11InputBuffer.java (original)
+++ tomcat/trunk/java/org/apache/coyote/http11/Http11InputBuffer.java Wed Oct  
5 15:57:05 2016
@@ -731,13 +731,13 @@ public class Http11InputBuffer implement
 byteBuffer.limit(end).position(end);
 }
 
-int oldPosition = byteBuffer.position();
+byteBuffer.mark();
 if (byteBuffer.position() < byteBuffer.limit()) {
 byteBuffer.position(byteBuffer.limit());
 }
 byteBuffer.limit(byteBuffer.capacity());
 int nRead = wrapper.read(block, byteBuffer);
-byteBuffer.limit(byteBuffer.position()).position(oldPosition);
+byteBuffer.limit(byteBuffer.position()).reset();
 if (nRead > 0) {
 return true;
 } else if (nRead == -1) {
@@ -1090,6 +1090,7 @@ public class Http11InputBuffer implement
 ByteBuffer temp = ByteBuffer.allocate(size);
 temp.put(byteBuffer);
 byteBuffer = temp;
+byteBuffer.mark();
 temp = null;
 }
 }



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: ECJ and Java 9

2016-10-05 Thread Emmanuel Bourg 
Le 5/10/2016 à 16:25, Rémy Maucherat a écrit :

> Also, there's an issue with the Java 9 constant that is used in Tomcat,
> CompilerOptions.VERSION_1_9 -> CompilerOptions.VERSION_9. This creates a
> compatibility problem where the new vs old build cannot be drop in
> replacements.

The CompilerOptions.VERSION constants are just strings, the static field
could probably be replaced by "1.9" and/or "9" to preserve the
compatibility during the transition.

Emmanuel Bourg


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: ECJ and Java 9

2016-10-05 Thread Rémy Maucherat 
2016-10-04 19:41 GMT+02:00 Emmanuel Bourg :

> Le 4/10/2016 à 19:19, Rémy Maucherat a écrit :
>
> > Does anyone have info on Java 9 support in ECJ ? This is going to be
> needed
> > for JSP support (obviously). I tested 4.7Ms [good news: it's a drop in
> > replacement for our current 4.5] but there's no change in that area.
>
> There is a Java 9 branch in the Git repository, I don't know how much
> of the new features it supports though:
>
>   http://git.eclipse.org/c/jdt/eclipse.jdt.core.git/log/?h=BETA_JAVA9
>
> It looks like the beta builds have a tag starting with Y, this one is
> the latest available:
>
>   http://git.eclipse.org/c/jdt/eclipse.jdt.core.git/snapshot/
> Y20160929-1000.tar.gz
>
> Thanks to bothof you.

I tested this beta build, but I don't see much difference yet. It still
cannot access the base module classes it seems (errors like:
"java.lang.Throwable cannot be resolved to a type", that cannot be normal).

Also, there's an issue with the Java 9 constant that is used in Tomcat,
CompilerOptions.VERSION_1_9 -> CompilerOptions.VERSION_9. This creates a
compatibility problem where the new vs old build cannot be drop in
replacements.

Rémy

[Bug 59710] java.io.IOException: Connection timed out

2016-10-05 Thread bugzilla 
https://bz.apache.org/bugzilla/show_bug.cgi?id=59710

Mark Thomas  changed:

   What|Removed |Added

 Resolution|--- |WORKSFORME
 Status|NEEDINFO|RESOLVED

--- Comment #7 from Mark Thomas  ---
No further response for 3+ months. Resolving as WORKSFORME.

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

buildbot success in on tomcat-trunk

2016-10-05 Thread buildbot 
The Buildbot has detected a restored build on builder tomcat-trunk while 
building . Full details are available at:
https://ci.apache.org/builders/tomcat-trunk/builds/1751

Buildbot URL: https://ci.apache.org/

Buildslave for this Build: silvanus_ubuntu

Build Reason: The AnyBranchScheduler scheduler named 'on-tomcat-commit' 
triggered this build
Build Source Stamp: [branch tomcat/trunk] 1763449
Blamelist: markt

Build succeeded!

Sincerely,
 -The Buildbot




-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 60196] isMandatory erroneously always set to true for JASPIC SAM

2016-10-05 Thread bugzilla 
https://bz.apache.org/bugzilla/show_bug.cgi?id=60196

Mark Thomas  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|NEW |RESOLVED

--- Comment #1 from Mark Thomas  ---
This has been fixed in the following branches:
- 9.0.x for 9.0.0.M11 onwards
- 8.5.x for 8.5.6 onwards

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r1763451 - in /tomcat/tc8.5.x/trunk: ./ java/org/apache/catalina/authenticator/AuthenticatorBase.java webapps/docs/changelog.xml

2016-10-05 Thread markt 
Author: markt
Date: Wed Oct  5 13:57:28 2016
New Revision: 1763451

URL: http://svn.apache.org/viewvc?rev=1763451=rev
Log:
Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=60196
Ensure that the isMandatory flag is correctly set when using JASPIC 
authentication.

Modified:
tomcat/tc8.5.x/trunk/   (props changed)

tomcat/tc8.5.x/trunk/java/org/apache/catalina/authenticator/AuthenticatorBase.java
tomcat/tc8.5.x/trunk/webapps/docs/changelog.xml

Propchange: tomcat/tc8.5.x/trunk/
--
--- svn:mergeinfo (original)
+++ svn:mergeinfo Wed Oct  5 13:57:28 2016
@@ -1 +1 @@
-/tomcat/trunk:1734785,1734799,1734845,1734928,1735041,1735044,1735480,1735577,1735597,1735599-1735600,1735615,1736145,1736162,1736209,1736280,1736297,1736299,1736489,1736646,1736703,1736836,1736849,1737104-1737105,1737112,1737117,1737119-1737120,1737155,1737157,1737192,1737280,1737339,1737632,1737664,1737715,1737748,1737785,1737834,1737860,1737903,1737959,1738005,1738007,1738014-1738015,1738018,1738022,1738039,1738043,1738059-1738060,1738147,1738149,1738174-1738175,1738261,1738589,1738623-1738625,1738643,1738816,1738850,1738855,1738946-1738948,1738953-1738954,1738979,1738982,1739079-1739081,1739087,1739113,1739153,1739172,1739176,1739191,1739474,1739726,1739762,1739775,1739814,1739817-1739818,1739975,1740131,1740324,1740465,1740495,1740508-1740509,1740520,1740535,1740707,1740803,1740810,1740969,1740980,1740991,1740997,1741015,1741033,1741036,1741058,1741060,1741080,1741147,1741159,1741164,1741173,1741181,1741190,1741197,1741202,1741208,1741213,1741221,1741225,1741232,1741409,1741501
 
,1741677,1741892,1741896,1741984,1742023,1742042,1742071,1742090,1742093,1742101,1742105,1742111,1742139,1742146,1742148,1742166,1742181,1742184,1742187,1742246,1742248-1742251,1742263-1742264,1742268,1742276,1742369,1742387,1742448,1742509-1742512,1742917,1742919,1742933,1742975-1742976,1742984,1742986,1743019,1743115,1743117,1743124-1743125,1743134,1743425,1743554,1743679,1743696-1743698,1743700-1743701,1744058,1744064-1744065,1744125,1744194,1744229,1744270,1744323,1744432,1744684,1744697,1744705,1744713,1744760,1744786,1745083,1745142-1745143,1745145,1745177,1745179-1745180,1745227,1745248,1745254,1745337,1745467,1745473,1745576,1745735,1745744,1746304,1746306-1746307,1746319,1746327,1746338,1746340-1746341,1746344,1746427,1746441,1746473,1746490,1746492,1746495-1746496,1746499-1746501,1746503-1746507,1746509,1746549,1746551,1746554,1746556,1746558,1746584,1746620,1746649,1746724,1746939,1746989,1747014,1747028,1747035,1747210,1747225,1747234,1747253,1747404,1747506,1747536,1747
 
924,1747980,1747993,1748001,1748253,1748452,1748547,1748629,1748676,1748715,1749287,1749296,1749328,1749373,1749465,1749506,1749508,1749665-1749666,1749763,1749865-1749866,1749898,1749978,1749980,1750011,1750015,1750056,1750480,1750617,1750634,1750692,1750697,1750700,1750703,1750707,1750714,1750718,1750723,1750774,1750899,1750975,1750995,1751061,1751097,1751173,1751438,1751447,1751463,1751702,1752212,1752737,1752745,1753078,1753080,1753358,1753363,1754111,1754140-1754141,1754281,1754310,1754445,1754467,1754494,1754496,1754528,1754532-1754533,1754613,1754714,1754874,1754941,1754944,1754950-1754951,1755005,1755007,1755009,1755132,1755180-1755181,1755185,1755190,1755204-1755206,1755208,1755214,1755224,1755227,1755230,1755629,1755646-1755647,1755650,1755653,1755675,1755680,1755683,1755693,1755717,1755731-1755737,1755812,1755828,1755884,1755890,1755918-1755919,1755942,1755958,1755960,1755970,1755993,1756013,1756019,1756039,1756056,1756083-1756114,1756175,1756288-1756289,1756408-1756410,1
 
756778,1756798,1756878,1756898,1756939,1757123-1757124,1757126,1757128,1757132-1757133,1757136,1757145,1757167-1757168,1757175,1757180,1757182,1757195,1757271,1757278,1757347,1757353-1757354,1757363,1757374,1757399,1757406,1757408,1757485,1757495,1757499,1757527,1757578,1757684,1757722,1757727,1757853,1757903,1757997,1758072-1758075,1758078-1758079,1758292,1758369,1758423,1758425-1758427,1758430,1758459,1758483,1758486-1758487,1758499,1758525,1758556,1758582,1758584,1758588,1758842,1759019,1759212,1759224,1759227,1759252,1759274,1759513-1759516,1759611,1760005,1760022,1760300,1760397,1760446,1760454,1760640,1760648,1761057,1761422,1761491,1761498,1761500-1761501,1761550,1761553,1761572,1761574,1761625-1761626,1761628,1761682,1761740,1761752,1762123,1762168,1762172,1762182,1762202,1762288,1762296,1762348,1762353,1762374,1762503,1762505,1762541,1762608,1762710,1762753,1762766,1762769,1762944,1762947,1762953,1763167,1763179,1763232,1763259,1763271-1763272,1763276-1763277,1763319-176332
 0,1763370,1763372,1763375,1763377,1763393,1763412,1763430

svn commit: r1763450 - in /tomcat/trunk: java/org/apache/catalina/authenticator/AuthenticatorBase.java webapps/docs/changelog.xml

2016-10-05 Thread markt 
Author: markt
Date: Wed Oct  5 13:52:58 2016
New Revision: 1763450

URL: http://svn.apache.org/viewvc?rev=1763450=rev
Log:
Ensure that the isMandatory flag is correctly set when using JASPIC 
authentication.

Modified:
tomcat/trunk/java/org/apache/catalina/authenticator/AuthenticatorBase.java
tomcat/trunk/webapps/docs/changelog.xml

Modified: 
tomcat/trunk/java/org/apache/catalina/authenticator/AuthenticatorBase.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/authenticator/AuthenticatorBase.java?rev=1763450=1763449=1763450=diff
==
--- tomcat/trunk/java/org/apache/catalina/authenticator/AuthenticatorBase.java 
(original)
+++ tomcat/trunk/java/org/apache/catalina/authenticator/AuthenticatorBase.java 
Wed Oct  5 13:52:58 2016
@@ -506,23 +506,26 @@ public abstract class AuthenticatorBase
 
 // Since authenticate modifies the response on failure,
 // we have to check for allow-from-all first.
-if (!authRequired && constraints != null) {
-authRequired = true;
-for (int i = 0; i < constraints.length && authRequired; i++) {
+boolean hasAuthConstraint = false;
+if (constraints != null) {
+hasAuthConstraint = true;
+for (int i = 0; i < constraints.length && hasAuthConstraint; i++) {
 if (!constraints[i].getAuthConstraint()) {
-authRequired = false;
-break;
+hasAuthConstraint = false;
 } else if (!constraints[i].getAllRoles() &&
 !constraints[i].getAuthenticatedUsers()) {
 String[] roles = constraints[i].findAuthRoles();
 if (roles == null || roles.length == 0) {
-authRequired = false;
-break;
+hasAuthConstraint = false;
 }
 }
 }
 }
 
+if (!authRequired && hasAuthConstraint) {
+authRequired = true;
+}
+
 if (!authRequired && context.getPreemptiveAuthentication()) {
 authRequired =
 
request.getCoyoteRequest().getMimeHeaders().getValue("authorization") != null;
@@ -542,7 +545,7 @@ public abstract class AuthenticatorBase
 }
 
 if (jaspicProvider != null) {
-jaspicState = getJaspicState(jaspicProvider, request, 
response);
+jaspicState = getJaspicState(jaspicProvider, request, 
response, hasAuthConstraint);
 if (jaspicState == null) {
 return;
 }
@@ -601,7 +604,7 @@ public abstract class AuthenticatorBase
 return doAuthenticate(request, httpResponse);
 } else {
 Response response = request.getResponse();
-JaspicState jaspicState = getJaspicState(jaspicProvider, request, 
response);
+JaspicState jaspicState = getJaspicState(jaspicProvider, request, 
response, true);
 if (jaspicState == null) {
 return false;
 }
@@ -627,11 +630,11 @@ public abstract class AuthenticatorBase
 
 
 private JaspicState getJaspicState(AuthConfigProvider jaspicProvider, 
Request request,
-Response response) throws IOException {
+Response response, boolean authMandatory) throws IOException {
 JaspicState jaspicState = new JaspicState();
 
 jaspicState.messageInfo =
-new MessageInfoImpl(request.getRequest(), 
response.getResponse(), true);
+new MessageInfoImpl(request.getRequest(), 
response.getResponse(), authMandatory);
 
 try {
 ServerAuthConfig serverAuthConfig = 
jaspicProvider.getServerAuthConfig(

Modified: tomcat/trunk/webapps/docs/changelog.xml
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/changelog.xml?rev=1763450=1763449=1763450=diff
==
--- tomcat/trunk/webapps/docs/changelog.xml (original)
+++ tomcat/trunk/webapps/docs/changelog.xml Wed Oct  5 13:52:58 2016
@@ -117,6 +117,10 @@
 where the current class loader is a child of the web application class
 loader. (markt)
   
+  
+60196: Ensure that the isMandatory flag is
+correctly set when using JASPIC authentication. (markt)
+  
 
   
   



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r1763449 - /tomcat/trunk/test/org/apache/catalina/authenticator/TesterDigestAuthenticatorPerformance.java

2016-10-05 Thread markt 
Author: markt
Date: Wed Oct  5 13:47:13 2016
New Revision: 1763449

URL: http://svn.apache.org/viewvc?rev=1763449=rev
Log:
Get the test working again

Modified:

tomcat/trunk/test/org/apache/catalina/authenticator/TesterDigestAuthenticatorPerformance.java

Modified: 
tomcat/trunk/test/org/apache/catalina/authenticator/TesterDigestAuthenticatorPerformance.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/test/org/apache/catalina/authenticator/TesterDigestAuthenticatorPerformance.java?rev=1763449=1763448=1763449=diff
==
--- 
tomcat/trunk/test/org/apache/catalina/authenticator/TesterDigestAuthenticatorPerformance.java
 (original)
+++ 
tomcat/trunk/test/org/apache/catalina/authenticator/TesterDigestAuthenticatorPerformance.java
 Wed Oct  5 13:47:13 2016
@@ -27,8 +27,14 @@ import org.junit.Before;
 import org.junit.Test;
 
 import org.apache.catalina.Context;
+import org.apache.catalina.Engine;
+import org.apache.catalina.Host;
+import org.apache.catalina.Service;
 import org.apache.catalina.connector.Request;
 import org.apache.catalina.core.StandardContext;
+import org.apache.catalina.core.StandardEngine;
+import org.apache.catalina.core.StandardHost;
+import org.apache.catalina.core.StandardService;
 import org.apache.catalina.filters.TesterHttpServletResponse;
 import org.apache.catalina.startup.TesterMapRealm;
 import org.apache.tomcat.util.descriptor.web.LoginConfig;
@@ -117,6 +123,15 @@ public class TesterDigestAuthenticatorPe
 context.setName(CONTEXT_PATH);
 context.setRealm(realm);
 
+Host host = new StandardHost();
+context.setParent(host);
+
+Engine engine = new StandardEngine();
+host.setParent(engine);
+
+Service service = new StandardService();
+engine.setService(service);
+
 // Configure the Login config
 LoginConfig config = new LoginConfig();
 config.setRealmName(REALM);



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

buildbot failure in on tomcat-trunk

2016-10-05 Thread buildbot 
The Buildbot has detected a new failure on builder tomcat-trunk while building 
. Full details are available at:
https://ci.apache.org/builders/tomcat-trunk/builds/1750

Buildbot URL: https://ci.apache.org/

Buildslave for this Build: silvanus_ubuntu

Build Reason: The AnyBranchScheduler scheduler named 'on-tomcat-commit' 
triggered this build
Build Source Stamp: [branch tomcat/trunk] 1763430
Blamelist: markt

BUILD FAILED: failed compile_1

Sincerely,
 -The Buildbot




-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: svn commit: r1763403 - in /tomcat/tc8.5.x/trunk: ./ bin/ conf/ java/org/apache/catalina/webresources/ java/org/apache/catalina/webresources/war/ java/org/apache/tomcat/util/buf/ java/org/apache/to

2016-10-05 Thread Mark Thomas 
On 05/10/2016 12:32, Mark Thomas wrote:
> On 05/10/2016 12:21, Konstantin Kolinko wrote:
>> 2016-10-05 13:48 GMT+03:00  :
>>> Author: markt
>>> Date: Wed Oct  5 10:48:51 2016
>>> New Revision: 1763403
>>>
>>> URL: http://svn.apache.org/viewvc?rev=1763403=rev
>>> Log:
>>> Refactor the web resources handling to use the Tomcat specific 
>>> 'war:file:...' URL protocol...



>>> Modified: tomcat/tc8.5.x/trunk/bin/catalina.bat
>>> URL: 
>>> http://svn.apache.org/viewvc/tomcat/tc8.5.x/trunk/bin/catalina.bat?rev=1763403=1763402=1763403=diff
>>> ==
>>> --- tomcat/tc8.5.x/trunk/bin/catalina.bat (original)
>>> +++ tomcat/tc8.5.x/trunk/bin/catalina.bat Wed Oct  5 10:48:51 2016
>>> @@ -201,6 +201,10 @@ set JSSE_OPTS="-Djdk.tls.ephemeralDHKeyS
>>>  :gotJsseOpts
>>>  set "JAVA_OPTS=%JAVA_OPTS% %JSSE_OPTS%"
>>>
>>> +rem Register custom URL handlers
>>> +rem Do this here so they can be used in the security policy
>>
>> Maybe clarify "they"?  s/they/war: URLs/
> 
> Will do.

Fixed.

>>> +set "JAVA_OPTS=%JAVA_OPTS% 
>>> -Djava.protocol.handler.pkgs=org.apache.catalina.webresources"
>>> +
>>>  if not "%LOGGING_CONFIG%" == "" goto noJuliConfig
>>>  set LOGGING_CONFIG=-Dnop
>>>  if not exist "%CATALINA_BASE%\conf\logging.properties" goto noJuliConfig
>>>
>>
>> Will Tomcat start without above change? (Is it only necessary when
>> running with a Security Manager, and policy file uses war: URLs)?
> 
> Yes, Tomcat will start unless you are using a SecurityManager that uses
> "war:..." URLs.
> 
>> 1. I am concerned about running Tomcat as service. (I do not see
>> changes to tomcat.nsi and to service.bat here).
> 
> Fair point. I'll take a look.

We don't configure a security manager so not an issue.

>> 3. daemon.sh was not updated as well.

Again, we don't configure a security manager so not an issue.

Should we ever add running under a security manger as an option for the
installer or the daemon then we'd need to take account of this.

Mark


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r1763433 - in /tomcat/tc8.0.x/trunk: ./ bin/catalina.bat bin/catalina.sh

2016-10-05 Thread markt 
Author: markt
Date: Wed Oct  5 11:41:24 2016
New Revision: 1763433

URL: http://svn.apache.org/viewvc?rev=1763433=rev
Log:
Better comments

Modified:
tomcat/tc8.0.x/trunk/   (props changed)
tomcat/tc8.0.x/trunk/bin/catalina.bat
tomcat/tc8.0.x/trunk/bin/catalina.sh

Propchange: tomcat/tc8.0.x/trunk/
--
--- svn:mergeinfo (original)
+++ svn:mergeinfo Wed Oct  5 11:41:24 2016
@@ -1,2 +1,2 @@
 
/tomcat/tc8.5.x/trunk:1735042,1737966,1743139-1743140,1744151,1747537,1747925,1748002,1754614,1754643,1762124,1762183,1762203
-/tomcat/trunk:1636524,1637156,1637176,1637188,1637331,1637684,1637695,1637890,1637892,1638720-1638725,1639653,1640010,1640083-1640084,1640088,1640275,1640322,1640347,1640361,1640365,1640403,1640410,1640652,1640655-1640658,1640688,1640700-1640883,1640903,1640976,1640978,1641000,1641026,1641038-1641039,1641051-1641052,1641058,1641064,1641300,1641369,1641374,1641380,1641486,1641634,1641656-1641692,1641704,1641707-1641718,1641720-1641722,1641735,1641981,1642233,1642280,1642554,1642564,1642595,1642606,1642668,1642679,1642697,1642699,1642766,1643002,1643045,1643054-1643055,1643066,1643121,1643128,1643206,1643209-1643210,1643216,1643249,1643270,1643283,1643309-1643310,1643323,1643365-1643366,1643370-1643371,1643465,1643474,1643536,1643570,1643634,1643649,1643651,1643654,1643675,1643731,1643733-1643734,1643761,1643766,1643814,1643937,1643963,1644017,1644169,1644201-1644203,1644321,1644323,1644516,1644523,1644529,1644535,1644730,1644768,1644784-1644785,1644790,1644793,1644815,1644884,1644886
 
,1644890,1644892,1644910,1644924,1644929-1644930,1644935,1644989,1645011,1645247,1645355,1645357-1645358,1645455,1645465,1645469,1645471,1645473,1645475,1645486-1645488,1645626,1645641,1645685,1645743,1645763,1645951-1645953,1645955,1645993,1646098-1646106,1646178,1646220,1646302,1646304,1646420,1646470-1646471,1646476,1646559,1646717-1646723,1646773,1647026,1647042,1647530,1647655,1648304,1648815,1648907,1649973,1650081,1650365,1651116,1651120,1651280,1651470,1652938,1652970,1653041,1653471,1653550,1653574,1653797,1653815-1653816,1653819,1653840,1653857,1653888,1653972,1654013,1654030,1654050,1654123,1654148,1654159,1654513,1654515,1654517,1654522,1654524,1654725,1654735,1654766,1654785,1654851-1654852,1654978,1655122-1655124,1655126-1655127,1655129-1655130,1655132-1655133,1655312,1655351,1655438,1655441,1655454,168,1656087,1656299,1656319,1656331,1656345,1656350,1656590,1656648-1656650,1656657,1657041,1657054,1657374,1657492,1657510,1657565,1657580,1657584,1657586,1657589,1657
 
592,1657607,1657609,1657682,1657907,1658207,1658734,1658781,1658790,1658799,1658802,1658804,1658833,1658840,1658966,1659043,1659053,1659059,1659174,1659184,1659188-1659189,1659216,1659263,1659293,1659304,1659306-1659307,1659382,1659384,1659428,1659471,1659486,1659505,1659516,1659521,1659524,1659559,1659562,1659803,1659806,1659814,1659833,1659862,1659905,1659919,1659948,1659967,1659983-1659984,1660060,1660074,1660077,1660133,1660168,1660331-1660332,1660353,1660358,1660924,1661386,1661770,1661867,1661972,1661990,1662200,1662308-1662309,1662548,1662614,1662696,1662736,1662985,1662988-1662989,1663264,1663277,1663298,1663534,1663562,1663676,1663715,1663754,1663768,1663772,1663781,1663893,1663995,1664143,1664163,1664174,1664301,1664317,1664347,1664657,1664659,1664710,1664863-1664864,1664866,1665085,1665292,1665559,1665653,1665661,1665672,1665694,1665697,1665736,1665779,1665976-1665977,1665980-1665981,1665985-1665986,1665989,1665998,1666004,1666008,1666013,1666017,1666024,1666116,1666386-1
 
666387,1666494,1666496,1666552,1666569,1666579,137,149,1666757,1666966,1666972,1666985,1666995,1666997,1667292,1667402,1667406,1667546,1667615,1667630,1667636,1667688,1667764,1667871,1668026,1668135,1668193,1668593,1668596,1668630,1668639,1668843,1669353,1669370,1669451,1669800,1669838,1669876,1669882,1670394,1670433,1670591,1670598-1670600,1670610,1670631,1670719,1670724,1670726,1670730,1670940,1671112,1672272,1672284,1673754,1674294,1675461,1675486,1675594,1675830,1676231,1676250-1676251,1676364,1676381,1676393,1676479,1676525,1676552,1676615,1676630,1676634,1676721,1676926,1676943,1677140,1677802,1678011,1678162,1678174,1678339,1678426-1678427,1678694,1678701,1679534,1679708,1679710,1679716,1680034,1680246,1681056,1681123,1681138,1681280,1681283,1681286,1681450,1681697,1681699,1681701,1681729,1681770,1681779,1681793,1681807,1681837-1681838,1681854,1681862,1681958,1682028,1682033,1682311,1682315,1682317,1682320,1682324,1682330,1682842,1684172,1684366,1684383,1684526-168452

svn commit: r1763431 - in /tomcat/tc8.5.x/trunk: ./ bin/catalina.bat bin/catalina.sh

2016-10-05 Thread markt 
Author: markt
Date: Wed Oct  5 11:40:02 2016
New Revision: 1763431

URL: http://svn.apache.org/viewvc?rev=1763431=rev
Log:
Better comments

Modified:
tomcat/tc8.5.x/trunk/   (props changed)
tomcat/tc8.5.x/trunk/bin/catalina.bat
tomcat/tc8.5.x/trunk/bin/catalina.sh

Propchange: tomcat/tc8.5.x/trunk/
--
--- svn:mergeinfo (original)
+++ svn:mergeinfo Wed Oct  5 11:40:02 2016
@@ -1 +1 @@
-/tomcat/trunk:1734785,1734799,1734845,1734928,1735041,1735044,1735480,1735577,1735597,1735599-1735600,1735615,1736145,1736162,1736209,1736280,1736297,1736299,1736489,1736646,1736703,1736836,1736849,1737104-1737105,1737112,1737117,1737119-1737120,1737155,1737157,1737192,1737280,1737339,1737632,1737664,1737715,1737748,1737785,1737834,1737860,1737903,1737959,1738005,1738007,1738014-1738015,1738018,1738022,1738039,1738043,1738059-1738060,1738147,1738149,1738174-1738175,1738261,1738589,1738623-1738625,1738643,1738816,1738850,1738855,1738946-1738948,1738953-1738954,1738979,1738982,1739079-1739081,1739087,1739113,1739153,1739172,1739176,1739191,1739474,1739726,1739762,1739775,1739814,1739817-1739818,1739975,1740131,1740324,1740465,1740495,1740508-1740509,1740520,1740535,1740707,1740803,1740810,1740969,1740980,1740991,1740997,1741015,1741033,1741036,1741058,1741060,1741080,1741147,1741159,1741164,1741173,1741181,1741190,1741197,1741202,1741208,1741213,1741221,1741225,1741232,1741409,1741501
 
,1741677,1741892,1741896,1741984,1742023,1742042,1742071,1742090,1742093,1742101,1742105,1742111,1742139,1742146,1742148,1742166,1742181,1742184,1742187,1742246,1742248-1742251,1742263-1742264,1742268,1742276,1742369,1742387,1742448,1742509-1742512,1742917,1742919,1742933,1742975-1742976,1742984,1742986,1743019,1743115,1743117,1743124-1743125,1743134,1743425,1743554,1743679,1743696-1743698,1743700-1743701,1744058,1744064-1744065,1744125,1744194,1744229,1744270,1744323,1744432,1744684,1744697,1744705,1744713,1744760,1744786,1745083,1745142-1745143,1745145,1745177,1745179-1745180,1745227,1745248,1745254,1745337,1745467,1745473,1745576,1745735,1745744,1746304,1746306-1746307,1746319,1746327,1746338,1746340-1746341,1746344,1746427,1746441,1746473,1746490,1746492,1746495-1746496,1746499-1746501,1746503-1746507,1746509,1746549,1746551,1746554,1746556,1746558,1746584,1746620,1746649,1746724,1746939,1746989,1747014,1747028,1747035,1747210,1747225,1747234,1747253,1747404,1747506,1747536,1747
 
924,1747980,1747993,1748001,1748253,1748452,1748547,1748629,1748676,1748715,1749287,1749296,1749328,1749373,1749465,1749506,1749508,1749665-1749666,1749763,1749865-1749866,1749898,1749978,1749980,1750011,1750015,1750056,1750480,1750617,1750634,1750692,1750697,1750700,1750703,1750707,1750714,1750718,1750723,1750774,1750899,1750975,1750995,1751061,1751097,1751173,1751438,1751447,1751463,1751702,1752212,1752737,1752745,1753078,1753080,1753358,1753363,1754111,1754140-1754141,1754281,1754310,1754445,1754467,1754494,1754496,1754528,1754532-1754533,1754613,1754714,1754874,1754941,1754944,1754950-1754951,1755005,1755007,1755009,1755132,1755180-1755181,1755185,1755190,1755204-1755206,1755208,1755214,1755224,1755227,1755230,1755629,1755646-1755647,1755650,1755653,1755675,1755680,1755683,1755693,1755717,1755731-1755737,1755812,1755828,1755884,1755890,1755918-1755919,1755942,1755958,1755960,1755970,1755993,1756013,1756019,1756039,1756056,1756083-1756114,1756175,1756288-1756289,1756408-1756410,1
 
756778,1756798,1756878,1756898,1756939,1757123-1757124,1757126,1757128,1757132-1757133,1757136,1757145,1757167-1757168,1757175,1757180,1757182,1757195,1757271,1757278,1757347,1757353-1757354,1757363,1757374,1757399,1757406,1757408,1757485,1757495,1757499,1757527,1757578,1757684,1757722,1757727,1757853,1757903,1757997,1758072-1758075,1758078-1758079,1758292,1758369,1758423,1758425-1758427,1758430,1758459,1758483,1758486-1758487,1758499,1758525,1758556,1758582,1758584,1758588,1758842,1759019,1759212,1759224,1759227,1759252,1759274,1759513-1759516,1759611,1760005,1760022,1760300,1760397,1760446,1760454,1760640,1760648,1761057,1761422,1761491,1761498,1761500-1761501,1761550,1761553,1761572,1761574,1761625-1761626,1761628,1761682,1761740,1761752,1762123,1762168,1762172,1762182,1762202,1762288,1762296,1762348,1762353,1762374,1762503,1762505,1762541,1762608,1762710,1762753,1762766,1762769,1762944,1762947,1762953,1763167,1763179,1763232,1763259,1763271-1763272,1763276-1763277,1763319-176332
 0,1763370,1763372,1763375,1763377,1763393,1763412

svn commit: r1763430 - in /tomcat/trunk/bin: catalina.bat catalina.sh

2016-10-05 Thread markt 
Author: markt
Date: Wed Oct  5 11:39:21 2016
New Revision: 1763430

URL: http://svn.apache.org/viewvc?rev=1763430=rev
Log:
Better comments

Modified:
tomcat/trunk/bin/catalina.bat
tomcat/trunk/bin/catalina.sh

Modified: tomcat/trunk/bin/catalina.bat
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/bin/catalina.bat?rev=1763430=1763429=1763430=diff
==
--- tomcat/trunk/bin/catalina.bat (original)
+++ tomcat/trunk/bin/catalina.bat Wed Oct  5 11:39:21 2016
@@ -202,7 +202,7 @@ set JSSE_OPTS="-Djdk.tls.ephemeralDHKeyS
 set "JAVA_OPTS=%JAVA_OPTS% %JSSE_OPTS%"
 
 rem Register custom URL handlers
-rem Do this here so they can be used in the security policy
+rem Do this here so custom URL handles (specifically 'war:...') can be used in 
the security policy
 set "JAVA_OPTS=%JAVA_OPTS% 
-Djava.protocol.handler.pkgs=org.apache.catalina.webresources"
 
 if not "%LOGGING_CONFIG%" == "" goto noJuliConfig

Modified: tomcat/trunk/bin/catalina.sh
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/bin/catalina.sh?rev=1763430=1763429=1763430=diff
==
--- tomcat/trunk/bin/catalina.sh (original)
+++ tomcat/trunk/bin/catalina.sh Wed Oct  5 11:39:21 2016
@@ -241,7 +241,7 @@ fi
 JAVA_OPTS="$JAVA_OPTS $JSSE_OPTS"
 
 # Register custom URL handlers
-# Do this here so they can be used in the security policy
+# Do this here so custom URL handles (specifically 'war:...') can be used in 
the security policy
 JAVA_OPTS="%JAVA_OPTS% 
-Djava.protocol.handler.pkgs=org.apache.catalina.webresources"
 
 # Set juli LogManager config file if it is present and an override has not 
been issued



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 60199] Improve error message if a session attribute could not load due to deserialization problems

2016-10-05 Thread bugzilla 
https://bz.apache.org/bugzilla/show_bug.cgi?id=60199

--- Comment #3 from Mark Thomas  ---
I'm not completely against this but...

The error is logged, with the attribute name when writing the session to disk.
Why do you need another error message when reading it?

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: svn commit: r1763403 - in /tomcat/tc8.5.x/trunk: ./ bin/ conf/ java/org/apache/catalina/webresources/ java/org/apache/catalina/webresources/war/ java/org/apache/tomcat/util/buf/ java/org/apache/to

2016-10-05 Thread Mark Thomas 
On 05/10/2016 12:21, Konstantin Kolinko wrote:
> 2016-10-05 13:48 GMT+03:00  :
>> Author: markt
>> Date: Wed Oct  5 10:48:51 2016
>> New Revision: 1763403
>>
>> URL: http://svn.apache.org/viewvc?rev=1763403=rev
>> Log:
>> Refactor the web resources handling to use the Tomcat specific 
>> 'war:file:...' URL protocol to refer to WAR files and their contents rather 
>> than the standard 'jar:file:...' form since some components of the JRE, such 
>> as JAR verification, give unexpected results when the standard form is used. 
>> A side-effect of the refactoring is that when using packed WARs, it is now 
>> possible to reference a WAR and/or specific JARs within a WAR in the 
>> security policy file used when running under a SecurityManager.
>>
>> Added:
>> 
>> tomcat/tc8.5.x/trunk/java/org/apache/catalina/webresources/AbstractSingleArchiveResource.java
>>   - copied unchanged from r1763377, 
>> tomcat/trunk/java/org/apache/catalina/webresources/AbstractSingleArchiveResource.java
>> 
>> tomcat/tc8.5.x/trunk/java/org/apache/catalina/webresources/AbstractSingleArchiveResourceSet.java
>>   - copied unchanged from r1763377, 
>> tomcat/trunk/java/org/apache/catalina/webresources/AbstractSingleArchiveResourceSet.java
>> 
>> tomcat/tc8.5.x/trunk/java/org/apache/catalina/webresources/WarResource.java
>>   - copied unchanged from r1763377, 
>> tomcat/trunk/java/org/apache/catalina/webresources/WarResource.java
>> 
>> tomcat/tc8.5.x/trunk/java/org/apache/catalina/webresources/WarResourceSet.java
>>   - copied unchanged from r1763377, 
>> tomcat/trunk/java/org/apache/catalina/webresources/WarResourceSet.java
>> Modified:
>> tomcat/tc8.5.x/trunk/   (props changed)
>> tomcat/tc8.5.x/trunk/bin/catalina.bat
>> tomcat/tc8.5.x/trunk/bin/catalina.sh
>> tomcat/tc8.5.x/trunk/build.xml
>> tomcat/tc8.5.x/trunk/conf/catalina.policy
>> 
>> tomcat/tc8.5.x/trunk/java/org/apache/catalina/webresources/JarResource.java
>> 
>> tomcat/tc8.5.x/trunk/java/org/apache/catalina/webresources/JarResourceSet.java
>> 
>> tomcat/tc8.5.x/trunk/java/org/apache/catalina/webresources/JarWarResource.java
>> 
>> tomcat/tc8.5.x/trunk/java/org/apache/catalina/webresources/StandardRoot.java
>> 
>> tomcat/tc8.5.x/trunk/java/org/apache/catalina/webresources/war/Handler.java
>> 
>> tomcat/tc8.5.x/trunk/java/org/apache/catalina/webresources/war/WarURLConnection.java
>> tomcat/tc8.5.x/trunk/java/org/apache/tomcat/util/buf/UriUtil.java
>> tomcat/tc8.5.x/trunk/java/org/apache/tomcat/util/scan/JarFactory.java
>> 
>> tomcat/tc8.5.x/trunk/test/org/apache/catalina/loader/TestWebappClassLoader.java
>> tomcat/tc8.5.x/trunk/webapps/docs/changelog.xml
>> tomcat/tc8.5.x/trunk/webapps/docs/security-manager-howto.xml
>>
>> Propchange: tomcat/tc8.5.x/trunk/
>> --
>> --- svn:mergeinfo (original)
>> +++ svn:mergeinfo Wed Oct  5 10:48:51 2016
>>
>> Modified: tomcat/tc8.5.x/trunk/bin/catalina.bat
>> URL: 
>> http://svn.apache.org/viewvc/tomcat/tc8.5.x/trunk/bin/catalina.bat?rev=1763403=1763402=1763403=diff
>> ==
>> --- tomcat/tc8.5.x/trunk/bin/catalina.bat (original)
>> +++ tomcat/tc8.5.x/trunk/bin/catalina.bat Wed Oct  5 10:48:51 2016
>> @@ -201,6 +201,10 @@ set JSSE_OPTS="-Djdk.tls.ephemeralDHKeyS
>>  :gotJsseOpts
>>  set "JAVA_OPTS=%JAVA_OPTS% %JSSE_OPTS%"
>>
>> +rem Register custom URL handlers
>> +rem Do this here so they can be used in the security policy
> 
> Maybe clarify "they"?  s/they/war: URLs/

Will do.

>> +set "JAVA_OPTS=%JAVA_OPTS% 
>> -Djava.protocol.handler.pkgs=org.apache.catalina.webresources"
>> +
>>  if not "%LOGGING_CONFIG%" == "" goto noJuliConfig
>>  set LOGGING_CONFIG=-Dnop
>>  if not exist "%CATALINA_BASE%\conf\logging.properties" goto noJuliConfig
>>
> 
> Will Tomcat start without above change? (Is it only necessary when
> running with a Security Manager, and policy file uses war: URLs)?

Yes, Tomcat will start unless you are using a SecurityManager that uses
"war:..." URLs.

> 1. I am concerned about running Tomcat as service. (I do not see
> changes to tomcat.nsi and to service.bat here).

Fair point. I'll take a look.

> 2. I am concerned about running Tomcat in Eclipse IDE. It runs as a
> java application (with a set of options), and the question is whether
> it can run with old configuration as long as war: URLs are not used in
> policy file, or people have to add the above -D to theirs.

As with the batch files, it will work unless a security manager is used
with a policy that uses "war:..." URLs. Given that you need to add
properties to enable the security manager, I'm not overly concerned
about this use case.

> 3. daemon.sh was not updated as well.

I'll look at that as well.

Thanks for the review.

Mark


-
To

Re: svn commit: r1763403 - in /tomcat/tc8.5.x/trunk: ./ bin/ conf/ java/org/apache/catalina/webresources/ java/org/apache/catalina/webresources/war/ java/org/apache/tomcat/util/buf/ java/org/apache/to

2016-10-05 Thread Konstantin Kolinko 
2016-10-05 13:48 GMT+03:00  :
> Author: markt
> Date: Wed Oct  5 10:48:51 2016
> New Revision: 1763403
>
> URL: http://svn.apache.org/viewvc?rev=1763403=rev
> Log:
> Refactor the web resources handling to use the Tomcat specific 'war:file:...' 
> URL protocol to refer to WAR files and their contents rather than the 
> standard 'jar:file:...' form since some components of the JRE, such as JAR 
> verification, give unexpected results when the standard form is used. A 
> side-effect of the refactoring is that when using packed WARs, it is now 
> possible to reference a WAR and/or specific JARs within a WAR in the security 
> policy file used when running under a SecurityManager.
>
> Added:
> 
> tomcat/tc8.5.x/trunk/java/org/apache/catalina/webresources/AbstractSingleArchiveResource.java
>   - copied unchanged from r1763377, 
> tomcat/trunk/java/org/apache/catalina/webresources/AbstractSingleArchiveResource.java
> 
> tomcat/tc8.5.x/trunk/java/org/apache/catalina/webresources/AbstractSingleArchiveResourceSet.java
>   - copied unchanged from r1763377, 
> tomcat/trunk/java/org/apache/catalina/webresources/AbstractSingleArchiveResourceSet.java
> 
> tomcat/tc8.5.x/trunk/java/org/apache/catalina/webresources/WarResource.java
>   - copied unchanged from r1763377, 
> tomcat/trunk/java/org/apache/catalina/webresources/WarResource.java
> 
> tomcat/tc8.5.x/trunk/java/org/apache/catalina/webresources/WarResourceSet.java
>   - copied unchanged from r1763377, 
> tomcat/trunk/java/org/apache/catalina/webresources/WarResourceSet.java
> Modified:
> tomcat/tc8.5.x/trunk/   (props changed)
> tomcat/tc8.5.x/trunk/bin/catalina.bat
> tomcat/tc8.5.x/trunk/bin/catalina.sh
> tomcat/tc8.5.x/trunk/build.xml
> tomcat/tc8.5.x/trunk/conf/catalina.policy
> 
> tomcat/tc8.5.x/trunk/java/org/apache/catalina/webresources/JarResource.java
> 
> tomcat/tc8.5.x/trunk/java/org/apache/catalina/webresources/JarResourceSet.java
> 
> tomcat/tc8.5.x/trunk/java/org/apache/catalina/webresources/JarWarResource.java
> 
> tomcat/tc8.5.x/trunk/java/org/apache/catalina/webresources/StandardRoot.java
> 
> tomcat/tc8.5.x/trunk/java/org/apache/catalina/webresources/war/Handler.java
> 
> tomcat/tc8.5.x/trunk/java/org/apache/catalina/webresources/war/WarURLConnection.java
> tomcat/tc8.5.x/trunk/java/org/apache/tomcat/util/buf/UriUtil.java
> tomcat/tc8.5.x/trunk/java/org/apache/tomcat/util/scan/JarFactory.java
> 
> tomcat/tc8.5.x/trunk/test/org/apache/catalina/loader/TestWebappClassLoader.java
> tomcat/tc8.5.x/trunk/webapps/docs/changelog.xml
> tomcat/tc8.5.x/trunk/webapps/docs/security-manager-howto.xml
>
> Propchange: tomcat/tc8.5.x/trunk/
> --
> --- svn:mergeinfo (original)
> +++ svn:mergeinfo Wed Oct  5 10:48:51 2016
>
> Modified: tomcat/tc8.5.x/trunk/bin/catalina.bat
> URL: 
> http://svn.apache.org/viewvc/tomcat/tc8.5.x/trunk/bin/catalina.bat?rev=1763403=1763402=1763403=diff
> ==
> --- tomcat/tc8.5.x/trunk/bin/catalina.bat (original)
> +++ tomcat/tc8.5.x/trunk/bin/catalina.bat Wed Oct  5 10:48:51 2016
> @@ -201,6 +201,10 @@ set JSSE_OPTS="-Djdk.tls.ephemeralDHKeyS
>  :gotJsseOpts
>  set "JAVA_OPTS=%JAVA_OPTS% %JSSE_OPTS%"
>
> +rem Register custom URL handlers
> +rem Do this here so they can be used in the security policy

Maybe clarify "they"?  s/they/war: URLs/

> +set "JAVA_OPTS=%JAVA_OPTS% 
> -Djava.protocol.handler.pkgs=org.apache.catalina.webresources"
> +
>  if not "%LOGGING_CONFIG%" == "" goto noJuliConfig
>  set LOGGING_CONFIG=-Dnop
>  if not exist "%CATALINA_BASE%\conf\logging.properties" goto noJuliConfig
>

Will Tomcat start without above change? (Is it only necessary when
running with a Security Manager, and policy file uses war: URLs)?

1. I am concerned about running Tomcat as service. (I do not see
changes to tomcat.nsi and to service.bat here).

2. I am concerned about running Tomcat in Eclipse IDE. It runs as a
java application (with a set of options), and the question is whether
it can run with old configuration as long as war: URLs are not used in
policy file, or people have to add the above -D to theirs.

3. daemon.sh was not updated as well.

Best regards,
Konstantin Kolinko

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 60192] There is a typographical error at 2 places

2016-10-05 Thread bugzilla 
https://bz.apache.org/bugzilla/show_bug.cgi?id=60192

Mark Thomas  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

--- Comment #2 from Mark Thomas  ---
Thanks for the report and the patch.

This has been fixed in the following branches:
- 9.0.x for 9.0.0.M11 onwards
- 8.5.x for 8.5.6 onwards
- 8.0.x for 8.0.38 onwards
- 7.0.x for 7.0.73 onwards
- 6.0.x for 6.0.46 onwards

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r1763416 - in /tomcat/tc6.0.x/trunk: ./ java/org/apache/catalina/manager/StatusTransformer.java webapps/docs/changelog.xml

2016-10-05 Thread markt 
Author: markt
Date: Wed Oct  5 11:06:02 2016
New Revision: 1763416

URL: http://svn.apache.org/viewvc?rev=1763416=rev
Log:
Correct a typo in the status output of the Manager application.
Patch provided by  Radhakrishna Pemmasani.

Modified:
tomcat/tc6.0.x/trunk/   (props changed)
tomcat/tc6.0.x/trunk/java/org/apache/catalina/manager/StatusTransformer.java
tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml

Propchange: tomcat/tc6.0.x/trunk/
--
--- svn:mergeinfo (original)
+++ svn:mergeinfo Wed Oct  5 11:06:02 2016
@@ -1,4 +1,4 @@
-/tomcat/tc7.0.x/trunk:1190476,1224802,1243045,1298635,1304471,1311997,1312007,1331772,1333164,1333176,1348992,1354866,1371298,1371302,1371620,1402110,1409014,1413553,1413557,1413563,1430083,1438415,1446641-1446660,1447013,1453106,1453119,1484919,1486877,1500065,1503852,1505844,1513151,1521040,1524796,1526470,1536524,1539176-1539177,1544469,1544473,1552805,1558894,1558917,1561368,1561382,1561386,1561552,1561561,1561636,1561641,1561643,1561737,1562748,1564317,1568922,1570163,1577328,1577464-1577465,1578814,1586659,1586897,1586960,1588199,1588997,1589740,1589851,1589997,1590019,1590028,1590337,1590492,1590651,1590838,1590845,1590848,1590912,1593262,1593288,1593371,1593835,1594230,1595174,1595366,1600956,1601333,1601856,1601909,1609079,1609606,1617364,1617374,1617433,1617457-1617458,1624249,1626579,1627420,1627469,1632586,1637686,1637711,1640675,1642045,1643515,1643540,1643572,1643585-1643586,1643642,1643647,1644019,1648817,1656301,1658815,1659523,1659564,1664001,1664176,1665087,1666968
 
,1666989,1668541,1668635,1669802,1676557,1681183,1681841,1681865,1681867,1685829,1693109,1694293,1694433,1694875,1696381,1701945,1710353,1712656,1713873,1714000,1714005,1714540,1715213,1716221,1716417,1717107,1717210,1717212,1720236,1720398,1720443,1720464,1721814,1721883,1722645,1722801,1723151,1724435,1724553,1724675,1724797,1724806,1725931,1726631,1726808,1726813,1726815,1726817,1726819,1726917,1726919,1726922-1726924,1727031,1727034,1727043,1727158,1727672,1727903,1728450,1729363,1731010,1731119,1731956,1731978,1732362,1732674-1732675,1733942,1734116,1734134,1734532,1737249,1737253,1737968,1738049,1738186,1739778,1741178,1741184,1741193,1741211,1741218,1741228,1741235,1742281,1743121,1743142,1743649,1744061,1744129,1744155,1744241,1744383,1744689,1745230,1746942,1746994,1749377,1750018,1750980,1751066,1754114,1754147,1754728,1754880,1754891,1754898,1754902,1756030,1756417,1756420,1756423,1756942,1757275,1757284,1757503,1758490,1758495,1761631,1761748,1762772,1763236
+/tomcat/tc7.0.x/trunk:1190476,1224802,1243045,1298635,1304471,1311997,1312007,1331772,1333164,1333176,1348992,1354866,1371298,1371302,1371620,1402110,1409014,1413553,1413557,1413563,1430083,1438415,1446641-1446660,1447013,1453106,1453119,1484919,1486877,1500065,1503852,1505844,1513151,1521040,1524796,1526470,1536524,1539176-1539177,1544469,1544473,1552805,1558894,1558917,1561368,1561382,1561386,1561552,1561561,1561636,1561641,1561643,1561737,1562748,1564317,1568922,1570163,1577328,1577464-1577465,1578814,1586659,1586897,1586960,1588199,1588997,1589740,1589851,1589997,1590019,1590028,1590337,1590492,1590651,1590838,1590845,1590848,1590912,1593262,1593288,1593371,1593835,1594230,1595174,1595366,1600956,1601333,1601856,1601909,1609079,1609606,1617364,1617374,1617433,1617457-1617458,1624249,1626579,1627420,1627469,1632586,1637686,1637711,1640675,1642045,1643515,1643540,1643572,1643585-1643586,1643642,1643647,1644019,1648817,1656301,1658815,1659523,1659564,1664001,1664176,1665087,1666968
 
,1666989,1668541,1668635,1669802,1676557,1681183,1681841,1681865,1681867,1685829,1693109,1694293,1694433,1694875,1696381,1701945,1710353,1712656,1713873,1714000,1714005,1714540,1715213,1716221,1716417,1717107,1717210,1717212,1720236,1720398,1720443,1720464,1721814,1721883,1722645,1722801,1723151,1724435,1724553,1724675,1724797,1724806,1725931,1726631,1726808,1726813,1726815,1726817,1726819,1726917,1726919,1726922-1726924,1727031,1727034,1727043,1727158,1727672,1727903,1728450,1729363,1731010,1731119,1731956,1731978,1732362,1732674-1732675,1733942,1734116,1734134,1734532,1737249,1737253,1737968,1738049,1738186,1739778,1741178,1741184,1741193,1741211,1741218,1741228,1741235,1742281,1743121,1743142,1743649,1744061,1744129,1744155,1744241,1744383,1744689,1745230,1746942,1746994,1749377,1750018,1750980,1751066,1754114,1754147,1754728,1754880,1754891,1754898,1754902,1756030,1756417,1756420,1756423,1756942,1757275,1757284,1757503,1758490,1758495,1761631,1761748,1762772,1763236,1763415

svn commit: r1763415 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/catalina/manager/StatusTransformer.java webapps/docs/changelog.xml

2016-10-05 Thread markt 
Author: markt
Date: Wed Oct  5 11:04:25 2016
New Revision: 1763415

URL: http://svn.apache.org/viewvc?rev=1763415=rev
Log:
Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=60192
Correct a typo in the status output of the Manager application.
Patch provided by  Radhakrishna Pemmasani.

Modified:
tomcat/tc7.0.x/trunk/   (props changed)
tomcat/tc7.0.x/trunk/java/org/apache/catalina/manager/StatusTransformer.java
tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml

Propchange: tomcat/tc7.0.x/trunk/
--
--- svn:mergeinfo (original)
+++ svn:mergeinfo Wed Oct  5 11:04:25 2016
@@ -1,3 +1,3 @@
 
/tomcat/tc8.0.x/trunk:1636525,1637336,1637685,1637709,1638726,1640089,1640276,1640349,1640363,1640366,1640642,1640672,1640674,1640689,1640884,1641001,1641065,1641067,1641375,1641638,1641723,1641726,1641729-1641730,1641736,1641988,1642669-1642670,1642698,1642701,1643205,1643215,1643217,1643230,1643232,1643273,1643285,1643329-1643330,1643511,1643513,1643521,1643539,1643571,1643581-1643582,1643635,1643655,1643738,1643964,1644018,1644333,1644954,1644992,1645014,1645360,1645456,1645627,1645642,1645686,1645903-1645904,1645908-1645909,1645913,1645920,1646458,1646460-1646462,1646735,1646738-1646741,1646744,1646746,1646748-1646755,1646757,1646759-1646760,1647043,1648816,1651420-1651422,1651844,1652926,1652939-1652940,1652973,1653798,1653817,1653841,1654042,1654161,1654736,1654767,1654787,1656592,1659907,1662986,1663265,1663278,1663325,1663535,1663567,1663679,1663997,1664175,1664321,1664872,1665061,1665086,1666027,1666395,1666503,1666506,1666560,1666570,1666581,1666759,1666967,1666988,1667553
 
-1667555,1667558,1667617,1667633,1667637,1667747,1667767,1667873,1668028,1668137,1668634,1669432,1669801,1669840,1669895-1669896,1670398,1670435,1670592,1670605-1670607,1670609,1670632,1670720,1670725,1670727,1670731,1671114,1672273,1672285,1673759,1674220,1674295,1675469,1675488,1675595,1675831,1676232,1676367-1676369,1676382,1676394,1676483,1676556,1676635,1678178,1679536,1679988,1680256,1681124,1681182,1681703,1681730,1681840,1681864,1681869,1682010,1682034,1682047,1682052-1682053,1682062,1682064,1682070,1682312,1682325,1682331,1682386,1684367,1684385,1685759,1685774,1685827,1685892,1687341,1688904,1689358,1689657,1689921,1692850,1693093,1693108,1693324,1694060,1694115,1694291,1694427,1694431,1694503,1694549,1694789,1694873,1694881,1695356,1695372,1695823-1695825,1696200,1696281,1696379,1696468,1700608,1700871,1700897,1700978,1701094,1701124,1701608,1701668,1701676,1701766,1701944,1702248,1702252,1702314,1702390,1702723,1702725,1702728,1702730,1702733,1702735,1702737,1702739,1702
 
742,1702744,1702748,1702751,1702754,1702758,1702760,1702763,1702766,1708779,1708782,1708806,1709314,1709670,1710347,1710442,1710448,1710490,1710574,1710578,1712226,1712229,1712235,1712255,1712618,1712649,1712655,1712860,1712899,1712903,1712906,1712913,1712926,1712975,1713185,1713262,1713287,1713613,1713621,1713872,1713976,1713994,1713998,1714004,1714013,1714059,1714538,1714580,1715189,1715207,1715544,1715549,1715637,1715639-1715645,1715667,1715683,1715866,1715978,1715981,1716216-1716217,1716355,1716414,1716421,1717208-1717209,1717257,1717283,1717288,1717291,1717421,1717517,1717529,1718797,1718840-1718843,1719348,1719357-1719358,1719400,1719491,1719737,1720235,1720396,1720442,1720446,1720450,1720463,1720658-1720660,1720756,1720816,1721813,1721818,1721831,1721861,1721867,1721882,1722523,1722527,1722800,1722926,1722941,1722997,1723130,1723440,1723488,1723890,1724434,1724674,1724792,1724803,1724902,1725128,1725131,1725154,1725167,1725911,1725921,1725929,1725963-1725965,1725970,1725974,1
 
726171-1726173,1726175,1726179-1726182,1726190-1726191,1726195-1726200,1726203,1726226,1726576,1726630,1726992,1727029,1727037,1727671,1727676,1727900,1728028,1728092,1728439,1728449,1729186,1729362,1731009,1731303,1731867,1731872,1731874,1731876,1731885,1731947,1731955,1731959,1731977,1731984,1732360,1732490,1732672,1732902,1733166,1733603,1733619,1733735,1733752,1733764,1733915,1733941,1733964,1734115,1734133,1734261,1734421,1734531,1736286,1737967,1738173,1738182,1738992,1739039,1739089-1739091,1739294,1739777,1739821,1739981,1740513,1740726,1741019,1741162,1741217,1743647,1743681,1744152,1744272,1746732,1746750,1752739,1754615,1755886,1756018,1759565,1761686,1762173,1762206

svn commit: r1763414 - in /tomcat/tc8.0.x/trunk: ./ java/org/apache/catalina/manager/StatusTransformer.java webapps/docs/changelog.xml

2016-10-05 Thread markt 
Author: markt
Date: Wed Oct  5 11:03:11 2016
New Revision: 1763414

URL: http://svn.apache.org/viewvc?rev=1763414=rev
Log:
Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=60192
Correct a typo in the status output of the Manager application.
Patch provided by  Radhakrishna Pemmasani.

Modified:
tomcat/tc8.0.x/trunk/   (props changed)
tomcat/tc8.0.x/trunk/java/org/apache/catalina/manager/StatusTransformer.java
tomcat/tc8.0.x/trunk/webapps/docs/changelog.xml

Propchange: tomcat/tc8.0.x/trunk/
--
--- svn:mergeinfo (original)
+++ svn:mergeinfo Wed Oct  5 11:03:11 2016
@@ -1,2 +1,2 @@
 
/tomcat/tc8.5.x/trunk:1735042,1737966,1743139-1743140,1744151,1747537,1747925,1748002,1754614,1754643,1762124,1762183,1762203
-/tomcat/trunk:1636524,1637156,1637176,1637188,1637331,1637684,1637695,1637890,1637892,1638720-1638725,1639653,1640010,1640083-1640084,1640088,1640275,1640322,1640347,1640361,1640365,1640403,1640410,1640652,1640655-1640658,1640688,1640700-1640883,1640903,1640976,1640978,1641000,1641026,1641038-1641039,1641051-1641052,1641058,1641064,1641300,1641369,1641374,1641380,1641486,1641634,1641656-1641692,1641704,1641707-1641718,1641720-1641722,1641735,1641981,1642233,1642280,1642554,1642564,1642595,1642606,1642668,1642679,1642697,1642699,1642766,1643002,1643045,1643054-1643055,1643066,1643121,1643128,1643206,1643209-1643210,1643216,1643249,1643270,1643283,1643309-1643310,1643323,1643365-1643366,1643370-1643371,1643465,1643474,1643536,1643570,1643634,1643649,1643651,1643654,1643675,1643731,1643733-1643734,1643761,1643766,1643814,1643937,1643963,1644017,1644169,1644201-1644203,1644321,1644323,1644516,1644523,1644529,1644535,1644730,1644768,1644784-1644785,1644790,1644793,1644815,1644884,1644886
 
,1644890,1644892,1644910,1644924,1644929-1644930,1644935,1644989,1645011,1645247,1645355,1645357-1645358,1645455,1645465,1645469,1645471,1645473,1645475,1645486-1645488,1645626,1645641,1645685,1645743,1645763,1645951-1645953,1645955,1645993,1646098-1646106,1646178,1646220,1646302,1646304,1646420,1646470-1646471,1646476,1646559,1646717-1646723,1646773,1647026,1647042,1647530,1647655,1648304,1648815,1648907,1649973,1650081,1650365,1651116,1651120,1651280,1651470,1652938,1652970,1653041,1653471,1653550,1653574,1653797,1653815-1653816,1653819,1653840,1653857,1653888,1653972,1654013,1654030,1654050,1654123,1654148,1654159,1654513,1654515,1654517,1654522,1654524,1654725,1654735,1654766,1654785,1654851-1654852,1654978,1655122-1655124,1655126-1655127,1655129-1655130,1655132-1655133,1655312,1655351,1655438,1655441,1655454,168,1656087,1656299,1656319,1656331,1656345,1656350,1656590,1656648-1656650,1656657,1657041,1657054,1657374,1657492,1657510,1657565,1657580,1657584,1657586,1657589,1657
 
592,1657607,1657609,1657682,1657907,1658207,1658734,1658781,1658790,1658799,1658802,1658804,1658833,1658840,1658966,1659043,1659053,1659059,1659174,1659184,1659188-1659189,1659216,1659263,1659293,1659304,1659306-1659307,1659382,1659384,1659428,1659471,1659486,1659505,1659516,1659521,1659524,1659559,1659562,1659803,1659806,1659814,1659833,1659862,1659905,1659919,1659948,1659967,1659983-1659984,1660060,1660074,1660077,1660133,1660168,1660331-1660332,1660353,1660358,1660924,1661386,1661770,1661867,1661972,1661990,1662200,1662308-1662309,1662548,1662614,1662696,1662736,1662985,1662988-1662989,1663264,1663277,1663298,1663534,1663562,1663676,1663715,1663754,1663768,1663772,1663781,1663893,1663995,1664143,1664163,1664174,1664301,1664317,1664347,1664657,1664659,1664710,1664863-1664864,1664866,1665085,1665292,1665559,1665653,1665661,1665672,1665694,1665697,1665736,1665779,1665976-1665977,1665980-1665981,1665985-1665986,1665989,1665998,1666004,1666008,1666013,1666017,1666024,1666116,1666386-1
 
666387,1666494,1666496,1666552,1666569,1666579,137,149,1666757,1666966,1666972,1666985,1666995,1666997,1667292,1667402,1667406,1667546,1667615,1667630,1667636,1667688,1667764,1667871,1668026,1668135,1668193,1668593,1668596,1668630,1668639,1668843,1669353,1669370,1669451,1669800,1669838,1669876,1669882,1670394,1670433,1670591,1670598-1670600,1670610,1670631,1670719,1670724,1670726,1670730,1670940,1671112,1672272,1672284,1673754,1674294,1675461,1675486,1675594,1675830,1676231,1676250-1676251,1676364,1676381,1676393,1676479,1676525,1676552,1676615,1676630,1676634,1676721,1676926,1676943,1677140,1677802,1678011,1678162,1678174,1678339,1678426-1678427,1678694,1678701,1679534,1679708,1679710,1679716,1680034,1680246,1681056,1681123,1681138,1681280,1681283,1681286,1681450,1681697,1681699,1681701,1681729,1681770,1681779,1681793,1681807,1681837-1681838,1681854,1681862,1681958,1682028,1682033,1682311,1682315,1682317,1682320,1682324,1682330,1682842,1684172,1684366,1684383,1684526-168452

svn commit: r1763413 - in /tomcat/tc8.5.x/trunk: ./ java/org/apache/catalina/manager/StatusTransformer.java webapps/docs/changelog.xml

2016-10-05 Thread markt 
Author: markt
Date: Wed Oct  5 11:02:45 2016
New Revision: 1763413

URL: http://svn.apache.org/viewvc?rev=1763413=rev
Log:
Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=60192
Correct a typo in the status output of the Manager application.
Patch provided by  Radhakrishna Pemmasani.

Modified:
tomcat/tc8.5.x/trunk/   (props changed)
tomcat/tc8.5.x/trunk/java/org/apache/catalina/manager/StatusTransformer.java
tomcat/tc8.5.x/trunk/webapps/docs/changelog.xml

Propchange: tomcat/tc8.5.x/trunk/
--
--- svn:mergeinfo (original)
+++ svn:mergeinfo Wed Oct  5 11:02:45 2016
@@ -1 +1 @@
-/tomcat/trunk:1734785,1734799,1734845,1734928,1735041,1735044,1735480,1735577,1735597,1735599-1735600,1735615,1736145,1736162,1736209,1736280,1736297,1736299,1736489,1736646,1736703,1736836,1736849,1737104-1737105,1737112,1737117,1737119-1737120,1737155,1737157,1737192,1737280,1737339,1737632,1737664,1737715,1737748,1737785,1737834,1737860,1737903,1737959,1738005,1738007,1738014-1738015,1738018,1738022,1738039,1738043,1738059-1738060,1738147,1738149,1738174-1738175,1738261,1738589,1738623-1738625,1738643,1738816,1738850,1738855,1738946-1738948,1738953-1738954,1738979,1738982,1739079-1739081,1739087,1739113,1739153,1739172,1739176,1739191,1739474,1739726,1739762,1739775,1739814,1739817-1739818,1739975,1740131,1740324,1740465,1740495,1740508-1740509,1740520,1740535,1740707,1740803,1740810,1740969,1740980,1740991,1740997,1741015,1741033,1741036,1741058,1741060,1741080,1741147,1741159,1741164,1741173,1741181,1741190,1741197,1741202,1741208,1741213,1741221,1741225,1741232,1741409,1741501
 
,1741677,1741892,1741896,1741984,1742023,1742042,1742071,1742090,1742093,1742101,1742105,1742111,1742139,1742146,1742148,1742166,1742181,1742184,1742187,1742246,1742248-1742251,1742263-1742264,1742268,1742276,1742369,1742387,1742448,1742509-1742512,1742917,1742919,1742933,1742975-1742976,1742984,1742986,1743019,1743115,1743117,1743124-1743125,1743134,1743425,1743554,1743679,1743696-1743698,1743700-1743701,1744058,1744064-1744065,1744125,1744194,1744229,1744270,1744323,1744432,1744684,1744697,1744705,1744713,1744760,1744786,1745083,1745142-1745143,1745145,1745177,1745179-1745180,1745227,1745248,1745254,1745337,1745467,1745473,1745576,1745735,1745744,1746304,1746306-1746307,1746319,1746327,1746338,1746340-1746341,1746344,1746427,1746441,1746473,1746490,1746492,1746495-1746496,1746499-1746501,1746503-1746507,1746509,1746549,1746551,1746554,1746556,1746558,1746584,1746620,1746649,1746724,1746939,1746989,1747014,1747028,1747035,1747210,1747225,1747234,1747253,1747404,1747506,1747536,1747
 
924,1747980,1747993,1748001,1748253,1748452,1748547,1748629,1748676,1748715,1749287,1749296,1749328,1749373,1749465,1749506,1749508,1749665-1749666,1749763,1749865-1749866,1749898,1749978,1749980,1750011,1750015,1750056,1750480,1750617,1750634,1750692,1750697,1750700,1750703,1750707,1750714,1750718,1750723,1750774,1750899,1750975,1750995,1751061,1751097,1751173,1751438,1751447,1751463,1751702,1752212,1752737,1752745,1753078,1753080,1753358,1753363,1754111,1754140-1754141,1754281,1754310,1754445,1754467,1754494,1754496,1754528,1754532-1754533,1754613,1754714,1754874,1754941,1754944,1754950-1754951,1755005,1755007,1755009,1755132,1755180-1755181,1755185,1755190,1755204-1755206,1755208,1755214,1755224,1755227,1755230,1755629,1755646-1755647,1755650,1755653,1755675,1755680,1755683,1755693,1755717,1755731-1755737,1755812,1755828,1755884,1755890,1755918-1755919,1755942,1755958,1755960,1755970,1755993,1756013,1756019,1756039,1756056,1756083-1756114,1756175,1756288-1756289,1756408-1756410,1
 
756778,1756798,1756878,1756898,1756939,1757123-1757124,1757126,1757128,1757132-1757133,1757136,1757145,1757167-1757168,1757175,1757180,1757182,1757195,1757271,1757278,1757347,1757353-1757354,1757363,1757374,1757399,1757406,1757408,1757485,1757495,1757499,1757527,1757578,1757684,1757722,1757727,1757853,1757903,1757997,1758072-1758075,1758078-1758079,1758292,1758369,1758423,1758425-1758427,1758430,1758459,1758483,1758486-1758487,1758499,1758525,1758556,1758582,1758584,1758588,1758842,1759019,1759212,1759224,1759227,1759252,1759274,1759513-1759516,1759611,1760005,1760022,1760300,1760397,1760446,1760454,1760640,1760648,1761057,1761422,1761491,1761498,1761500-1761501,1761550,1761553,1761572,1761574,1761625-1761626,1761628,1761682,1761740,1761752,1762123,1762168,1762172,1762182,1762202,1762288,1762296,1762348,1762353,1762374,1762503,1762505,1762541,1762608,1762710,1762753,1762766,1762769,1762944,1762947,1762953,1763167,1763179,1763232,1763259,1763271-1763272,1763276-1763277,1763319-176332
 0,1763370,1763372,1763375,1763377,1763393

svn commit: r1763412 - in /tomcat/trunk: java/org/apache/catalina/manager/StatusTransformer.java webapps/docs/changelog.xml

2016-10-05 Thread markt 
Author: markt
Date: Wed Oct  5 11:02:03 2016
New Revision: 1763412

URL: http://svn.apache.org/viewvc?rev=1763412=rev
Log:
Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=60192
Correct a typo in the status output of the Manager application.
Patch provided by  Radhakrishna Pemmasani.

Modified:
tomcat/trunk/java/org/apache/catalina/manager/StatusTransformer.java
tomcat/trunk/webapps/docs/changelog.xml

Modified: tomcat/trunk/java/org/apache/catalina/manager/StatusTransformer.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/manager/StatusTransformer.java?rev=1763412=1763411=1763412=diff
==
--- tomcat/trunk/java/org/apache/catalina/manager/StatusTransformer.java 
(original)
+++ tomcat/trunk/java/org/apache/catalina/manager/StatusTransformer.java Wed 
Oct  5 11:02:03 2016
@@ -305,7 +305,7 @@ public class StatusTransformer {
 writer.print(mBeanServer.getAttribute(tpName, 
"currentThreadsBusy"));
 try {
 Object value = mBeanServer.getAttribute(tpName, 
"keepAliveCount");
-writer.print(" Keeped alive sockets count: ");
+writer.print(" Keep alive sockets count: ");
 writer.print(value);
 } catch (Exception e) {
 // Ignore

Modified: tomcat/trunk/webapps/docs/changelog.xml
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/changelog.xml?rev=1763412=1763411=1763412=diff
==
--- tomcat/trunk/webapps/docs/changelog.xml (original)
+++ tomcat/trunk/webapps/docs/changelog.xml Wed Oct  5 11:02:03 2016
@@ -173,6 +173,10 @@
 of the JreMemoryLeakPreventionListener to the 
documentation
 web application. Based on a patch by Cris Berneburg. (markt)
   
+  
+60192: Correct a typo in the status output of the Manager
+application. Patch provided by  Radhakrishna Pemmasani. (markt)
+  
 
   
   



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 60087] Bouncy Castle in WEB-INF/lib not working on Tomcat 8 when unpackWars=false

2016-10-05 Thread bugzilla 
https://bz.apache.org/bugzilla/show_bug.cgi?id=60087

Mark Thomas  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

--- Comment #5 from Mark Thomas  ---
This has been fixed in the following branches:
- 9.0.x for 9.0.0.M11 onwards
- 8.5.x for 8.5.6 onwards
- 8.0.x for 8.0.38 onwards

7.0.x and earlier versions were not affected.

Fixing this required refactoring of the web resources handling to use the
Tomcat specific 'war:file:...' URL protocol to refer to WAR files and their
contents rather than the standard 'jar:file:...' form. A side-effect of the
refactoring is that when using packed WARs, it is now possible to reference a
WAR and/or specific JARs within a WAR in the security policy file used when
running under a SecurityManager.

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r1763405 - in /tomcat/tc8.0.x/trunk: ./ bin/ conf/ java/org/apache/catalina/webresources/ java/org/apache/catalina/webresources/war/ java/org/apache/tomcat/util/buf/ java/org/apache/tomcat

2016-10-05 Thread markt 
Author: markt
Date: Wed Oct  5 10:56:42 2016
New Revision: 1763405

URL: http://svn.apache.org/viewvc?rev=1763405=rev
Log:
Refactor the web resources handling to use the Tomcat specific 'war:file:...' 
URL protocol to refer to WAR files and their contents rather than the standard 
'jar:file:...' form since some components of the JRE, such as JAR verification, 
give unexpected results when the standard form is used. A side-effect of the 
refactoring is that when using packed WARs, it is now possible to reference a 
WAR and/or specific JARs within a WAR in the security policy file used when 
running under a SecurityManager.

Added:

tomcat/tc8.0.x/trunk/java/org/apache/catalina/webresources/AbstractSingleArchiveResource.java
  - copied unchanged from r1763377, 
tomcat/trunk/java/org/apache/catalina/webresources/AbstractSingleArchiveResource.java

tomcat/tc8.0.x/trunk/java/org/apache/catalina/webresources/AbstractSingleArchiveResourceSet.java
  - copied unchanged from r1763377, 
tomcat/trunk/java/org/apache/catalina/webresources/AbstractSingleArchiveResourceSet.java
tomcat/tc8.0.x/trunk/java/org/apache/catalina/webresources/WarResource.java
  - copied unchanged from r1763377, 
tomcat/trunk/java/org/apache/catalina/webresources/WarResource.java

tomcat/tc8.0.x/trunk/java/org/apache/catalina/webresources/WarResourceSet.java
  - copied unchanged from r1763377, 
tomcat/trunk/java/org/apache/catalina/webresources/WarResourceSet.java
Modified:
tomcat/tc8.0.x/trunk/   (props changed)
tomcat/tc8.0.x/trunk/bin/catalina.bat
tomcat/tc8.0.x/trunk/bin/catalina.sh
tomcat/tc8.0.x/trunk/build.xml
tomcat/tc8.0.x/trunk/conf/catalina.policy
tomcat/tc8.0.x/trunk/java/org/apache/catalina/webresources/JarResource.java

tomcat/tc8.0.x/trunk/java/org/apache/catalina/webresources/JarResourceSet.java

tomcat/tc8.0.x/trunk/java/org/apache/catalina/webresources/JarWarResource.java
tomcat/tc8.0.x/trunk/java/org/apache/catalina/webresources/StandardRoot.java
tomcat/tc8.0.x/trunk/java/org/apache/catalina/webresources/war/Handler.java

tomcat/tc8.0.x/trunk/java/org/apache/catalina/webresources/war/WarURLConnection.java
tomcat/tc8.0.x/trunk/java/org/apache/tomcat/util/buf/UriUtil.java
tomcat/tc8.0.x/trunk/java/org/apache/tomcat/util/scan/JarFactory.java

tomcat/tc8.0.x/trunk/test/org/apache/catalina/loader/TestWebappClassLoader.java
tomcat/tc8.0.x/trunk/webapps/docs/changelog.xml
tomcat/tc8.0.x/trunk/webapps/docs/security-manager-howto.xml

Propchange: tomcat/tc8.0.x/trunk/
--
--- svn:mergeinfo (original)
+++ svn:mergeinfo Wed Oct  5 10:56:42 2016
@@ -1,2 +1,2 @@
 
/tomcat/tc8.5.x/trunk:1735042,1737966,1743139-1743140,1744151,1747537,1747925,1748002,1754614,1754643,1762124,1762183,1762203
-/tomcat/trunk:1636524,1637156,1637176,1637188,1637331,1637684,1637695,1637890,1637892,1638720-1638725,1639653,1640010,1640083-1640084,1640088,1640275,1640322,1640347,1640361,1640365,1640403,1640410,1640652,1640655-1640658,1640688,1640700-1640883,1640903,1640976,1640978,1641000,1641026,1641038-1641039,1641051-1641052,1641058,1641064,1641300,1641369,1641374,1641380,1641486,1641634,1641656-1641692,1641704,1641707-1641718,1641720-1641722,1641735,1641981,1642233,1642280,1642554,1642564,1642595,1642606,1642668,1642679,1642697,1642699,1642766,1643002,1643045,1643054-1643055,1643066,1643121,1643128,1643206,1643209-1643210,1643216,1643249,1643270,1643283,1643309-1643310,1643323,1643365-1643366,1643370-1643371,1643465,1643474,1643536,1643570,1643634,1643649,1643651,1643654,1643675,1643731,1643733-1643734,1643761,1643766,1643814,1643937,1643963,1644017,1644169,1644201-1644203,1644321,1644323,1644516,1644523,1644529,1644535,1644730,1644768,1644784-1644785,1644790,1644793,1644815,1644884,1644886
 
,1644890,1644892,1644910,1644924,1644929-1644930,1644935,1644989,1645011,1645247,1645355,1645357-1645358,1645455,1645465,1645469,1645471,1645473,1645475,1645486-1645488,1645626,1645641,1645685,1645743,1645763,1645951-1645953,1645955,1645993,1646098-1646106,1646178,1646220,1646302,1646304,1646420,1646470-1646471,1646476,1646559,1646717-1646723,1646773,1647026,1647042,1647530,1647655,1648304,1648815,1648907,1649973,1650081,1650365,1651116,1651120,1651280,1651470,1652938,1652970,1653041,1653471,1653550,1653574,1653797,1653815-1653816,1653819,1653840,1653857,1653888,1653972,1654013,1654030,1654050,1654123,1654148,1654159,1654513,1654515,1654517,1654522,1654524,1654725,1654735,1654766,1654785,1654851-1654852,1654978,1655122-1655124,1655126-1655127,1655129-1655130,1655132-1655133,1655312,1655351,1655438,1655441,1655454,168,1656087,1656299,1656319,1656331,1656345,1656350,1656590,1656648-1656650,1656657,1657041,1657054,1657374,1657492,1657510,1657565,1657580,1657584,1657586,1657589,1657

svn commit: r1763403 - in /tomcat/tc8.5.x/trunk: ./ bin/ conf/ java/org/apache/catalina/webresources/ java/org/apache/catalina/webresources/war/ java/org/apache/tomcat/util/buf/ java/org/apache/tomcat

2016-10-05 Thread markt 
Author: markt
Date: Wed Oct  5 10:48:51 2016
New Revision: 1763403

URL: http://svn.apache.org/viewvc?rev=1763403=rev
Log:
Refactor the web resources handling to use the Tomcat specific 'war:file:...' 
URL protocol to refer to WAR files and their contents rather than the standard 
'jar:file:...' form since some components of the JRE, such as JAR verification, 
give unexpected results when the standard form is used. A side-effect of the 
refactoring is that when using packed WARs, it is now possible to reference a 
WAR and/or specific JARs within a WAR in the security policy file used when 
running under a SecurityManager.

Added:

tomcat/tc8.5.x/trunk/java/org/apache/catalina/webresources/AbstractSingleArchiveResource.java
  - copied unchanged from r1763377, 
tomcat/trunk/java/org/apache/catalina/webresources/AbstractSingleArchiveResource.java

tomcat/tc8.5.x/trunk/java/org/apache/catalina/webresources/AbstractSingleArchiveResourceSet.java
  - copied unchanged from r1763377, 
tomcat/trunk/java/org/apache/catalina/webresources/AbstractSingleArchiveResourceSet.java
tomcat/tc8.5.x/trunk/java/org/apache/catalina/webresources/WarResource.java
  - copied unchanged from r1763377, 
tomcat/trunk/java/org/apache/catalina/webresources/WarResource.java

tomcat/tc8.5.x/trunk/java/org/apache/catalina/webresources/WarResourceSet.java
  - copied unchanged from r1763377, 
tomcat/trunk/java/org/apache/catalina/webresources/WarResourceSet.java
Modified:
tomcat/tc8.5.x/trunk/   (props changed)
tomcat/tc8.5.x/trunk/bin/catalina.bat
tomcat/tc8.5.x/trunk/bin/catalina.sh
tomcat/tc8.5.x/trunk/build.xml
tomcat/tc8.5.x/trunk/conf/catalina.policy
tomcat/tc8.5.x/trunk/java/org/apache/catalina/webresources/JarResource.java

tomcat/tc8.5.x/trunk/java/org/apache/catalina/webresources/JarResourceSet.java

tomcat/tc8.5.x/trunk/java/org/apache/catalina/webresources/JarWarResource.java
tomcat/tc8.5.x/trunk/java/org/apache/catalina/webresources/StandardRoot.java
tomcat/tc8.5.x/trunk/java/org/apache/catalina/webresources/war/Handler.java

tomcat/tc8.5.x/trunk/java/org/apache/catalina/webresources/war/WarURLConnection.java
tomcat/tc8.5.x/trunk/java/org/apache/tomcat/util/buf/UriUtil.java
tomcat/tc8.5.x/trunk/java/org/apache/tomcat/util/scan/JarFactory.java

tomcat/tc8.5.x/trunk/test/org/apache/catalina/loader/TestWebappClassLoader.java
tomcat/tc8.5.x/trunk/webapps/docs/changelog.xml
tomcat/tc8.5.x/trunk/webapps/docs/security-manager-howto.xml

Propchange: tomcat/tc8.5.x/trunk/
--
--- svn:mergeinfo (original)
+++ svn:mergeinfo Wed Oct  5 10:48:51 2016
@@ -1 +1 @@
-/tomcat/trunk:1734785,1734799,1734845,1734928,1735041,1735044,1735480,1735577,1735597,1735599-1735600,1735615,1736145,1736162,1736209,1736280,1736297,1736299,1736489,1736646,1736703,1736836,1736849,1737104-1737105,1737112,1737117,1737119-1737120,1737155,1737157,1737192,1737280,1737339,1737632,1737664,1737715,1737748,1737785,1737834,1737860,1737903,1737959,1738005,1738007,1738014-1738015,1738018,1738022,1738039,1738043,1738059-1738060,1738147,1738149,1738174-1738175,1738261,1738589,1738623-1738625,1738643,1738816,1738850,1738855,1738946-1738948,1738953-1738954,1738979,1738982,1739079-1739081,1739087,1739113,1739153,1739172,1739176,1739191,1739474,1739726,1739762,1739775,1739814,1739817-1739818,1739975,1740131,1740324,1740465,1740495,1740508-1740509,1740520,1740535,1740707,1740803,1740810,1740969,1740980,1740991,1740997,1741015,1741033,1741036,1741058,1741060,1741080,1741147,1741159,1741164,1741173,1741181,1741190,1741197,1741202,1741208,1741213,1741221,1741225,1741232,1741409,1741501
 
,1741677,1741892,1741896,1741984,1742023,1742042,1742071,1742090,1742093,1742101,1742105,1742111,1742139,1742146,1742148,1742166,1742181,1742184,1742187,1742246,1742248-1742251,1742263-1742264,1742268,1742276,1742369,1742387,1742448,1742509-1742512,1742917,1742919,1742933,1742975-1742976,1742984,1742986,1743019,1743115,1743117,1743124-1743125,1743134,1743425,1743554,1743679,1743696-1743698,1743700-1743701,1744058,1744064-1744065,1744125,1744194,1744229,1744270,1744323,1744432,1744684,1744697,1744705,1744713,1744760,1744786,1745083,1745142-1745143,1745145,1745177,1745179-1745180,1745227,1745248,1745254,1745337,1745467,1745473,1745576,1745735,1745744,1746304,1746306-1746307,1746319,1746327,1746338,1746340-1746341,1746344,1746427,1746441,1746473,1746490,1746492,1746495-1746496,1746499-1746501,1746503-1746507,1746509,1746549,1746551,1746554,1746556,1746558,1746584,1746620,1746649,1746724,1746939,1746989,1747014,1747028,1747035,1747210,1747225,1747234,1747253,1747404,1747506,1747536,1747

[Bug 60193] A child container failed during start

2016-10-05 Thread bugzilla 
https://bz.apache.org/bugzilla/show_bug.cgi?id=60193

Mark Thomas  changed:

   What|Removed |Added

 Status|NEEDINFO|RESOLVED
 Resolution|--- |INVALID

--- Comment #2 from Mark Thomas  ---
Bugzilla is not a support forum. This question belongs on the users mailing
list.

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

buildbot success in on tomcat-trunk

2016-10-05 Thread buildbot 
The Buildbot has detected a restored build on builder tomcat-trunk while 
building . Full details are available at:
https://ci.apache.org/builders/tomcat-trunk/builds/1748

Buildbot URL: https://ci.apache.org/

Buildslave for this Build: silvanus_ubuntu

Build Reason: The AnyBranchScheduler scheduler named 'on-tomcat-commit' 
triggered this build
Build Source Stamp: [branch tomcat/trunk] 1763393
Blamelist: markt

Build succeeded!

Sincerely,
 -The Buildbot




-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r16375 - /release/tomcat/tomcat-connectors/native/README.html

2016-10-05 Thread markt 
Author: markt
Date: Wed Oct  5 10:37:19 2016
New Revision: 16375

Log:
Update latest version

Modified:
release/tomcat/tomcat-connectors/native/README.html

Modified: release/tomcat/tomcat-connectors/native/README.html
==
--- release/tomcat/tomcat-connectors/native/README.html (original)
+++ release/tomcat/tomcat-connectors/native/README.html Wed Oct  5 10:37:19 2016
@@ -1,6 +1,6 @@
 The Apache Tomcat Native
 
-The latest release version is 1.2.7.
+The latest release version is 1.2.10.
 The latest release version for 1.1.x is 1.1.34
 
 



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r16374 - /dev/tomcat/tomcat-connectors/native/1.2.10/ /release/tomcat/tomcat-connectors/native/1.2.10/

2016-10-05 Thread markt 
Author: markt
Date: Wed Oct  5 10:36:45 2016
New Revision: 16374

Log:
Release Tomcat Native 1.2.10

Added:
release/tomcat/tomcat-connectors/native/1.2.10/
  - copied from r16371, dev/tomcat/tomcat-connectors/native/1.2.10/
Removed:
dev/tomcat/tomcat-connectors/native/1.2.10/


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[VOTE][RESULT] Release Apache Tomcat Native 1.2.10

2016-10-05 Thread Mark Thomas 
The following votes were cast:

Binding:
+1: markt, violetagg, hgomez, fschumacher

Non-binding:
+1: csutherl

Thanks to everyone who voted.

I'll start the next steps now. We should be able to announce tomorrow.

Mark

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r1763393 - /tomcat/trunk/test/org/apache/catalina/loader/TestWebappClassLoader.java

2016-10-05 Thread markt 
Author: markt
Date: Wed Oct  5 10:25:58 2016
New Revision: 1763393

URL: http://svn.apache.org/viewvc?rev=1763393=rev
Log:
Update test to check for new URL form

Modified:
tomcat/trunk/test/org/apache/catalina/loader/TestWebappClassLoader.java

Modified: 
tomcat/trunk/test/org/apache/catalina/loader/TestWebappClassLoader.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/test/org/apache/catalina/loader/TestWebappClassLoader.java?rev=1763393=1763392=1763393=diff
==
--- tomcat/trunk/test/org/apache/catalina/loader/TestWebappClassLoader.java 
(original)
+++ tomcat/trunk/test/org/apache/catalina/loader/TestWebappClassLoader.java Wed 
Oct  5 10:25:58 2016
@@ -36,8 +36,8 @@ public class TestWebappClassLoader exten
 
 String[] expected = new String[2];
 String warUrl = f.toURI().toURL().toExternalForm();
-expected[0] = "jar:" + warUrl + "!/WEB-INF/classes/";
-expected[1] = "jar:" + warUrl + "!/WEB-INF/lib/test.jar";
+expected[0] = "war:" + warUrl + "*/WEB-INF/classes/";
+expected[1] = "war:" + warUrl + "*/WEB-INF/lib/test.jar";
 
 Tomcat tomcat = getTomcatInstance();
 



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: [VOTE] Release Apache Tomcat Native 1.2.10

2016-10-05 Thread Felix Schumacher 

Am 26.09.2016 18:17, schrieb Mark Thomas:

Version 1.2.10 includes the following change:

- Update minimum recommended OpenSSL version to 1.0.2j
- Windows binaries built with OpenSSL 1.0.2j

The proposed release artefacts can be found at [1],
and the build was done using tag [2].

The Apache Tomcat Native 1.2.10 is
 [x] Stable, go ahead and release
 [ ] Broken because of ...


Regards,
 Felix



Thanks,

Mark


[1]
https://dist.apache.org/repos/dist/dev/tomcat/tomcat-connectors/native/1.2.10/
[2] 
https://svn.apache.org/repos/asf/tomcat/native/tags/TOMCAT_NATIVE_1_2_10


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r16373 - /release/tomcat/tomcat-connectors/jk/binaries/netware/

2016-10-05 Thread markt 
Author: markt
Date: Wed Oct  5 10:18:56 2016
New Revision: 16373

Log:
Remove the now very out of date Netware binaries from the mirrors.
They remain available from the archive.
The last user question on Netware was 2009.

Removed:
release/tomcat/tomcat-connectors/jk/binaries/netware/


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r16372 - /dev/tomcat/tomcat-connectors/jk/ /release/tomcat/tomcat-connectors/jk/ /release/tomcat/tomcat-connectors/jk/binaries/windows/

2016-10-05 Thread markt 
Author: markt
Date: Wed Oct  5 10:11:23 2016
New Revision: 16372

Log:
Move the JK 1.2.42 release files into place.
Update READMEs

Added:

release/tomcat/tomcat-connectors/jk/binaries/windows/tomcat-connectors-1.2.42-windows-i386-iis.zip
  - copied unchanged from r16371, 
dev/tomcat/tomcat-connectors/jk/binaries/tomcat-connectors-1.2.42-windows-i386-iis.zip

release/tomcat/tomcat-connectors/jk/binaries/windows/tomcat-connectors-1.2.42-windows-i386-iis.zip.asc
  - copied unchanged from r15949, 
dev/tomcat/tomcat-connectors/jk/binaries/tomcat-connectors-1.2.42-windows-i386-iis.zip.asc

release/tomcat/tomcat-connectors/jk/binaries/windows/tomcat-connectors-1.2.42-windows-i386-iis.zip.md5
  - copied unchanged from r15949, 
dev/tomcat/tomcat-connectors/jk/binaries/tomcat-connectors-1.2.42-windows-i386-iis.zip.md5

release/tomcat/tomcat-connectors/jk/binaries/windows/tomcat-connectors-1.2.42-windows-i386-iis.zip.sha1
  - copied unchanged from r15949, 
dev/tomcat/tomcat-connectors/jk/binaries/tomcat-connectors-1.2.42-windows-i386-iis.zip.sha1

release/tomcat/tomcat-connectors/jk/binaries/windows/tomcat-connectors-1.2.42-windows-x86_64-iis.zip
  - copied unchanged from r15949, 
dev/tomcat/tomcat-connectors/jk/binaries/tomcat-connectors-1.2.42-windows-x86_64-iis.zip

release/tomcat/tomcat-connectors/jk/binaries/windows/tomcat-connectors-1.2.42-windows-x86_64-iis.zip.asc
  - copied unchanged from r15949, 
dev/tomcat/tomcat-connectors/jk/binaries/tomcat-connectors-1.2.42-windows-x86_64-iis.zip.asc

release/tomcat/tomcat-connectors/jk/binaries/windows/tomcat-connectors-1.2.42-windows-x86_64-iis.zip.md5
  - copied unchanged from r15949, 
dev/tomcat/tomcat-connectors/jk/binaries/tomcat-connectors-1.2.42-windows-x86_64-iis.zip.md5

release/tomcat/tomcat-connectors/jk/binaries/windows/tomcat-connectors-1.2.42-windows-x86_64-iis.zip.sha1
  - copied unchanged from r15949, 
dev/tomcat/tomcat-connectors/jk/binaries/tomcat-connectors-1.2.42-windows-x86_64-iis.zip.sha1
release/tomcat/tomcat-connectors/jk/tomcat-connectors-1.2.42-src.tar.gz
  - copied unchanged from r15949, 
dev/tomcat/tomcat-connectors/jk/tomcat-connectors-1.2.42-src.tar.gz
release/tomcat/tomcat-connectors/jk/tomcat-connectors-1.2.42-src.tar.gz.asc
  - copied unchanged from r15949, 
dev/tomcat/tomcat-connectors/jk/tomcat-connectors-1.2.42-src.tar.gz.asc
release/tomcat/tomcat-connectors/jk/tomcat-connectors-1.2.42-src.tar.gz.md5
  - copied unchanged from r15951, 
dev/tomcat/tomcat-connectors/jk/tomcat-connectors-1.2.42-src.tar.gz.md5
release/tomcat/tomcat-connectors/jk/tomcat-connectors-1.2.42-src.tar.gz.sha1
  - copied unchanged from r15951, 
dev/tomcat/tomcat-connectors/jk/tomcat-connectors-1.2.42-src.tar.gz.sha1
release/tomcat/tomcat-connectors/jk/tomcat-connectors-1.2.42-src.zip
  - copied unchanged from r15949, 
dev/tomcat/tomcat-connectors/jk/tomcat-connectors-1.2.42-src.zip
release/tomcat/tomcat-connectors/jk/tomcat-connectors-1.2.42-src.zip.asc
  - copied unchanged from r15949, 
dev/tomcat/tomcat-connectors/jk/tomcat-connectors-1.2.42-src.zip.asc
release/tomcat/tomcat-connectors/jk/tomcat-connectors-1.2.42-src.zip.md5
  - copied unchanged from r15951, 
dev/tomcat/tomcat-connectors/jk/tomcat-connectors-1.2.42-src.zip.md5
release/tomcat/tomcat-connectors/jk/tomcat-connectors-1.2.42-src.zip.sha1
  - copied unchanged from r15951, 
dev/tomcat/tomcat-connectors/jk/tomcat-connectors-1.2.42-src.zip.sha1
Removed:
dev/tomcat/tomcat-connectors/jk/
Modified:
release/tomcat/tomcat-connectors/jk/binaries/windows/README.html

Modified: release/tomcat/tomcat-connectors/jk/binaries/windows/README.html
==
--- release/tomcat/tomcat-connectors/jk/binaries/windows/README.html (original)
+++ release/tomcat/tomcat-connectors/jk/binaries/windows/README.html Wed Oct  5 
10:11:23 2016
@@ -13,14 +13,6 @@
 TCP/IP must be correctly installed, configured and running in 
order to install and use Apache Tomcat Connectors on Windows.
 
-If you are installing on Windows XP prior to Service Pack 3
-
-Install the Windows XP Service Pack 3. Refer to
-   http://support.microsoft.com/default.aspx?scid=kb;en-us;317949;>
-   KB article 317949 if you need the gory details exactly why you must
-   not run the original Windows XP or SP1.
-
-
 Warning about the Quality of Service driver
 
 We suggest disabling the "Quality of Service" (or QoS) network driver from 
@@ -35,7 +27,7 @@
connector to fail.
 
 
-The current stable release is 1.2.40
+The current stable release is 1.2.42
 
 See the Apache Tomcat Connectors
 http://tomcat.apache.org/connectors-doc/miscellaneous/changelog.html;>changelog



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r16371 - /release/tomcat/tomcat-connectors/jk/binaries/windows/symbols/

2016-10-05 Thread markt 
Author: markt
Date: Wed Oct  5 10:03:26 2016
New Revision: 16371

Log:
Remove old versions

Removed:

release/tomcat/tomcat-connectors/jk/binaries/windows/symbols/tomcat-connectors-1.2.39-windows-i386-symbols.zip

release/tomcat/tomcat-connectors/jk/binaries/windows/symbols/tomcat-connectors-1.2.39-windows-i386-symbols.zip.asc

release/tomcat/tomcat-connectors/jk/binaries/windows/symbols/tomcat-connectors-1.2.39-windows-i386-symbols.zip.md5

release/tomcat/tomcat-connectors/jk/binaries/windows/symbols/tomcat-connectors-1.2.39-windows-i386-symbols.zip.sha1

release/tomcat/tomcat-connectors/jk/binaries/windows/symbols/tomcat-connectors-1.2.39-windows-x86_64-symbols.zip

release/tomcat/tomcat-connectors/jk/binaries/windows/symbols/tomcat-connectors-1.2.39-windows-x86_64-symbols.zip.asc

release/tomcat/tomcat-connectors/jk/binaries/windows/symbols/tomcat-connectors-1.2.39-windows-x86_64-symbols.zip.md5

release/tomcat/tomcat-connectors/jk/binaries/windows/symbols/tomcat-connectors-1.2.39-windows-x86_64-symbols.zip.sha1


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

buildbot failure in on tomcat-trunk

2016-10-05 Thread buildbot 
The Buildbot has detected a new failure on builder tomcat-trunk while building 
. Full details are available at:
https://ci.apache.org/builders/tomcat-trunk/builds/1747

Buildbot URL: https://ci.apache.org/

Buildslave for this Build: silvanus_ubuntu

Build Reason: The AnyBranchScheduler scheduler named 'on-tomcat-commit' 
triggered this build
Build Source Stamp: [branch tomcat/trunk] 1763377
Blamelist: markt

BUILD FAILED: failed compile_1

Sincerely,
 -The Buildbot




-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[VOTE][RESULT] JK 1.2.42

2016-10-05 Thread Mark Thomas 
The following votes were cast:

Binding:
+1: markt, kfujino, hgomez

The vote therefore passes.

Thanks to everyone who helped with this release.

I'll start the next steps now. We should be able to announce tomorrow.

Mark

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r1763377 - in /tomcat/trunk: conf/ java/org/apache/catalina/webresources/ webapps/docs/

2016-10-05 Thread markt 
Author: markt
Date: Wed Oct  5 09:50:39 2016
New Revision: 1763377

URL: http://svn.apache.org/viewvc?rev=1763377=rev
Log:
Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=60087
Refactor the web resources handling to use the Tomcat specific 'war:file:...' 
URL protocol to refer to WAR files and their contents rather than the standard 
'jar:file:...' form since some components of the JRE, such as JAR verification, 
give unexpected results when the standard form is used. A side-effect of the 
refactoring is that when using packed WARs, it is now possible to reference a 
WAR and/or specific JARs within a WAR in the security policy file used when 
running under a SecurityManager.

Added:

tomcat/trunk/java/org/apache/catalina/webresources/AbstractSingleArchiveResource.java
   (with props)

tomcat/trunk/java/org/apache/catalina/webresources/AbstractSingleArchiveResourceSet.java
   (with props)
tomcat/trunk/java/org/apache/catalina/webresources/WarResource.java   (with 
props)
tomcat/trunk/java/org/apache/catalina/webresources/WarResourceSet.java   
(with props)
Modified:
tomcat/trunk/conf/catalina.policy
tomcat/trunk/java/org/apache/catalina/webresources/JarResource.java
tomcat/trunk/java/org/apache/catalina/webresources/JarResourceSet.java
tomcat/trunk/java/org/apache/catalina/webresources/JarWarResource.java
tomcat/trunk/java/org/apache/catalina/webresources/StandardRoot.java
tomcat/trunk/webapps/docs/changelog.xml
tomcat/trunk/webapps/docs/security-manager-howto.xml

Modified: tomcat/trunk/conf/catalina.policy
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/conf/catalina.policy?rev=1763377=1763376=1763377=diff
==
--- tomcat/trunk/conf/catalina.policy (original)
+++ tomcat/trunk/conf/catalina.policy Wed Oct  5 09:50:39 2016
@@ -245,3 +245,13 @@ grant codeBase "file:${catalina.home}/we
 //  permission java.net.SocketPermission "*.noaa.gov:80", "connect";
 // };
 
+// To grant permissions for web applications using packed WAR files, use the
+// Tomcat specific WAR url scheme.
+//
+// The permissions granted to the entire web application
+// grant codeBase "war:file:${catalina.base}/webapps/examples.war*/-" {
+// };
+//
+// The permissions granted to a specific JAR
+// grant codeBase 
"war:file:${catalina.base}/webapps/examples.war*/WEB-INF/lib/foo.jar" {
+// };
\ No newline at end of file

Added: 
tomcat/trunk/java/org/apache/catalina/webresources/AbstractSingleArchiveResource.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/webresources/AbstractSingleArchiveResource.java?rev=1763377=auto
==
--- 
tomcat/trunk/java/org/apache/catalina/webresources/AbstractSingleArchiveResource.java
 (added)
+++ 
tomcat/trunk/java/org/apache/catalina/webresources/AbstractSingleArchiveResource.java
 Wed Oct  5 09:50:39 2016
@@ -0,0 +1,52 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *  http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.catalina.webresources;
+
+import java.io.IOException;
+import java.io.InputStream;
+import java.util.jar.JarEntry;
+import java.util.jar.JarFile;
+
+public abstract class AbstractSingleArchiveResource extends 
AbstractArchiveResource {
+
+protected AbstractSingleArchiveResource(AbstractArchiveResourceSet 
archiveResourceSet, String webAppPath,
+String baseUrl, JarEntry jarEntry, String codeBaseUrl) {
+super(archiveResourceSet, webAppPath, baseUrl, jarEntry, codeBaseUrl);
+}
+
+
+@Override
+protected JarInputStreamWrapper getJarInputStreamWrapper() {
+JarFile jarFile = null;
+try {
+jarFile = getArchiveResourceSet().openJarFile();
+// Need to create a new JarEntry so the certificates can be read
+JarEntry jarEntry = jarFile.getJarEntry(getResource().getName());
+InputStream is = jarFile.getInputStream(jarEntry);
+return new JarInputStreamWrapper(jarEntry, is);
+} catch (IOException e) {
+if (getLog().isDebugEnabled()) {
+getLog().debug(sm.getString("jarResource.getInputStreamFail",
+

svn commit: r1763375 - in /tomcat/trunk: build.xml java/org/apache/catalina/webresources/war/WarURLConnection.java java/org/apache/tomcat/util/buf/UriUtil.java java/org/apache/tomcat/util/scan/JarFact

2016-10-05 Thread markt 
Author: markt
Date: Wed Oct  5 09:40:54 2016
New Revision: 1763375

URL: http://svn.apache.org/viewvc?rev=1763375=rev
Log:
Add support for using 'war:file:...' URLs to refer to WAR files rather than 
'jar:file:...'

Modified:
tomcat/trunk/build.xml
tomcat/trunk/java/org/apache/catalina/webresources/war/WarURLConnection.java
tomcat/trunk/java/org/apache/tomcat/util/buf/UriUtil.java
tomcat/trunk/java/org/apache/tomcat/util/scan/JarFactory.java

Modified: tomcat/trunk/build.xml
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/build.xml?rev=1763375=1763374=1763375=diff
==
--- tomcat/trunk/build.xml (original)
+++ tomcat/trunk/build.xml Wed Oct  5 09:40:54 2016
@@ -339,6 +339,7 @@
 
 
 
+
   
 
   

Modified: 
tomcat/trunk/java/org/apache/catalina/webresources/war/WarURLConnection.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/webresources/war/WarURLConnection.java?rev=1763375=1763374=1763375=diff
==
--- 
tomcat/trunk/java/org/apache/catalina/webresources/war/WarURLConnection.java 
(original)
+++ 
tomcat/trunk/java/org/apache/catalina/webresources/war/WarURLConnection.java 
Wed Oct  5 09:40:54 2016
@@ -22,6 +22,8 @@ import java.net.URL;
 import java.net.URLConnection;
 import java.security.Permission;
 
+import org.apache.tomcat.util.buf.UriUtil;
+
 
 public class WarURLConnection extends URLConnection {
 
@@ -30,18 +32,7 @@ public class WarURLConnection extends UR
 
 protected WarURLConnection(URL url) throws IOException {
 super(url);
-
-// Need to make this look like a JAR URL for the WAR file
-// Assumes that the spec is absolute and starts war:file:/...
-String file = url.getFile();
-if (file.contains("*/")) {
-file = file.replaceFirst("\\*/", "!/");
-} else {
-file = file.replaceFirst("\\^/", "!/");
-}
-
-URL innerJarUrl = new URL("jar", url.getHost(), url.getPort(), file);
-
+URL innerJarUrl = UriUtil.warToJar(url);
 wrappedJarUrlConnection = innerJarUrl.openConnection();
 }
 

Modified: tomcat/trunk/java/org/apache/tomcat/util/buf/UriUtil.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/tomcat/util/buf/UriUtil.java?rev=1763375=1763374=1763375=diff
==
--- tomcat/trunk/java/org/apache/tomcat/util/buf/UriUtil.java (original)
+++ tomcat/trunk/java/org/apache/tomcat/util/buf/UriUtil.java Wed Oct  5 
09:40:54 2016
@@ -128,4 +128,27 @@ public final class UriUtil {
 tmp = PATTERN_CARET.matcher(tmp).replaceAll("%5e/");
 return PATTERN_ASTERISK.matcher(tmp).replaceAll("%2a/");
 }
+
+
+/**
+ * Convert a URL of the form war:file:... to
+ * war:file:
+ *
+ * @param warUrl The WAR URL to convert
+ *
+ * @return The equivalent JAR URL
+ *
+ * @throws MalformedURLException If the conversion fails
+ */
+public static URL warToJar(URL warUrl) throws MalformedURLException {
+// Assumes that the spec is absolute and starts war:file:/...
+String file = warUrl.getFile();
+if (file.contains("*/")) {
+file = file.replaceFirst("\\*/", "!/");
+} else {
+file = file.replaceFirst("\\^/", "!/");
+}
+
+return new URL("jar", warUrl.getHost(), warUrl.getPort(), file);
+}
 }

Modified: tomcat/trunk/java/org/apache/tomcat/util/scan/JarFactory.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/tomcat/util/scan/JarFactory.java?rev=1763375=1763374=1763375=diff
==
--- tomcat/trunk/java/org/apache/tomcat/util/scan/JarFactory.java (original)
+++ tomcat/trunk/java/org/apache/tomcat/util/scan/JarFactory.java Wed Oct  5 
09:40:54 2016
@@ -21,6 +21,7 @@ import java.net.MalformedURLException;
 import java.net.URL;
 
 import org.apache.tomcat.Jar;
+import org.apache.tomcat.util.buf.UriUtil;
 
 /**
  * Provide a mechanism to obtain objects that implement {@link Jar}.
@@ -31,21 +32,26 @@ public class JarFactory {
 // Factory class. Hide public constructor.
 }
 
+
 public static Jar newInstance(URL url) throws IOException {
-String jarUrl = url.toString();
-if (jarUrl.startsWith("jar:file:")) {
-if (jarUrl.endsWith("!/")) {
+String urlString = url.toString();
+if (urlString.startsWith("jar:file:")) {
+if (urlString.endsWith("!/")) {
 return new JarFileUrlJar(url, true);
 } else {
 return new JarFileUrlNestedJar(url);
 }
-} else if (jarUrl.startsWith("file:")) {
+} else if (urlString.startsWith("war:file:")) {
+URL jarUrl = UriUtil.warToJar(url);
+

svn commit: r1763372 - /tomcat/trunk/java/org/apache/catalina/webresources/war/Handler.java

2016-10-05 Thread markt 
Author: markt
Date: Wed Oct  5 09:30:09 2016
New Revision: 1763372

URL: http://svn.apache.org/viewvc?rev=1763372=rev
Log:
Add a work-around for poorly constructed "war:..." URLs obtained from the 
security policy file.

Modified:
tomcat/trunk/java/org/apache/catalina/webresources/war/Handler.java

Modified: tomcat/trunk/java/org/apache/catalina/webresources/war/Handler.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/webresources/war/Handler.java?rev=1763372=1763371=1763372=diff
==
--- tomcat/trunk/java/org/apache/catalina/webresources/war/Handler.java 
(original)
+++ tomcat/trunk/java/org/apache/catalina/webresources/war/Handler.java Wed Oct 
 5 09:30:09 2016
@@ -27,4 +27,20 @@ public class Handler extends URLStreamHa
 protected URLConnection openConnection(URL u) throws IOException {
 return new WarURLConnection(u);
 }
+
+@Override
+protected void setURL(URL u, String protocol, String host, int port, 
String authority, String userInfo, String path,
+String query, String ref) {
+if (path.startsWith("file:") && !path.startsWith("file:/")) {
+// Work around a problem with the URLs in the security policy file.
+// On Windows, the use of ${catalina.[home|base]} in the policy 
file
+// results in codebase URLs of the form file:C:/... when they 
should
+// be file:/C:/...
+// For file: and jar: URLs, the JRE compensates for this. It does 
not
+// compensate for this for war:file:... URLs. Therefore, we do that
+// here
+path = "file:/" + path.substring(5);
+}
+super.setURL(u, protocol, host, port, authority, userInfo, path, 
query, ref);
+}
 }



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r1763370 - /tomcat/trunk/build.xml

2016-10-05 Thread markt 
Author: markt
Date: Wed Oct  5 09:26:26 2016
New Revision: 1763370

URL: http://svn.apache.org/viewvc?rev=1763370=rev
Log:
Nice idea but excluding bootstrap classes from files.catalina just makes 
building files.tomcat-embed-core more complex

Modified:
tomcat/trunk/build.xml

Modified: tomcat/trunk/build.xml
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/build.xml?rev=1763370=1763369=1763370=diff
==
--- tomcat/trunk/build.xml (original)
+++ tomcat/trunk/build.xml Wed Oct  5 09:26:26 2016
@@ -325,6 +325,11 @@
 
   
 
+  
+  
+  
+  
+  
   
 
 
@@ -379,10 +384,6 @@
   
 
 
-
-
-  
-
 
 
 
@@ -438,7 +439,6 @@
   
   
 
-
 
 
 



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: Early Access build 136 for JDK 9 & JDK 9 with Project Jigsaw are available on java.net

2016-10-05 Thread Rory O'Donnell 

Thanks Mark, I'll update the bug.

Rgds,Rory


On 05/10/2016 09:15, Mark Thomas wrote:

On 04/10/2016 18:12, Rory O'Donnell wrote:

Hi Mark,

There was an update to JDK-8163449 below:

Caching is enabled by default, but it can be disabled statically (if
strangely through a non-static api). The fact that files can't be
deleted on windows is a consequence of this caching, and also that files
are opened by the Java runtime on windows in a mode that prevents
deletion. So, really, this isn't a bug and the question is can the
submitter just disable caching?

Let me know if that works for you ?

It doesn't.

The caching causes file locking on all operating systems. It is more
obvious on Windows since the OS won't let you delete the file. On Linux
while you can delete the file but the space won't be freed until the
lock is released.

I'm aware of the ability to disable the caching and this is what Tomcat
does to work-around this issue.

The bug was raised because the current default triggers file descriptor
leaks and lock files for JarURLConnection and that seems like a poor
choice for a default.

Equally, I'd rather not have to to disable all caching just to avoid a
problem with one URLConnection sub-class.

My hope was that rather than a single default caching option for all
URLConnections, the default could be configured per protocol and that
the default for the jar protocol would be changed to false.

Mark




Rgds,Rory

On 20/09/2016 11:15, Rory O'Donnell wrote:

Hi Mark,

Early Access b136  for JDK 9 is
available on java.net, summary of  changes are listed here
.
Early Access b136  (#5506) for JDK 9
with Project Jigsaw is available on java.net, summary of  changes are
listed here
.

There have been a number of fixes to bugs reported by Open Source
projects since the last availability email  :

   * 8165723 - b136 - core-libs JarFile::isMultiRelease() method
 returns false when it should return true
   * 8165116 - b136 - xml redirect function is not allowed even with
 enableExtensionFunctions

NOTE:-  Build 135 included a fix for  JDK-8161016 which *has
introduced a behavioral change to HttpURLConnection, more info:*

The behavior of HttpURLConnection when using a ProxySelector has been
modified with this JDK release. Currently, HttpURLConnection.connect()
call would fallback to a DIRECT connection attempt if the configured
proxy/proxies failed to make a connection. This release introduces a
change whereby no DIRECT connection will be attempted in such a
scenario. Instead, the HttpURLConnection.connect() method will fail
and throw an IOException which occurred from the last proxy tested.
This behavior now matches with the HTTP connections made by popular
web browsers. But this change will bring compatibility issues for the
applications expecting a DIRECT connection when a proxy server is down
or when wrong proxies are provided.
*

JDK 9 Outreach Survey*

In order to encourage and receive additional feedback from developers
testing their applications with JDK 9,
the OpenJDK Quality Outreach effort has put together a very brief
survey about your experiences with JDK 9 so far.

It is available at***https://www.surveymonkey.de/r/JDK9EA*

We would love to hear feedback from you!


Rgds,Rory
--
Rgds,Rory O'Donnell
Quality Engineering Manager
Oracle EMEA , Dublin, Ireland

--
Rgds,Rory O'Donnell
Quality Engineering Manager
Oracle EMEA , Dublin, Ireland



--
Rgds,Rory O'Donnell
Quality Engineering Manager
Oracle EMEA , Dublin, Ireland


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: Early Access build 136 for JDK 9 & JDK 9 with Project Jigsaw are available on java.net

2016-10-05 Thread Mark Thomas 
On 04/10/2016 18:12, Rory O'Donnell wrote:
> Hi Mark,
> 
> There was an update to JDK-8163449 below:
> 
> Caching is enabled by default, but it can be disabled statically (if
> strangely through a non-static api). The fact that files can't be
> deleted on windows is a consequence of this caching, and also that files
> are opened by the Java runtime on windows in a mode that prevents
> deletion. So, really, this isn't a bug and the question is can the
> submitter just disable caching?
> 
> Let me know if that works for you ?

It doesn't.

The caching causes file locking on all operating systems. It is more
obvious on Windows since the OS won't let you delete the file. On Linux
while you can delete the file but the space won't be freed until the
lock is released.

I'm aware of the ability to disable the caching and this is what Tomcat
does to work-around this issue.

The bug was raised because the current default triggers file descriptor
leaks and lock files for JarURLConnection and that seems like a poor
choice for a default.

Equally, I'd rather not have to to disable all caching just to avoid a
problem with one URLConnection sub-class.

My hope was that rather than a single default caching option for all
URLConnections, the default could be configured per protocol and that
the default for the jar protocol would be changed to false.

Mark



> 
> Rgds,Rory
> 
> On 20/09/2016 11:15, Rory O'Donnell wrote:
>>
>> Hi Mark,
>>
>> Early Access b136  for JDK 9 is
>> available on java.net, summary of  changes are listed here
>> .
>> Early Access b136  (#5506) for JDK 9
>> with Project Jigsaw is available on java.net, summary of  changes are
>> listed here
>> .
>>
>> There have been a number of fixes to bugs reported by Open Source
>> projects since the last availability email  :
>>
>>   * 8165723 - b136 - core-libs JarFile::isMultiRelease() method
>> returns false when it should return true
>>   * 8165116 - b136 - xml redirect function is not allowed even with
>> enableExtensionFunctions
>>
>> NOTE:-  Build 135 included a fix for  JDK-8161016 which *has
>> introduced a behavioral change to HttpURLConnection, more info:*
>>
>> The behavior of HttpURLConnection when using a ProxySelector has been
>> modified with this JDK release. Currently, HttpURLConnection.connect()
>> call would fallback to a DIRECT connection attempt if the configured
>> proxy/proxies failed to make a connection. This release introduces a
>> change whereby no DIRECT connection will be attempted in such a
>> scenario. Instead, the HttpURLConnection.connect() method will fail
>> and throw an IOException which occurred from the last proxy tested.
>> This behavior now matches with the HTTP connections made by popular
>> web browsers. But this change will bring compatibility issues for the
>> applications expecting a DIRECT connection when a proxy server is down
>> or when wrong proxies are provided.
>> *
>>
>> JDK 9 Outreach Survey*
>>
>> In order to encourage and receive additional feedback from developers
>> testing their applications with JDK 9,
>> the OpenJDK Quality Outreach effort has put together a very brief
>> survey about your experiences with JDK 9 so far.
>>
>> It is available at***https://www.surveymonkey.de/r/JDK9EA*
>>
>> We would love to hear feedback from you!
>>
>>
>> Rgds,Rory
>> -- 
>> Rgds,Rory O'Donnell
>> Quality Engineering Manager
>> Oracle EMEA , Dublin, Ireland 
> 
> -- 
> Rgds,Rory O'Donnell
> Quality Engineering Manager
> Oracle EMEA , Dublin, Ireland 
> 


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org