Re: [RESULT][VOTE] Release Apache Tomcat 8.0.46

[Violeta Georgieva]

Hi,

2017-08-10 13:55 GMT+03:00 Violeta Georgieva :
>
> The proposed Apache Tomcat 8.0.46 release is now available for voting.
>
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.0.46/
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-1150/
> The svn tag is:
> http://svn.apache.org/repos/asf/tomcat/tc8.0.x/tags/TOMCAT_8_0_46/
>
> The proposed 8.0.46 release is:
> [ ] Broken - do not release
> [ ] Stable - go ahead and release as 8.0.46


+1 (binding):violetagg, mgrigorov, kkolinko, csutherl

No other voters were cast.

The vote has passed.

I'll do the release shortly and announce it once the mirrors catch up.

Regards,
Violeta

[Bug 61441] daemon.sh's auto-detection fails on linux system's where java is installed via an RPM

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=61441

--- Comment #3 from Rainer Jung  ---
What about the following addition, copied and adjusted from the top of the file
where it is used to resolve another possible symlink:

Index: bin/daemon.sh
===
--- bin/daemon.sh   (revision 1805340)
+++ bin/daemon.sh   (working copy)
@@ -94,6 +94,15 @@
 #
 if [ -z "$JAVA_HOME" ]; then
 JAVA_BIN="`which java 2>/dev/null || type java 2>&1`"
+while [ -h "$JAVA_BIN" ]; do
+ls=`ls -ld "$JAVA_BIN"`
+link=`expr "$ls" : '.*-> \(.*\)$'`
+if expr "$link" : '/.*' > /dev/null; then
+JAVA_BIN="$link"
+else
+JAVA_BIN="`dirname $JAVA_BIN`/$link"
+fi
+done
 test -x "$JAVA_BIN" && JAVA_HOME="`dirname $JAVA_BIN`"
 test ".$JAVA_HOME" != . && JAVA_HOME=`cd "$JAVA_HOME/.." >/dev/null; pwd`
 else


Does that work?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 61441] daemon.sh's auto-detection fails on linux system's where java is installed via an RPM

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=61441

--- Comment #2 from Coty Sutherland  ---
Created attachment 35247
  --> https://bz.apache.org/bugzilla/attachment.cgi?id=35247=edit
Another seemingly viable option

Another option is to remove the -java-home option from the JSVC command lines.
Doing so resolves the issue for me because JSVC seems to be able to figure out
what to do on it's own.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 61441] daemon.sh's auto-detection fails on linux system's where java is installed via an RPM

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=61441

--- Comment #1 from Coty Sutherland  ---
Created attachment 35246
  --> https://bz.apache.org/bugzilla/attachment.cgi?id=35246=edit
Option to add fallbacks

This patch would just add a check for JAVA_HOME being /usr and if it is, use
the correct directories for the JDK or JRE installation.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 61441] New: daemon.sh's auto-detection fails on linux system's where java is installed via an RPM

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=61441

Bug ID: 61441
   Summary: daemon.sh's auto-detection fails on linux system's
where java is installed via an RPM
   Product: Tomcat 8
   Version: 8.5.x-trunk
  Hardware: PC
OS: Linux
Status: NEW
  Severity: normal
  Priority: P2
 Component: Packaging
  Assignee: dev@tomcat.apache.org
  Reporter: csuth...@redhat.com
  Target Milestone: 

On RHEL/Centos/Fedora, when java is installed from the RPMs neither JAVA_HOME
nor JRE_HOME environment variables are set. Luckily, the Tomcat startup scripts
are able to auto-detect them but the daemon.sh script cannot properly do so.
The failure is in the JAVA_HOME auto-detection in the script here:

daemon.sh:96:

~~~
JAVA_BIN="`which java 2>/dev/null || type java 2>&1`"
test -x "$JAVA_BIN" && JAVA_HOME="`dirname $JAVA_BIN`"
test ".$JAVA_HOME" != . && JAVA_HOME=`cd "$JAVA_HOME/.." >/dev/null; pwd`
~~~

The problem is that when java is installed from the RPMs, `which java`
evaluates to '/usr/bin/java', which is a symlink maintained by alternatives.
The code snippet above will evaluate to JAVA_HOME and JRE_HOME being set to
'/usr'. Having JRE_HOME set to '/usr' doesn't seem to cause problems for
Tomcat, but the problem manifests itself when running the daemon.sh script:

~~~
# ./daemon.sh start
Cannot find any VM in Java Home /usr
~~~

jsvc is only used in daemon.sh, therefore this problem was not seen when
starting Tomcat using startup.sh or catalina.sh.

I think a good fallback for JAVA_HOME and JRE_HOME is '/usr/lib/jvm/java' and
'/usr/lib/jvm/jre' respectively.

To Reproduce:

1. Install tomcat
2. Install java from RPMs
3. cd $CATALINA_HOME
4. bin/daemon.sh start
5. Observe error mentioned above

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 61439] New: Stop shipping JavaEE APIs as part as tomcat-embed-core

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=61439

Bug ID: 61439
   Summary: Stop shipping JavaEE APIs as part as tomcat-embed-core
   Product: Tomcat 8
   Version: 8.5.x-trunk
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P2
 Component: Packaging
  Assignee: dev@tomcat.apache.org
  Reporter: stephane.nic...@gmail.com
  Target Milestone: 

This relates to #59899 and the support of Java9 which is summarized in this
Spring Boot issue: https://github.com/spring-projects/spring-boot/issues/9366

Essentially, we are wondering if you would consider stop shipping JavaEE APIs
and rather rely on official JAR(s). That way, we (and anyone) could apply
regular build exclusion in case we are shipping it ourselves or if we want to
provide a more recent version.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: [VOTE] Release Apache Tomcat 8.0.46

[Coty Sutherland]

On Thu, Aug 10, 2017 at 6:55 AM, Violeta Georgieva  wrote:
> The proposed Apache Tomcat 8.0.46 release is now available for voting.
>
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.0.46/
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-1150/
> The svn tag is:
> http://svn.apache.org/repos/asf/tomcat/tc8.0.x/tags/TOMCAT_8_0_46/
>
> The proposed 8.0.46 release is:
> [ ] Broken - do not release
> [x] Stable - go ahead and release as 8.0.46

+1

>
> Regards,
> Violeta

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: [VOTE] Release Apache Tomcat 8.0.46

[Konstantin Kolinko]

2017-08-10 13:55 GMT+03:00 Violeta Georgieva :
> The proposed Apache Tomcat 8.0.46 release is now available for voting.
>
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.0.46/
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-1150/
> The svn tag is:
> http://svn.apache.org/repos/asf/tomcat/tc8.0.x/tags/TOMCAT_8_0_46/
>
> The proposed 8.0.46 release is:
> [ ] Broken - do not release
> [x] Stable - go ahead and release as 8.0.46

Unit tests OK.

Smoke testing: an issue when running with Security Manager
https://bz.apache.org/bugzilla/show_bug.cgi?id=61437

I do not treat it as a show stopper, because a workaround via
configuration (preloading a clsss in server.xml) is available.

Best regards,
Konstantin Kolinko

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 61437] 8.0.46: Websockets examples failure with AccessControlException "accessClassInPackage.org.apache.catalina.webresources"

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=61437

--- Comment #2 from Konstantin Kolinko  ---
> StandardRoot.isPackedWarFile(StandardRoot.java:651)

The code there is
[[[
protected boolean isPackedWarFile() {
return main instanceof WarResourceSet && preResources.isEmpty() &&
postResources.isEmpty();
}
]]]

If I configure JreMemoryLeakPreventionListener in server.xml to preload
WarResourceSet class, this issue does not happen.


This is: to work-around this issue, add the following attribute to
JreMemoryLeakPreventionListener configured in conf/server.xml:

[[[
classesToInitialize="org.apache.catalina.webresources.WarResourceSet"
]]]

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 61437] 8.0.46: Websockets examples failure with AccessControlException "accessClassInPackage.org.apache.catalina.webresources"

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=61437

Konstantin Kolinko  changed:

   What|Removed |Added

 OS||All

--- Comment #1 from Konstantin Kolinko  ---
If I start by visiting one of plain Servlet examples - "Hello world", and go to
WebSockets examples after that - all works successfully.

I mean. the following sequence of visits.

http://localhost:8080/examples/
http://localhost:8080/examples/servlets/
http://localhost:8080/examples/servlets/servlet/HelloWorldExample

http://localhost:8080/examples/websocket/index.xhtml
http://localhost:8080/examples/websocket/echo.xhtml
http://localhost:8080/examples/websocket/chat.xhtml
http://localhost:8080/examples/websocket/snake.xhtml
http://localhost:8080/examples/websocket/drawboard.xhtml

If I run without SecurityManager, all runs successfully as well.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 61437] New: 8.0.46: Websockets examples failure with AccessControlException "accessClassInPackage.org.apache.catalina.webresources"

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=61437

Bug ID: 61437
   Summary: 8.0.46: Websockets examples failure with
AccessControlException
"accessClassInPackage.org.apache.catalina.webresources
"
   Product: Tomcat 8
   Version: 8.0.x-trunk
  Hardware: PC
Status: NEW
  Severity: normal
  Priority: P2
 Component: Catalina
  Assignee: dev@tomcat.apache.org
  Reporter: knst.koli...@gmail.com
  Target Milestone: 

Created attachment 35244
  --> https://bz.apache.org/bugzilla/attachment.cgi?id=35244=edit
logs_2017-08-17.zip

Smoke-testing examples webapp of Tomcat 8.0.46 Release Candidate

Configuration:
Java 7u80, configured connector to use NIO protocol

Steps to reproduce:
1. Start Tomcat with SecurityManager enabled
> catalina.bat start -security

2. Go to 'Examples' page, click on Websocket examples

http://localhost:8080/examples/
http://localhost:8080/examples/websocket/index.xhtml

3. Open 4 websocket examples in new browser tabs
http://localhost:8080/examples/websocket/echo.xhtml
http://localhost:8080/examples/websocket/chat.xhtml
http://localhost:8080/examples/websocket/snake.xhtml
http://localhost:8080/examples/websocket/drawboard.xhtml

Result: Snake and Drawboard examples fail immediately, printing "WebSocket
connection closed" messages into their log areas.

In catalina.2017-08-17.log there is exception:

[[[
 java.security.AccessControlException: access denied
("java.lang.RuntimePermission"
"accessClassInPackage.org.apache.catalina.webresources")
at
java.security.AccessControlContext.checkPermission(AccessControlContext.java:372)
at
java.security.AccessController.checkPermission(AccessController.java:559)
at java.lang.SecurityManager.checkPermission(SecurityManager.java:549)
at
java.lang.SecurityManager.checkPackageAccess(SecurityManager.java:1525)
at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:305)
at java.lang.ClassLoader.loadClass(ClassLoader.java:412)
at java.lang.ClassLoader.loadClass(ClassLoader.java:358)
at
org.apache.catalina.webresources.StandardRoot.isPackedWarFile(StandardRoot.java:651)
at
org.apache.catalina.webresources.CachedResource.validateResource(CachedResource.java:96)
at org.apache.catalina.webresources.Cache.getResource(Cache.java:69)
at
org.apache.catalina.webresources.StandardRoot.getResource(StandardRoot.java:216)
at
org.apache.catalina.webresources.StandardRoot.getResource(StandardRoot.java:206)
at
org.apache.catalina.webresources.FileResource.getCodeBase(FileResource.java:224)
at
org.apache.catalina.loader.WebappClassLoaderBase.findClassInternal(WebappClassLoaderBase.java:2499)
at
org.apache.catalina.loader.WebappClassLoaderBase.findClass(WebappClassLoaderBase.java:859)
at
org.apache.catalina.loader.WebappClassLoaderBase.loadClass(WebappClassLoaderBase.java:1302)
at
org.apache.catalina.loader.WebappClassLoaderBase.loadClass(WebappClassLoaderBase.java:1167)
at websocket.snake.SnakeAnnotation.onOpen(SnakeAnnotation.java:78)
]]]

This is followed by
java.lang.NoClassDefFoundError: websocket/snake/SnakeTimer

In localhost.2017-08-17.log there is
java.lang.ClassNotFoundException: websocket.drawboard.DrawboardEndpoint$3


A zip with log files is attached.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[ANN] Apache Tomcat 7.0.81 released

[Violeta Georgieva]

The Apache Tomcat team announces the immediate availability of Apache
Tomcat 7.0.81.

Apache Tomcat is an open source software implementation of the Java
Servlet, JavaServer Pages, Java Expression Language and Java
WebSocket technologies.

This release contains a number of bug fixes and improvements compared to
version 7.0.79. The notable changes since 7.0.79 include:


- Add the ability to set the defaults used by the Windows installer from
  a configuration file. Patch provided by Sandra Madden.

- Add support to the WebSocket client for following redirects when
  attempting to establish a WebSocket connection. Patch provided by J
  Fernandez.


Please refer to the change log for the complete list of changes:
http://tomcat.apache.org/tomcat-7.0-doc/changelog.html

Downloads:
http://tomcat.apache.org/download-70.cgi

Migration guides from Apache Tomcat 5.5.x and 6.0.x:
http://tomcat.apache.org/migration.html

Enjoy

The Apache Tomcat team

svn commit: r21202 - /release/tomcat/tomcat-7/v7.0.79/

[violetagg]

Author: violetagg
Date: Thu Aug 17 09:15:33 2017
New Revision: 21202

Log:
Remove 7.0.79

Removed:
release/tomcat/tomcat-7/v7.0.79/


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r1805271 - in /tomcat/site/trunk/docs/tomcat-7.0-doc: ./ api/ api/org/apache/catalina/ api/org/apache/catalina/ant/ api/org/apache/catalina/ant/jmx/ api/org/apache/catalina/authenticator/

[violetagg]

Author: violetagg
Date: Thu Aug 17 09:12:41 2017
New Revision: 1805271

URL: http://svn.apache.org/viewvc?rev=1805271=rev
Log:
Update docs for Apache Tomcat 7.0.81 release.


[This commit notification would consist of 63 parts, 
which exceeds the limit of 50 ones, so it was shortened to the summary.]

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r1805269 - in /tomcat/site/trunk: ./ docs/ xdocs/

[violetagg]

Author: violetagg
Date: Thu Aug 17 08:58:22 2017
New Revision: 1805269

URL: http://svn.apache.org/viewvc?rev=1805269=rev
Log:
Updates (excluding docs) for 7.0.81 release

Modified:
tomcat/site/trunk/build.properties.default
tomcat/site/trunk/docs/doap_Tomcat.rdf
tomcat/site/trunk/docs/download-70.html
tomcat/site/trunk/docs/index.html
tomcat/site/trunk/docs/migration-7.html
tomcat/site/trunk/docs/oldnews.html
tomcat/site/trunk/docs/whichversion.html
tomcat/site/trunk/xdocs/doap_Tomcat.rdf
tomcat/site/trunk/xdocs/download-70.xml
tomcat/site/trunk/xdocs/index.xml
tomcat/site/trunk/xdocs/migration-7.xml
tomcat/site/trunk/xdocs/oldnews.xml
tomcat/site/trunk/xdocs/whichversion.xml

Modified: tomcat/site/trunk/build.properties.default
URL: 
http://svn.apache.org/viewvc/tomcat/site/trunk/build.properties.default?rev=1805269=1805268=1805269=diff
==
--- tomcat/site/trunk/build.properties.default (original)
+++ tomcat/site/trunk/build.properties.default Thu Aug 17 08:58:22 2017
@@ -37,7 +37,7 @@ tomcat.loc=http://www.apache.org/dist/to
 
 # - Tomcat versions -
 tomcat60=6.0.53
-tomcat70=7.0.79
+tomcat70=7.0.81
 tomcat80=8.0.45
 tomcat85=8.5.20
 tomcat90=9.0.0.M26

Modified: tomcat/site/trunk/docs/doap_Tomcat.rdf
URL: 
http://svn.apache.org/viewvc/tomcat/site/trunk/docs/doap_Tomcat.rdf?rev=1805269=1805268=1805269=diff
==
--- tomcat/site/trunk/docs/doap_Tomcat.rdf (original)
+++ tomcat/site/trunk/docs/doap_Tomcat.rdf Thu Aug 17 08:58:22 2017
@@ -74,8 +74,8 @@
 
   
 Latest Stable 7.0.x Release
-2017-07-01
-7.0.79
+2017-08-16
+7.0.81
   
 
 

Modified: tomcat/site/trunk/docs/download-70.html
URL: 
http://svn.apache.org/viewvc/tomcat/site/trunk/docs/download-70.html?rev=1805269=1805268=1805269=diff
==
--- tomcat/site/trunk/docs/download-70.html (original)
+++ tomcat/site/trunk/docs/download-70.html Thu Aug 17 08:58:22 2017
@@ -213,7 +213,7 @@
 Quick Navigation
 
 
-[define v]7.0.79[end]
+[define v]7.0.81[end]
 https://www.apache.org/dist/tomcat/tomcat-7/KEYS;>KEYS |
 [v] |
 Browse |

Modified: tomcat/site/trunk/docs/index.html
URL: 
http://svn.apache.org/viewvc/tomcat/site/trunk/docs/index.html?rev=1805269=1805268=1805269=diff
==
--- tomcat/site/trunk/docs/index.html (original)
+++ tomcat/site/trunk/docs/index.html Thu Aug 17 08:58:22 2017
@@ -236,6 +236,40 @@ project logo are trademarks of the Apach
 
 
 
+
+2017-08-16 Tomcat 7.0.81 Released
+
+
+
+The Apache Tomcat Project is proud to announce the release of version 7.0.81 of
+Apache Tomcat. This release contains a number of bug fixes and improvements
+compared to version 7.0.79. The notable changes compared to 7.0.79 include:
+
+
+
+
+Add the ability to set the defaults used by the Windows installer from a
+configuration file. Patch provided by Sandra Madden. 
+
+Add support to the WebSocket client for following redirects when attempting
+to establish a WebSocket connection. Patch provided by J Fernandez.
+
+
+
+
+
+Full details of these changes, and all the other changes, are available in the
+Tomcat 7 
changelog.
+
+
+
+
+
+Download
+
+
+
+
 
 2017-08-08 Tomcat 8.5.20 Released
 
@@ -379,41 +413,6 @@ changelog.
 
 
 
-
-
-2017-07-01 Tomcat 7.0.79 Released
-
-
-
-The Apache Tomcat Project is proud to announce the release of version 7.0.79 of
-Apache Tomcat. This release contains a number of bug fixes and improvements
-compared to version 7.0.78. The notable changes compared to 7.0.78 include:
-
-
-
-
-Add a new JULI FileHandler configuration for specifying the maximum number
-of days to keep the log files. By default the log files will be kept
-indefinitely.
-
-Improvements to enable the Manager and HostManager to work in the default
-configuration when working under a security manager.
-
-
-
-
-
-Full details of these changes, and all the other changes, are available in the
-Tomcat 7 
changelog.
-
-
-
-
-
-Download
-
-
-
 
 
 2017-02-21 Tomcat Native 1.2.12 
Released

Modified: tomcat/site/trunk/docs/migration-7.html
URL: 
http://svn.apache.org/viewvc/tomcat/site/trunk/docs/migration-7.html?rev=1805269=1805268=1805269=diff
==
--- tomcat/site/trunk/docs/migration-7.html (original)
+++ tomcat/site/trunk/docs/migration-7.html Thu Aug 17 08:58:22 2017
@@ -1093,7 +1093,8 @@ of Apache Tomcat.
   "7.0.76":"1786169",
   "7.0.77":"1789168",
   "7.0.78":"1794730",
-  "7.0.79":"1799944"
+  "7.0.79":"1799944",
+  "7.0.81":"1804761"
 };
 
 formSubmit.action =