Re: [Bug 61180] Change log level of sessionIdGeneratorBase.createRandom to warn rather than info

[Mark Thomas]

On 24/07/2019 07:58, bugzi...@apache.org wrote:
> https://bz.apache.org/bugzilla/show_bug.cgi?id=61180
> 
> --- Comment #8 from Oscar Dawson  ---

Another idiot blocked and the spam deleted.

FYI, Infra have made some config changes that should reduce the level of
spam.

Mark

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 61180] Change log level of sessionIdGeneratorBase.createRandom to warn rather than info

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=61180

--- Comment #8 from Oscar Dawson  ---
ID generator base is the generation of ID and the component by various kind of
situational forming. The log level succession is also the same criteria in the
link of https://www.thebestessayservice.com/dissertationwriting.html with the
dissertion writing help of the fortune company.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: [Bug 61180] Change log level of sessionIdGeneratorBase.createRandom to warn rather than info

[Mark Thomas]

On 22/07/2019 07:22, bugzi...@apache.org wrote:
> https://bz.apache.org/bugzilla/show_bug.cgi?id=61180
> 
> --- Comment #8 from Oliver Skene <0ltlj...@besttempmail.com> ---

Spam comment deleted. User disabled.

Mark

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 61180] Change log level of sessionIdGeneratorBase.createRandom to warn rather than info

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=61180

--- Comment #8 from Oliver Skene <0ltlj...@besttempmail.com> ---
ID generator base is the generation of ID and the component by various kind of
situational forming. The log level succession is also the same criteria in the
link of https://www.thebestessayservice.com/dissertationwriting.html with the
dissertion writing help of the fortune company.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 61180] Change log level of sessionIdGeneratorBase.createRandom to warn rather than info

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=61180

--- Comment #7 from Piotr Chlebda  ---
Thanks Mark Thomas for a quick response.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 61180] Change log level of sessionIdGeneratorBase.createRandom to warn rather than info

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=61180

--- Comment #6 from Mark Thomas  ---
(In reply to Piotr Chlebda from comment #5)
> 1) Would that be another bug for that ?

Maybe. We need to wait and see if we get any such reports. I'd be surprised to
get such a report where there wasn't an underlying entropy problem.


> 2)I'd like to make sure that my PR was ok, since it was only at trunk
> (version 9). Are there any requirments for PR for other
> version(8.5.x,8.0.x,7.0.x) ?

Bug fixes to trunk are back-ported to earlier versions. The back-ports normally
apply cleanly so no further work is required.

It would be helpful to include a changelog entry when you fix a bug. It saves
the committers a few minutes writing it themselves.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 61180] Change log level of sessionIdGeneratorBase.createRandom to warn rather than info

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=61180

--- Comment #5 from Piotr Chlebda  ---
1) Would that be another bug for that ?
2)I'd like to make sure that my PR was ok, since it was only at trunk (version
9). Are there any requirments for PR for other version(8.5.x,8.0.x,7.0.x) ?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 61180] Change log level of sessionIdGeneratorBase.createRandom to warn rather than info

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=61180

Mark Thomas  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|NEW |RESOLVED

--- Comment #4 from Mark Thomas  ---
I don't see the message on my new(ish) desktop nor my old(ish) laptop. If the
threshold is too low for some systems, we can look at increasing it. My
instinct is that 100ms will be plenty of time for that block of code unless
there is an entropy problem,

I also took the opportunity to clean up some formatting and I added a changelog
entry.

Thanks to Piotr Chlebda for the patch.

Fixed in:
- trunk for 9.0.0.M22 onwards
- 8.5.x for 8.5.16 onwards
- 8.0.x for 8.0.45 onwards
- 7.0.x for 7.0.79 onwards

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 61180] Change log level of sessionIdGeneratorBase.createRandom to warn rather than info

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=61180

--- Comment #3 from Coty Sutherland  ---
Taking another look at the code around the info message I think we may need to
add another check to see if the delay time is larger than 100 ms. If we make
this a warning message as-is I think that everyone's log may have a warning in
it. Should we print an info message if the delay is less than some number (like
30 seconds) and a warning if the delay is greater?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 61180] Change log level of sessionIdGeneratorBase.createRandom to warn rather than info

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=61180

--- Comment #2 from Piotr Chlebda  ---
Hi,
I'm newby as a tomcat contributor and I'd like to take this issue.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 61180] Change log level of sessionIdGeneratorBase.createRandom to warn rather than info

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=61180

Coty Sutherland  changed:

   What|Removed |Added

   Keywords||Beginner

--- Comment #1 from Coty Sutherland  ---
This is the definition of a "Beginner" issue IMO :)

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org