Re: [VOTE] Release Apache Tomcat 10.1.24

2024-05-13 Thread Rainer Jung 

Am 09.05.24 um 20:12 schrieb Christopher Schultz:

The proposed Apache Tomcat 10.1.24 release is now available for
voting.

The notable changes compared to 10.1.23 are:

- Correct error handling for asynchronous requests

- Refactor HTTP header parsing to use common parsing code and fix
   non-blocking reads of chunked request bodies including trailer fields

- WebDAV locking handling fixes

For full details, see the change log:
https://nightlies.apache.org/tomcat/tomcat-10.1.x/docs/changelog.html

Applications that run on Tomcat 9 and earlier will not run on Tomcat 10 
without changes. Java EE applications designed for Tomcat 9 and earlier 
may be placed in the $CATALINA_BASE/webapps-javaee directory and Tomcat 
will automatically convert them to Jakarta EE and copy them to the 
webapps directory.


It can be obtained from:
https://dist.apache.org/repos/dist/dev/tomcat/tomcat-10/v10.1.24/

The Maven staging repo is:
https://repository.apache.org/content/repositories/orgapachetomcat-1494

The tag is:
https://github.com/apache/tomcat/tree/10.1.24
https://github.com/apache/tomcat/commit/f2a274bc00cf73670a614999561c69a391b5e35f

Please reply with a +1 for release or -0/-1 with an explanation.

The proposed 10.1.24 release is:
[ ] Broken - do not release
[X] Stable - go ahead and release as 10.1.24


+1, builds fine (on RHEL8 using OpenJDK 22.0.1+8-16).

The only test failures are sporadic, happen with tcnative and are 
crashes. I observe these for many years now, but this time I have 
checked and all of them happen with NIO2. I use two threads during 
testing and when I checked a few months ago, it seems they are happening 
during shutdown (duplicate pool destruction).


Tested via unit test suite on RHEL 6, 7, 8 and 9, SLES 11, 12 and 15 and 
Solaris 11 using latest patch levels of 11, 17, 21, 22 from Adoptium 
Temurin, Zulu Azul, Amazon Coretto, Oracle and RedHat (the latter only 
on RHEL) plus JDK 23 EA 18. Solaris tests limited to JDK 11. A total of 
124 test runs for NIO+NIO2.


Also ran the few relevant tests for all of these platforms and JVMs in 
combination with tcnative 1.3.0 and 2.0.7 built with OpenSSL 3.0.13, 
3.1.5, 3.2.1 and 3.3.0. A total of 992 test runs for NIO+NIO2. Tests 
assumed to be relevant were 
org/apache/coyote/http2/TestLargeUpload.java,org/apache/**/Test*SSL*.java,org/apache/**/Test*Ssl*.java,org/apache/**/Test*openssl*.java,org/apache/tomcat/util/net/**/Test*.java,org/apache/tomcat/jni/**/Test*.java


Finally ran the relevant tests with JVMs 22 and 23 plus panama for the 
same four OpenSSL versions. A total of 124 test runs.


No testing done for APR connectors.

Test adjustments:

- TestMapperPerformance increased maxTime from 5000 to 25000
- TesterTagHandlerPoolPerformance lowered loop count from 500, to 50
- SimpleHttpClient increased soTimeout from 1 to 2

No unusual test failures, only sporadic crashes in tcnative (nothing 
new, probably during shutdown, running with 2 test threads; this time 
all with NIO2).


- org.apache.catalina.valves.rewrite.TestResolverSSL
rh_jdk17-rhel7.x86_64-tcnative-1.3.0-300-1

- org.apache.coyote.http2.TestLargeUpload
adopt_jdk22-rhel8.x86_64-tcnative-1.3.0-320-1
oracle_jdk17-rhel8.x86_64-tcnative-2.0.7-300-1

- org.apache.tomcat.util.net.TestClientCert
adopt_jdk21-rhel7.x86_64-tcnative-1.3.0-310-2
amazon_jdk22-rhel8.x86_64-tcnative-2.0.7-320-1
oracle_jdk11-rhel6.x86_64-tcnative-1.3.0-330-1
oracle_jdk22-sles11.x86_64-tcnative-2.0.7-330-1
zulu_jdk17-sles11.x86_64-tcnative-1.3.0-330-1
zulu_jdk21-sles12.x86_64-tcnative-2.0.7-320-1

- org.apache.tomcat.util.net.TestCustomSslTrustManager
zulu_jdk17-rhel8.x86_64-tcnative-2.0.7-330-1

- org.apache.tomcat.util.net.TestSSLHostConfigCompat
adopt_jdk11-sles15.x86_64-tcnative-1.3.0-330-1
amazon_jdk11-rhel9.x86_64-tcnative-2.0.7-300-1
oracle_jdk17-rhel7.x86_64-tcnative-2.0.7-330-1
oracle_jdk17-rhel8.x86_64-tcnative-1.3.0-300-1
oracle_jdk22-rhel7.x86_64-tcnative-2.0.7-300-1
oracle_jdk22-rhel8.x86_64-tcnative-1.3.0-320-1
oracle_jdk22-sles15.x86_64-tcnative-1.3.0-320-1
zulu_jdk11-sles15.x86_64-tcnative-1.3.0-310-2
zulu_jdk11-sles15.x86_64-tcnative-2.0.7-300-1
zulu_jdk17-rhel8.x86_64-tcnative-1.3.0-330-1
zulu_jdk17-sles11.x86_64-tcnative-1.3.0-310-2

- org.apache.tomcat.util.net.TestSsl
amazon_jdk11-rhel7.x86_64-tcnative-1.3.0-320-1
amazon_jdk17-sles15.x86_64-tcnative-1.3.0-330-1
oracle_jdk17-rhel7.x86_64-tcnative-1.3.0-330-1

Best regards,

Rainer

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: [VOTE] Release Apache Tomcat 10.1.24

2024-05-10 Thread Christopher Schultz 

Mark,

On 5/10/24 06:26, Mark Thomas wrote:

On 10/05/2024 11:22, Romain Manni-Bucau wrote:

Hi Christopher,

Is it possible to close the staging repo please (I get a 404)?


There is a typo in the VOTE email. The correct staging repo is:
https://repository.apache.org/content/repositories/orgapachetomcat-1495


Thanks for replying about this. Apologies for the typo :/

-chris


Le ven. 10 mai 2024 à 10:00, Mark Thomas  a écrit :


On 09/05/2024 19:12, Christopher Schultz wrote:


The proposed 10.1.24 release is:
[ ] Broken - do not release
[X] Stable - go ahead and release as 10.1.24


Tests pass on Linux, Windows, MacOS (Intel) and MacOS (M1).

Build is cross platform reproducible (Linux / Windows).

Mark

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org






-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: [VOTE] Release Apache Tomcat 10.1.24

2024-05-10 Thread Romain Manni-Bucau 
Thanks Mark.

+1 then, tested on several embed servers which use the standard artifacts
(Yupiik Fusion, Apache Meecrowave apps, ...).

Romain Manni-Bucau
@rmannibucau  |  Blog
 | Old Blog
 | Github  |
LinkedIn  | Book



Le ven. 10 mai 2024 à 12:26, Mark Thomas  a écrit :

> On 10/05/2024 11:22, Romain Manni-Bucau wrote:
> > Hi Christopher,
> >
> > Is it possible to close the staging repo please (I get a 404)?
>
> There is a typo in the VOTE email. The correct staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-1495
>
> Mark
>
>
> >
> > Best,
> > Romain Manni-Bucau
> > @rmannibucau  |  Blog
> >  | Old Blog
> >  | Github <
> https://github.com/rmannibucau> |
> > LinkedIn  | Book
> > <
> https://www.packtpub.com/application-development/java-ee-8-high-performance
> >
> >
> >
> > Le ven. 10 mai 2024 à 10:00, Mark Thomas  a écrit :
> >
> >> On 09/05/2024 19:12, Christopher Schultz wrote:
> >>
> >>> The proposed 10.1.24 release is:
> >>> [ ] Broken - do not release
> >>> [X] Stable - go ahead and release as 10.1.24
> >>
> >> Tests pass on Linux, Windows, MacOS (Intel) and MacOS (M1).
> >>
> >> Build is cross platform reproducible (Linux / Windows).
> >>
> >> Mark
> >>
> >> -
> >> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> >> For additional commands, e-mail: dev-h...@tomcat.apache.org
> >>
> >>
> >
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
>

Re: [VOTE] Release Apache Tomcat 10.1.24

2024-05-10 Thread Mark Thomas 

On 10/05/2024 11:22, Romain Manni-Bucau wrote:

Hi Christopher,

Is it possible to close the staging repo please (I get a 404)?


There is a typo in the VOTE email. The correct staging repo is:
https://repository.apache.org/content/repositories/orgapachetomcat-1495

Mark




Best,
Romain Manni-Bucau
@rmannibucau  |  Blog
 | Old Blog
 | Github  |
LinkedIn  | Book



Le ven. 10 mai 2024 à 10:00, Mark Thomas  a écrit :


On 09/05/2024 19:12, Christopher Schultz wrote:


The proposed 10.1.24 release is:
[ ] Broken - do not release
[X] Stable - go ahead and release as 10.1.24


Tests pass on Linux, Windows, MacOS (Intel) and MacOS (M1).

Build is cross platform reproducible (Linux / Windows).

Mark

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org






-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: [VOTE] Release Apache Tomcat 10.1.24

2024-05-10 Thread Romain Manni-Bucau 
Hi Christopher,

Is it possible to close the staging repo please (I get a 404)?

Best,
Romain Manni-Bucau
@rmannibucau  |  Blog
 | Old Blog
 | Github  |
LinkedIn  | Book



Le ven. 10 mai 2024 à 10:00, Mark Thomas  a écrit :

> On 09/05/2024 19:12, Christopher Schultz wrote:
>
> > The proposed 10.1.24 release is:
> > [ ] Broken - do not release
> > [X] Stable - go ahead and release as 10.1.24
>
> Tests pass on Linux, Windows, MacOS (Intel) and MacOS (M1).
>
> Build is cross platform reproducible (Linux / Windows).
>
> Mark
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
>

Re: [VOTE] Release Apache Tomcat 10.1.24

2024-05-10 Thread Mark Thomas 

On 09/05/2024 19:12, Christopher Schultz wrote:


The proposed 10.1.24 release is:
[ ] Broken - do not release
[X] Stable - go ahead and release as 10.1.24


Tests pass on Linux, Windows, MacOS (Intel) and MacOS (M1).

Build is cross platform reproducible (Linux / Windows).

Mark

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: [VOTE] Release Apache Tomcat 10.1.24

2024-05-09 Thread Rémy Maucherat 
On Thu, May 9, 2024 at 8:12 PM Christopher Schultz
 wrote:
>
> The proposed Apache Tomcat 10.1.24 release is now available for
> voting.
>
> The notable changes compared to 10.1.23 are:
>
> - Correct error handling for asynchronous requests
>
> - Refactor HTTP header parsing to use common parsing code and fix
>non-blocking reads of chunked request bodies including trailer fields
>
> - WebDAV locking handling fixes
>
> For full details, see the change log:
> https://nightlies.apache.org/tomcat/tomcat-10.1.x/docs/changelog.html
>
> Applications that run on Tomcat 9 and earlier will not run on Tomcat 10
> without changes. Java EE applications designed for Tomcat 9 and earlier
> may be placed in the $CATALINA_BASE/webapps-javaee directory and Tomcat
> will automatically convert them to Jakarta EE and copy them to the
> webapps directory.
>
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-10/v10.1.24/
>
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-1494
>
> The tag is:
> https://github.com/apache/tomcat/tree/10.1.24
> https://github.com/apache/tomcat/commit/f2a274bc00cf73670a614999561c69a391b5e35f
>
> Please reply with a +1 for release or -0/-1 with an explanation.
>
> The proposed 10.1.24 release is:
> [ ] Broken - do not release
> [X] Stable - go ahead and release as 10.1.24

Rémy

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: [VOTE] Release Apache Tomcat 10.1.24

2024-05-09 Thread Christopher Schultz 

All,

On 5/9/24 14:12, Christopher Schultz wrote:

The proposed Apache Tomcat 10.1.24 release is now available for
voting.

The notable changes compared to 10.1.23 are:

- Correct error handling for asynchronous requests

- Refactor HTTP header parsing to use common parsing code and fix
   non-blocking reads of chunked request bodies including trailer fields

- WebDAV locking handling fixes

For full details, see the change log:
https://nightlies.apache.org/tomcat/tomcat-10.1.x/docs/changelog.html

Applications that run on Tomcat 9 and earlier will not run on Tomcat 10 
without changes. Java EE applications designed for Tomcat 9 and earlier 
may be placed in the $CATALINA_BASE/webapps-javaee directory and Tomcat 
will automatically convert them to Jakarta EE and copy them to the 
webapps directory.


It can be obtained from:
https://dist.apache.org/repos/dist/dev/tomcat/tomcat-10/v10.1.24/

The Maven staging repo is:
https://repository.apache.org/content/repositories/orgapachetomcat-1494

The tag is:
https://github.com/apache/tomcat/tree/10.1.24
https://github.com/apache/tomcat/commit/f2a274bc00cf73670a614999561c69a391b5e35f

Please reply with a +1 for release or -0/-1 with an explanation.

The proposed 10.1.24 release is:
[ ] Broken - do not release
[ ] Stable - go ahead and release as 10.1.24


+1 for stable release

The build is 100% reproducible on MacOS x86-64.

Unit tests pass on MacOS aarch64 and x86-84.

Details:

* Environment
*  Java (build):openjdk version "22.0.1" 2024-04-16 OpenJDK Runtime 
Environment Temurin-22.0.1+8 (build 22.0.1+8) OpenJDK 64-Bit Server VM 
Temurin-22.0.1+8 (build 22.0.1+8, mixed mode)
*  Java (test): openjdk version "22.0.1" 2024-04-16 OpenJDK Runtime 
Environment Temurin-22.0.1+8 (build 22.0.1+8) OpenJDK 64-Bit Server VM 
Temurin-22.0.1+8 (build 22.0.1+8, mixed mode)
*  Ant: Apache Ant(TM) version 1.10.14 compiled on August 16 
2023

*  OS:  Darwin 23.4.0 arm64
*  cc:  Apple clang version 15.0.0 (clang-1500.3.9.4)
*  make:GNU Make 3.81
*  OpenSSL: OpenSSL 3.2.0 23 Nov 2023 (Library: OpenSSL 3.2.0 23 
Nov 2023)

*  APR: 1.7.4
*
* Valid SHA-512 signature for apache-tomcat-10.1.24.zip
* Valid GPG signature for apache-tomcat-10.1.24.zip
* Valid SHA-512 signature for apache-tomcat-10.1.24.tar.gz
* Valid GPG signature for apache-tomcat-10.1.24.tar.gz
* Valid SHA-512 signature for apache-tomcat-10.1.24.exe
* Valid GPG signature for apache-tomcat-10.1.24.exe
* Valid SHA512 signature for apache-tomcat-10.1.24-src.zip
* Valid GPG signature for apache-tomcat-10.1.24-src.zip
* Valid SHA512 signature for apache-tomcat-10.1.24-src.tar.gz
* Valid GPG signature for apache-tomcat-10.1.24-src.tar.gz
*
* Binary Zip and tarball: Same
* Source Zip and tarball: Same
*
* Building dependencies returned: 0
* tcnative builds cleanly
* Tomcat builds cleanly
* Junit Tests: PASSED

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[VOTE] Release Apache Tomcat 10.1.24

2024-05-09 Thread Christopher Schultz 

The proposed Apache Tomcat 10.1.24 release is now available for
voting.

The notable changes compared to 10.1.23 are:

- Correct error handling for asynchronous requests

- Refactor HTTP header parsing to use common parsing code and fix
  non-blocking reads of chunked request bodies including trailer fields

- WebDAV locking handling fixes

For full details, see the change log:
https://nightlies.apache.org/tomcat/tomcat-10.1.x/docs/changelog.html

Applications that run on Tomcat 9 and earlier will not run on Tomcat 10 
without changes. Java EE applications designed for Tomcat 9 and earlier 
may be placed in the $CATALINA_BASE/webapps-javaee directory and Tomcat 
will automatically convert them to Jakarta EE and copy them to the 
webapps directory.


It can be obtained from:
https://dist.apache.org/repos/dist/dev/tomcat/tomcat-10/v10.1.24/

The Maven staging repo is:
https://repository.apache.org/content/repositories/orgapachetomcat-1494

The tag is:
https://github.com/apache/tomcat/tree/10.1.24
https://github.com/apache/tomcat/commit/f2a274bc00cf73670a614999561c69a391b5e35f

Please reply with a +1 for release or -0/-1 with an explanation.

The proposed 10.1.24 release is:
[ ] Broken - do not release
[ ] Stable - go ahead and release as 10.1.24

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org