Bug in modal window.onBeforeRender - tests

2009-07-19 Thread Martin Makundi
Hi!

For some reason ModalWindow assumes request is not ajax even though it
is clicked via executeAjaxEvent:
if (getWebRequest().isAjax() == false)
{
shown = false; // This hides the button
}

Thread [main] (Suspended (breakpoint at line 3191 in Component))
SettingsModalPanelContents$8$3$1(Component).setVisible(boolean) line: 
3191  
ModalWindow.onBeforeRender() line: 820  
ModalWindow(Component).internalBeforeRender() line: 1061
ModalWindow(Component).beforeRender() line: 1095
RedirectPageRequestTarget(PageRequestTarget).respond(RequestCycle) 
line: 63 

WicketTester(MockWebApplication).postProcessRequestCycle(WebRequestCycle)
line: 558
WicketTester(MockWebApplication).processRequestCycle(WebRequestCycle)
line: 517
WicketTester(BaseWicketTester).executeAjaxEvent(Component, String) 
line: 1233   
WicketTester(BaseWicketTester).executeAjaxEvent(String, String) line: 
1109  
TestSettings.testModalSettings() line: 157  
NativeMethodAccessorImpl.invoke0(Method, Object, Object[]) line: not
available [native method]
NativeMethodAccessorImpl.invoke(Object, Object[]) line: not available   
DelegatingMethodAccessorImpl.invoke(Object, Object[]) line: not 
available   
Method.invoke(Object, Object...) line: not available

So the test fails with no good reason when the modal window assumes it
is not visible.

Basically what the test does is the following:
1. submit form
2. click links
3. executeajaxevent
4. submit form
5. executeajaxevent to open modal window
6. exceuteajaxevent on a button on the modal window fails

I found a workaround by placing tester.setupRequestAndResponse()
just before line 5. Ofcourse a true fix would we nice.

**
Martin


wicketstuff rc7 deployment

2009-07-19 Thread Antony Stubbs
Are the wicketstuff rc1-[-2]-7 releases (excluding rc2) not being  
deployed? I see we have a rc8-snapshot deployed.


http://wicketstuff.org/maven/repository/org/wicketstuff/gmap2/

Regards,
Antony Stubbs

Talk to me about Wicket, Spring, Maven consulting, small scale  
outsourcing to Australasia and India and Open Source development!


Check out the Spring Modules fork at http://wiki.github.com/astubbs/spring-modules 
 ! We've just done the first release of the project in over a year!


Website: http://sharca.com
Blog: http://stubbisms.wordpress.com
Linked In: http://www.linkedin.com/in/antonystubbs
Podcast: http://www.illegalargument.com



Re: wicketstuff rc7 deployment

2009-07-19 Thread Jeremy Thomerson
They haven't been auto-deployed by any means.  I built an rc2 and
deployed it.  I did build an rc7 release last week, but have not
deployed it to the repos yet.

rc8-SNAPSHOT should actually be just 1.4-SNAPSHOT - I'll work on both
these things this week.

--
Jeremy Thomerson
http://www.wickettraining.com




On Sun, Jul 19, 2009 at 9:14 PM, Antony Stubbsantony.stu...@gmail.com wrote:
 Are the wicketstuff rc1-[-2]-7 releases (excluding rc2) not being deployed?
 I see we have a rc8-snapshot deployed.

 http://wicketstuff.org/maven/repository/org/wicketstuff/gmap2/
 Regards,
 Antony Stubbs
 Talk to me about Wicket, Spring, Maven consulting, small scale outsourcing
 to Australasia and India and Open Source development!
 Check out the Spring Modules fork at
 http://wiki.github.com/astubbs/spring-modules ! We've just done the first
 release of the project in over a year!
 Website: http://sharca.com
 Blog: http://stubbisms.wordpress.com
 Linked In: http://www.linkedin.com/in/antonystubbs
 Podcast: http://www.illegalargument.com



Re: wicketstuff rc7 deployment

2009-07-19 Thread Antony Stubbs
That would be great. Am just trying to cut a release of my project and  
bumped into the issue that a non-snapshot wasn't available that had my  
fix in it. So am no downloading the 1.7 tag and building it myself to  
release into out repo.


btw - is it possible to get access to the wicket-stuff jira? I  
committed a fix for an issue which needs closing - http://wicketstuff.org/jira/browse/WSGMAPP-7


On 20/07/2009, at 2:43 PM, Jeremy Thomerson wrote:


They haven't been auto-deployed by any means.  I built an rc2 and
deployed it.  I did build an rc7 release last week, but have not
deployed it to the repos yet.

rc8-SNAPSHOT should actually be just 1.4-SNAPSHOT - I'll work on both
these things this week.

--
Jeremy Thomerson
http://www.wickettraining.com




On Sun, Jul 19, 2009 at 9:14 PM, Antony  
Stubbsantony.stu...@gmail.com wrote:
Are the wicketstuff rc1-[-2]-7 releases (excluding rc2) not being  
deployed?

I see we have a rc8-snapshot deployed.

http://wicketstuff.org/maven/repository/org/wicketstuff/gmap2/
Regards,
Antony Stubbs
Talk to me about Wicket, Spring, Maven consulting, small scale  
outsourcing

to Australasia and India and Open Source development!
Check out the Spring Modules fork at
http://wiki.github.com/astubbs/spring-modules ! We've just done the  
first

release of the project in over a year!
Website: http://sharca.com
Blog: http://stubbisms.wordpress.com
Linked In: http://www.linkedin.com/in/antonystubbs
Podcast: http://www.illegalargument.com