Consistent ue of generics etc in Wicket
Dear Wicket team, what is your policy regarding the (consistent) use of Java 5 features such as generics in Wicket and related projects (extensions etc)? I was looking into https://issues.apache.org/jira/browse/WICKET-2949 and the Select class which does not use generics currently. This gives some 10 compiler warnings (at least in my Eclipse configuration). The problem with adding generics to classes like Select is that it will potentially result in compiler warnings in client code. So, adding generics when touching some code to fix a bug might be fine for 1.5 but might annoy people when done on 1.4.x? But generics do have some advantages, right? And therefore should be used where and when possible... What is your suggestion about how to handle this? What is the general rule when working on trunk / 1.5? Thank you Cheers, Erich
Re: Consistent ue of generics etc in Wicket
In 1.5 (which is trunk) everything can be changed/improved. 1.4 is a drop-in replacement for 1.3 - no changes to the API - except for adding generics. 1.4 is recommended for production. Juergen On Mon, Jul 26, 2010 at 11:08 AM, Erich W Schreiner eschrei...@yahoo.com wrote: Dear Wicket team, what is your policy regarding the (consistent) use of Java 5 features such as generics in Wicket and related projects (extensions etc)? I was looking into https://issues.apache.org/jira/browse/WICKET-2949 and the Select class which does not use generics currently. This gives some 10 compiler warnings (at least in my Eclipse configuration). The problem with adding generics to classes like Select is that it will potentially result in compiler warnings in client code. So, adding generics when touching some code to fix a bug might be fine for 1.5 but might annoy people when done on 1.4.x? But generics do have some advantages, right? And therefore should be used where and when possible... What is your suggestion about how to handle this? What is the general rule when working on trunk / 1.5? Thank you Cheers, Erich
RE: [jira] Resolved: (WICKET-2966) markupStream field in MarkupException breaks Exception's Serializable contract.
Could you please remove me from this mailing list.
Best regards,
Steven
Steven Tierney
Bright Purple Resourcing Ltd
Senior ConsultantBR
The Eagle Building, 19 Rose Street, Edinburgh, EH2 2PR
Office: +44 131 473 7045 (Direct Line)
+44 131 473 7030
Fax: +44 131 473 7040
Website: www.brightpurple.co.uk
Twitter: twitter.com/BrightPurpleR
Bright Purple Resourcing - “PERFECTLY PLACING PROFESSIONALS SINCE 1995”
Think before you print. Please do not print this email unless you really need
to.
Any views or opinions presented in this email are solely
those of the author and do not necessarily represent those of the company.
Employees of Bright Purple Resourcing are expressly required not to make
defamatory statements and not to infringe or authorise any infringement of
copyright or any other legal right by email communications. Any such
communication is contrary to company policy and outside the scope of the
employment of the individual concerned. The company will not accept any
liability in respect of such communication, and the employee responsible will
be personally liable for any damages or other liability arising. This email and
any files transmitted with it are confidential and intended solely for the use
of the individual or entity to whom they are addressed. If you have received
this email in error please notify the system manager.-Original Message-
From: Juergen Donnerstag (JIRA) [mailto:j...@apache.org]
Sent: 26 July 2010 11:22
To: comm...@wicket.apache.org
Subject: [jira] Resolved: (WICKET-2966) markupStream field in MarkupException
breaks Exception's Serializable contract.
[
https://issues.apache.org/jira/browse/WICKET-2966?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Juergen Donnerstag resolved WICKET-2966.
Assignee: Juergen Donnerstag
Fix Version/s: 1.4.10
1.5-M1
Resolution: Fixed
markupStream field in MarkupException breaks Exception's Serializable
contract.
-
Key: WICKET-2966
URL: https://issues.apache.org/jira/browse/WICKET-2966
Project: Wicket
Issue Type: Bug
Components: wicket
Affects Versions: 1.4.7
Reporter: Maarten Billemont
Assignee: Juergen Donnerstag
Fix For: 1.4.10, 1.5-M1
{code}
private org.apache.wicket.markup.MarkupStream
org.apache.wicket.markup.MarkupException.markupStream
[class=org.apache.wicket.markup.MarkupStream] - field that is not
serializable
{code}
Exceptions have the contract of being serializable. That means, all their
fields have to be serializable; otherwise you break that contract. I think
for Wicket especially, it is important to respect and honor that contract.
Therefore, MarkupException (or any other Wicket exceptions) should not
contain any non-serializable objects in their fields. Either the
markupException field should become transient or it should be replaced with a
serializable view of it.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
This footnote confirms that this email message has been swept by MIMEsweeper
for the presence of computer viruses.
Bright Purple Resourcing Ltd is a company registered in Scotland with company
number SC155147. VAT Number 658 2716 10.
Registered office address: Eagle Building, 19 Rose Street, Edinburgh. EH2 2PR
www.brightpurple.co.uk
RE: [jira] Resolved: (WICKET-2966) markupStream field in MarkupException breaks Exception's Serializable contract.
Could you please remove me from this mailing list.
Best regards,
Steven
Steven Tierney
Bright Purple Resourcing Ltd
Senior ConsultantBR
The Eagle Building, 19 Rose Street, Edinburgh, EH2 2PR
Office: +44 131 473 7045 (Direct Line)
+44 131 473 7030
Fax: +44 131 473 7040
Website: www.brightpurple.co.uk
Twitter: twitter.com/BrightPurpleR
Bright Purple Resourcing - “PERFECTLY PLACING PROFESSIONALS SINCE 1995”
Think before you print. Please do not print this email unless you really need
to.
Any views or opinions presented in this email are solely
those of the author and do not necessarily represent those of the company.
Employees of Bright Purple Resourcing are expressly required not to make
defamatory statements and not to infringe or authorise any infringement of
copyright or any other legal right by email communications. Any such
communication is contrary to company policy and outside the scope of the
employment of the individual concerned. The company will not accept any
liability in respect of such communication, and the employee responsible will
be personally liable for any damages or other liability arising. This email and
any files transmitted with it are confidential and intended solely for the use
of the individual or entity to whom they are addressed. If you have received
this email in error please notify the system manager.-Original Message-
From: Juergen Donnerstag (JIRA) [mailto:j...@apache.org]
Sent: 26 July 2010 11:22
To: comm...@wicket.apache.org
Subject: [jira] Resolved: (WICKET-2966) markupStream field in MarkupException
breaks Exception's Serializable contract.
[
https://issues.apache.org/jira/browse/WICKET-2966?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Juergen Donnerstag resolved WICKET-2966.
Assignee: Juergen Donnerstag
Fix Version/s: 1.4.10
1.5-M1
Resolution: Fixed
markupStream field in MarkupException breaks Exception's Serializable
contract.
-
Key: WICKET-2966
URL: https://issues.apache.org/jira/browse/WICKET-2966
Project: Wicket
Issue Type: Bug
Components: wicket
Affects Versions: 1.4.7
Reporter: Maarten Billemont
Assignee: Juergen Donnerstag
Fix For: 1.4.10, 1.5-M1
{code}
private org.apache.wicket.markup.MarkupStream
org.apache.wicket.markup.MarkupException.markupStream
[class=org.apache.wicket.markup.MarkupStream] - field that is not
serializable
{code}
Exceptions have the contract of being serializable. That means, all their
fields have to be serializable; otherwise you break that contract. I think
for Wicket especially, it is important to respect and honor that contract.
Therefore, MarkupException (or any other Wicket exceptions) should not
contain any non-serializable objects in their fields. Either the
markupException field should become transient or it should be replaced with a
serializable view of it.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
This footnote confirms that this email message has been swept by MIMEsweeper
for the presence of computer viruses.
Bright Purple Resourcing Ltd is a company registered in Scotland with company
number SC155147. VAT Number 658 2716 10.
Registered office address: Eagle Building, 19 Rose Street, Edinburgh. EH2 2PR
www.brightpurple.co.uk
Re: [jira] Resolved: (WICKET-2966) markupStream field in MarkupException breaks Exception's Serializable contract.
You can do it by sending an email to dev-unsubscr...@wicket.apache.org
On Mon, Jul 26, 2010 at 12:46 PM, Steven Tierney
steven.tier...@brightpurple.co.uk wrote:
Could you please remove me from this mailing list.
Best regards,
Steven
Steven Tierney
Bright Purple Resourcing Ltd
Senior ConsultantBR
The Eagle Building, 19 Rose Street, Edinburgh, EH2 2PR
Office: +44 131 473 7045 (Direct Line)
+44 131 473 7030
Fax: +44 131 473 7040
Website: www.brightpurple.co.uk
Twitter: twitter.com/BrightPurpleR
Bright Purple Resourcing - “PERFECTLY PLACING PROFESSIONALS SINCE 1995”
Think before you print. Please do not print this email unless you really
need to.
Any views or opinions presented in this email are solely
those of the author and do not necessarily represent those of the company.
Employees of Bright Purple Resourcing are expressly required not to make
defamatory statements and not to infringe or authorise any infringement of
copyright or any other legal right by email communications. Any such
communication is contrary to company policy and outside the scope of the
employment of the individual concerned. The company will not accept any
liability in respect of such communication, and the employee responsible
will be personally liable for any damages or other liability arising. This
email and any files transmitted with it are confidential and intended solely
for the use of the individual or entity to whom they are addressed. If you
have received this email in error please notify the system
manager.-Original Message-
From: Juergen Donnerstag (JIRA) [mailto:j...@apache.org]
Sent: 26 July 2010 11:22
To: comm...@wicket.apache.org
Subject: [jira] Resolved: (WICKET-2966) markupStream field in
MarkupException breaks Exception's Serializable contract.
[
https://issues.apache.org/jira/browse/WICKET-2966?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel]
Juergen Donnerstag resolved WICKET-2966.
Assignee: Juergen Donnerstag
Fix Version/s: 1.4.10
1.5-M1
Resolution: Fixed
markupStream field in MarkupException breaks Exception's Serializable
contract.
-
Key: WICKET-2966
URL: https://issues.apache.org/jira/browse/WICKET-2966
Project: Wicket
Issue Type: Bug
Components: wicket
Affects Versions: 1.4.7
Reporter: Maarten Billemont
Assignee: Juergen Donnerstag
Fix For: 1.4.10, 1.5-M1
{code}
private org.apache.wicket.markup.MarkupStream
org.apache.wicket.markup.MarkupException.markupStream
[class=org.apache.wicket.markup.MarkupStream] - field that is not
serializable
{code}
Exceptions have the contract of being serializable. That means, all
their fields have to be serializable; otherwise you break that contract. I
think for Wicket especially, it is important to respect and honor that
contract. Therefore, MarkupException (or any other Wicket exceptions)
should not contain any non-serializable objects in their fields. Either the
markupException field should become transient or it should be replaced with
a serializable view of it.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
This footnote confirms that this email message has been swept by
MIMEsweeper for the presence of computer viruses.
Bright Purple Resourcing Ltd is a company registered in Scotland with
company number SC155147. VAT Number 658 2716 10.
Registered office address: Eagle Building, 19 Rose Street, Edinburgh. EH2
2PR
www.brightpurple.co.uk
Re: [jira] Commented: (WICKET-2967) org.apache.wicket.util.value.Count: add decrement method
It's an automated list so you are responsible for both subscribing and
unsubscribing yourself.
**
Martin
2010/7/26 Steven Tierney steven.tier...@brightpurple.co.uk:
Please un subscribe me from this mailing list
Thanks
Steven Tierney
Bright Purple Resourcing Ltd
Senior ConsultantBR
The Eagle Building, 19 Rose Street, Edinburgh, EH2 2PR
Office: +44 131 473 7045 (Direct Line)
+44 131 473 7030
Fax: +44 131 473 7040
Website: www.brightpurple.co.uk
Twitter: twitter.com/BrightPurpleR
Bright Purple Resourcing - “PERFECTLY PLACING PROFESSIONALS SINCE 1995”
Think before you print. Please do not print this email unless you really need
to.
Any views or opinions presented in this email are solely
those of the author and do not necessarily represent those of the company.
Employees of Bright Purple Resourcing are expressly required not to make
defamatory statements and not to infringe or authorise any infringement of
copyright or any other legal right by email communications. Any such
communication is contrary to company policy and outside the scope of the
employment of the individual concerned. The company will not accept any
liability in respect of such communication, and the employee responsible will
be personally liable for any damages or other liability arising. This email
and any files transmitted with it are confidential and intended solely for
the use of the individual or entity to whom they are addressed. If you have
received this email in error please notify the system manager.-Original
Message-
From: Hudson (JIRA) [mailto:j...@apache.org]
Sent: 26 July 2010 12:13
To: comm...@wicket.apache.org
Subject: [jira] Commented: (WICKET-2967) org.apache.wicket.util.value.Count:
add decrement method
[
https://issues.apache.org/jira/browse/WICKET-2967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12892262#action_12892262
]
Hudson commented on WICKET-2967:
Integrated in Apache Wicket 1.4.x #62 (See
[http://hudson.zones.apache.org/hudson/job/Apache%20Wicket%201.4.x/62/])
fixed: org.apache.wicket.util.value.Count: add decrement method
Issue: WICKET-2967
org.apache.wicket.util.value.Count: add decrement method
Key: WICKET-2967
URL: https://issues.apache.org/jira/browse/WICKET-2967
Project: Wicket
Issue Type: Wish
Components: wicket
Affects Versions: 1.4.9
Reporter: Ralf Eichinger
Assignee: Juergen Donnerstag
Priority: Trivial
Fix For: 1.4.10, 1.5-M1
Original Estimate: 0.17h
Remaining Estimate: 0.17h
Wicket-Examples (LinkPage) use examples specific ClickCount-model class.
Should use org.apache.wicket.util.value.Count class (to promote the use of
it).
For being usable for all examples, the Count-class needs this additional
method:
/**
* Decreases the count value by one.
*/
public void decrement() {
count--;
}
and a setCount(int count) method.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
This footnote confirms that this email message has been swept by MIMEsweeper
for the presence of computer viruses.
Bright Purple Resourcing Ltd is a company registered in Scotland with company
number SC155147. VAT Number 658 2716 10.
Registered office address: Eagle Building, 19 Rose Street, Edinburgh. EH2 2PR
www.brightpurple.co.uk
Re: Examples for the new request mappers
On Sat, Jul 24, 2010 at 1:53 PM, Martin Makundi martin.maku...@koodaripalvelut.com wrote: Any brief what this is all about ;) ? Sounds interesting but I don't have any clue. Any selected links to previous discussion on the topic? The new URL mapping features in 1.5 (trunk). Jeremy Thomerson http://www.wickettraining.com
