Re: [wicketstuff] core pom - not used dependencies
Hi Attila, Feel free to improve these projects however you find appropriate. Some of us watch the activity in wicketstuff-core and we will comment if we see anything suspicious. There is also Hudson build that will tell you if you break something. martin-g On Sun, Feb 20, 2011 at 9:23 PM, Attila Király kiralyattila...@gmail.comwrote: Hi! I noticed that there are a lot of dependencies in the dependencyManagement section of wicketstuff-core/pom.xml that are actually not used by the modules at all or the modules define the version for it (for example: commons-dbutils, lucene, spring-hibernate3). Are these definitions needed or could they be removed? Attila
Re: [wicketstuff] core pom - not used dependencies
Hi! 2011/2/21 Erik van Oosten e.vanoos...@grons.nl Hi Attila, Are you sure they are not used? They could be used transitively. No, I am not sure that's why I am asking. I searched the poms, the java files and mvn dependency:tree reports but none of them contained the examples I mentioned before. Anyways, in order for core to be consistent, having versions in the modules is not desirable if they are already in the core pom. I agree with you but this is not the case. A lot of modules define the versions for their dependencies. Regards, Erik. Op 20-02-11 20:23, Attila Király wrote: Hi! I noticed that there are a lot of dependencies in the dependencyManagement section of wicketstuff-core/pom.xml that are actually not used by the modules at all or the modules define the version for it (for example: commons-dbutils, lucene, spring-hibernate3). Are these definitions needed or could they be removed? Attila -- Sent from my SMTP compliant software Erik van Oosten http://day-to-day-stuff.blogspot.com/
Re: 1.4.16 - adding methods to IBehavior
why not just introduce that interface and the impl in component? So why also alter abstract behavior? Because that would mean that suddenly almost all the behaviors that are used are suddenly also IComponentConfigurationBehavior And 99.9% of them don't do anything. On Sat, Feb 19, 2011 at 04:17, Jeremy Thomerson jer...@wickettraining.com wrote: What does everyone think about the following patch [1] to add two methods to IBehavior? Obviously, it's not added directly to IBehavior since that would be a breaking API change. It's added to a sub-interface that can optionally be implemented by IBehaviors and is implemented by AbstractBehavior by default. It's for the purpose of allowing behaviors to contribute to things like the visibility and enabled status of a component, which they can't currently do in beforeRender because that happens during the render cycle, at which time such changes are not allowed. [1] - http://mysticpaste.com/view/8231 -- Jeremy Thomerson http://wickettraining.com *Need a CMS for Wicket? Use Brix! http://brixcms.org*
Re: [vote] release wicket 1.5-rc2
+1 to release it Tested : - create quickstart from the staging repo, - checkout the branch from svn and build - test most of the wicket-examples and I didn't found a single issue just one minor thing: the version is 1.5-rc2 (lower case 'rc'), while the previous was 1.5-RC1. This confused me in the beginning. On Mon, Feb 21, 2011 at 6:34 AM, Igor Vaynberg igor.vaynb...@gmail.comwrote: This vote is to release wicket 1.5-rc2 Branch: http://svn.apache.org/repos/asf/wicket/branches/wicket-1.5-rc2/ Artifacts: http://people.apache.org/~ivaynberg/wicket-1.5-rc2/dist Maven repo: https://repository.apache.org/content/repositories/orgapachewicket-031/ Changelog: https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310561version=12316059 This vote ends Wednesday, February 23 at 9:00am (GMT-8) Please test the release and offer your vote. -igor
Re: [vote] release wicket 1.5-rc2
+1 Also some quick testing on wicket-examples On Mon, Feb 21, 2011 at 11:58 AM, Martin Grigorov mgrigo...@apache.orgwrote: +1 to release it Tested : - create quickstart from the staging repo, - checkout the branch from svn and build - test most of the wicket-examples and I didn't found a single issue just one minor thing: the version is 1.5-rc2 (lower case 'rc'), while the previous was 1.5-RC1. This confused me in the beginning. On Mon, Feb 21, 2011 at 6:34 AM, Igor Vaynberg igor.vaynb...@gmail.com wrote: This vote is to release wicket 1.5-rc2 Branch: http://svn.apache.org/repos/asf/wicket/branches/wicket-1.5-rc2/ Artifacts: http://people.apache.org/~ivaynberg/wicket-1.5-rc2/dist Maven repo: https://repository.apache.org/content/repositories/orgapachewicket-031/ Changelog: https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310561version=12316059 This vote ends Wednesday, February 23 at 9:00am (GMT-8) Please test the release and offer your vote. -igor
Re: [vote] release wicket 1.5-rc2
+1 Am 21.02.2011 um 16:03 schrieb Francisco Diaz Trepat - gmail: +1 Also some quick testing on wicket-examples On Mon, Feb 21, 2011 at 11:58 AM, Martin Grigorov mgrigo...@apache.orgwrote: +1 to release it Tested : - create quickstart from the staging repo, - checkout the branch from svn and build - test most of the wicket-examples and I didn't found a single issue just one minor thing: the version is 1.5-rc2 (lower case 'rc'), while the previous was 1.5-RC1. This confused me in the beginning. On Mon, Feb 21, 2011 at 6:34 AM, Igor Vaynberg igor.vaynb...@gmail.com wrote: This vote is to release wicket 1.5-rc2 Branch: http://svn.apache.org/repos/asf/wicket/branches/wicket-1.5-rc2/ Artifacts: http://people.apache.org/~ivaynberg/wicket-1.5-rc2/dist Maven repo: https://repository.apache.org/content/repositories/orgapachewicket-031/ Changelog: https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310561version=12316059 This vote ends Wednesday, February 23 at 9:00am (GMT-8) Please test the release and offer your vote. -igor
Re: [vote] release wicket 1.5-rc2
Hi Igor, I think you've missed jar wicket-core.jar in artifacts. I can't find it in lib folder. Bye. This vote is to release wicket 1.5-rc2 Branch: http://svn.apache.org/repos/asf/wicket/branches/wicket-1.5-rc2/ Artifacts: http://people.apache.org/~ivaynberg/wicket-1.5-rc2/dist Maven repo: https://repository.apache.org/content/repositories/orgapachewicket-031/ Changelog: https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310561version=12316059 This vote ends Wednesday, February 23 at 9:00am (GMT-8) Please test the release and offer your vote. -igor
Re: [vote] release wicket 1.5-rc2
On Mon, Feb 21, 2011 at 6:06 PM, Andrea Del Bene adelb...@ciseonweb.itwrote: Hi Igor, I think you've missed jar wicket-core.jar in artifacts. I can't find it in lib folder. Yep, confirmed. It is in https://repository.apache.org/content/repositories/orgapachewicket-031/org/apache/wicket/wicket-core/1.5-rc2/wicket-core-1.5-rc2.jar But there is no -core.jar in http://people.apache.org/~ivaynberg/wicket-1.5-rc2/dist/ Bye. This vote is to release wicket 1.5-rc2 Branch: http://svn.apache.org/repos/asf/wicket/branches/wicket-1.5-rc2/ Artifacts: http://people.apache.org/~ivaynberg/wicket-1.5-rc2/dist Maven repo: https://repository.apache.org/content/repositories/orgapachewicket-031/ Changelog: https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310561version=12316059 This vote ends Wednesday, February 23 at 9:00am (GMT-8) Please test the release and offer your vote. -igor
Re: Reducing JIRA spam
On Tue, Feb 15, 2011 at 2:23 AM, Pedro Santos pedros...@gmail.com wrote: fine by me also, can hudson integration messages be disabled also? done. I have stopped those for 1.5.x few months ago, now they are stopped for 1.4.x too On Tue, Feb 8, 2011 at 8:58 AM, Martijn Dashorst martijn.dasho...@gmail.com wrote: It appears that we can reduce the amount of spam JIRA sends to our commits list by telling it not to send notifications when the fix-in version is modified. I'd like that feature to be enabled... Martijn -- Become a Wicket expert, learn from the best: http://wicketinaction.com -- Pedro Henrique Oliveira dos Santos
Re: Reducing JIRA spam
On Tue, Feb 8, 2011 at 12:58 PM, Martijn Dashorst martijn.dasho...@gmail.com wrote: It appears that we can reduce the amount of spam JIRA sends to our commits list by telling it not to send notifications when the fix-in version is modified. I'd like that feature to be enabled... I'm -0. sometimes we make mistakes by setting this property to wrong version. Today I fixed one of those. Martijn -- Become a Wicket expert, learn from the best: http://wicketinaction.com
Re: [wicketstuff] core pom - not used dependencies
Hi Atilla, You seem to have covered it. I think you know what you are doing. Regards, Erik. Op 21-02-11 09:23, Attila Király wrote: Hi Attila, Are you sure they are not used? They could be used transitively. No, I am not sure that's why I am asking. I searched the poms, the java files and mvn dependency:tree reports but none of them contained the examples I mentioned before. Anyways, in order for core to be consistent, having versions in the modules is not desirable if they are already in the core pom. I agree with you but this is not the case. A lot of modules define the versions for their dependencies. -- Erik van Oosten http://www.day-to-day-stuff.blogspot.com/
Re: [vote] release wicket 1.5-rc2
+1 Juergen On Mon, Feb 21, 2011 at 5:01 PM, Peter Ertl pe...@gmx.org wrote: +1 Am 21.02.2011 um 16:03 schrieb Francisco Diaz Trepat - gmail: +1 Also some quick testing on wicket-examples On Mon, Feb 21, 2011 at 11:58 AM, Martin Grigorov mgrigo...@apache.orgwrote: +1 to release it Tested : - create quickstart from the staging repo, - checkout the branch from svn and build - test most of the wicket-examples and I didn't found a single issue just one minor thing: the version is 1.5-rc2 (lower case 'rc'), while the previous was 1.5-RC1. This confused me in the beginning. On Mon, Feb 21, 2011 at 6:34 AM, Igor Vaynberg igor.vaynb...@gmail.com wrote: This vote is to release wicket 1.5-rc2 Branch: http://svn.apache.org/repos/asf/wicket/branches/wicket-1.5-rc2/ Artifacts: http://people.apache.org/~ivaynberg/wicket-1.5-rc2/dist Maven repo: https://repository.apache.org/content/repositories/orgapachewicket-031/ Changelog: https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310561version=12316059 This vote ends Wednesday, February 23 at 9:00am (GMT-8) Please test the release and offer your vote. -igor
Re: [vote] release wicket 1.5-rc2
Do we still include the Doug Lea concurrent library? I though we removed that with our migration to Java 5? If so, we should remove the license and notice from our distribution Martijn On Mon, Feb 21, 2011 at 5:34 AM, Igor Vaynberg igor.vaynb...@gmail.com wrote: This vote is to release wicket 1.5-rc2 Branch: http://svn.apache.org/repos/asf/wicket/branches/wicket-1.5-rc2/ Artifacts: http://people.apache.org/~ivaynberg/wicket-1.5-rc2/dist Maven repo: https://repository.apache.org/content/repositories/orgapachewicket-031/ Changelog: https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310561version=12316059 This vote ends Wednesday, February 23 at 9:00am (GMT-8) Please test the release and offer your vote. -igor -- Become a Wicket expert, learn from the best: http://wicketinaction.com
Re: Reducing JIRA spam
I agree with Martin - I've fixed several, especially while releases are being voted on, so the current unreleased version is actually already closed, and new things should go in the next one, but someone puts it in the one that is being voted on. On Mon, Feb 21, 2011 at 11:44 AM, Martin Grigorov mgrigo...@apache.orgwrote: On Tue, Feb 8, 2011 at 12:58 PM, Martijn Dashorst martijn.dasho...@gmail.com wrote: It appears that we can reduce the amount of spam JIRA sends to our commits list by telling it not to send notifications when the fix-in version is modified. I'd like that feature to be enabled... I'm -0. sometimes we make mistakes by setting this property to wrong version. Today I fixed one of those. Martijn -- Become a Wicket expert, learn from the best: http://wicketinaction.com -- Jeremy Thomerson http://wickettraining.com *Need a CMS for Wicket? Use Brix! http://brixcms.org*
