Re: [vote3] release wicket 1.3.0-beta3

2007-08-27 Thread Frank Bille
On 8/26/07, Martijn Dashorst [EMAIL PROTECTED] wrote:

 [x] yes release this third version of 1.3.0-beta3 to our community
 [ ] no, ...


With the fixes you have applied I say +1. This is based on:

   - I have checked the RAT log (attached to this mail). I didn't see any
   problems.
   - mvn clean install works
   - Random testing in wicket-examples
   - There is one small issue. The target directory isn't deleted from
   the maven archetype quickstart project. This is my fault and I will fix it.
   But IMO it's not a showstopper.


Frank


Re: [vote3] release wicket 1.3.0-beta3

2007-08-27 Thread Frank Bille
And by attached to this email I mean Now it's attached

On 8/27/07, Frank Bille [EMAIL PROTECTED] wrote:

 On 8/26/07, Martijn Dashorst [EMAIL PROTECTED] wrote:
 
  [x] yes release this third version of 1.3.0-beta3 to our community
  [ ] no, ...
 

 With the fixes you have applied I say +1. This is based on:

- I have checked the RAT log (attached to this mail). I didn't see
any problems.
- mvn clean install works
- Random testing in wicket-examples
- There is one small issue. The target directory isn't deleted from
the maven archetype quickstart project. This is my fault and I will fix it.
But IMO it's not a showstopper.


 Frank



Re: [vote3] release wicket 1.3.0-beta3

2007-08-27 Thread Eelco Hillenius
On 8/27/07, Frank Bille [EMAIL PROTECTED] wrote:
 On 8/26/07, Martijn Dashorst [EMAIL PROTECTED] wrote:
 
  [x] yes release this third version of 1.3.0-beta3 to our community
  [ ] no, ...

If Frank says it's good, it must be good! +1 for releasing.

Eelco


Re: [vote3] release wicket 1.3.0-beta3

2007-08-27 Thread Igor Vaynberg
if frank and eelco say its ok then it must be ok

+1

-igor


On 8/27/07, Eelco Hillenius [EMAIL PROTECTED] wrote:

 On 8/27/07, Frank Bille [EMAIL PROTECTED] wrote:
  On 8/26/07, Martijn Dashorst [EMAIL PROTECTED] wrote:
  
   [x] yes release this third version of 1.3.0-beta3 to our community
   [ ] no, ...

 If Frank says it's good, it must be good! +1 for releasing.

 Eelco



Re: [vote3] release wicket 1.3.0-beta3

2007-08-26 Thread Eelco Hillenius
On 8/26/07, Martijn Dashorst [EMAIL PROTECTED] wrote:
 I have uploaded a new version (the third) of the Wicket 1.3.0-beta3
 release to my
 people.apache.org account. Updates are:

Sorry that I'm the bad guy this time, but the message bundle problem
(and probably the same goes for all resource loading) is so serious
that it doesn't warrant a release.

Eelco


Re: [vote3] release wicket 1.3.0-beta3

2007-08-26 Thread Eelco Hillenius
On 8/26/07, Eelco Hillenius [EMAIL PROTECTED] wrote:
 On 8/26/07, Martijn Dashorst [EMAIL PROTECTED] wrote:
  I have uploaded a new version (the third) of the Wicket 1.3.0-beta3
  release to my
  people.apache.org account. Updates are:

 Sorry that I'm the bad guy this time, but the message bundle problem
 (and probably the same goes for all resource loading) is so serious
 that it doesn't warrant a release.

see https://issues.apache.org/jira/browse/WICKET-891

Eelco