Re: [PATCH] trivial dcs_to_fields fix
Hi Alex, ok, I see that's it's only MO related. Commiting this to cvs. If someone complains, we will roll-back. Stipe [EMAIL PROTECTED] --- Wapme Systems AG Vogelsanger Weg 80 40470 Düsseldorf Tel: +49-211-74845-0 Fax: +49-211-74845-299 E-Mail: [EMAIL PROTECTED] Internet: http://www.wapme-systems.de --- wapme.net - wherever you are
Re: [PATCH] trivial dcs_to_fields fix
Hi Stipe, all, On Wednesday 26 February 2003 23:00, Stipe Tolj wrote: Alexander Malysh wrote: attached patch should fix dcs_to_fields and versus functions. The problem: assume you got dcs=0xf5 in your smpp/ucp triber. Simple call: dcs = 0xf5; dcs_to_fields(dcs,msg); filds_to_dcs(msg, msg-sms.alt_dcs); And look what happens ;) Please apply... that patch would change the alt_dcs behaviour from alt_dcs = 0 to alt_dcs = 1 for all MT messages. No. This patch has nothing to do with MT messages ... It corrects only alt_dcs settings for MO messages. For MT we use alt_dcs directive from config file or sendsms http api... I think , it's not good if MO message has had dcs=0xf5 and after simple dcs_to_fields(dcs,msg); fields_to_dcs(msg, msg-sms.alt_dcs); calls has dcs=0x05 because of missing alt_dcs setting in message. Or I am missing something? Specifically we would default the 'alt-dcs' config directive of the smsc group to 1 instread of 0. Any comments/votes from the others?! Stipe [EMAIL PROTECTED] --- Wapme Systems AG Vogelsanger Weg 80 40470 Düsseldorf Tel: +49-211-74845-0 Fax: +49-211-74845-299 E-Mail: [EMAIL PROTECTED] Internet: http://www.wapme-systems.de --- wapme.net - wherever you are -- Best Regards / Mit besten Grüßen aus Köln Dipl.-Ing. Alexander Malysh ___ Centrium GmbH Ehrenstrasse 2 50672 Köln Fon: +49 (0221) 277 49 240 Fax: +49 (0221) 277 49 109 email: [EMAIL PROTECTED] web: http://www.centrium.de msn: [EMAIL PROTECTED] smime.p7s Description: signature
Re: [PATCH] trivial dcs_to_fields fix
Alexander Malysh wrote: attached patch should fix dcs_to_fields and versus functions. The problem: assume you got dcs=0xf5 in your smpp/ucp triber. Simple call: dcs = 0xf5; dcs_to_fields(dcs,msg); filds_to_dcs(msg, msg-sms.alt_dcs); And look what happens ;) Please apply... that patch would change the alt_dcs behaviour from alt_dcs = 0 to alt_dcs = 1 for all MT messages. Specifically we would default the 'alt-dcs' config directive of the smsc group to 1 instread of 0. Any comments/votes from the others?! Stipe [EMAIL PROTECTED] --- Wapme Systems AG Vogelsanger Weg 80 40470 Düsseldorf Tel: +49-211-74845-0 Fax: +49-211-74845-299 E-Mail: [EMAIL PROTECTED] Internet: http://www.wapme-systems.de --- wapme.net - wherever you are
[PATCH] trivial dcs_to_fields fix
Hi, attached patch should fix dcs_to_fields and versus functions. The problem: assume you got dcs=0xf5 in your smpp/ucp triber. Simple call: dcs = 0xf5; dcs_to_fields(dcs,msg); filds_to_dcs(msg, msg-sms.alt_dcs); And look what happens ;) Please apply... -- Best regards / Mit besten Grüßen aus Köln Dipl.-Ing. Alexander Malysh ___ Centrium GmbH Ehrenstraße 2 50672 Köln Fon: +49 (0221) 277 49 240 Fax: +49 (0221) 277 49 109 email: [EMAIL PROTECTED] web: www.centrium.de msn: [EMAIL PROTECTED] icq: 98063111 Index: gw/sms.c === RCS file: /home/cvs/gateway/gw/sms.c,v retrieving revision 1.6 diff -a -u -r1.6 sms.c --- gw/sms.c 7 Dec 2002 14:30:54 - 1.6 +++ gw/sms.c 26 Feb 2003 16:09:20 - @@ -83,6 +83,7 @@ dcs = 0x07; (*msg)-sms.coding = (dcs 0x04) ? DC_8BIT : DC_7BIT; /* grab bit 2 */ (*msg)-sms.mclass = 1 + (dcs 0x03); /* grab bits 1,0 */ +(*msg)-sms.alt_dcs = 1; /* set 0xfX data coding */ } /* Non-MWI Mode 0 */