Re: [PATCH] trivial dcs_to_fields fix

2003-03-04 Thread Stipe Tolj
Hi Alex,

ok, I see that's it's only MO related. Commiting this to cvs.

If someone complains, we will roll-back.

Stipe

[EMAIL PROTECTED]
---
Wapme Systems AG

Vogelsanger Weg 80
40470 Düsseldorf

Tel: +49-211-74845-0
Fax: +49-211-74845-299

E-Mail: [EMAIL PROTECTED]
Internet: http://www.wapme-systems.de
---
wapme.net - wherever you are



Re: [PATCH] trivial dcs_to_fields fix

2003-03-01 Thread Alexander Malysh
Hi Stipe, all,

On Wednesday 26 February 2003 23:00, Stipe Tolj wrote:
 Alexander Malysh wrote:
  attached patch should fix dcs_to_fields and versus functions.
  The problem: assume you got dcs=0xf5 in your smpp/ucp triber.
  Simple call:
  dcs = 0xf5;
  dcs_to_fields(dcs,msg);
  filds_to_dcs(msg, msg-sms.alt_dcs);
 
  And look what happens ;)
 
  Please apply...

 that patch would change the alt_dcs behaviour from alt_dcs = 0 to
 alt_dcs = 1 for all MT messages.

No. This patch has nothing to do with MT messages ... It corrects only alt_dcs 
settings for MO messages. For MT we use alt_dcs directive from config file or 
sendsms http api...
I think , it's not good if MO message has had dcs=0xf5 and after simple
dcs_to_fields(dcs,msg); fields_to_dcs(msg, msg-sms.alt_dcs); calls has 
dcs=0x05 because of missing alt_dcs setting in message.

Or I am missing something?



 Specifically we would default the 'alt-dcs' config directive of the
 smsc group to 1 instread of 0.

 Any comments/votes from the others?!

 Stipe

 [EMAIL PROTECTED]
 ---
 Wapme Systems AG

 Vogelsanger Weg 80
 40470 Düsseldorf

 Tel: +49-211-74845-0
 Fax: +49-211-74845-299

 E-Mail: [EMAIL PROTECTED]
 Internet: http://www.wapme-systems.de
 ---
 wapme.net - wherever you are

-- 
Best Regards / Mit besten Grüßen aus Köln

Dipl.-Ing.
Alexander Malysh
___

Centrium GmbH
Ehrenstrasse 2
50672 Köln

Fon: +49 (0221) 277 49 240
Fax: +49 (0221) 277 49 109

email: [EMAIL PROTECTED]
web: http://www.centrium.de
msn: [EMAIL PROTECTED]


smime.p7s
Description: signature


Re: [PATCH] trivial dcs_to_fields fix

2003-02-27 Thread Stipe Tolj
Alexander Malysh wrote:
 
 attached patch should fix dcs_to_fields and versus functions.
 The problem: assume you got dcs=0xf5 in your smpp/ucp triber.
 Simple call:
 dcs = 0xf5;
 dcs_to_fields(dcs,msg);
 filds_to_dcs(msg, msg-sms.alt_dcs);
 
 And look what happens ;)
 
 Please apply...

that patch would change the alt_dcs behaviour from alt_dcs = 0 to
alt_dcs = 1 for all MT messages.

Specifically we would default the 'alt-dcs' config directive of the
smsc group to 1 instread of 0.

Any comments/votes from the others?!

Stipe

[EMAIL PROTECTED]
---
Wapme Systems AG

Vogelsanger Weg 80
40470 Düsseldorf

Tel: +49-211-74845-0
Fax: +49-211-74845-299

E-Mail: [EMAIL PROTECTED]
Internet: http://www.wapme-systems.de
---
wapme.net - wherever you are