Re: Tagging commit hashes of Koji builds in dist-git
On Thu, Jun 06, 2019 at 02:07:18PM -0500, Dennis Gilmore wrote: > On Thu, Jun 6, 2019 at 7:11 AM Neal Gompa wrote: > > > > On Thu, Jun 6, 2019 at 7:53 AM Florian Weimer wrote: > > > > > > Is there a reason why we do not tag dist-git commits, using a name which > > > is derived from the NEVR from a Koji build? > > > > > > How well does Git scale with thousands of tags? > > > > > > > We used to back in the CVS days, because we needed it for plague. Koji > > blocks duplicate submissions anyway, so it stopped being needed when > > we transitioned to Git. > > it was not plague that needed it, using tags was the only way to > cjeckout the intended output, they had the problem that they were not > immutable, if you made a typo you forced in a new tag so you did not > need to bump the nvr > > > We're going to probably introduce it for some automation in the near > > future, though. > > > > Git is not great with thousands of any kind of refs, be it branches or > > tags. It still works, it's just things like 'git log' get kind of > > expensive. > > koji stores the git hash for all builds, writing a script to get the > hash for a given nvr would be trivial. it just means you have to be > online to retrieve the data than being able to get the date while > disconnected, if it was stored in git. I'd also point out that the link is also made in pagure, for example: https://src.fedoraproject.org/rpms/kernel/c/ead55fdbc7606e96fb1436249e4d121c5119218b?branch=master Basically, we listen for koji build results and "flag" the commit which was used for the build with the outcome (success/failure) of the build. Here is another example who both succeeded and failed to build in koji: https://src.fedoraproject.org/rpms/0ad/c/d43ffc4721e7c5d6af33e9bc26b739ec6802cb76?branch=master If this needs to be made more easily discoverable via the API, we can adjust pagure for this. Pierre ___ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org
Re: Tagging commit hashes of Koji builds in dist-git
On Fri, Jun 7, 2019 at 8:09 AM clime wrote: > > On Thu, 6 Jun 2019 at 13:53, Florian Weimer wrote: > > > > Is there a reason why we do not tag dist-git commits, using a name which > > is derived from the NEVR from a Koji build? > > Interesting idea. I am soon coming with a proposal of the annotated tags > being created by packagers and storing changelog automatically in them. > > These tags would have name derived automatically from Name-Version-Release > put in the spec file and constitute a basically a package release > record in DistGit. > > The information in Koji would then be derivative of it. I guess this is > another > way how to go around things. > This is very similar to what Igor and I had been thinking of doing, too. -- 真実はいつも一つ！/ Always, there's only one truth! ___ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org
Re: Tagging commit hashes of Koji builds in dist-git
On Thu, 6 Jun 2019 at 13:53, Florian Weimer wrote: > > Is there a reason why we do not tag dist-git commits, using a name which > is derived from the NEVR from a Koji build? Interesting idea. I am soon coming with a proposal of the annotated tags being created by packagers and storing changelog automatically in them. These tags would have name derived automatically from Name-Version-Release put in the spec file and constitute a basically a package release record in DistGit. The information in Koji would then be derivative of it. I guess this is another way how to go around things. clime > > How well does Git scale with thousands of tags? > > Thanks, > Florian > ___ > devel mailing list -- devel@lists.fedoraproject.org > To unsubscribe send an email to devel-le...@lists.fedoraproject.org > Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html > List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines > List Archives: > https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org ___ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org
Re: Tagging commit hashes of Koji builds in dist-git
* Bruno Wolff, III: > On Fri, Jun 07, 2019 at 08:37:57 -, > Petr Pisar wrote: >>On 2019-06-06, Stephen Gallagher wrote: >>> Might be worth asking if there's a reason to need this offline. If the >>> exact commit ID is stored in Koji and is authoritative, also tagging >>> it into git might be convenient for offline purposes. The fact that >>> it's not immutable is probably not an issue as long as the >>> authoritative site *is*. (e.g. The same script that gets the hash from >>> Koji could also detect if someone manually changed it in git, which >>> would probably qualify as suspicious behavior.) >> >>If tags in dist-git could disagree with Koji, people could not rely on >>them and would use Koji instead rendering tags in dist-tag useless. > > Would having signed tags help? No, the tags must recide in a namespace, and dist-git (i.e., src.fedoraproject.org) must restrict who can push into that namespace. Thanks, Florian ___ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org
Re: Tagging commit hashes of Koji builds in dist-git
On Fri, Jun 07, 2019 at 08:37:57 -, Petr Pisar wrote: On 2019-06-06, Stephen Gallagher wrote: Might be worth asking if there's a reason to need this offline. If the exact commit ID is stored in Koji and is authoritative, also tagging it into git might be convenient for offline purposes. The fact that it's not immutable is probably not an issue as long as the authoritative site *is*. (e.g. The same script that gets the hash from Koji could also detect if someone manually changed it in git, which would probably qualify as suspicious behavior.) If tags in dist-git could disagree with Koji, people could not rely on them and would use Koji instead rendering tags in dist-tag useless. Would having signed tags help? ___ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org
Re: Tagging commit hashes of Koji builds in dist-git
On 2019-06-06, Stephen Gallagher wrote: > Might be worth asking if there's a reason to need this offline. If the > exact commit ID is stored in Koji and is authoritative, also tagging > it into git might be convenient for offline purposes. The fact that > it's not immutable is probably not an issue as long as the > authoritative site *is*. (e.g. The same script that gets the hash from > Koji could also detect if someone manually changed it in git, which > would probably qualify as suspicious behavior.) If tags in dist-git could disagree with Koji, people could not rely on them and would use Koji instead rendering tags in dist-tag useless. -- Petr ___ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org
Re: Tagging commit hashes of Koji builds in dist-git
On Thu, Jun 6, 2019 at 3:08 PM Dennis Gilmore wrote: > > On Thu, Jun 6, 2019 at 7:11 AM Neal Gompa wrote: > > > > On Thu, Jun 6, 2019 at 7:53 AM Florian Weimer wrote: > > > > > > Is there a reason why we do not tag dist-git commits, using a name which > > > is derived from the NEVR from a Koji build? > > > > > > How well does Git scale with thousands of tags? > > > > > > > We used to back in the CVS days, because we needed it for plague. Koji > > blocks duplicate submissions anyway, so it stopped being needed when > > we transitioned to Git. > > it was not plague that needed it, using tags was the only way to > cjeckout the intended output, they had the problem that they were not > immutable, if you made a typo you forced in a new tag so you did not > need to bump the nvr > > > We're going to probably introduce it for some automation in the near > > future, though. > > > > Git is not great with thousands of any kind of refs, be it branches or > > tags. It still works, it's just things like 'git log' get kind of > > expensive. > > koji stores the git hash for all builds, writing a script to get the > hash for a given nvr would be trivial. it just means you have to be > online to retrieve the data than being able to get the date while > disconnected, if it was stored in git. Might be worth asking if there's a reason to need this offline. If the exact commit ID is stored in Koji and is authoritative, also tagging it into git might be convenient for offline purposes. The fact that it's not immutable is probably not an issue as long as the authoritative site *is*. (e.g. The same script that gets the hash from Koji could also detect if someone manually changed it in git, which would probably qualify as suspicious behavior.) ___ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org
Re: Tagging commit hashes of Koji builds in dist-git
On Thu, Jun 6, 2019 at 7:11 AM Neal Gompa wrote: > > On Thu, Jun 6, 2019 at 7:53 AM Florian Weimer wrote: > > > > Is there a reason why we do not tag dist-git commits, using a name which > > is derived from the NEVR from a Koji build? > > > > How well does Git scale with thousands of tags? > > > > We used to back in the CVS days, because we needed it for plague. Koji > blocks duplicate submissions anyway, so it stopped being needed when > we transitioned to Git. it was not plague that needed it, using tags was the only way to cjeckout the intended output, they had the problem that they were not immutable, if you made a typo you forced in a new tag so you did not need to bump the nvr > We're going to probably introduce it for some automation in the near > future, though. > > Git is not great with thousands of any kind of refs, be it branches or > tags. It still works, it's just things like 'git log' get kind of > expensive. koji stores the git hash for all builds, writing a script to get the hash for a given nvr would be trivial. it just means you have to be online to retrieve the data than being able to get the date while disconnected, if it was stored in git. Dennis > > > -- > 真実はいつも一つ！/ Always, there's only one truth! > ___ > devel mailing list -- devel@lists.fedoraproject.org > To unsubscribe send an email to devel-le...@lists.fedoraproject.org > Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html > List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines > List Archives: > https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org ___ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org
Re: Tagging commit hashes of Koji builds in dist-git
* Thomas Moschny: > Am Do., 6. Juni 2019 um 14:12 Uhr schrieb Pierre-Yves Chibon > : >> >> On Thu, Jun 06, 2019 at 01:52:20PM +0200, Florian Weimer wrote: >> > Is there a reason why we do not tag dist-git commits, using a name which >> > is derived from the NEVR from a Koji build? >> >> One of the issue is that currently tags are not immutable, ei packagers could >> override them. > > Tags could be signed, and also pagure could reject removal of tags. > Immutability is a feature of the repository, not the tags themselves, > I think. Yes, I think you can have a Git hook which updates certain tag updates, just like you would reject branch updates. It probably makes sense to put the Koji tags into a separate namespace anyway, so filtering it by prefix string should be possible. (It would also stop people from pushing misleading tags that don't correspond to Koji builds, but look that way.) Tagging would have to happen upon successful completion of the build (for a failed build, the NVR can be reused), which is slightly annoying, but still better than having no tags at all, ever. Thanks, Florian ___ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org
Re: Tagging commit hashes of Koji builds in dist-git
Am Do., 6. Juni 2019 um 14:12 Uhr schrieb Pierre-Yves Chibon : > > On Thu, Jun 06, 2019 at 01:52:20PM +0200, Florian Weimer wrote: > > Is there a reason why we do not tag dist-git commits, using a name which > > is derived from the NEVR from a Koji build? > > One of the issue is that currently tags are not immutable, ei packagers could > override them. Tags could be signed, and also pagure could reject removal of tags. Immutability is a feature of the repository, not the tags themselves, I think. - Thomas ___ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org
Re: Tagging commit hashes of Koji builds in dist-git
On Thu, Jun 6, 2019 at 7:53 AM Florian Weimer wrote: > > Is there a reason why we do not tag dist-git commits, using a name which > is derived from the NEVR from a Koji build? > > How well does Git scale with thousands of tags? > We used to back in the CVS days, because we needed it for plague. Koji blocks duplicate submissions anyway, so it stopped being needed when we transitioned to Git. We're going to probably introduce it for some automation in the near future, though. Git is not great with thousands of any kind of refs, be it branches or tags. It still works, it's just things like 'git log' get kind of expensive. -- 真実はいつも一つ！/ Always, there's only one truth! ___ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org
Re: Tagging commit hashes of Koji builds in dist-git
On Thu, Jun 06, 2019 at 01:52:20PM +0200, Florian Weimer wrote: > Is there a reason why we do not tag dist-git commits, using a name which > is derived from the NEVR from a Koji build? One of the issue is that currently tags are not immutable, ei packagers could override them. Pierre ___ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org
Re: Tagging commit hashes of Koji builds in dist-git
We actually talked about this on oSC19 with Neal Gompa and Florian Festi. And we'd need it for automation we are planning to work on... Then I spoke to pingou and he told me that tags are easy to delete and you need some special hook to prevent that... I did not have time to look at it though. On Thu, Jun 6, 2019 at 2:02 PM Florian Weimer wrote: > > Is there a reason why we do not tag dist-git commits, using a name which > is derived from the NEVR from a Koji build? > > How well does Git scale with thousands of tags? > > Thanks, > Florian > ___ > devel mailing list -- devel@lists.fedoraproject.org > To unsubscribe send an email to devel-le...@lists.fedoraproject.org > Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html > List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines > List Archives: > https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org ___ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org
Tagging commit hashes of Koji builds in dist-git
Is there a reason why we do not tag dist-git commits, using a name which is derived from the NEVR from a Koji build? How well does Git scale with thousands of tags? Thanks, Florian ___ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org
