Re: how to do minor bump using %autorelease?
On Mon, Apr 29, 2024 at 01:44:05PM +0200, Fabio Valentini wrote: > On Mon, Apr 29, 2024 at 1:28 PM Richard W.M. Jones wrote: > > > > On Sat, Apr 27, 2024 at 10:41:59PM +0200, Julian Sikorski wrote: > > > Hello, > > > > > > I need to rebuild mame on F40 only for qt-6.7. On rawhide, > > > mame-0.265-1.fc41 is already built against it so I only need to > > > build mame-0.265-1.fc40.1. Can it be done using %autorelease? > > > > I don't think anyone answered your actual question which is ... > > > > Release: %autorelease -e 1 > > No, this will make a Release like 2.1.fc40 - which is not what's > needed (which would be 1.fc40.1). > So it doesn't work because -e adds a component *before* the dist-tag, > *and* because the main number is still incremented. Interesting .. I've definitely seen this flag being used in an attempt to fix the issue described, but I didn't realise that it didn't work. It sounds like a bug in %autorelease. Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com Fedora Windows cross-compiler. Compile Windows programs, test, and build Windows installers. Over 100 libraries supported. http://fedoraproject.org/wiki/MinGW -- ___ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
Re: how to do minor bump using %autorelease?
On Mon, Apr 29, 2024 at 11:44 AM Fabio Valentini wrote: > No, this will make a Release like 2.1.fc40 - which is not what's > needed (which would be 1.fc40.1). > So it doesn't work because -e adds a component *before* the dist-tag, > *and* because the main number is still incremented. Since [.minorbump] is a documented method for packaging, if autorelease does not support it is feature incomplete. If one wants/needs to use [.minorbump] now, or in the future, autorelease is not currently the tool to use. I'll let the autorelease authors decide whether autorelease needs to be updated to support [.minorbump]. -- ___ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
Re: how to do minor bump using %autorelease?
On Mon, Apr 29, 2024 at 1:28 PM Richard W.M. Jones wrote: > > On Sat, Apr 27, 2024 at 10:41:59PM +0200, Julian Sikorski wrote: > > Hello, > > > > I need to rebuild mame on F40 only for qt-6.7. On rawhide, > > mame-0.265-1.fc41 is already built against it so I only need to > > build mame-0.265-1.fc40.1. Can it be done using %autorelease? > > I don't think anyone answered your actual question which is ... > > Release: %autorelease -e 1 No, this will make a Release like 2.1.fc40 - which is not what's needed (which would be 1.fc40.1). So it doesn't work because -e adds a component *before* the dist-tag, *and* because the main number is still incremented. Fabio -- ___ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
Re: how to do minor bump using %autorelease?
On Sat, Apr 27, 2024 at 10:41:59PM +0200, Julian Sikorski wrote: > Hello, > > I need to rebuild mame on F40 only for qt-6.7. On rawhide, > mame-0.265-1.fc41 is already built against it so I only need to > build mame-0.265-1.fc40.1. Can it be done using %autorelease? I don't think anyone answered your actual question which is ... Release: %autorelease -e 1 (https://docs.pagure.org/Fedora-Infra.rpmautospec/autorelease.html) Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com libguestfs lets you edit virtual machines. Supports shell scripting, bindings from many languages. http://libguestfs.org -- ___ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
Re: how to do minor bump using %autorelease?
Fabio Valentini wrote: > No, that's just wrong. > The "upgrade path" (wrt/ NVRs) is no longer enforced across release > boundaries. AFAIK, all supported release-upgrade methods now use > distro-sync or something equivalent, so NVR-based "upgrade path" is just > not important any more. That just does not make sense: We enforce upgrade paths from Rawhide to Rawhide (!) requiring lots of unnecessary Epoch bumps when things need to be reverted (which is normal for a development running release), but we happily allow the ones that actually matter to end users to break? All this just so that lazy packagers do not have to increment a number (in most cases a single-character change, in some cases (such as a minor bump or every 10 major bumps) a two-character change, rarely more) when doing a new build. Kevin Kofler -- ___ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
Re: how to do minor bump using %autorelease?
On Mon, Apr 29, 2024 at 11:17 AM Kevin Kofler via devel
wrote:
>
> Michael J Gruber wrote:
> > A minor bump (as in %{?dist}[.]) only comes into play
> > if a "lower" branch needs to move forward without creating a version
> > ahead of a "higher" branch. And (independent of autorelease) you cannot
> > do that unless you use divergent git branches and cherry-picks in
> > dist-git, in which case "version" makes sense per branch only anyways.
>
> But Release MUST maintain the upgrade path from one release to the next.
No, that's just wrong.
The "upgrade path" (wrt/ NVRs) is no longer enforced across release boundaries.
AFAIK, all supported release-upgrade methods now use distro-sync or
something equivalent, so NVR-based "upgrade path" is just not
important any more.
Fabio
--
___
devel mailing list -- devel@lists.fedoraproject.org
To unsubscribe send an email to devel-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org
Do not reply to spam, report it:
https://pagure.io/fedora-infrastructure/new_issue
Re: how to do minor bump using %autorelease?
Michael J Gruber wrote:
> A minor bump (as in %{?dist}[.]) only comes into play
> if a "lower" branch needs to move forward without creating a version
> ahead of a "higher" branch. And (independent of autorelease) you cannot
> do that unless you use divergent git branches and cherry-picks in
> dist-git, in which case "version" makes sense per branch only anyways.
But Release MUST maintain the upgrade path from one release to the next.
Also, no, you do not necessarily need to allow the branches to diverge. If
you keep your branches fast-forwarded, you can just fast-forward the
"rebuild for libfoo in Fn" commit with the minor bump to all branches, but
build it only in the fn branch where it is relevant. The minor bump ensures
that doing that maintains the correct upgrade path, so you do not have to
push unnecessary rebuilds to releases where it is not relevant.
> In a dist-git where you work with release branches "contained" in
> rawhide - and use macros extensively - you automatically have commits
> which you merge down but which don't affect all branches, e.g. rebuild
> commits for dependencies or mass rebuilds. I'm not saying this is the best
> way of doing things (we should do it differently), but it's a common
> pattern. So you can have the "f40 mass rebuild" commit in an f39 branch.
> And in a world where you have and accept that, you can also push a
> "rebuild for libfoo" to rawhide and merge down to f40 if that is what
> you need to have f40 versions <= rawhide versions.
Sure, but as I explained above, this only works properly if you do a minor
bump rather than a full bump to Release. Otherwise you have to rebuild
everywhere or you break the upgrade path.
> But as others have pointed out, in the light of distrosync and
> macro-determined differences etc. we may just as well give up the
> illusion that "-5" means the same in different branches, and
> consequently lift the sorting policy between different branches.
But that breaks the upgrade path, so it is a no go.
Kevin Kofler
--
___
devel mailing list -- devel@lists.fedoraproject.org
To unsubscribe send an email to devel-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org
Do not reply to spam, report it:
https://pagure.io/fedora-infrastructure/new_issue
Re: how to do minor bump using %autorelease?
Kevin Kofler via devel venit, vidit, dixit 2024-04-28 23:55:37:
> Julian Sikorski wrote:
> > I need to rebuild mame on F40 only for qt-6.7. On rawhide,
> > mame-0.265-1.fc41 is already built against it so I only need to build
> > mame-0.265-1.fc40.1. Can it be done using %autorelease?
>
> No, which is why you should not be using %autorelease.
>
> I would just replace %autorelease with a correctly manually bumped Release
> in the specfile as part of doing the rebuild.
>
> Just letting %autorelease do its thing and ending up with a full bump would
> be incorrect, so it should not even be considered as an option.
Bumping to mame-0.265-1.fc40 to mame-0.265-2.fc40 for a rebuild against
a changed dependency is the normal and recommended way of doing
rebuilds, whether you bump manually or using autolease.
A minor bump (as in %{?dist}[.]) only comes into play
if a "lower" branch needs to move forward without creating a version
ahead of a "higher" branch. And (independent of autorelease) you cannot
do that unless you use divergent git branches and cherry-picks in
dist-git, in which case "version" makes sense per branch only anyways.
In a dist-git where you work with release branches "contained" in
rawhide - and use macros extensively - you automatically have commits
which you merge down but which don't affect all branches, e.g. rebuild commits
for dependencies or mass rebuilds. I'm not saying this is the best way
of doing things (we should do it differently), but it's a common
pattern. So you can have the "f40 mass rebuild" commit in an f39 branch.
And in a world where you have and accept that, you can also push a
"rebuild for libfoo" to rawhide and merge down to f40 if that is what
you need to have f40 versions <= rawhide versions.
But as others have pointed out, in the light of distrosync and
macro-determined differences etc. we may just as well give up the
illusion that "-5" means the same in different branches, and
consequently lift the sorting policy between different branches.
Michael
--
___
devel mailing list -- devel@lists.fedoraproject.org
To unsubscribe send an email to devel-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org
Do not reply to spam, report it:
https://pagure.io/fedora-infrastructure/new_issue
Re: how to do minor bump using %autorelease?
Julian Sikorski wrote: > I need to rebuild mame on F40 only for qt-6.7. On rawhide, > mame-0.265-1.fc41 is already built against it so I only need to build > mame-0.265-1.fc40.1. Can it be done using %autorelease? No, which is why you should not be using %autorelease. I would just replace %autorelease with a correctly manually bumped Release in the specfile as part of doing the rebuild. Just letting %autorelease do its thing and ending up with a full bump would be incorrect, so it should not even be considered as an option. Kevin Kofler -- ___ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
Re: how to do minor bump using %autorelease?
On Sat, Apr 27, 2024 at 11:51 PM Sandro wrote: > > On 27-04-2024 22:41, Julian Sikorski wrote: > > I need to rebuild mame on F40 only for qt-6.7. On rawhide, > > mame-0.265-1.fc41 is already built against it so I only need to build > > mame-0.265-1.fc40.1. Can it be done using %autorelease? > > Make an empty commit: > > git commit -m 'Rebuild for mame' --allow-empty This is not the answer to the question. It will cause a normal Release bump. AFAIK using rpmautospec, it's not possible to do post-dist.tag .1 bumps. But it's also not really important either, since release-upgrades do distro-syncs. Fabio -- ___ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
Re: how to do minor bump using %autorelease?
On 27-04-2024 23:51, Sandro wrote: On 27-04-2024 22:41, Julian Sikorski wrote: I need to rebuild mame on F40 only for qt-6.7. On rawhide, mame-0.265-1.fc41 is already built against it so I only need to build mame-0.265-1.fc40.1. Can it be done using %autorelease? Make an empty commit: git commit -m 'Rebuild for mame' --allow-empty Or rather: git commit -m 'Rebuild for qt-6.7' --allow-empty Sorry, was only half reading the message. -- Sandro -- ___ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
Re: how to do minor bump using %autorelease?
On 27-04-2024 22:41, Julian Sikorski wrote: I need to rebuild mame on F40 only for qt-6.7. On rawhide, mame-0.265-1.fc41 is already built against it so I only need to build mame-0.265-1.fc40.1. Can it be done using %autorelease? Make an empty commit: git commit -m 'Rebuild for mame' --allow-empty -- Sandro -- ___ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
how to do minor bump using %autorelease?
Hello, I need to rebuild mame on F40 only for qt-6.7. On rawhide, mame-0.265-1.fc41 is already built against it so I only need to build mame-0.265-1.fc40.1. Can it be done using %autorelease? Best regards, Julian -- ___ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
