Via driver build problems

2003-12-17 Thread Matthieu Herrb
I need the attached patch to build the latest via driver on platforms
without DRI. But this raises the question: shouldn't XFREE_44 be
defined for this driver ?

Index: xc/programs/Xserver/hw/xfree86/drivers/via/via_memory.c
===
RCS file: /cvs/xf86/xc/programs/Xserver/hw/xfree86/drivers/via/via_memory.c,v
retrieving revision 1.1
diff -u -r1.1 via_memory.c
--- xc/programs/Xserver/hw/xfree86/drivers/via/via_memory.c 17 Dec 2003 18:58:35 
-  1.1
+++ xc/programs/Xserver/hw/xfree86/drivers/via/via_memory.c 17 Dec 2003 22:59:08 
-
@@ -82,8 +82,11 @@
 
 unsigned long VIAAllocLinear(VIAMemPtr mem, ScrnInfoPtr pScrn, unsigned long size)
 {
-#ifdef XF86DRI
+#if defined(XF86DRI) || !defined(XFREE_44)
VIAPtr  pVia = VIAPTR(pScrn);
+#endif
+
+#ifdef XF86DRI

if(mem-pool)
ErrorF(VIA Double Alloc.\n);

Matthieu
___
Devel mailing list
[EMAIL PROTECTED]
http://XFree86.Org/mailman/listinfo/devel


Re: Via driver build problems

2003-12-17 Thread Uberto Barbini
On Thursday 18 December 2003 00:01, Matthieu Herrb wrote:
 I need the attached patch to build the latest via driver on platforms
 without DRI. But this raises the question: shouldn't XFREE_44 be
 defined for this driver ?

 I need the attached patch to build the latest via driver on platforms
 without DRI. But this raises the question: shouldn't XFREE_44 be
 defined for this driver ?

Did you write a bugzilla about this?

There are a few patches about via_driver that apparently aren't going to be 
merged in xfree anytime soon.
As a matter of fact none replied on ML about via_driver.
With bugzilla is simpler to keep track of all these patches.

Bye Uberto

___
Devel mailing list
[EMAIL PROTECTED]
http://XFree86.Org/mailman/listinfo/devel


Re: Via driver build problems

2003-12-17 Thread David Dawes
On Thu, Dec 18, 2003 at 12:01:43AM +0100, Matthieu Herrb wrote:
I need the attached patch to build the latest via driver on platforms
without DRI. But this raises the question: shouldn't XFREE_44 be
defined for this driver ?

That's a question for Alan (Cox) to answer.  From what he said with
the patch, that path hasn't had a lot of testing compared with the
other one.

The macro should probably be USE_LINEAR_ALLOC or some such if it is to
stay for the release.

David
-- 
David Dawes
developer/release engineer  The XFree86 Project
www.XFree86.org/~dawes
___
Devel mailing list
[EMAIL PROTECTED]
http://XFree86.Org/mailman/listinfo/devel