Re: cvs:drivers/via/via_driver.c: problem with Virtual
death writes: The Savage driver, from which I believe this driver was derived, copies pScrn- display-virtual[XY] to pScrn-virtual[XY] a page or so above the call to xf86ValidateModes. Is that not happening here? -- - Tim Roberts, [EMAIL PROTECTED] Providenza Boekelheide, Inc. Well, i hadnt looked as far, i just saw it done like this in vesa.c and i810_driver.c. Also, i just used a few xf86DrvMsgs to tell me the values of pScrn-VirtualX/Y throughout PreInit. In both vesa and via_driver, they were 0 before xf86ValidateModes and set (properly in case of vesa and to actual resolution in via) after. This made me assume that pScrn-display-virtualX/Y would contain the values of the Display subsection, the values requested through the config and that xf86ValidateModes would validate this (duh.) and, if approved of, place those values in the toplevel pScrn. Yes, this should be done in xf86ValidateModes() and in fact the via driver doesn't copy it before calling it. Egbert. ___ Devel mailing list [EMAIL PROTECTED] http://XFree86.Org/mailman/listinfo/devel
Re: cvs:drivers/via/via_driver.c: problem with Virtual
Committed. death writes: Seperate modelines error out on: width too large for virtual size for everything since this virtual width then is 0. Virtual config does not work, max/default usable size is used instead. Reason: via_driver.c:VIAPreInit: xf86ValidateModes is called with pScrn-virtual[XY] instead of pScrn-display-virtual[XY] This looks like a plain oversight from via which has existed since 1.1. and is pretty trivial. Thanks, Luc Verhaegen --- xc/programs/Xserver/hw/xfree86/drivers/via/via_driver.c 2003-08-25 04:05:39.0 +0200 +++ xc1/programs/Xserver/hw/xfree86/drivers/via/via_driver.c 2003-08-25 04:05:39.0 +0200 @@ -1504,8 +1504,8 @@ 16 * pScrn-bitsPerPixel, /* pitch inc (bits) */ 128, /* min height */ 2048, /* max height */ - pScrn-virtualX, /* virtual width */ - pScrn-virtualY, /* virutal height */ + pScrn-display-virtualX, /* virtual width */ + pScrn-display-virtualY, /* virtual height */ pVia-videoRambytes, /* size of video memory */ LOOKUP_BEST_REFRESH); /* lookup mode flags */ ___ Devel mailing list [EMAIL PROTECTED] http://XFree86.Org/mailman/listinfo/devel
