Re: xterm warning regressions (was Re: CVS Update: xc (branch: trunk))
On Tue, 14 Mar 2006, Thomas Dickey wrote: On Tue, 14 Mar 2006, David Dawes wrote: and adds this one: main.c:2586: warning: `pty_search' defined but not used yes, that's an annoyance (but the proposed fix reversed the general process of removing special definitions from main.c). Please expand on this statement. Marc. +--+---+ | Marc Aurele La France | work: 1-780-492-9310 | | Academic Information and| fax:1-780-492-1729 | |Communications Technologies | email: [EMAIL PROTECTED] | | 352 General Services Building +---+ | University of Alberta | | | Edmonton, Alberta | Standard disclaimers apply| | T6G 2H1 | | | CANADA | | +--+---+ XFree86 developer and VP. ATI driver and X server internals. ___ Devel mailing list Devel@XFree86.Org http://XFree86.Org/mailman/listinfo/devel
Re: xterm warning regressions (was Re: CVS Update: xc (branch: trunk))
On Thu, 16 Mar 2006, Marc Aurele La France wrote: On Tue, 14 Mar 2006, Thomas Dickey wrote: On Tue, 14 Mar 2006, David Dawes wrote: and adds this one: main.c:2586: warning: `pty_search' defined but not used yes, that's an annoyance (but the proposed fix reversed the general process of removing special definitions from main.c). Please expand on this statement. It overrode a definition in ptyx.h, moving the definition inline into main.c, rather than refining it in xterm.h as a fallback for a configure script test. (main.c has too many special cases) -- Thomas E. Dickey http://invisible-island.net ftp://invisible-island.net ___ Devel mailing list Devel@XFree86.Org http://XFree86.Org/mailman/listinfo/devel
Re: xterm warning regressions (was Re: CVS Update: xc (branch: trunk))
On Thu, 16 Mar 2006, Thomas Dickey wrote: On Thu, 16 Mar 2006, Marc Aurele La France wrote: On Tue, 14 Mar 2006, Thomas Dickey wrote: On Tue, 14 Mar 2006, David Dawes wrote: and adds this one: main.c:2586: warning: `pty_search' defined but not used yes, that's an annoyance (but the proposed fix reversed the general process of removing special definitions from main.c). Please expand on this statement. It overrode a definition in ptyx.h, moving the definition inline into main.c, rather than refining it in xterm.h as a fallback for a configure script test. That's irrelevent. My fix holds whether xterm is built through imake or through autowhatchamecallsit. (main.c has too many special cases) Indeed... Marc. +--+---+ | Marc Aurele La France | work: 1-780-492-9310 | | Academic Information and| fax:1-780-492-1729 | |Communications Technologies | email: [EMAIL PROTECTED] | | 352 General Services Building +---+ | University of Alberta | | | Edmonton, Alberta | Standard disclaimers apply| | T6G 2H1 | | | CANADA | | +--+---+ XFree86 developer and VP. ATI driver and X server internals. ___ Devel mailing list Devel@XFree86.Org http://XFree86.Org/mailman/listinfo/devel
Re: xterm warning regressions (was Re: CVS Update: xc (branch: trunk))
On Thu, 16 Mar 2006, Marc Aurele La France wrote: main.c, rather than refining it in xterm.h as a fallback for a configure script test. That's irrelevent. My fix holds whether xterm is built through imake or no, it is relevant. I considered a change like that some time ago, decided that it was too ugly to bother with, and that it would be better to do it properly sometime, leaving the warning as a reminder than cover it up. regards. -- Thomas E. Dickey http://invisible-island.net ftp://invisible-island.net ___ Devel mailing list Devel@XFree86.Org http://XFree86.Org/mailman/listinfo/devel
Re: xterm warning regressions (was Re: CVS Update: xc (branch: trunk))
On Thu, 16 Mar 2006, Thomas Dickey wrote: On Thu, 16 Mar 2006, Marc Aurele La France wrote: main.c, rather than refining it in xterm.h as a fallback for a configure script test. That's irrelevent. My fix holds whether xterm is built through imake or no, it is relevant. I considered a change like that some time ago, decided that it was too ugly to bother with, and that it would be better to do it properly sometime, leaving the warning as a reminder than cover it up. I agree my fix is a coverup, but, as I see it, this has gone on for waaayyy too long. xterm's tty handling needs a major rewrite, perhaps along the lines of OpenSSH's, and I just don't see that happening any time soon. So perhaps, a post-it on your refrigerator would be more productive than reminding everybody else. Marc. +--+---+ | Marc Aurele La France | work: 1-780-492-9310 | | Academic Information and| fax:1-780-492-1729 | |Communications Technologies | email: [EMAIL PROTECTED] | | 352 General Services Building +---+ | University of Alberta | | | Edmonton, Alberta | Standard disclaimers apply| | T6G 2H1 | | | CANADA | | +--+---+ XFree86 developer and VP. ATI driver and X server internals. ___ Devel mailing list Devel@XFree86.Org http://XFree86.Org/mailman/listinfo/devel
Re: xterm warning regressions (was Re: CVS Update: xc (branch: trunk))
On Tue, 14 Mar 2006, David Dawes wrote: On Tue, Mar 14, 2006 at 06:49:49PM -0500, Thomas Dickey wrote: than those addressed by the fix for lastlog(). That was using the configure script of course. Perhaps having the particular -D's set by imake would help focus the discussion. gcc -c -O2 -fno-strength-reduce -fno-strict-aliasing -DNO_ASM -Wall -Wpointer-arith -Wstrict-prototypes -Wmissing-prototypes -Wmissing-declarations -Wredundant-decls -Wnested-externs -Wundef -I. -I. -I../../exports/include -I../../exports/include -I../../exports/include/freetype2 -I../../exports/include -Dsun -DSVR4 -D__EXTENSIONS__ -Di386 -D__i386 -D__i386__-DSCROLLBAR_RIGHT -DOPT_WIDE_CHARS -DOPT_LUIT_PROG -DXRENDERFONT -DXFREE86_FT2 -DPROJECTROOT=/usr/X11R6 -DUTMP -DUSE_TTY_GROUP -DOSMAJORVERSION=5 -DOSMINORVERSION=9 main.c thanks -- Thomas E. Dickey http://invisible-island.net ftp://invisible-island.net ___ Devel mailing list Devel@XFree86.Org http://XFree86.Org/mailman/listinfo/devel
xterm warning regressions (was Re: CVS Update: xc (branch: trunk))
On Sun, Mar 12, 2006 at 05:28:02PM -0800, Thomas Dickey wrote: CVSROOT: /home/x-cvs Module name: xc Changes by:[EMAIL PROTECTED] 06/03/12 17:28:02 Log message: 241. Xterm patch #210 (Thomas Dickey). This reinstates the following warnings on Solaris 9: xterm.h:243: warning: redundant redeclaration of `errno' in same scope /usr/include/errno.h:41: warning: previous declaration of `errno' main.c:452: warning: redundant redeclaration of `ptsname' in same scope /usr/include/stdlib.h:170: warning: previous declaration of `ptsname' main.c:2818: warning: unsigned int format, long unsigned int arg (arg 5) and adds this one: main.c:2586: warning: `pty_search' defined but not used David ___ Devel mailing list Devel@XFree86.Org http://XFree86.Org/mailman/listinfo/devel
Re: xterm warning regressions (was Re: CVS Update: xc (branch: trunk))
On Tue, 14 Mar 2006, David Dawes wrote: On Sun, Mar 12, 2006 at 05:28:02PM -0800, Thomas Dickey wrote: CVSROOT:/home/x-cvs Module name:xc Changes by: [EMAIL PROTECTED] 06/03/12 17:28:02 Log message: 241. Xterm patch #210 (Thomas Dickey). This reinstates the following warnings on Solaris 9: xterm.h:243: warning: redundant redeclaration of `errno' in same scope /usr/include/errno.h:41: warning: previous declaration of `errno' I test-built on Solaris 8, 9 and 10 without seeing any warnings other than those addressed by the fix for lastlog(). That was using the configure script of course. Perhaps having the particular -D's set by imake would help focus the discussion. main.c:452: warning: redundant redeclaration of `ptsname' in same scope /usr/include/stdlib.h:170: warning: previous declaration of `ptsname' main.c:2818: warning: unsigned int format, long unsigned int arg (arg 5) and adds this one: main.c:2586: warning: `pty_search' defined but not used yes, that's an annoyance (but the proposed fix reversed the general process of removing special definitions from main.c). -- Thomas E. Dickey http://invisible-island.net ftp://invisible-island.net ___ Devel mailing list Devel@XFree86.Org http://XFree86.Org/mailman/listinfo/devel
Re: xterm warning regressions (was Re: CVS Update: xc (branch: trunk))
On Tue, Mar 14, 2006 at 06:49:49PM -0500, Thomas Dickey wrote: On Tue, 14 Mar 2006, David Dawes wrote: On Sun, Mar 12, 2006 at 05:28:02PM -0800, Thomas Dickey wrote: CVSROOT: /home/x-cvs Module name: xc Changes by: [EMAIL PROTECTED] 06/03/12 17:28:02 Log message: 241. Xterm patch #210 (Thomas Dickey). This reinstates the following warnings on Solaris 9: xterm.h:243: warning: redundant redeclaration of `errno' in same scope /usr/include/errno.h:41: warning: previous declaration of `errno' I test-built on Solaris 8, 9 and 10 without seeing any warnings other than those addressed by the fix for lastlog(). That was using the configure script of course. Perhaps having the particular -D's set by imake would help focus the discussion. gcc -c -O2 -fno-strength-reduce -fno-strict-aliasing -DNO_ASM -Wall -Wpointer-arith -Wstrict-prototypes -Wmissing-prototypes -Wmissing-declarations -Wredundant-decls -Wnested-externs -Wundef -I. -I. -I../../exports/include -I../../exports/include -I../../exports/include/freetype2 -I../../exports/include -Dsun -DSVR4 -D__EXTENSIONS__ -Di386 -D__i386 -D__i386__-DSCROLLBAR_RIGHT -DOPT_WIDE_CHARS -DOPT_LUIT_PROG -DXRENDERFONT -DXFREE86_FT2 -DPROJECTROOT=/usr/X11R6 -DUTMP -DUSE_TTY_GROUP -DOSMAJORVERSION=5 -DOSMINORVERSION=9 main.c main.c:452: warning: redundant redeclaration of `ptsname' in same scope /usr/include/stdlib.h:170: warning: previous declaration of `ptsname' main.c:2818: warning: unsigned int format, long unsigned int arg (arg 5) and adds this one: main.c:2586: warning: `pty_search' defined but not used yes, that's an annoyance (but the proposed fix reversed the general process of removing special definitions from main.c). David ___ Devel mailing list Devel@XFree86.Org http://XFree86.Org/mailman/listinfo/devel
