Re: [jQuery] Broken Build
Why not just force everyone to use UNIX-style endlines (e.g. \n only)? Up until now, that has been the case. To everyone who commits to core: Please watch your endlines, especially in OSX and Windows. --John On 10/8/06, Jörn Zaefferer [EMAIL PROTECTED] wrote: Franck Marcia schrieb: It's not because of the code but because of the data. There are many contributors now, using different OS which means different ways to insert a character when you strike enter :-) In short, the current regexp blockMatch in build/build/lite.js doesn't take '\r' into account. A quick and dirty way to fix the problem is to insert .replace( /\r/g, ) just after readFile(...) and before any other replace. Thanks Franck! I tried your quick and dirty fix for lite: It worked but was awfully slow. To solve the problem, I changed the use of readFile to my own read function, that uses some java classes to replace line ends with a simple \n. At least docs and test build now run again, but lite doesn't, maybe due to limitations of Rhino or due to limitations of my knowledge of Rhino. ___ jQuery mailing list discuss@jquery.com http://jquery.com/discuss/
Re: [jQuery] Broken Build
2006/10/8, Jörn Zaefferer [EMAIL PROTECTED]: the current build script seems to be broken: Only the ajax part of the complete jQuery file is parsed, resulting in a lite version with only ajax docs removed and api docs and tests with only ajax docs/tests. Doing some diff debugging by comparing revisions of the files involved (build.xml, build/js/parse.js etc.) didn't reveal anything. Any ideas? Is this working with the makefile? Hi Jörn, It's not because of the code but because of the data. There are many contributors now, using different OS which means different ways to insert a character when you strike enter :-) In short, the current regexp blockMatch in build/build/lite.js doesn't take '\r' into account. A quick and dirty way to fix the problem is to insert .replace( /\r/g, ) just after readFile(...) and before any other replace. Cheers, Franck. ___ jQuery mailing list discuss@jquery.com http://jquery.com/discuss/
Re: [jQuery] Broken Build
Franck Marcia schrieb: It's not because of the code but because of the data. There are many contributors now, using different OS which means different ways to insert a character when you strike enter :-) In short, the current regexp blockMatch in build/build/lite.js doesn't take '\r' into account. A quick and dirty way to fix the problem is to insert .replace( /\r/g, ) just after readFile(...) and before any other replace. Thanks Franck! I tried your quick and dirty fix for lite: It worked but was awfully slow. To solve the problem, I changed the use of readFile to my own read function, that uses some java classes to replace line ends with a simple \n. At least docs and test build now run again, but lite doesn't, maybe due to limitations of Rhino or due to limitations of my knowledge of Rhino. -- Jörn ___ jQuery mailing list discuss@jquery.com http://jquery.com/discuss/
Re: [jQuery] Broken Build
2006/10/8, Jörn Zaefferer [EMAIL PROTECTED]: I tried your quick and dirty fix for lite: It worked but was awfully slow. This hack works for me and is fast: var blockMatch = /\s*\/\*\*\s*((.|\r\n|\r|\n)*?)\s*\*\/(\r\n|\r|\n)*/g; var f = readFile(arguments[0]).replace( blockMatch, \n ).replace( /\r/g, ).replace( /\n\n+/g, \n\n ); However, I'm not sure it's the best way as I'm not a regexp guru. Franck. ___ jQuery mailing list discuss@jquery.com http://jquery.com/discuss/
Re: [jQuery] Broken Build
I guess it is obvious I'm using a different OS :) -- Brandon Aaron On 10/8/06, Franck Marcia [EMAIL PROTECTED] wrote: 2006/10/8, Jörn Zaefferer [EMAIL PROTECTED]: I tried your quick and dirty fix for lite: It worked but was awfully slow. This hack works for me and is fast: var blockMatch = /\s*\/\*\*\s*((.|\r\n|\r|\n)*?)\s*\*\/(\r\n|\r|\n)*/g; var f = readFile(arguments[0]).replace( blockMatch, \n ).replace( /\r/g, ).replace( /\n\n+/g, \n\n ); However, I'm not sure it's the best way as I'm not a regexp guru. Franck. ___ jQuery mailing list discuss@jquery.com http://jquery.com/discuss/ ___ jQuery mailing list discuss@jquery.com http://jquery.com/discuss/
[jQuery] Broken Build
Hi folks, the current build script seems to be broken: Only the ajax part of the complete jQuery file is parsed, resulting in a lite version with only ajax docs removed and api docs and tests with only ajax docs/tests. Doing some diff debugging by comparing revisions of the files involved (build.xml, build/js/parse.js etc.) didn't reveal anything. Any ideas? Is this working with the makefile? -- Jörn ___ jQuery mailing list discuss@jquery.com http://jquery.com/discuss/
Re: [jQuery] Broken Build
I just did a new checkout and did a make pack and everything seems to be okay. I ran a few of my example pages with it and didn't get any errors. -- Brandon Aaron On 10/7/06, Jörn Zaefferer [EMAIL PROTECTED] wrote: Hi folks, the current build script seems to be broken: Only the ajax part of the complete jQuery file is parsed, resulting in a lite version with only ajax docs removed and api docs and tests with only ajax docs/tests. Doing some diff debugging by comparing revisions of the files involved (build.xml, build/js/parse.js etc.) didn't reveal anything. Any ideas? Is this working with the makefile? -- Jörn ___ jQuery mailing list discuss@jquery.com http://jquery.com/discuss/ ___ jQuery mailing list discuss@jquery.com http://jquery.com/discuss/
