Re: [PATCH 0/5 v4] accel/qaic: Improve bounds checking in encode/decode
On 7/12/2023 12:30 AM, Dan Carpenter wrote: On Tue, Jul 11, 2023 at 11:33:25AM -0600, Jeffrey Hugo wrote: On 7/11/2023 2:20 AM, Dan Carpenter wrote: Fixed in v4: Send the correct [PATCH 1/5] patch. Fixed in v3: Redo messed up threading Fixed two things in v2: Include the file. Change the >= in encode and decode to >. regards, dan carpenter Did you intentionally drop tags from previous versions? Sorry, I kept messing up the resends. For 1-3, 5 Reviewed-by: Jeffrey Hugo Looks like 3,5 are reviewed by Pranjal and also good. I see 5 is also reviewed by Dafna. Expect those to be merged. 1,2 need a review from Pranjal, but I expect all is good and will be merged. I did not see feedback on my question for 4. Would like your feedback before queuing that one up. Sorry, again. Yeah. I think you're right. Could we queue the rest and I will resend 4 separately? I know it's a headache. If not it's fine, I can resend them all. Resend for #4 is still coming, right? I just don't want to forget about it. -Jeff
Re: [PATCH 0/5 v4] accel/qaic: Improve bounds checking in encode/decode
On 7/12/2023 12:30 AM, Dan Carpenter wrote: On Tue, Jul 11, 2023 at 11:33:25AM -0600, Jeffrey Hugo wrote: On 7/11/2023 2:20 AM, Dan Carpenter wrote: Fixed in v4: Send the correct [PATCH 1/5] patch. Fixed in v3: Redo messed up threading Fixed two things in v2: Include the file. Change the >= in encode and decode to >. regards, dan carpenter Did you intentionally drop tags from previous versions? Sorry, I kept messing up the resends. For 1-3, 5 Reviewed-by: Jeffrey Hugo Looks like 3,5 are reviewed by Pranjal and also good. I see 5 is also reviewed by Dafna. Expect those to be merged. 1,2 need a review from Pranjal, but I expect all is good and will be merged. I did not see feedback on my question for 4. Would like your feedback before queuing that one up. Sorry, again. Yeah. I think you're right. Could we queue the rest and I will resend 4 separately? I know it's a headache. If not it's fine, I can resend them all. These all seem independent enough that I don't see splitting out 4 as a problem. -Jeff
Re: [PATCH 0/5 v4] accel/qaic: Improve bounds checking in encode/decode
On Tue, Jul 11, 2023 at 11:33:25AM -0600, Jeffrey Hugo wrote: > On 7/11/2023 2:20 AM, Dan Carpenter wrote: > > Fixed in v4: Send the correct [PATCH 1/5] patch. > > > > Fixed in v3: Redo messed up threading > > > > Fixed two things in v2: Include the file. Change > > the >= in encode and decode to >. > > > > regards, > > dan carpenter > > Did you intentionally drop tags from previous versions? Sorry, I kept messing up the resends. > > For 1-3, 5 > Reviewed-by: Jeffrey Hugo > > Looks like 3,5 are reviewed by Pranjal and also good. I see 5 is also > reviewed by Dafna. Expect those to be merged. 1,2 need a review from > Pranjal, but I expect all is good and will be merged. > > I did not see feedback on my question for 4. Would like your feedback > before queuing that one up. > Sorry, again. Yeah. I think you're right. Could we queue the rest and I will resend 4 separately? I know it's a headache. If not it's fine, I can resend them all. regards, dan carpenter
Re: [PATCH 0/5 v4] accel/qaic: Improve bounds checking in encode/decode
On 7/11/2023 2:20 AM, Dan Carpenter wrote: Fixed in v4: Send the correct [PATCH 1/5] patch. Fixed in v3: Redo messed up threading Fixed two things in v2: Include the file. Change the >= in encode and decode to >. regards, dan carpenter Did you intentionally drop tags from previous versions? For 1-3, 5 Reviewed-by: Jeffrey Hugo Looks like 3,5 are reviewed by Pranjal and also good. I see 5 is also reviewed by Dafna. Expect those to be merged. 1,2 need a review from Pranjal, but I expect all is good and will be merged. I did not see feedback on my question for 4. Would like your feedback before queuing that one up. Overall, thanks for your work. I think we are pretty close to wrapping this up. -Jeff
[PATCH 0/5 v4] accel/qaic: Improve bounds checking in encode/decode
Fixed in v4: Send the correct [PATCH 1/5] patch. Fixed in v3: Redo messed up threading Fixed two things in v2: Include the file. Change the >= in encode and decode to >. regards, dan carpenter
