Re: [PATCH 1/2] drm/drm_file: fix use of uninitialized variable

[Laurent Pinchart]

On Fri, Aug 04, 2023 at 01:57:39PM +0300, Tomi Valkeinen wrote:
> smatch reports:
> 
> drivers/gpu/drm/drm_file.c:967 drm_show_memory_stats() error: uninitialized 
> symbol 'supported_status'.
> 
> 'supported_status' is only set in one code path. I'm not familiar with
> the code to say if that path will always be ran in real life, but
> whether that is the case or not, I think it is good to initialize
> 'supported_status' to 0 to silence the warning (and possibly fix a bug).
> 
> Signed-off-by: Tomi Valkeinen 

Reviewed-by: Laurent Pinchart 

> ---
>  drivers/gpu/drm/drm_file.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/drm_file.c b/drivers/gpu/drm/drm_file.c
> index 883d83bc0e3d..cc06e1836bf5 100644
> --- a/drivers/gpu/drm/drm_file.c
> +++ b/drivers/gpu/drm/drm_file.c
> @@ -924,7 +924,7 @@ void drm_show_memory_stats(struct drm_printer *p, struct 
> drm_file *file)
>  {
>   struct drm_gem_object *obj;
>   struct drm_memory_stats status = {};
> - enum drm_gem_object_status supported_status;
> + enum drm_gem_object_status supported_status = 0;
>   int id;
>  
>   spin_lock(>table_lock);
> 

-- 
Regards,

Laurent Pinchart

[PATCH 1/2] drm/drm_file: fix use of uninitialized variable

[Tomi Valkeinen]

smatch reports:

drivers/gpu/drm/drm_file.c:967 drm_show_memory_stats() error: uninitialized 
symbol 'supported_status'.

'supported_status' is only set in one code path. I'm not familiar with
the code to say if that path will always be ran in real life, but
whether that is the case or not, I think it is good to initialize
'supported_status' to 0 to silence the warning (and possibly fix a bug).

Signed-off-by: Tomi Valkeinen 
---
 drivers/gpu/drm/drm_file.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/drm_file.c b/drivers/gpu/drm/drm_file.c
index 883d83bc0e3d..cc06e1836bf5 100644
--- a/drivers/gpu/drm/drm_file.c
+++ b/drivers/gpu/drm/drm_file.c
@@ -924,7 +924,7 @@ void drm_show_memory_stats(struct drm_printer *p, struct 
drm_file *file)
 {
struct drm_gem_object *obj;
struct drm_memory_stats status = {};
-   enum drm_gem_object_status supported_status;
+   enum drm_gem_object_status supported_status = 0;
int id;
 
spin_lock(>table_lock);

-- 
2.34.1