Re: 3.2-rc2+: Reported regressions from 3.0 and 3.1

2011-12-03 Thread Konrad Rzeszutek Wilk
 From what I can see, you get the following callchain:
 
 start_kernel
 |- setup_arch
 |- x86_init.oem.arch_setup = xen_arch_setup
 
 |- check_bugs
 |- identify_boot_cpu
   |- identify_cpu
   |- select_idle_routine
 
 
 so xen_arch_setup will set pm_idle and select_idle_routine will honour
 it. I'm being told this is run either in the dom0 or the paravirt guest
 and if so, I don't see any issue with this for baremetal. So you can
 have my ACK provided this is tested on baremetal too.

Tested on baremetal and there were no abnormalities. Thanks!
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel


3.2-rc2+: Reported regressions from 3.0 and 3.1

2011-12-01 Thread Borislav Petkov
On Wed, Nov 30, 2011 at 12:59:36PM -0500, Konrad Rzeszutek Wilk wrote:
> On Tue, Nov 29, 2011 at 07:34:28PM +0100, Borislav Petkov wrote:
> > On Tue, Nov 29, 2011 at 01:04:14PM -0500, Konrad Rzeszutek Wilk wrote:
> > > This patch:
> 
> 
> Borislav,
> 
> Thanks for your review comments. How does this patch look? I believe
> I touched upon all of the things you mentioned.
> 
> From eb6dbd80078312c428dde69e9313606b7513a2e6 Mon Sep 17 00:00:00 2001
> From: Konrad Rzeszutek Wilk 
> Date: Mon, 21 Nov 2011 18:02:02 -0500
> Subject: [PATCH] xen/pm_idle: Make pm_idle be default_idle under Xen.
> 
> This patch:
> 
> commit d91ee5863b71e8c90eaf6035bff3078a85e2e7b5
> Author: Len Brown 
> Date:   Fri Apr 1 18:28:35 2011 -0400
> 
> cpuidle: replace xen access to x86 pm_idle and default_idle
> 
> ..scribble on pm_idle and access default_idle,
>have it simply disable_cpuidle() so acpi_idle will not load and
>architecture default HLT will be used.
> 
> idea was to have one call - disable_cpuidle() which would make
> pm_idle not be molested by other code. It disallows cpuidle_idle_call
> to be set to pm_idle (which is excellent). But in the select_idle_routine()
> and idle_setup(), the pm_idle can still be set to either:
> amd_e400_idle, mwait_idle or default_idle. This depends on some
> CPU flags (MWAIT) and in AMD case on the type of CPU.
> 
> In case of mwait_idle we can hit some instances where the hypervisor
> (Amazon EC2 specifically) sets the MWAIT and we get:
> 
> Brought up 2 CPUs
> invalid opcode:  [#1] SMP
> CPU 1
> Modules linked in:
> 
> Pid: 0, comm: swapper Not tainted 3.1.0-0.rc6.git0.3.fc16.x86_64 #1
> RIP: e030:[]  [] mwait_idle+0x6f/0xb4
> RSP: e02b:8801d28ddf10  EFLAGS: 00010082
> RAX: 8801d28dc010 RBX: 8801d28ddfd8 RCX: 
> RDX:  RSI: 0001 RDI: 0001
> RBP: 8801d28ddf10 R08:  R09: 0001
> R10: 0001 R11: 8801d28ddfd8 R12: 81b590d0
> R13:  R14:  R15: 
> FS:  () GS:8801dff81000() knlGS:
> CS:  e033 DS: 002b ES: 002b CR0: 8005003b
> CR2:  CR3: 01a05000 CR4: 2660
> DR0:  DR1:  DR2: 
> DR3:  DR6: 0ff0 DR7: 
> Process swapper (pid: 0, threadinfo 8801d28dc000, task 8801d28cae60)
> Stack:
>  8801d28ddf40 8100e2ed 8801dff8e390 c136dfe72feab515
>    8801d28ddf50 8149ee78
>     
> Call Trace:
>  [] cpu_idle+0xae/0xe8
>  [] cpu_bringup_and_idle+0xe/0x10
> RIP  [] mwait_idle+0x6f/0xb4
>  RSP 
> 
> In case of amd_e400_idle we don't get so spectacular crashes, but
> we do end up making an MSR which is trapped in the hypervisor,
> and then follow it up with a yield hypercall. Meaning we end up
> going to hypervisor twice instead of just once.
> 
> The previous behavior before v3.0 was that pm_idle was set
> to default_idle irregardless of select_idle_routine/idle_setup.
> 
> We want to do that, but only for one specific case: Xen.
> This patch does that.
> 
> Fixes RH BZ #739499 and Ubuntu #881076
> Reported-by: Stefan Bader 
> Signed-off-by: Konrad Rzeszutek Wilk 
> ---
>  arch/x86/include/asm/system.h |1 +
>  arch/x86/kernel/process.c |8 
>  arch/x86/xen/setup.c  |2 +-
>  3 files changed, 10 insertions(+), 1 deletions(-)
> 
> diff --git a/arch/x86/include/asm/system.h b/arch/x86/include/asm/system.h
> index c2ff2a1..2d2f01c 100644
> --- a/arch/x86/include/asm/system.h
> +++ b/arch/x86/include/asm/system.h
> @@ -401,6 +401,7 @@ extern unsigned long arch_align_stack(unsigned long sp);
>  extern void free_init_pages(char *what, unsigned long begin, unsigned long 
> end);
>  
>  void default_idle(void);
> +bool set_pm_idle_to_default(void);
>  
>  void stop_this_cpu(void *dummy);
>  
> diff --git a/arch/x86/kernel/process.c b/arch/x86/kernel/process.c
> index 1f7f8c8..31f47ba 100644
> --- a/arch/x86/kernel/process.c
> +++ b/arch/x86/kernel/process.c
> @@ -404,6 +404,14 @@ void default_idle(void)
>  EXPORT_SYMBOL(default_idle);
>  #endif
>  
> +bool set_pm_idle_to_default(void)
> +{
> + bool ret = !!pm_idle;
> +
> + pm_idle = default_idle;
> +
> + return ret;
> +}
>  void stop_this_cpu(void *dummy)
>  {
>   local_irq_disable();
> diff --git a/arch/x86/xen/setup.c b/arch/x86/xen/setup.c
> index 46d6d21..79dfb57 100644
> --- a/arch/x86/xen/setup.c
> +++ b/arch/x86/xen/setup.c
> @@ -448,6 +448,6 @@ void __init xen_arch_setup(void)
>  #endif
>   disable_cpuidle();
>   boot_option_idle_override = IDLE_HALT;
> -
> + WARN_ON(set_pm_idle_to_default());
>   fiddle_vdso();
>  }



3.2-rc2+: Reported regressions from 3.0 and 3.1

2011-12-01 Thread Konrad Rzeszutek Wilk
> >From what I can see, you get the following callchain:
> 
> start_kernel
> |-> setup_arch
> |-> x86_init.oem.arch_setup = xen_arch_setup
> 
> |-> check_bugs
> |-> identify_boot_cpu
>   |-> identify_cpu
>   |-> select_idle_routine
> 
> 
> so xen_arch_setup will set pm_idle and select_idle_routine will honour
> it. I'm being told this is run either in the dom0 or the paravirt guest
> and if so, I don't see any issue with this for baremetal. So you can
> have my ACK provided this is tested on baremetal too.

Tested on baremetal and there were no abnormalities. Thanks!


Re: 3.2-rc2+: Reported regressions from 3.0 and 3.1

2011-12-01 Thread Borislav Petkov
On Wed, Nov 30, 2011 at 12:59:36PM -0500, Konrad Rzeszutek Wilk wrote:
 On Tue, Nov 29, 2011 at 07:34:28PM +0100, Borislav Petkov wrote:
  On Tue, Nov 29, 2011 at 01:04:14PM -0500, Konrad Rzeszutek Wilk wrote:
   This patch:
 
 
 Borislav,
 
 Thanks for your review comments. How does this patch look? I believe
 I touched upon all of the things you mentioned.
 
 From eb6dbd80078312c428dde69e9313606b7513a2e6 Mon Sep 17 00:00:00 2001
 From: Konrad Rzeszutek Wilk konrad.w...@oracle.com
 Date: Mon, 21 Nov 2011 18:02:02 -0500
 Subject: [PATCH] xen/pm_idle: Make pm_idle be default_idle under Xen.
 
 This patch:
 
 commit d91ee5863b71e8c90eaf6035bff3078a85e2e7b5
 Author: Len Brown len.br...@intel.com
 Date:   Fri Apr 1 18:28:35 2011 -0400
 
 cpuidle: replace xen access to x86 pm_idle and default_idle
 
 ..scribble on pm_idle and access default_idle,
have it simply disable_cpuidle() so acpi_idle will not load and
architecture default HLT will be used.
 
 idea was to have one call - disable_cpuidle() which would make
 pm_idle not be molested by other code. It disallows cpuidle_idle_call
 to be set to pm_idle (which is excellent). But in the select_idle_routine()
 and idle_setup(), the pm_idle can still be set to either:
 amd_e400_idle, mwait_idle or default_idle. This depends on some
 CPU flags (MWAIT) and in AMD case on the type of CPU.
 
 In case of mwait_idle we can hit some instances where the hypervisor
 (Amazon EC2 specifically) sets the MWAIT and we get:
 
 Brought up 2 CPUs
 invalid opcode:  [#1] SMP
 CPU 1
 Modules linked in:
 
 Pid: 0, comm: swapper Not tainted 3.1.0-0.rc6.git0.3.fc16.x86_64 #1
 RIP: e030:[81015d1d]  [81015d1d] mwait_idle+0x6f/0xb4
 RSP: e02b:8801d28ddf10  EFLAGS: 00010082
 RAX: 8801d28dc010 RBX: 8801d28ddfd8 RCX: 
 RDX:  RSI: 0001 RDI: 0001
 RBP: 8801d28ddf10 R08:  R09: 0001
 R10: 0001 R11: 8801d28ddfd8 R12: 81b590d0
 R13:  R14:  R15: 
 FS:  () GS:8801dff81000() knlGS:
 CS:  e033 DS: 002b ES: 002b CR0: 8005003b
 CR2:  CR3: 01a05000 CR4: 2660
 DR0:  DR1:  DR2: 
 DR3:  DR6: 0ff0 DR7: 
 Process swapper (pid: 0, threadinfo 8801d28dc000, task 8801d28cae60)
 Stack:
  8801d28ddf40 8100e2ed 8801dff8e390 c136dfe72feab515
    8801d28ddf50 8149ee78
     
 Call Trace:
  [8100e2ed] cpu_idle+0xae/0xe8
  [8149ee78] cpu_bringup_and_idle+0xe/0x10
 RIP  [81015d1d] mwait_idle+0x6f/0xb4
  RSP 8801d28ddf10
 
 In case of amd_e400_idle we don't get so spectacular crashes, but
 we do end up making an MSR which is trapped in the hypervisor,
 and then follow it up with a yield hypercall. Meaning we end up
 going to hypervisor twice instead of just once.
 
 The previous behavior before v3.0 was that pm_idle was set
 to default_idle irregardless of select_idle_routine/idle_setup.
 
 We want to do that, but only for one specific case: Xen.
 This patch does that.
 
 Fixes RH BZ #739499 and Ubuntu #881076
 Reported-by: Stefan Bader stefan.ba...@canonical.com
 Signed-off-by: Konrad Rzeszutek Wilk konrad.w...@oracle.com
 ---
  arch/x86/include/asm/system.h |1 +
  arch/x86/kernel/process.c |8 
  arch/x86/xen/setup.c  |2 +-
  3 files changed, 10 insertions(+), 1 deletions(-)
 
 diff --git a/arch/x86/include/asm/system.h b/arch/x86/include/asm/system.h
 index c2ff2a1..2d2f01c 100644
 --- a/arch/x86/include/asm/system.h
 +++ b/arch/x86/include/asm/system.h
 @@ -401,6 +401,7 @@ extern unsigned long arch_align_stack(unsigned long sp);
  extern void free_init_pages(char *what, unsigned long begin, unsigned long 
 end);
  
  void default_idle(void);
 +bool set_pm_idle_to_default(void);
  
  void stop_this_cpu(void *dummy);
  
 diff --git a/arch/x86/kernel/process.c b/arch/x86/kernel/process.c
 index 1f7f8c8..31f47ba 100644
 --- a/arch/x86/kernel/process.c
 +++ b/arch/x86/kernel/process.c
 @@ -404,6 +404,14 @@ void default_idle(void)
  EXPORT_SYMBOL(default_idle);
  #endif
  
 +bool set_pm_idle_to_default(void)
 +{
 + bool ret = !!pm_idle;
 +
 + pm_idle = default_idle;
 +
 + return ret;
 +}
  void stop_this_cpu(void *dummy)
  {
   local_irq_disable();
 diff --git a/arch/x86/xen/setup.c b/arch/x86/xen/setup.c
 index 46d6d21..79dfb57 100644
 --- a/arch/x86/xen/setup.c
 +++ b/arch/x86/xen/setup.c
 @@ -448,6 +448,6 @@ void __init xen_arch_setup(void)
  #endif
   disable_cpuidle();
   boot_option_idle_override = IDLE_HALT;
 -
 + WARN_ON(set_pm_idle_to_default());
   fiddle_vdso();
  }

From what I can see, you get the following 

3.2-rc2+: Reported regressions from 3.0 and 3.1

2011-11-30 Thread Konrad Rzeszutek Wilk
On Tue, Nov 29, 2011 at 07:34:28PM +0100, Borislav Petkov wrote:
> On Tue, Nov 29, 2011 at 01:04:14PM -0500, Konrad Rzeszutek Wilk wrote:
> > This patch:


Borislav,

Thanks for your review comments. How does this patch look? I believe
I touched upon all of the things you mentioned.



Re: 3.2-rc2+: Reported regressions from 3.0 and 3.1

2011-11-30 Thread Borislav Petkov
On Tue, Nov 29, 2011 at 01:04:14PM -0500, Konrad Rzeszutek Wilk wrote:
 This patch:
 
 commit d91ee5863b71e8c90eaf6035bff3078a85e2e7b5
 Author: Len Brown len.br...@intel.com
 Date:   Fri Apr 1 18:28:35 2011 -0400
 
 cpuidle: replace xen access to x86 pm_idle and default_idle
 
 ..scribble on pm_idle and access default_idle,
have it simply disable_cpuidle() so acpi_idle will not load and
architecture default HLT will be used.
 
 idea was to have one call - disable_cpuidle() which would make
 pm_idle not be molested by other code. It disallows cpuidle_idle_call
 and acpi_idle_call to not set pm_idle (which is excellent). But the

what is acpi_idle_call, I can't find it anywhere.

 amd_e400_idle and mwait_idle can still setup pm_idle which we really
 do not want.

This is not the case: rather select_idle_routine()/idle_setup() sets
pm_idle.

[..]

 +bool set_pm_idle_to_default()
 +{
 + if (!pm_idle) {
 + pm_idle = default_idle;
 + return true;
 + }
 + return false;
 +}

I don't understand what you're trying to achieve here? Do you want
default_idle to be always the pm_idle for xen or what is the deal here?

If yes, then simply do:

bool set_pm_idle_to_default(void)   // remember to add void for no 
function args
{
bool ret = !!pm_idle;

pm_idle = default_idle;

return ret;

}

...

  void stop_this_cpu(void *dummy)
  {
   local_irq_disable();
 diff --git a/arch/x86/xen/setup.c b/arch/x86/xen/setup.c
 index 46d6d21..7506181 100644
 --- a/arch/x86/xen/setup.c
 +++ b/arch/x86/xen/setup.c
 @@ -448,6 +448,6 @@ void __init xen_arch_setup(void)
  #endif
   disable_cpuidle();
   boot_option_idle_override = IDLE_HALT;
 -
 + WARN_ON(!set_pm_idle_to_default());

and then do

WARN_ON(set_pm_idle_to_default());

instead of having arbitrary confusing logic. This way you can warn
whether something else set pm_idle already. Or?

Thanks.

-- 
Regards/Gruss,
Boris.

Advanced Micro Devices GmbH
Einsteinring 24, 85609 Dornach
GM: Alberto Bozzo
Reg: Dornach, Landkreis Muenchen
HRB Nr. 43632 WEEE Registernr: 129 19551
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel


Re: 3.2-rc2+: Reported regressions from 3.0 and 3.1

2011-11-30 Thread Konrad Rzeszutek Wilk
On Tue, Nov 29, 2011 at 07:34:28PM +0100, Borislav Petkov wrote:
 On Tue, Nov 29, 2011 at 01:04:14PM -0500, Konrad Rzeszutek Wilk wrote:
  This patch:


Borislav,

Thanks for your review comments. How does this patch look? I believe
I touched upon all of the things you mentioned.

From eb6dbd80078312c428dde69e9313606b7513a2e6 Mon Sep 17 00:00:00 2001
From: Konrad Rzeszutek Wilk konrad.w...@oracle.com
Date: Mon, 21 Nov 2011 18:02:02 -0500
Subject: [PATCH] xen/pm_idle: Make pm_idle be default_idle under Xen.

This patch:

commit d91ee5863b71e8c90eaf6035bff3078a85e2e7b5
Author: Len Brown len.br...@intel.com
Date:   Fri Apr 1 18:28:35 2011 -0400

cpuidle: replace xen access to x86 pm_idle and default_idle

..scribble on pm_idle and access default_idle,
   have it simply disable_cpuidle() so acpi_idle will not load and
   architecture default HLT will be used.

idea was to have one call - disable_cpuidle() which would make
pm_idle not be molested by other code. It disallows cpuidle_idle_call
to be set to pm_idle (which is excellent). But in the select_idle_routine()
and idle_setup(), the pm_idle can still be set to either:
amd_e400_idle, mwait_idle or default_idle. This depends on some
CPU flags (MWAIT) and in AMD case on the type of CPU.

In case of mwait_idle we can hit some instances where the hypervisor
(Amazon EC2 specifically) sets the MWAIT and we get:

Brought up 2 CPUs
invalid opcode:  [#1] SMP
CPU 1
Modules linked in:

Pid: 0, comm: swapper Not tainted 3.1.0-0.rc6.git0.3.fc16.x86_64 #1
RIP: e030:[81015d1d]  [81015d1d] mwait_idle+0x6f/0xb4
RSP: e02b:8801d28ddf10  EFLAGS: 00010082
RAX: 8801d28dc010 RBX: 8801d28ddfd8 RCX: 
RDX:  RSI: 0001 RDI: 0001
RBP: 8801d28ddf10 R08:  R09: 0001
R10: 0001 R11: 8801d28ddfd8 R12: 81b590d0
R13:  R14:  R15: 
FS:  () GS:8801dff81000() knlGS:
CS:  e033 DS: 002b ES: 002b CR0: 8005003b
CR2:  CR3: 01a05000 CR4: 2660
DR0:  DR1:  DR2: 
DR3:  DR6: 0ff0 DR7: 
Process swapper (pid: 0, threadinfo 8801d28dc000, task 8801d28cae60)
Stack:
 8801d28ddf40 8100e2ed 8801dff8e390 c136dfe72feab515
   8801d28ddf50 8149ee78
    
Call Trace:
 [8100e2ed] cpu_idle+0xae/0xe8
 [8149ee78] cpu_bringup_and_idle+0xe/0x10
RIP  [81015d1d] mwait_idle+0x6f/0xb4
 RSP 8801d28ddf10

In case of amd_e400_idle we don't get so spectacular crashes, but
we do end up making an MSR which is trapped in the hypervisor,
and then follow it up with a yield hypercall. Meaning we end up
going to hypervisor twice instead of just once.

The previous behavior before v3.0 was that pm_idle was set
to default_idle irregardless of select_idle_routine/idle_setup.

We want to do that, but only for one specific case: Xen.
This patch does that.

Fixes RH BZ #739499 and Ubuntu #881076
Reported-by: Stefan Bader stefan.ba...@canonical.com
Signed-off-by: Konrad Rzeszutek Wilk konrad.w...@oracle.com
---
 arch/x86/include/asm/system.h |1 +
 arch/x86/kernel/process.c |8 
 arch/x86/xen/setup.c  |2 +-
 3 files changed, 10 insertions(+), 1 deletions(-)

diff --git a/arch/x86/include/asm/system.h b/arch/x86/include/asm/system.h
index c2ff2a1..2d2f01c 100644
--- a/arch/x86/include/asm/system.h
+++ b/arch/x86/include/asm/system.h
@@ -401,6 +401,7 @@ extern unsigned long arch_align_stack(unsigned long sp);
 extern void free_init_pages(char *what, unsigned long begin, unsigned long 
end);
 
 void default_idle(void);
+bool set_pm_idle_to_default(void);
 
 void stop_this_cpu(void *dummy);
 
diff --git a/arch/x86/kernel/process.c b/arch/x86/kernel/process.c
index 1f7f8c8..31f47ba 100644
--- a/arch/x86/kernel/process.c
+++ b/arch/x86/kernel/process.c
@@ -404,6 +404,14 @@ void default_idle(void)
 EXPORT_SYMBOL(default_idle);
 #endif
 
+bool set_pm_idle_to_default(void)
+{
+   bool ret = !!pm_idle;
+
+   pm_idle = default_idle;
+
+   return ret;
+}
 void stop_this_cpu(void *dummy)
 {
local_irq_disable();
diff --git a/arch/x86/xen/setup.c b/arch/x86/xen/setup.c
index 46d6d21..79dfb57 100644
--- a/arch/x86/xen/setup.c
+++ b/arch/x86/xen/setup.c
@@ -448,6 +448,6 @@ void __init xen_arch_setup(void)
 #endif
disable_cpuidle();
boot_option_idle_override = IDLE_HALT;
-
+   WARN_ON(set_pm_idle_to_default());
fiddle_vdso();
 }
-- 
1.7.7.3

___
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel


3.2-rc2+: Reported regressions from 3.0 and 3.1

2011-11-29 Thread Borislav Petkov
On Tue, Nov 29, 2011 at 01:04:14PM -0500, Konrad Rzeszutek Wilk wrote:
> This patch:
> 
> commit d91ee5863b71e8c90eaf6035bff3078a85e2e7b5
> Author: Len Brown 
> Date:   Fri Apr 1 18:28:35 2011 -0400
> 
> cpuidle: replace xen access to x86 pm_idle and default_idle
> 
> ..scribble on pm_idle and access default_idle,
>have it simply disable_cpuidle() so acpi_idle will not load and
>architecture default HLT will be used.
> 
> idea was to have one call - disable_cpuidle() which would make
> pm_idle not be molested by other code. It disallows cpuidle_idle_call
> and acpi_idle_call to not set pm_idle (which is excellent). But the

what is acpi_idle_call, I can't find it anywhere.

> amd_e400_idle and mwait_idle can still setup pm_idle which we really
> do not want.

This is not the case: rather select_idle_routine()/idle_setup() sets
pm_idle.

[..]

> +bool set_pm_idle_to_default()
> +{
> + if (!pm_idle) {
> + pm_idle = default_idle;
> + return true;
> + }
> + return false;
> +}

I don't understand what you're trying to achieve here? Do you want
default_idle to be always the pm_idle for xen or what is the deal here?

If yes, then simply do:

bool set_pm_idle_to_default(void)   // remember to add "void" for no 
function args
{
bool ret = !!pm_idle;

pm_idle = default_idle;

return ret;

}

...

>  void stop_this_cpu(void *dummy)
>  {
>   local_irq_disable();
> diff --git a/arch/x86/xen/setup.c b/arch/x86/xen/setup.c
> index 46d6d21..7506181 100644
> --- a/arch/x86/xen/setup.c
> +++ b/arch/x86/xen/setup.c
> @@ -448,6 +448,6 @@ void __init xen_arch_setup(void)
>  #endif
>   disable_cpuidle();
>   boot_option_idle_override = IDLE_HALT;
> -
> + WARN_ON(!set_pm_idle_to_default());

and then do

WARN_ON(set_pm_idle_to_default());

instead of having arbitrary confusing logic. This way you can warn
whether something else set pm_idle already. Or?

Thanks.

-- 
Regards/Gruss,
Boris.

Advanced Micro Devices GmbH
Einsteinring 24, 85609 Dornach
GM: Alberto Bozzo
Reg: Dornach, Landkreis Muenchen
HRB Nr. 43632 WEEE Registernr: 129 19551


3.2-rc2+: Reported regressions from 3.0 and 3.1

2011-11-29 Thread Konrad Rzeszutek Wilk
On Tue, Nov 29, 2011 at 07:34:28PM +0100, Borislav Petkov wrote:
> On Tue, Nov 29, 2011 at 01:04:14PM -0500, Konrad Rzeszutek Wilk wrote:
> > This patch:
> > 
> > commit d91ee5863b71e8c90eaf6035bff3078a85e2e7b5
> > Author: Len Brown 
> > Date:   Fri Apr 1 18:28:35 2011 -0400
> > 
> > cpuidle: replace xen access to x86 pm_idle and default_idle
> > 
> > ..scribble on pm_idle and access default_idle,
> >have it simply disable_cpuidle() so acpi_idle will not load and
> >architecture default HLT will be used.
> > 
> > idea was to have one call - disable_cpuidle() which would make
> > pm_idle not be molested by other code. It disallows cpuidle_idle_call
> > and acpi_idle_call to not set pm_idle (which is excellent). But the
> 
> what is acpi_idle_call, I can't find it anywhere.

You are right. I had "acpi_idle_enter_*" and its friend in mind. Which
are called from the cpuidle_idle_call.

Let me fix that comment up.
> 
> > amd_e400_idle and mwait_idle can still setup pm_idle which we really
> > do not want.
> 
> This is not the case: rather select_idle_routine()/idle_setup() sets
> pm_idle.

Yes. Let me fix up the comment.
> 
> [..]
> 
> > +bool set_pm_idle_to_default()
> > +{
> > +   if (!pm_idle) {
> > +   pm_idle = default_idle;
> > +   return true;
> > +   }
> > +   return false;
> > +}
> 
> I don't understand what you're trying to achieve here? Do you want
> default_idle to be always the pm_idle for xen or what is the deal here?

Yes (always want default_idle).
> 
> If yes, then simply do:
> 
> bool set_pm_idle_to_default(void) // remember to add "void" for no 
> function args
> {
>   bool ret = !!pm_idle;
> 
>   pm_idle = default_idle;

That would work too.
> 
>   return ret;
> 
> }
> 
> ...
> 
> >  void stop_this_cpu(void *dummy) 
> >  {
> > local_irq_disable();
> > diff --git a/arch/x86/xen/setup.c b/arch/x86/xen/setup.c
> > index 46d6d21..7506181 100644
> > --- a/arch/x86/xen/setup.c
> > +++ b/arch/x86/xen/setup.c
> > @@ -448,6 +448,6 @@ void __init xen_arch_setup(void)
> >  #endif
> > disable_cpuidle();
> > boot_option_idle_override = IDLE_HALT;
> > -
> > +   WARN_ON(!set_pm_idle_to_default());
> 
> and then do
> 
>   WARN_ON(set_pm_idle_to_default());
> 
> instead of having arbitrary confusing logic. This way you can warn
> whether something else set pm_idle already. Or?

That would work as well.


3.2-rc2+: Reported regressions from 3.0 and 3.1

2011-11-29 Thread Konrad Rzeszutek Wilk
On Tue, Nov 22, 2011 at 08:54:12AM -0500, Konrad Rzeszutek Wilk wrote:
> > Subject: Regression in 3.1 causes Xen to use wrong idle routine
> > Submitter  : Stefan Bader 
> > Date   : 2011-10-26 10:24
> > Message-ID : 4EA7DFD1.9060608 at canonical.com
> > References : http://marc.info/?l=linux-acpi=131962467924564=2
> 
> The patch mentioned in http://mid.gmane.org/2015144004.GE22675 at 
> phenom.dumpdata.com 
> should do it. But the patch needs an Ack from ACPI/x86 folks.

This patch (mentioned in the URL above) fixes the issue. Could it be
applied to the x86 tree for 3.2 or get an Ack, please?



Re: 3.2-rc2+: Reported regressions from 3.0 and 3.1

2011-11-29 Thread Konrad Rzeszutek Wilk
On Tue, Nov 29, 2011 at 07:34:28PM +0100, Borislav Petkov wrote:
 On Tue, Nov 29, 2011 at 01:04:14PM -0500, Konrad Rzeszutek Wilk wrote:
  This patch:
  
  commit d91ee5863b71e8c90eaf6035bff3078a85e2e7b5
  Author: Len Brown len.br...@intel.com
  Date:   Fri Apr 1 18:28:35 2011 -0400
  
  cpuidle: replace xen access to x86 pm_idle and default_idle
  
  ..scribble on pm_idle and access default_idle,
 have it simply disable_cpuidle() so acpi_idle will not load and
 architecture default HLT will be used.
  
  idea was to have one call - disable_cpuidle() which would make
  pm_idle not be molested by other code. It disallows cpuidle_idle_call
  and acpi_idle_call to not set pm_idle (which is excellent). But the
 
 what is acpi_idle_call, I can't find it anywhere.

You are right. I had acpi_idle_enter_* and its friend in mind. Which
are called from the cpuidle_idle_call.

Let me fix that comment up.
 
  amd_e400_idle and mwait_idle can still setup pm_idle which we really
  do not want.
 
 This is not the case: rather select_idle_routine()/idle_setup() sets
 pm_idle.

Yes. Let me fix up the comment.
 
 [..]
 
  +bool set_pm_idle_to_default()
  +{
  +   if (!pm_idle) {
  +   pm_idle = default_idle;
  +   return true;
  +   }
  +   return false;
  +}
 
 I don't understand what you're trying to achieve here? Do you want
 default_idle to be always the pm_idle for xen or what is the deal here?

Yes (always want default_idle).
 
 If yes, then simply do:
 
 bool set_pm_idle_to_default(void) // remember to add void for no 
 function args
 {
   bool ret = !!pm_idle;
 
   pm_idle = default_idle;

That would work too.
 
   return ret;
 
 }
 
 ...
 
   void stop_this_cpu(void *dummy) 
   {
  local_irq_disable();
  diff --git a/arch/x86/xen/setup.c b/arch/x86/xen/setup.c
  index 46d6d21..7506181 100644
  --- a/arch/x86/xen/setup.c
  +++ b/arch/x86/xen/setup.c
  @@ -448,6 +448,6 @@ void __init xen_arch_setup(void)
   #endif
  disable_cpuidle();
  boot_option_idle_override = IDLE_HALT;
  -
  +   WARN_ON(!set_pm_idle_to_default());
 
 and then do
 
   WARN_ON(set_pm_idle_to_default());
 
 instead of having arbitrary confusing logic. This way you can warn
 whether something else set pm_idle already. Or?

That would work as well.
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel


[PATCH] hugetlb: release pages in the error path of hugetlb_cow() (was: Re: 3.2-rc2+: Reported regressions from 3.0 and 3.1)

2011-11-28 Thread Michal Hocko
On Mon 21-11-11 14:18:29, Linus Torvalds wrote:
> On Mon, Nov 21, 2011 at 1:49 PM, Rafael J. Wysocki  wrote:
> >
> > Subject ? ?: hugetlb oops on 3.1.0-rc8-devel
> > Submitter ?: Andy Lutomirski 
> > Date ? ? ? : 2011-11-01 22:20
> > Message-ID : CALCETrW1mpVCz2tO5roaz1r6vnno+srHR-dHA6_pkRi2qiCfdw at 
> > mail.gmail.com
> > References : http://marc.info/?l=linux-kernel=132018604426692=2
> 
> Despite the subject line, that's not an oops, it's a BUG_ON().
> 
> And it *should* be fixed by commit ea4039a34c4c ("hugetlb: release
> pages in the error path of hugetlb_cow()") although I don't think Andy
> ever confirmed that (since it was hard to trigger).

AFAICS the issue has been introduced by 0fe6e20b (hugetlb, rmap:
add reverse mapping for hugepage) in 2.6.36-rc1 so this is a stable
material. I do not see the patch in any stable branch so here we go.
The patch is on top of 3.0.y branch and it applies as is to 3.1.y
as well.
---


[PATCH] hugetlb: release pages in the error path of hugetlb_cow() (was: Re: 3.2-rc2+: Reported regressions from 3.0 and 3.1)

2011-11-28 Thread Michal Hocko
On Mon 21-11-11 14:18:29, Linus Torvalds wrote:
 On Mon, Nov 21, 2011 at 1:49 PM, Rafael J. Wysocki r...@sisk.pl wrote:
 
  Subject    : hugetlb oops on 3.1.0-rc8-devel
  Submitter  : Andy Lutomirski l...@amacapital.net
  Date       : 2011-11-01 22:20
  Message-ID : 
  calcetrw1mpvcz2to5roaz1r6vnno+srhr-dha6_pkri2qic...@mail.gmail.com
  References : http://marc.info/?l=linux-kernelm=132018604426692w=2
 
 Despite the subject line, that's not an oops, it's a BUG_ON().
 
 And it *should* be fixed by commit ea4039a34c4c (hugetlb: release
 pages in the error path of hugetlb_cow()) although I don't think Andy
 ever confirmed that (since it was hard to trigger).

AFAICS the issue has been introduced by 0fe6e20b (hugetlb, rmap:
add reverse mapping for hugepage) in 2.6.36-rc1 so this is a stable
material. I do not see the patch in any stable branch so here we go.
The patch is on top of 3.0.y branch and it applies as is to 3.1.y
as well.
---
From fdaa4aaa008cce149a5fd60934112acd8988e0b6 Mon Sep 17 00:00:00 2001
From: Hillf Danton dhi...@gmail.com
Date: Tue, 15 Nov 2011 14:36:12 -0800
Subject: [PATCH] hugetlb: release pages in the error path of hugetlb_cow()

commit ea4039a34c4c206d015d34a49d0b00868e37db1d upstream.

If we fail to prepare an anon_vma, the {new, old}_page should be released,
or they will leak.

Signed-off-by: Hillf Danton dhi...@gmail.com
Reviewed-by: Andrea Arcangeli aarca...@redhat.com
Cc: Hugh Dickins hu...@google.com
Cc: Johannes Weiner jwei...@redhat.com
Signed-off-by: Andrew Morton a...@linux-foundation.org
Signed-off-by: Linus Torvalds torva...@linux-foundation.org
---
 mm/hugetlb.c |2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/mm/hugetlb.c b/mm/hugetlb.c
index bfcf153..2b57cd9 100644
--- a/mm/hugetlb.c
+++ b/mm/hugetlb.c
@@ -2415,6 +2415,8 @@ retry_avoidcopy:
 * anon_vma prepared.
 */
if (unlikely(anon_vma_prepare(vma))) {
+   page_cache_release(new_page);
+   page_cache_release(old_page);
/* Caller expects lock to be held */
spin_lock(mm-page_table_lock);
return VM_FAULT_OOM;
-- 
1.7.7.3


-- 
Michal Hocko
SUSE Labs
SUSE LINUX s.r.o.
Lihovarska 1060/12
190 00 Praha 9
Czech Republic
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel


3.2-rc2+: Reported regressions from 3.0 and 3.1

2011-11-23 Thread Rafał Miłecki
W dniu 21 listopada 2011 23:22 u?ytkownik Linus Torvalds
 napisa?:
> On Mon, Nov 21, 2011 at 1:49 PM, Rafael J. Wysocki  wrote:
>>
>> Subject ? ?: [3.1-rc8 REGRESSION] sky2 hangs machine on turning off or 
>> suspending
>> Submitter ?: Rafa? Mi?ecki 
>> Date ? ? ? : 2011-11-09 11:46
>> Message-ID : CACna6ryTdLcWVYgHu=_mRFga1sFivpE_DyZOY-HMmKggkWAJAw at 
>> mail.gmail.com
>> References : http://marc.info/?l=linux-netdev=13208398088=4
>
> This should be fixed by commit 1401a8008a09 ("sky2: fix hang on
> shutdown (and other irq issues)") in current -git.

This patch doesn't fix my hang.

However git contains also:
sky2: fix hang in napi_disable
This is the one fixing my case.

So the bug is resolved, however I'm a little disappointed noone
ping-ed me about that patches. I've spent some time on bisecting this
issue, expected to get some response :/

-- 
Rafa?


3.2-rc2+: Reported regressions from 3.0 and 3.1

2011-11-22 Thread Andrea Arcangeli
On Mon, Nov 21, 2011 at 09:59:18PM -0800, Andrew Morton wrote:
> grr, nothing in that patch's changelog indicates that it fixed a
> regression nor that it fixed an infinite blockage of suspend.

Well it's not a recent thing so I didn't flag it as a regression. It
doesn't infinite block it, suspend works fine almost all the time (or
it would have been noticed before), and if you've bad luck and it
doesn't suspend the first time around like someone experienced, if you
try again a bit later it'll work.

> I moved it to my 3.2 queue, thanks.

Thanks!


3.2-rc2+: Reported regressions from 3.0 and 3.1

2011-11-22 Thread Srivatsa S. Bhat
On 11/22/2011 03:19 AM, Rafael J. Wysocki wrote:
> This message contains a list of some regressions from 3.0 and 3.1
> for which there are no fixes in the mainline known to the tracking team.
> If any of them have been fixed already, please let us know.
> 
> If you know of any other unresolved regressions from 3.0 and 3.1, please let 
> us
> know either and we'll add them to the list.  Also, please let us know if any 
> of
> the entries below are invalid.
> 
> The entries below are simplified and the statistics are not present due to the
> continuing Bugzilla outage.
> 
> Subject: iwlagn is getting very shaky
> Submitter  : Norbert Preining 
> Date   : 2011-10-19 6:01
> Message-ID : 20111019060108.GA11588 at gamma.logic.tuwien.ac.at
> References : http://marc.info/?l=linux-kernel=131914553920614=2
> 
> Subject: Regression: "irqpoll" hasn't been working for me since March 16 
> IRQ
> Submitter  : Edward Donovan 
> Date   : 2011-10-19 22:09
> Message-ID : CADdbW+HXdCPfJu2RTF6zz+ujCmiu_dmZwL2iScuF53p=AaZ1Uw at 
> mail.gmail.com
> References : http://marc.info/?l=linux-kernel=131914554220679=2
> 
> Subject: Regression in 3.1 causes Xen to use wrong idle routine
> Submitter  : Stefan Bader 
> Date   : 2011-10-26 10:24
> Message-ID : 4EA7DFD1.9060608 at canonical.com
> References : http://marc.info/?l=linux-acpi=131962467924564=2
> 
> Subject: 3.1+ iwlwifi lockup
> Submitter  : Dave Jones 
> Date   : 2011-10-31 14:34
> Message-ID : 20111031143408.GA17152 at redhat.com
> References : http://marc.info/?l=linux-kernel=132007169420160=2
> 
> Subject: hugetlb oops on 3.1.0-rc8-devel
> Submitter  : Andy Lutomirski 
> Date   : 2011-11-01 22:20
> Message-ID : CALCETrW1mpVCz2tO5roaz1r6vnno+srHR-dHA6_pkRi2qiCfdw at 
> mail.gmail.com
> References : http://marc.info/?l=linux-kernel=132018604426692=2
> 
> Subject: Simultaneous cat and external keyboard input causing kernel panic
> Submitter  : Timo Jyrinki 
> Date   : 2011-11-03 12:14
> Message-ID : CAJtFfxmovJHspHHKbvBVc4pw+u5mjGmUejCXEzdV+GqE=jVSOQ at 
> mail.gmail.com
> References : http://marc.info/?l=linux-kernel=132032253903074=2
> 
> Subject: Linus GIT - INFO: possible circular locking dependency detected
> Submitter  : Miles Lane 
> Date   : 2011-11-03 15:57
> Message-ID : CAHFgRy8S0xLfhZxTUOEH5A0PL_Fb79-0-gmbQ=9h2D-xMqt1hA at 
> mail.gmail.com
> References : http://marc.info/?l=linux-kernel=132033587908426=2
> 
> Subject: lockdep warning after aa6afca5bcab: "proc: fix races against 
> execve() of /proc/PID/fd**"
> Submitter  : Ari Savolainen 
> Date   : 2011-11-08 3:47
> Message-ID : CAEbykaXYZEFhTgWMm2AfaWQ2SaXYuO_ypTnw+6AVWScOYSCuuw at 
> mail.gmail.com
> References : http://marc.info/?l=linux-kernel=132072413125099=2
> 
> Subject: DMA-API check_sync errors with 3.2
> Submitter  : Josh Boyer 
> Date   : 2011-11-08 17:31
> Message-ID : 2008173153.GE14216 at zod.bos.redhat.com
> References : http://marc.info/?l=linux-kernel=132077357608797=2
> 
> Subject: [3.1-rc8 REGRESSION] sky2 hangs machine on turning off or 
> suspending
> Submitter  : Rafa? Mi?ecki 
> Date   : 2011-11-09 11:46
> Message-ID : CACna6ryTdLcWVYgHu=_mRFga1sFivpE_DyZOY-HMmKggkWAJAw at 
> mail.gmail.com
> References : http://marc.info/?l=linux-netdev=13208398088=4
> 
> Subject: 3.2-rc1 doesn't boot on dual socket opteron without swap
> Submitter  : Niklas Schnelle 
> Date   : 2011-11-10 20:09
> Message-ID : 1320955769.1718.8.camel at jupiter
> References : http://marc.info/?l=linux-kernel=132095583501767=2
> 
> Subject: Sparc-32 doesn't work in 3.1.
> Submitter  : Rob Landley 
> Date   : 2011-11-12 11:22
> Message-ID : 4EBEAB5A.5020809 at landley.net
> References : http://www.spinics.net/lists/kernel/msg1260383.html
> 
> Subject: khugepaged blocks suspend2ram (3.2.0-rc1-00252-g8f042aa)
> Submitter  : Sergei Trofimovich 
> Date   : 2011-11-12 10:48
> Message-ID : 2012104859.7744b282 at sf.home
> References : https://lkml.org/lkml/2011/11/12/11
> 

Andrea's patch already fixes this issue, which was reported first by
Jiri Slaby. https://lkml.org/lkml/2011/11/11/93
I remember Andrew Morton taking this patch in his -mm tree. But it is
not in mainline yet. So can we consider this closed or not?

Thanks,
Srivatsa S. Bhat



3.2-rc2+: Reported regressions from 3.0 and 3.1

2011-11-22 Thread Konrad Rzeszutek Wilk
> Subject: Regression in 3.1 causes Xen to use wrong idle routine
> Submitter  : Stefan Bader 
> Date   : 2011-10-26 10:24
> Message-ID : 4EA7DFD1.9060608 at canonical.com
> References : http://marc.info/?l=linux-acpi=131962467924564=2

The patch mentioned in http://mid.gmane.org/2015144004.GE22675 at 
phenom.dumpdata.com 
should do it. But the patch needs an Ack from ACPI/x86 folks.


3.2-rc2+: Reported regressions from 3.0 and 3.1

2011-11-22 Thread Ari Savolainen
2011/11/22 Linus Torvalds :
> On Mon, Nov 21, 2011 at 1:49 PM, Rafael J. Wysocki  wrote:
>>
>> Subject ? ?: lockdep warning after aa6afca5bcab: "proc: fix races against 
>> execve() of /proc/PID/fd**"
>> Submitter ?: Ari Savolainen 
>> Date ? ? ? : 2011-11-08 3:47
>> Message-ID : CAEbykaXYZEFhTgWMm2AfaWQ2SaXYuO_ypTnw+6AVWScOYSCuuw at 
>> mail.gmail.com
>> References : http://marc.info/?l=linux-kernel=132072413125099=2
>
> Commit aa6afca5bcab was reverted by commit 5e442a493fc5, so this one
> is presumably stale.
>
> ? ? ? ? ? ? ? ? ? ? ?Linus

Yes, this went away after the reversion.

Ari


Re: 3.2-rc2+: Reported regressions from 3.0 and 3.1

2011-11-22 Thread Konrad Rzeszutek Wilk
 Subject: Regression in 3.1 causes Xen to use wrong idle routine
 Submitter  : Stefan Bader stefan.ba...@canonical.com
 Date   : 2011-10-26 10:24
 Message-ID : 4ea7dfd1.9060...@canonical.com
 References : http://marc.info/?l=linux-acpim=131962467924564w=2

The patch mentioned in 
http://mid.gmane.org/2015144004.ge22...@phenom.dumpdata.com 
should do it. But the patch needs an Ack from ACPI/x86 folks.
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel


Re: 3.2-rc2+: Reported regressions from 3.0 and 3.1

2011-11-22 Thread Andy Lutomirski
On Mon, Nov 21, 2011 at 2:34 PM, Andy Lutomirski l...@amacapital.net wrote:
 On Mon, Nov 21, 2011 at 2:11 PM, Linus Torvalds
 torva...@linux-foundation.org wrote:
 On Mon, Nov 21, 2011 at 1:49 PM, Rafael J. Wysocki r...@sisk.pl wrote:

 Subject    : [3.1 REGRESSION] Commit 
 5cec93c216db77c45f7ce970d46283bcb1933884 breaks the Chromium seccomp sandbox
 Submitter  : Nix n...@esperi.org.uk
 Date       : 2011-11-14 0:40
 Message-ID : 8762inleno@spindle.srvr.nix
 References : http://marc.info/?l=linux-kernelm=132123396226377w=2


This is apparently fixed in seccompsandbox.  See:

https://code.google.com/p/seccompsandbox/issues/detail?id=17
https://code.google.com/p/seccompsandbox/source/detail?r=178

Unless someone objects, I'll consider this to not be a kernel
regression worth fixing.

--Andy
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel


Re: 3.2-rc2+: Reported regressions from 3.0 and 3.1

2011-11-22 Thread Andy Lutomirski
On Mon, Nov 21, 2011 at 2:18 PM, Linus Torvalds
torva...@linux-foundation.org wrote:
 On Mon, Nov 21, 2011 at 1:49 PM, Rafael J. Wysocki r...@sisk.pl wrote:

 Subject    : hugetlb oops on 3.1.0-rc8-devel
 Submitter  : Andy Lutomirski l...@amacapital.net
 Date       : 2011-11-01 22:20
 Message-ID : 
 calcetrw1mpvcz2to5roaz1r6vnno+srhr-dha6_pkri2qic...@mail.gmail.com
 References : http://marc.info/?l=linux-kernelm=132018604426692w=2

 Despite the subject line, that's not an oops, it's a BUG_ON().

 And it *should* be fixed by commit ea4039a34c4c (hugetlb: release
 pages in the error path of hugetlb_cow()) although I don't think Andy
 ever confirmed that (since it was hard to trigger).

I haven't seen it again, but that probably doesn't mean anything.
I've also fixed a bug in some userspace software I was running, and
that fix means I'm probably not stressing that part of the kernel
anymore.  (Even without the fix, it took two weeks to hit this.)
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel


Re: 3.2-rc2+: Reported regressions from 3.0 and 3.1

2011-11-22 Thread Andy Lutomirski
On Mon, Nov 21, 2011 at 2:11 PM, Linus Torvalds
torva...@linux-foundation.org wrote:
 On Mon, Nov 21, 2011 at 1:49 PM, Rafael J. Wysocki r...@sisk.pl wrote:

 Subject    : [3.1 REGRESSION] Commit 
 5cec93c216db77c45f7ce970d46283bcb1933884 breaks the Chromium seccomp sandbox
 Submitter  : Nix n...@esperi.org.uk
 Date       : 2011-11-14 0:40
 Message-ID : 8762inleno@spindle.srvr.nix
 References : http://marc.info/?l=linux-kernelm=132123396226377w=2

 So this should be fixed by commit 2b666859ec32 (x86: Default to
 vsyscall=native for now), since we disabled the vsyscall emulation
 because it broken UML too.

I don't think so.  I think the issue is that the chromium sandbox is
trying to use getcpu, time, or gettimeofday from seccomp mode and the
kernel is (IMO correctly) sending it SIGKILL.  Nix can trigger the bug
in vsyscall=native mode, so it's not the emulation.  (If it's
gettimeofday, then it's definitely not a regression.  vgettimeofday
would SIGKILL in seccomp mode with any timing source other than rdtsc
or hpet even on old kernels.)

I sent a patch to show which syscall is causing SIGKILL and haven't
heard back.  Meanwhile, I'm downloading the 1.1GB (!) tarball to see
if I can reproduce it here.  Fedora's build didn't trigger it for me,
probably because the sandbox was disabled.

To try to reduce the incidence of this stuff in the future, and to
make vsyscall=none and UML more useful, I filed this bug:

http://sourceware.org/bugzilla/show_bug.cgi?id=13425

--Andy
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel


Re: 3.2-rc2+: Reported regressions from 3.0 and 3.1

2011-11-22 Thread Srivatsa S. Bhat
On 11/22/2011 03:19 AM, Rafael J. Wysocki wrote:
 This message contains a list of some regressions from 3.0 and 3.1
 for which there are no fixes in the mainline known to the tracking team.
 If any of them have been fixed already, please let us know.
 
 If you know of any other unresolved regressions from 3.0 and 3.1, please let 
 us
 know either and we'll add them to the list.  Also, please let us know if any 
 of
 the entries below are invalid.
 
 The entries below are simplified and the statistics are not present due to the
 continuing Bugzilla outage.
 
 Subject: iwlagn is getting very shaky
 Submitter  : Norbert Preining prein...@logic.at
 Date   : 2011-10-19 6:01
 Message-ID : 20111019060108.ga11...@gamma.logic.tuwien.ac.at
 References : http://marc.info/?l=linux-kernelm=131914553920614w=2
 
 Subject: Regression: irqpoll hasn't been working for me since March 16 
 IRQ
 Submitter  : Edward Donovan edward.dono...@numble.net
 Date   : 2011-10-19 22:09
 Message-ID : 
 CADdbW+HXdCPfJu2RTF6zz+ujCmiu_dmZwL2iScuF53p=aaz...@mail.gmail.com
 References : http://marc.info/?l=linux-kernelm=131914554220679w=2
 
 Subject: Regression in 3.1 causes Xen to use wrong idle routine
 Submitter  : Stefan Bader stefan.ba...@canonical.com
 Date   : 2011-10-26 10:24
 Message-ID : 4ea7dfd1.9060...@canonical.com
 References : http://marc.info/?l=linux-acpim=131962467924564w=2
 
 Subject: 3.1+ iwlwifi lockup
 Submitter  : Dave Jones da...@redhat.com
 Date   : 2011-10-31 14:34
 Message-ID : 20111031143408.ga17...@redhat.com
 References : http://marc.info/?l=linux-kernelm=132007169420160w=2
 
 Subject: hugetlb oops on 3.1.0-rc8-devel
 Submitter  : Andy Lutomirski l...@amacapital.net
 Date   : 2011-11-01 22:20
 Message-ID : 
 calcetrw1mpvcz2to5roaz1r6vnno+srhr-dha6_pkri2qic...@mail.gmail.com
 References : http://marc.info/?l=linux-kernelm=132018604426692w=2
 
 Subject: Simultaneous cat and external keyboard input causing kernel panic
 Submitter  : Timo Jyrinki timo.jyri...@gmail.com
 Date   : 2011-11-03 12:14
 Message-ID : 
 CAJtFfxmovJHspHHKbvBVc4pw+u5mjGmUejCXEzdV+GqE=jv...@mail.gmail.com
 References : http://marc.info/?l=linux-kernelm=132032253903074w=2
 
 Subject: Linus GIT - INFO: possible circular locking dependency detected
 Submitter  : Miles Lane miles.l...@gmail.com
 Date   : 2011-11-03 15:57
 Message-ID : 
 CAHFgRy8S0xLfhZxTUOEH5A0PL_Fb79-0-gmbQ=9h2d-xmqt...@mail.gmail.com
 References : http://marc.info/?l=linux-kernelm=132033587908426w=2
 
 Subject: lockdep warning after aa6afca5bcab: proc: fix races against 
 execve() of /proc/PID/fd**
 Submitter  : Ari Savolainen ari.m.savolai...@gmail.com
 Date   : 2011-11-08 3:47
 Message-ID : 
 caebykaxyzefhtgwmm2afawq2saxyuo_yptnw+6avwscoysc...@mail.gmail.com
 References : http://marc.info/?l=linux-kernelm=132072413125099w=2
 
 Subject: DMA-API check_sync errors with 3.2
 Submitter  : Josh Boyer jwbo...@redhat.com
 Date   : 2011-11-08 17:31
 Message-ID : 2008173153.ge14...@zod.bos.redhat.com
 References : http://marc.info/?l=linux-kernelm=132077357608797w=2
 
 Subject: [3.1-rc8 REGRESSION] sky2 hangs machine on turning off or 
 suspending
 Submitter  : Rafał Miłecki zaj...@gmail.com
 Date   : 2011-11-09 11:46
 Message-ID : 
 CACna6ryTdLcWVYgHu=_mrfga1sfivpe_dyzoy-hmmkggkwa...@mail.gmail.com
 References : http://marc.info/?l=linux-netdevm=13208398088w=4
 
 Subject: 3.2-rc1 doesn't boot on dual socket opteron without swap
 Submitter  : Niklas Schnelle nik...@komani.de
 Date   : 2011-11-10 20:09
 Message-ID : 1320955769.1718.8.camel@jupiter
 References : http://marc.info/?l=linux-kernelm=132095583501767w=2
 
 Subject: Sparc-32 doesn't work in 3.1.
 Submitter  : Rob Landley r...@landley.net
 Date   : 2011-11-12 11:22
 Message-ID : 4ebeab5a.5020...@landley.net
 References : http://www.spinics.net/lists/kernel/msg1260383.html
 
 Subject: khugepaged blocks suspend2ram (3.2.0-rc1-00252-g8f042aa)
 Submitter  : Sergei Trofimovich sly...@gmail.com
 Date   : 2011-11-12 10:48
 Message-ID : 2012104859.7744b...@sf.home
 References : https://lkml.org/lkml/2011/11/12/11
 

Andrea's patch already fixes this issue, which was reported first by
Jiri Slaby. https://lkml.org/lkml/2011/11/11/93
I remember Andrew Morton taking this patch in his -mm tree. But it is
not in mainline yet. So can we consider this closed or not?

Thanks,
Srivatsa S. Bhat

___
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel


Re: 3.2-rc2+: Reported regressions from 3.0 and 3.1

2011-11-22 Thread Andrea Arcangeli
On Mon, Nov 21, 2011 at 09:59:18PM -0800, Andrew Morton wrote:
 grr, nothing in that patch's changelog indicates that it fixed a
 regression nor that it fixed an infinite blockage of suspend.

Well it's not a recent thing so I didn't flag it as a regression. It
doesn't infinite block it, suspend works fine almost all the time (or
it would have been noticed before), and if you've bad luck and it
doesn't suspend the first time around like someone experienced, if you
try again a bit later it'll work.

 I moved it to my 3.2 queue, thanks.

Thanks!
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel


Re: 3.2-rc2+: Reported regressions from 3.0 and 3.1

2011-11-22 Thread Rafał Miłecki
W dniu 21 listopada 2011 23:22 użytkownik Linus Torvalds
torva...@linux-foundation.org napisał:
 On Mon, Nov 21, 2011 at 1:49 PM, Rafael J. Wysocki r...@sisk.pl wrote:

 Subject    : [3.1-rc8 REGRESSION] sky2 hangs machine on turning off or 
 suspending
 Submitter  : Rafał Miłecki zaj...@gmail.com
 Date       : 2011-11-09 11:46
 Message-ID : 
 CACna6ryTdLcWVYgHu=_mrfga1sfivpe_dyzoy-hmmkggkwa...@mail.gmail.com
 References : http://marc.info/?l=linux-netdevm=13208398088w=4

 This should be fixed by commit 1401a8008a09 (sky2: fix hang on
 shutdown (and other irq issues)) in current -git.

This patch doesn't fix my hang.

However git contains also:
sky2: fix hang in napi_disable
This is the one fixing my case.

So the bug is resolved, however I'm a little disappointed noone
ping-ed me about that patches. I've spent some time on bisecting this
issue, expected to get some response :/

-- 
Rafał
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel


3.2-rc2+: Reported regressions from 3.0 and 3.1

2011-11-21 Thread Andy Lutomirski
On Mon, Nov 21, 2011 at 2:34 PM, Andy Lutomirski  wrote:
> On Mon, Nov 21, 2011 at 2:11 PM, Linus Torvalds
>  wrote:
>> On Mon, Nov 21, 2011 at 1:49 PM, Rafael J. Wysocki  wrote:
>>>
>>> Subject ? ?: [3.1 REGRESSION] Commit 
>>> 5cec93c216db77c45f7ce970d46283bcb1933884 breaks the Chromium seccomp sandbox
>>> Submitter ?: Nix 
>>> Date ? ? ? : 2011-11-14 0:40
>>> Message-ID : 8762inleno.fsf at spindle.srvr.nix
>>> References : http://marc.info/?l=linux-kernel=132123396226377=2
>>

This is apparently fixed in seccompsandbox.  See:

https://code.google.com/p/seccompsandbox/issues/detail?id=17
https://code.google.com/p/seccompsandbox/source/detail?r=178

Unless someone objects, I'll consider this to not be a kernel
regression worth fixing.

--Andy


3.2-rc2+: Reported regressions from 3.0 and 3.1

2011-11-21 Thread Rafael J. Wysocki
This message contains a list of some regressions from 3.0 and 3.1
for which there are no fixes in the mainline known to the tracking team.
If any of them have been fixed already, please let us know.

If you know of any other unresolved regressions from 3.0 and 3.1, please let us
know either and we'll add them to the list.  Also, please let us know if any of
the entries below are invalid.

The entries below are simplified and the statistics are not present due to the
continuing Bugzilla outage.

Subject: iwlagn is getting very shaky
Submitter  : Norbert Preining 
Date   : 2011-10-19 6:01
Message-ID : 20111019060108.GA11588 at gamma.logic.tuwien.ac.at
References : http://marc.info/?l=linux-kernel=131914553920614=2

Subject: Regression: "irqpoll" hasn't been working for me since March 16 IRQ
Submitter  : Edward Donovan 
Date   : 2011-10-19 22:09
Message-ID : CADdbW+HXdCPfJu2RTF6zz+ujCmiu_dmZwL2iScuF53p=AaZ1Uw at 
mail.gmail.com
References : http://marc.info/?l=linux-kernel=131914554220679=2

Subject: Regression in 3.1 causes Xen to use wrong idle routine
Submitter  : Stefan Bader 
Date   : 2011-10-26 10:24
Message-ID : 4EA7DFD1.9060608 at canonical.com
References : http://marc.info/?l=linux-acpi=131962467924564=2

Subject: 3.1+ iwlwifi lockup
Submitter  : Dave Jones 
Date   : 2011-10-31 14:34
Message-ID : 20111031143408.GA17152 at redhat.com
References : http://marc.info/?l=linux-kernel=132007169420160=2

Subject: hugetlb oops on 3.1.0-rc8-devel
Submitter  : Andy Lutomirski 
Date   : 2011-11-01 22:20
Message-ID : CALCETrW1mpVCz2tO5roaz1r6vnno+srHR-dHA6_pkRi2qiCfdw at 
mail.gmail.com
References : http://marc.info/?l=linux-kernel=132018604426692=2

Subject: Simultaneous cat and external keyboard input causing kernel panic
Submitter  : Timo Jyrinki 
Date   : 2011-11-03 12:14
Message-ID : CAJtFfxmovJHspHHKbvBVc4pw+u5mjGmUejCXEzdV+GqE=jVSOQ at 
mail.gmail.com
References : http://marc.info/?l=linux-kernel=132032253903074=2

Subject: Linus GIT - INFO: possible circular locking dependency detected
Submitter  : Miles Lane 
Date   : 2011-11-03 15:57
Message-ID : CAHFgRy8S0xLfhZxTUOEH5A0PL_Fb79-0-gmbQ=9h2D-xMqt1hA at 
mail.gmail.com
References : http://marc.info/?l=linux-kernel=132033587908426=2

Subject: lockdep warning after aa6afca5bcab: "proc: fix races against 
execve() of /proc/PID/fd**"
Submitter  : Ari Savolainen 
Date   : 2011-11-08 3:47
Message-ID : CAEbykaXYZEFhTgWMm2AfaWQ2SaXYuO_ypTnw+6AVWScOYSCuuw at 
mail.gmail.com
References : http://marc.info/?l=linux-kernel=132072413125099=2

Subject: DMA-API check_sync errors with 3.2
Submitter  : Josh Boyer 
Date   : 2011-11-08 17:31
Message-ID : 2008173153.GE14216 at zod.bos.redhat.com
References : http://marc.info/?l=linux-kernel=132077357608797=2

Subject: [3.1-rc8 REGRESSION] sky2 hangs machine on turning off or 
suspending
Submitter  : Rafa? Mi?ecki 
Date   : 2011-11-09 11:46
Message-ID : CACna6ryTdLcWVYgHu=_mRFga1sFivpE_DyZOY-HMmKggkWAJAw at 
mail.gmail.com
References : http://marc.info/?l=linux-netdev=13208398088=4

Subject: 3.2-rc1 doesn't boot on dual socket opteron without swap
Submitter  : Niklas Schnelle 
Date   : 2011-11-10 20:09
Message-ID : 1320955769.1718.8.camel at jupiter
References : http://marc.info/?l=linux-kernel=132095583501767=2

Subject: Sparc-32 doesn't work in 3.1.
Submitter  : Rob Landley 
Date   : 2011-11-12 11:22
Message-ID : 4EBEAB5A.5020809 at landley.net
References : http://www.spinics.net/lists/kernel/msg1260383.html

Subject: khugepaged blocks suspend2ram (3.2.0-rc1-00252-g8f042aa)
Submitter  : Sergei Trofimovich 
Date   : 2011-11-12 10:48
Message-ID : 2012104859.7744b282 at sf.home
References : https://lkml.org/lkml/2011/11/12/11

Subject: WARNING: at fs/sysfs/sysfs.h:195 (during boot)
Submitter  : Markus Trippelsdorf 
Date   : 2011-11-13 19:24
Message-ID : 2013192417.GA1659 at x4.trippels.de
References : http://marc.info/?l=linux-kernel=132121231921932=2

Subject: PROBLEM: Radeon display connector : No monitor connected or 
invalid EDID
Submitter  : Treeve Jelbert 
Date   : 2011-11-13 17:27
Message-ID : 2407026.akcTO2Ggic at gemini-64
References : http://marc.info/?l=linux-kernel=132120530920139=2

Subject: [3.1 REGRESSION] Commit 5cec93c216db77c45f7ce970d46283bcb1933884 
breaks the Chromium seccomp sandbox
Submitter  : Nix 
Date   : 2011-11-14 0:40
Message-ID : 8762inleno.fsf at spindle.srvr.nix
References : http://marc.info/?l=linux-kernel=132123396226377=2

Subject: max PWM is zero
Submitter  : Marcos Paulo de Souza 
Date   : 2011-11-15 15:14
Message-ID : alpine.LNX.2.00.151301410.2693 at darkstar.example.net
References : http://marc.info/?l=linux-kernel=132137019330548=2

Subject: Oops on suspend with libertas SDIO (Linux 3.2-rc2)
Submitter  : Sven Neumann 
Date   : 2011-11-17 15:36
Message-ID : 1321544210.31090.6.camel at sven
References : 

3.2-rc2+: Reported regressions from 3.0 and 3.1

2011-11-21 Thread Andrew Morton
On Tue, 22 Nov 2011 11:19:24 +0530 "Srivatsa S. Bhat"  wrote:

> > Subject: khugepaged blocks suspend2ram (3.2.0-rc1-00252-g8f042aa)
> > Submitter  : Sergei Trofimovich 
> > Date   : 2011-11-12 10:48
> > Message-ID : 2012104859.7744b282 at sf.home
> > References : https://lkml.org/lkml/2011/11/12/11
> > 
> 
> Andrea's patch already fixes this issue, which was reported first by
> Jiri Slaby. https://lkml.org/lkml/2011/11/11/93
> I remember Andrew Morton taking this patch in his -mm tree. But it is
> not in mainline yet. So can we consider this closed or not?

grr, nothing in that patch's changelog indicates that it fixed a
regression nor that it fixed an infinite blockage of suspend.

I moved it to my 3.2 queue, thanks.


3.2-rc2+: Reported regressions from 3.0 and 3.1

2011-11-21 Thread Alex Deucher
On Mon, Nov 21, 2011 at 4:49 PM, Rafael J. Wysocki  wrote:
> This message contains a list of some regressions from 3.0 and 3.1
> for which there are no fixes in the mainline known to the tracking team.
> If any of them have been fixed already, please let us know.
>
> If you know of any other unresolved regressions from 3.0 and 3.1, please let 
> us
> know either and we'll add them to the list. ?Also, please let us know if any 
> of
> the entries below are invalid.
>
> The entries below are simplified and the statistics are not present due to the
> continuing Bugzilla outage.
>
> Subject ? ?: iwlagn is getting very shaky
> Submitter ?: Norbert Preining 
> Date ? ? ? : 2011-10-19 6:01
> Message-ID : 20111019060108.GA11588 at gamma.logic.tuwien.ac.at
> References : http://marc.info/?l=linux-kernel=131914553920614=2
>
> Subject ? ?: Regression: "irqpoll" hasn't been working for me since March 16 
> IRQ
> Submitter ?: Edward Donovan 
> Date ? ? ? : 2011-10-19 22:09
> Message-ID : CADdbW+HXdCPfJu2RTF6zz+ujCmiu_dmZwL2iScuF53p=AaZ1Uw at 
> mail.gmail.com
> References : http://marc.info/?l=linux-kernel=131914554220679=2
>
> Subject ? ?: Regression in 3.1 causes Xen to use wrong idle routine
> Submitter ?: Stefan Bader 
> Date ? ? ? : 2011-10-26 10:24
> Message-ID : 4EA7DFD1.9060608 at canonical.com
> References : http://marc.info/?l=linux-acpi=131962467924564=2
>
> Subject ? ?: 3.1+ iwlwifi lockup
> Submitter ?: Dave Jones 
> Date ? ? ? : 2011-10-31 14:34
> Message-ID : 20111031143408.GA17152 at redhat.com
> References : http://marc.info/?l=linux-kernel=132007169420160=2
>
> Subject ? ?: hugetlb oops on 3.1.0-rc8-devel
> Submitter ?: Andy Lutomirski 
> Date ? ? ? : 2011-11-01 22:20
> Message-ID : CALCETrW1mpVCz2tO5roaz1r6vnno+srHR-dHA6_pkRi2qiCfdw at 
> mail.gmail.com
> References : http://marc.info/?l=linux-kernel=132018604426692=2
>
> Subject ? ?: Simultaneous cat and external keyboard input causing kernel panic
> Submitter ?: Timo Jyrinki 
> Date ? ? ? : 2011-11-03 12:14
> Message-ID : CAJtFfxmovJHspHHKbvBVc4pw+u5mjGmUejCXEzdV+GqE=jVSOQ at 
> mail.gmail.com
> References : http://marc.info/?l=linux-kernel=132032253903074=2
>
> Subject ? ?: Linus GIT - INFO: possible circular locking dependency detected
> Submitter ?: Miles Lane 
> Date ? ? ? : 2011-11-03 15:57
> Message-ID : CAHFgRy8S0xLfhZxTUOEH5A0PL_Fb79-0-gmbQ=9h2D-xMqt1hA at 
> mail.gmail.com
> References : http://marc.info/?l=linux-kernel=132033587908426=2
>
> Subject ? ?: lockdep warning after aa6afca5bcab: "proc: fix races against 
> execve() of /proc/PID/fd**"
> Submitter ?: Ari Savolainen 
> Date ? ? ? : 2011-11-08 3:47
> Message-ID : CAEbykaXYZEFhTgWMm2AfaWQ2SaXYuO_ypTnw+6AVWScOYSCuuw at 
> mail.gmail.com
> References : http://marc.info/?l=linux-kernel=132072413125099=2
>
> Subject ? ?: DMA-API check_sync errors with 3.2
> Submitter ?: Josh Boyer 
> Date ? ? ? : 2011-11-08 17:31
> Message-ID : 2008173153.GE14216 at zod.bos.redhat.com
> References : http://marc.info/?l=linux-kernel=132077357608797=2
>
> Subject ? ?: [3.1-rc8 REGRESSION] sky2 hangs machine on turning off or 
> suspending
> Submitter ?: Rafa? Mi?ecki 
> Date ? ? ? : 2011-11-09 11:46
> Message-ID : CACna6ryTdLcWVYgHu=_mRFga1sFivpE_DyZOY-HMmKggkWAJAw at 
> mail.gmail.com
> References : http://marc.info/?l=linux-netdev=13208398088=4
>
> Subject ? ?: 3.2-rc1 doesn't boot on dual socket opteron without swap
> Submitter ?: Niklas Schnelle 
> Date ? ? ? : 2011-11-10 20:09
> Message-ID : 1320955769.1718.8.camel at jupiter
> References : http://marc.info/?l=linux-kernel=132095583501767=2
>
> Subject ? ?: Sparc-32 doesn't work in 3.1.
> Submitter ?: Rob Landley 
> Date ? ? ? : 2011-11-12 11:22
> Message-ID : 4EBEAB5A.5020809 at landley.net
> References : http://www.spinics.net/lists/kernel/msg1260383.html
>
> Subject ? ?: khugepaged blocks suspend2ram (3.2.0-rc1-00252-g8f042aa)
> Submitter ?: Sergei Trofimovich 
> Date ? ? ? : 2011-11-12 10:48
> Message-ID : 2012104859.7744b282 at sf.home
> References : https://lkml.org/lkml/2011/11/12/11
>
> Subject ? ?: WARNING: at fs/sysfs/sysfs.h:195 (during boot)
> Submitter ?: Markus Trippelsdorf 
> Date ? ? ? : 2011-11-13 19:24
> Message-ID : 2013192417.GA1659 at x4.trippels.de
> References : http://marc.info/?l=linux-kernel=132121231921932=2
>
> Subject ? ?: PROBLEM: Radeon display connector : No monitor connected or 
> invalid EDID
> Submitter ?: Treeve Jelbert 
> Date ? ? ? : 2011-11-13 17:27
> Message-ID : 2407026.akcTO2Ggic at gemini-64
> References : http://marc.info/?l=linux-kernel=132120530920139=2

Treeve replied to me directly saying the it was a problem with his
config file and everything is working fine now.

Alex

>
> Subject ? ?: [3.1 REGRESSION] Commit 5cec93c216db77c45f7ce970d46283bcb1933884 
> breaks the Chromium seccomp sandbox
> Submitter ?: Nix 
> Date ? ? ? : 2011-11-14 0:40
> Message-ID : 8762inleno.fsf at spindle.srvr.nix
> References : http://marc.info/?l=linux-kernel=132123396226377=2
>
> Subject ? ?: max PWM is zero

3.2-rc2+: Reported regressions from 3.0 and 3.1

2011-11-21 Thread Andy Lutomirski
On Mon, Nov 21, 2011 at 2:11 PM, Linus Torvalds
 wrote:
> On Mon, Nov 21, 2011 at 1:49 PM, Rafael J. Wysocki  wrote:
>>
>> Subject ? ?: [3.1 REGRESSION] Commit 
>> 5cec93c216db77c45f7ce970d46283bcb1933884 breaks the Chromium seccomp sandbox
>> Submitter ?: Nix 
>> Date ? ? ? : 2011-11-14 0:40
>> Message-ID : 8762inleno.fsf at spindle.srvr.nix
>> References : http://marc.info/?l=linux-kernel=132123396226377=2
>
> So this should be fixed by commit 2b666859ec32 ("x86: Default to
> vsyscall=native for now"), since we disabled the vsyscall emulation
> because it broken UML too.

I don't think so.  I think the issue is that the chromium sandbox is
trying to use getcpu, time, or gettimeofday from seccomp mode and the
kernel is (IMO correctly) sending it SIGKILL.  Nix can trigger the bug
in vsyscall=native mode, so it's not the emulation.  (If it's
gettimeofday, then it's definitely not a regression.  vgettimeofday
would SIGKILL in seccomp mode with any timing source other than rdtsc
or hpet even on old kernels.)

I sent a patch to show which syscall is causing SIGKILL and haven't
heard back.  Meanwhile, I'm downloading the 1.1GB (!) tarball to see
if I can reproduce it here.  Fedora's build didn't trigger it for me,
probably because the sandbox was disabled.

To try to reduce the incidence of this stuff in the future, and to
make vsyscall=none and UML more useful, I filed this bug:

http://sourceware.org/bugzilla/show_bug.cgi?id=13425

--Andy


3.2-rc2+: Reported regressions from 3.0 and 3.1

2011-11-21 Thread Andy Lutomirski
On Mon, Nov 21, 2011 at 2:18 PM, Linus Torvalds
 wrote:
> On Mon, Nov 21, 2011 at 1:49 PM, Rafael J. Wysocki  wrote:
>>
>> Subject ? ?: hugetlb oops on 3.1.0-rc8-devel
>> Submitter ?: Andy Lutomirski 
>> Date ? ? ? : 2011-11-01 22:20
>> Message-ID : CALCETrW1mpVCz2tO5roaz1r6vnno+srHR-dHA6_pkRi2qiCfdw at 
>> mail.gmail.com
>> References : http://marc.info/?l=linux-kernel=132018604426692=2
>
> Despite the subject line, that's not an oops, it's a BUG_ON().
>
> And it *should* be fixed by commit ea4039a34c4c ("hugetlb: release
> pages in the error path of hugetlb_cow()") although I don't think Andy
> ever confirmed that (since it was hard to trigger).

I haven't seen it again, but that probably doesn't mean anything.
I've also fixed a bug in some userspace software I was running, and
that fix means I'm probably not stressing that part of the kernel
anymore.  (Even without the fix, it took two weeks to hit this.)


3.2-rc2+: Reported regressions from 3.0 and 3.1

2011-11-21 Thread Linus Torvalds
On Mon, Nov 21, 2011 at 1:49 PM, Rafael J. Wysocki  wrote:
>
> Subject ? ?: [3.1-rc8 REGRESSION] sky2 hangs machine on turning off or 
> suspending
> Submitter ?: Rafa? Mi?ecki 
> Date ? ? ? : 2011-11-09 11:46
> Message-ID : CACna6ryTdLcWVYgHu=_mRFga1sFivpE_DyZOY-HMmKggkWAJAw at 
> mail.gmail.com
> References : http://marc.info/?l=linux-netdev=13208398088=4

This should be fixed by commit 1401a8008a09 ("sky2: fix hang on
shutdown (and other irq issues)") in current -git.

   Linus


3.2-rc2+: Reported regressions from 3.0 and 3.1

2011-11-21 Thread Linus Torvalds
On Mon, Nov 21, 2011 at 1:49 PM, Rafael J. Wysocki  wrote:
>
> Subject ? ?: lockdep warning after aa6afca5bcab: "proc: fix races against 
> execve() of /proc/PID/fd**"
> Submitter ?: Ari Savolainen 
> Date ? ? ? : 2011-11-08 3:47
> Message-ID : CAEbykaXYZEFhTgWMm2AfaWQ2SaXYuO_ypTnw+6AVWScOYSCuuw at 
> mail.gmail.com
> References : http://marc.info/?l=linux-kernel=132072413125099=2

Commit aa6afca5bcab was reverted by commit 5e442a493fc5, so this one
is presumably stale.

  Linus


3.2-rc2+: Reported regressions from 3.0 and 3.1

2011-11-21 Thread Linus Torvalds
On Mon, Nov 21, 2011 at 1:49 PM, Rafael J. Wysocki  wrote:
>
> Subject ? ?: hugetlb oops on 3.1.0-rc8-devel
> Submitter ?: Andy Lutomirski 
> Date ? ? ? : 2011-11-01 22:20
> Message-ID : CALCETrW1mpVCz2tO5roaz1r6vnno+srHR-dHA6_pkRi2qiCfdw at 
> mail.gmail.com
> References : http://marc.info/?l=linux-kernel=132018604426692=2

Despite the subject line, that's not an oops, it's a BUG_ON().

And it *should* be fixed by commit ea4039a34c4c ("hugetlb: release
pages in the error path of hugetlb_cow()") although I don't think Andy
ever confirmed that (since it was hard to trigger).

 Linus


3.2-rc2+: Reported regressions from 3.0 and 3.1

2011-11-21 Thread Linus Torvalds
On Mon, Nov 21, 2011 at 1:49 PM, Rafael J. Wysocki  wrote:
>
> Subject ? ?: [3.1 REGRESSION] Commit 5cec93c216db77c45f7ce970d46283bcb1933884 
> breaks the Chromium seccomp sandbox
> Submitter ?: Nix 
> Date ? ? ? : 2011-11-14 0:40
> Message-ID : 8762inleno.fsf at spindle.srvr.nix
> References : http://marc.info/?l=linux-kernel=132123396226377=2

So this should be fixed by commit 2b666859ec32 ("x86: Default to
vsyscall=native for now"), since we disabled the vsyscall emulation
because it broken UML too.

Of course, the chromium seccomp thing might re-surface with the
patches that enable the emulation (with better emulation), which Andy
is still working on, and that I was planning on merging for 3.3.

Andy, it migth be worth contacting Nix and having him test whether
your fixed emulation works for chromium too.

  Linus


3.2-rc2+: Reported regressions from 3.0 and 3.1

2011-11-21 Thread Linus Torvalds
On Mon, Nov 21, 2011 at 1:49 PM, Rafael J. Wysocki  wrote:
>
> Subject ? ?: Simultaneous cat and external keyboard input causing kernel panic
> Submitter ?: Timo Jyrinki 
> Date ? ? ? : 2011-11-03 12:14
> Message-ID : CAJtFfxmovJHspHHKbvBVc4pw+u5mjGmUejCXEzdV+GqE=jVSOQ at 
> mail.gmail.com
> References : http://marc.info/?l=linux-kernel=132032253903074=2

So while funny, I doubt this is actually a bug. It's a feature, as
pointed out by Clemens Ladisch in that thread.

It's simply sysrq-c: "perform a system crash by a NULL pointer dereference".

Now, I'm perfectly willing to consider that feature to be a
mis-feature, and that this should be considered a bug to be fixed. But
it is not a regression.

Keeping it on the regression list just because it is amusing is
understandable, though ;)

Linus


Re: 3.2-rc2+: Reported regressions from 3.0 and 3.1

2011-11-21 Thread Linus Torvalds
On Mon, Nov 21, 2011 at 1:49 PM, Rafael J. Wysocki r...@sisk.pl wrote:

 Subject    : Simultaneous cat and external keyboard input causing kernel panic
 Submitter  : Timo Jyrinki timo.jyri...@gmail.com
 Date       : 2011-11-03 12:14
 Message-ID : 
 CAJtFfxmovJHspHHKbvBVc4pw+u5mjGmUejCXEzdV+GqE=jv...@mail.gmail.com
 References : http://marc.info/?l=linux-kernelm=132032253903074w=2

So while funny, I doubt this is actually a bug. It's a feature, as
pointed out by Clemens Ladisch in that thread.

It's simply sysrq-c: perform a system crash by a NULL pointer dereference.

Now, I'm perfectly willing to consider that feature to be a
mis-feature, and that this should be considered a bug to be fixed. But
it is not a regression.

Keeping it on the regression list just because it is amusing is
understandable, though ;)

Linus
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel


Re: 3.2-rc2+: Reported regressions from 3.0 and 3.1

2011-11-21 Thread Linus Torvalds
On Mon, Nov 21, 2011 at 1:49 PM, Rafael J. Wysocki r...@sisk.pl wrote:

 Subject    : [3.1 REGRESSION] Commit 5cec93c216db77c45f7ce970d46283bcb1933884 
 breaks the Chromium seccomp sandbox
 Submitter  : Nix n...@esperi.org.uk
 Date       : 2011-11-14 0:40
 Message-ID : 8762inleno@spindle.srvr.nix
 References : http://marc.info/?l=linux-kernelm=132123396226377w=2

So this should be fixed by commit 2b666859ec32 (x86: Default to
vsyscall=native for now), since we disabled the vsyscall emulation
because it broken UML too.

Of course, the chromium seccomp thing might re-surface with the
patches that enable the emulation (with better emulation), which Andy
is still working on, and that I was planning on merging for 3.3.

Andy, it migth be worth contacting Nix and having him test whether
your fixed emulation works for chromium too.

  Linus
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel


3.2-rc2+: Reported regressions from 3.0 and 3.1

2011-11-21 Thread Rafael J. Wysocki
This message contains a list of some regressions from 3.0 and 3.1
for which there are no fixes in the mainline known to the tracking team.
If any of them have been fixed already, please let us know.

If you know of any other unresolved regressions from 3.0 and 3.1, please let us
know either and we'll add them to the list.  Also, please let us know if any of
the entries below are invalid.

The entries below are simplified and the statistics are not present due to the
continuing Bugzilla outage.

Subject: iwlagn is getting very shaky
Submitter  : Norbert Preining prein...@logic.at
Date   : 2011-10-19 6:01
Message-ID : 20111019060108.ga11...@gamma.logic.tuwien.ac.at
References : http://marc.info/?l=linux-kernelm=131914553920614w=2

Subject: Regression: irqpoll hasn't been working for me since March 16 IRQ
Submitter  : Edward Donovan edward.dono...@numble.net
Date   : 2011-10-19 22:09
Message-ID : CADdbW+HXdCPfJu2RTF6zz+ujCmiu_dmZwL2iScuF53p=aaz...@mail.gmail.com
References : http://marc.info/?l=linux-kernelm=131914554220679w=2

Subject: Regression in 3.1 causes Xen to use wrong idle routine
Submitter  : Stefan Bader stefan.ba...@canonical.com
Date   : 2011-10-26 10:24
Message-ID : 4ea7dfd1.9060...@canonical.com
References : http://marc.info/?l=linux-acpim=131962467924564w=2

Subject: 3.1+ iwlwifi lockup
Submitter  : Dave Jones da...@redhat.com
Date   : 2011-10-31 14:34
Message-ID : 20111031143408.ga17...@redhat.com
References : http://marc.info/?l=linux-kernelm=132007169420160w=2

Subject: hugetlb oops on 3.1.0-rc8-devel
Submitter  : Andy Lutomirski l...@amacapital.net
Date   : 2011-11-01 22:20
Message-ID : calcetrw1mpvcz2to5roaz1r6vnno+srhr-dha6_pkri2qic...@mail.gmail.com
References : http://marc.info/?l=linux-kernelm=132018604426692w=2

Subject: Simultaneous cat and external keyboard input causing kernel panic
Submitter  : Timo Jyrinki timo.jyri...@gmail.com
Date   : 2011-11-03 12:14
Message-ID : CAJtFfxmovJHspHHKbvBVc4pw+u5mjGmUejCXEzdV+GqE=jv...@mail.gmail.com
References : http://marc.info/?l=linux-kernelm=132032253903074w=2

Subject: Linus GIT - INFO: possible circular locking dependency detected
Submitter  : Miles Lane miles.l...@gmail.com
Date   : 2011-11-03 15:57
Message-ID : CAHFgRy8S0xLfhZxTUOEH5A0PL_Fb79-0-gmbQ=9h2d-xmqt...@mail.gmail.com
References : http://marc.info/?l=linux-kernelm=132033587908426w=2

Subject: lockdep warning after aa6afca5bcab: proc: fix races against 
execve() of /proc/PID/fd**
Submitter  : Ari Savolainen ari.m.savolai...@gmail.com
Date   : 2011-11-08 3:47
Message-ID : caebykaxyzefhtgwmm2afawq2saxyuo_yptnw+6avwscoysc...@mail.gmail.com
References : http://marc.info/?l=linux-kernelm=132072413125099w=2

Subject: DMA-API check_sync errors with 3.2
Submitter  : Josh Boyer jwbo...@redhat.com
Date   : 2011-11-08 17:31
Message-ID : 2008173153.ge14...@zod.bos.redhat.com
References : http://marc.info/?l=linux-kernelm=132077357608797w=2

Subject: [3.1-rc8 REGRESSION] sky2 hangs machine on turning off or 
suspending
Submitter  : Rafał Miłecki zaj...@gmail.com
Date   : 2011-11-09 11:46
Message-ID : CACna6ryTdLcWVYgHu=_mrfga1sfivpe_dyzoy-hmmkggkwa...@mail.gmail.com
References : http://marc.info/?l=linux-netdevm=13208398088w=4

Subject: 3.2-rc1 doesn't boot on dual socket opteron without swap
Submitter  : Niklas Schnelle nik...@komani.de
Date   : 2011-11-10 20:09
Message-ID : 1320955769.1718.8.camel@jupiter
References : http://marc.info/?l=linux-kernelm=132095583501767w=2

Subject: Sparc-32 doesn't work in 3.1.
Submitter  : Rob Landley r...@landley.net
Date   : 2011-11-12 11:22
Message-ID : 4ebeab5a.5020...@landley.net
References : http://www.spinics.net/lists/kernel/msg1260383.html

Subject: khugepaged blocks suspend2ram (3.2.0-rc1-00252-g8f042aa)
Submitter  : Sergei Trofimovich sly...@gmail.com
Date   : 2011-11-12 10:48
Message-ID : 2012104859.7744b...@sf.home
References : https://lkml.org/lkml/2011/11/12/11

Subject: WARNING: at fs/sysfs/sysfs.h:195 (during boot)
Submitter  : Markus Trippelsdorf mar...@trippelsdorf.de
Date   : 2011-11-13 19:24
Message-ID : 2013192417.ga1...@x4.trippels.de
References : http://marc.info/?l=linux-kernelm=132121231921932w=2

Subject: PROBLEM: Radeon display connector : No monitor connected or 
invalid EDID
Submitter  : Treeve Jelbert tre...@scarlet.be
Date   : 2011-11-13 17:27
Message-ID : 2407026.akcTO2Ggic@gemini-64
References : http://marc.info/?l=linux-kernelm=132120530920139w=2

Subject: [3.1 REGRESSION] Commit 5cec93c216db77c45f7ce970d46283bcb1933884 
breaks the Chromium seccomp sandbox
Submitter  : Nix n...@esperi.org.uk
Date   : 2011-11-14 0:40
Message-ID : 8762inleno@spindle.srvr.nix
References : http://marc.info/?l=linux-kernelm=132123396226377w=2

Subject: max PWM is zero
Submitter  : Marcos Paulo de Souza marcos.m...@gmail.com
Date   : 2011-11-15 15:14
Message-ID : 

Re: 3.2-rc2+: Reported regressions from 3.0 and 3.1

2011-11-21 Thread Linus Torvalds
On Mon, Nov 21, 2011 at 1:49 PM, Rafael J. Wysocki r...@sisk.pl wrote:

 Subject    : hugetlb oops on 3.1.0-rc8-devel
 Submitter  : Andy Lutomirski l...@amacapital.net
 Date       : 2011-11-01 22:20
 Message-ID : 
 calcetrw1mpvcz2to5roaz1r6vnno+srhr-dha6_pkri2qic...@mail.gmail.com
 References : http://marc.info/?l=linux-kernelm=132018604426692w=2

Despite the subject line, that's not an oops, it's a BUG_ON().

And it *should* be fixed by commit ea4039a34c4c (hugetlb: release
pages in the error path of hugetlb_cow()) although I don't think Andy
ever confirmed that (since it was hard to trigger).

 Linus
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel


Re: 3.2-rc2+: Reported regressions from 3.0 and 3.1

2011-11-21 Thread Linus Torvalds
On Mon, Nov 21, 2011 at 1:49 PM, Rafael J. Wysocki r...@sisk.pl wrote:

 Subject    : [3.1-rc8 REGRESSION] sky2 hangs machine on turning off or 
 suspending
 Submitter  : Rafał Miłecki zaj...@gmail.com
 Date       : 2011-11-09 11:46
 Message-ID : 
 CACna6ryTdLcWVYgHu=_mrfga1sfivpe_dyzoy-hmmkggkwa...@mail.gmail.com
 References : http://marc.info/?l=linux-netdevm=13208398088w=4

This should be fixed by commit 1401a8008a09 (sky2: fix hang on
shutdown (and other irq issues)) in current -git.

   Linus
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel


Re: 3.2-rc2+: Reported regressions from 3.0 and 3.1

2011-11-21 Thread Alex Deucher
On Mon, Nov 21, 2011 at 4:49 PM, Rafael J. Wysocki r...@sisk.pl wrote:
 This message contains a list of some regressions from 3.0 and 3.1
 for which there are no fixes in the mainline known to the tracking team.
 If any of them have been fixed already, please let us know.

 If you know of any other unresolved regressions from 3.0 and 3.1, please let 
 us
 know either and we'll add them to the list.  Also, please let us know if any 
 of
 the entries below are invalid.

 The entries below are simplified and the statistics are not present due to the
 continuing Bugzilla outage.

 Subject    : iwlagn is getting very shaky
 Submitter  : Norbert Preining prein...@logic.at
 Date       : 2011-10-19 6:01
 Message-ID : 20111019060108.ga11...@gamma.logic.tuwien.ac.at
 References : http://marc.info/?l=linux-kernelm=131914553920614w=2

 Subject    : Regression: irqpoll hasn't been working for me since March 16 
 IRQ
 Submitter  : Edward Donovan edward.dono...@numble.net
 Date       : 2011-10-19 22:09
 Message-ID : 
 CADdbW+HXdCPfJu2RTF6zz+ujCmiu_dmZwL2iScuF53p=aaz...@mail.gmail.com
 References : http://marc.info/?l=linux-kernelm=131914554220679w=2

 Subject    : Regression in 3.1 causes Xen to use wrong idle routine
 Submitter  : Stefan Bader stefan.ba...@canonical.com
 Date       : 2011-10-26 10:24
 Message-ID : 4ea7dfd1.9060...@canonical.com
 References : http://marc.info/?l=linux-acpim=131962467924564w=2

 Subject    : 3.1+ iwlwifi lockup
 Submitter  : Dave Jones da...@redhat.com
 Date       : 2011-10-31 14:34
 Message-ID : 20111031143408.ga17...@redhat.com
 References : http://marc.info/?l=linux-kernelm=132007169420160w=2

 Subject    : hugetlb oops on 3.1.0-rc8-devel
 Submitter  : Andy Lutomirski l...@amacapital.net
 Date       : 2011-11-01 22:20
 Message-ID : 
 calcetrw1mpvcz2to5roaz1r6vnno+srhr-dha6_pkri2qic...@mail.gmail.com
 References : http://marc.info/?l=linux-kernelm=132018604426692w=2

 Subject    : Simultaneous cat and external keyboard input causing kernel panic
 Submitter  : Timo Jyrinki timo.jyri...@gmail.com
 Date       : 2011-11-03 12:14
 Message-ID : 
 CAJtFfxmovJHspHHKbvBVc4pw+u5mjGmUejCXEzdV+GqE=jv...@mail.gmail.com
 References : http://marc.info/?l=linux-kernelm=132032253903074w=2

 Subject    : Linus GIT - INFO: possible circular locking dependency detected
 Submitter  : Miles Lane miles.l...@gmail.com
 Date       : 2011-11-03 15:57
 Message-ID : 
 CAHFgRy8S0xLfhZxTUOEH5A0PL_Fb79-0-gmbQ=9h2d-xmqt...@mail.gmail.com
 References : http://marc.info/?l=linux-kernelm=132033587908426w=2

 Subject    : lockdep warning after aa6afca5bcab: proc: fix races against 
 execve() of /proc/PID/fd**
 Submitter  : Ari Savolainen ari.m.savolai...@gmail.com
 Date       : 2011-11-08 3:47
 Message-ID : 
 caebykaxyzefhtgwmm2afawq2saxyuo_yptnw+6avwscoysc...@mail.gmail.com
 References : http://marc.info/?l=linux-kernelm=132072413125099w=2

 Subject    : DMA-API check_sync errors with 3.2
 Submitter  : Josh Boyer jwbo...@redhat.com
 Date       : 2011-11-08 17:31
 Message-ID : 2008173153.ge14...@zod.bos.redhat.com
 References : http://marc.info/?l=linux-kernelm=132077357608797w=2

 Subject    : [3.1-rc8 REGRESSION] sky2 hangs machine on turning off or 
 suspending
 Submitter  : Rafał Miłecki zaj...@gmail.com
 Date       : 2011-11-09 11:46
 Message-ID : 
 CACna6ryTdLcWVYgHu=_mrfga1sfivpe_dyzoy-hmmkggkwa...@mail.gmail.com
 References : http://marc.info/?l=linux-netdevm=13208398088w=4

 Subject    : 3.2-rc1 doesn't boot on dual socket opteron without swap
 Submitter  : Niklas Schnelle nik...@komani.de
 Date       : 2011-11-10 20:09
 Message-ID : 1320955769.1718.8.camel@jupiter
 References : http://marc.info/?l=linux-kernelm=132095583501767w=2

 Subject    : Sparc-32 doesn't work in 3.1.
 Submitter  : Rob Landley r...@landley.net
 Date       : 2011-11-12 11:22
 Message-ID : 4ebeab5a.5020...@landley.net
 References : http://www.spinics.net/lists/kernel/msg1260383.html

 Subject    : khugepaged blocks suspend2ram (3.2.0-rc1-00252-g8f042aa)
 Submitter  : Sergei Trofimovich sly...@gmail.com
 Date       : 2011-11-12 10:48
 Message-ID : 2012104859.7744b...@sf.home
 References : https://lkml.org/lkml/2011/11/12/11

 Subject    : WARNING: at fs/sysfs/sysfs.h:195 (during boot)
 Submitter  : Markus Trippelsdorf mar...@trippelsdorf.de
 Date       : 2011-11-13 19:24
 Message-ID : 2013192417.ga1...@x4.trippels.de
 References : http://marc.info/?l=linux-kernelm=132121231921932w=2

 Subject    : PROBLEM: Radeon display connector : No monitor connected or 
 invalid EDID
 Submitter  : Treeve Jelbert tre...@scarlet.be
 Date       : 2011-11-13 17:27
 Message-ID : 2407026.akcTO2Ggic@gemini-64
 References : http://marc.info/?l=linux-kernelm=132120530920139w=2

Treeve replied to me directly saying the it was a problem with his
config file and everything is working fine now.

Alex


 Subject    : [3.1 REGRESSION] Commit 5cec93c216db77c45f7ce970d46283bcb1933884 
 breaks the Chromium seccomp sandbox
 Submitter  : Nix 

Re: 3.2-rc2+: Reported regressions from 3.0 and 3.1

2011-11-21 Thread Ari Savolainen
2011/11/22 Linus Torvalds torva...@linux-foundation.org:
 On Mon, Nov 21, 2011 at 1:49 PM, Rafael J. Wysocki r...@sisk.pl wrote:

 Subject    : lockdep warning after aa6afca5bcab: proc: fix races against 
 execve() of /proc/PID/fd**
 Submitter  : Ari Savolainen ari.m.savolai...@gmail.com
 Date       : 2011-11-08 3:47
 Message-ID : 
 caebykaxyzefhtgwmm2afawq2saxyuo_yptnw+6avwscoysc...@mail.gmail.com
 References : http://marc.info/?l=linux-kernelm=132072413125099w=2

 Commit aa6afca5bcab was reverted by commit 5e442a493fc5, so this one
 is presumably stale.

                      Linus

Yes, this went away after the reversion.

Ari
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel


Re: 3.2-rc2+: Reported regressions from 3.0 and 3.1

2011-11-21 Thread Andrew Morton
On Tue, 22 Nov 2011 11:19:24 +0530 Srivatsa S. Bhat 
srivatsa.b...@linux.vnet.ibm.com wrote:

  Subject: khugepaged blocks suspend2ram (3.2.0-rc1-00252-g8f042aa)
  Submitter  : Sergei Trofimovich sly...@gmail.com
  Date   : 2011-11-12 10:48
  Message-ID : 2012104859.7744b...@sf.home
  References : https://lkml.org/lkml/2011/11/12/11
  
 
 Andrea's patch already fixes this issue, which was reported first by
 Jiri Slaby. https://lkml.org/lkml/2011/11/11/93
 I remember Andrew Morton taking this patch in his -mm tree. But it is
 not in mainline yet. So can we consider this closed or not?

grr, nothing in that patch's changelog indicates that it fixed a
regression nor that it fixed an infinite blockage of suspend.

I moved it to my 3.2 queue, thanks.
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel