RE: [PATCH v2 09/10] drm/ttm: Don't count pages in SG BOs against pages_limit

[Errabolu, Ramesh]

[AMD Official Use Only - Internal Distribution Only]

Acked-by: Ramesh Errabolu <ramesh.errab...@amd.com>

-----Original Message-----
From: amd-gfx <amd-gfx-boun...@lists.freedesktop.org> On Behalf Of Kuehling, 
Felix
Sent: Wednesday, April 21, 2021 8:31 PM
To: amd-...@lists.freedesktop.org; dri-devel@lists.freedesktop.org
Subject: [PATCH v2 09/10] drm/ttm: Don't count pages in SG BOs against 
pages_limit

Pages in SG BOs were not allocated by TTM. So don't count them against TTM's 
pages limit.

Signed-off-by: Felix Kuehling <felix.kuehl...@amd.com>
---
 drivers/gpu/drm/ttm/ttm_tt.c | 27 ++++++++++++++++++---------
 1 file changed, 18 insertions(+), 9 deletions(-)

diff --git a/drivers/gpu/drm/ttm/ttm_tt.c b/drivers/gpu/drm/ttm/ttm_tt.c index 
5d8820725b75..e8b8c3257392 100644
--- a/drivers/gpu/drm/ttm/ttm_tt.c
+++ b/drivers/gpu/drm/ttm/ttm_tt.c
@@ -317,9 +317,12 @@ int ttm_tt_populate(struct ttm_device *bdev,
        if (ttm_tt_is_populated(ttm))
                return 0;
 
-       atomic_long_add(ttm->num_pages, &ttm_pages_allocated);
-       if (bdev->pool.use_dma32)
-               atomic_long_add(ttm->num_pages, &ttm_dma32_pages_allocated);
+       if (!(ttm->page_flags & TTM_PAGE_FLAG_SG)) {
+               atomic_long_add(ttm->num_pages, &ttm_pages_allocated);
+               if (bdev->pool.use_dma32)
+                       atomic_long_add(ttm->num_pages,
+                                       &ttm_dma32_pages_allocated);
+       }
 
        while (atomic_long_read(&ttm_pages_allocated) > ttm_pages_limit ||
               atomic_long_read(&ttm_dma32_pages_allocated) > @@ -350,9 +353,12 
@@ int ttm_tt_populate(struct ttm_device *bdev,
        return 0;
 
 error:
-       atomic_long_sub(ttm->num_pages, &ttm_pages_allocated);
-       if (bdev->pool.use_dma32)
-               atomic_long_sub(ttm->num_pages, &ttm_dma32_pages_allocated);
+       if (!(ttm->page_flags & TTM_PAGE_FLAG_SG)) {
+               atomic_long_sub(ttm->num_pages, &ttm_pages_allocated);
+               if (bdev->pool.use_dma32)
+                       atomic_long_sub(ttm->num_pages,
+                                       &ttm_dma32_pages_allocated);
+       }
        return ret;
 }
 EXPORT_SYMBOL(ttm_tt_populate);
@@ -382,9 +388,12 @@ void ttm_tt_unpopulate(struct ttm_device *bdev, struct 
ttm_tt *ttm)
        else
                ttm_pool_free(&bdev->pool, ttm);
 
-       atomic_long_sub(ttm->num_pages, &ttm_pages_allocated);
-       if (bdev->pool.use_dma32)
-               atomic_long_sub(ttm->num_pages, &ttm_dma32_pages_allocated);
+       if (!(ttm->page_flags & TTM_PAGE_FLAG_SG)) {
+               atomic_long_sub(ttm->num_pages, &ttm_pages_allocated);
+               if (bdev->pool.use_dma32)
+                       atomic_long_sub(ttm->num_pages,
+                                       &ttm_dma32_pages_allocated);
+       }
 
        ttm->page_flags &= ~TTM_PAGE_FLAG_PRIV_POPULATED;  }
--
2.31.1

_______________________________________________
amd-gfx mailing list
amd-...@lists.freedesktop.org
https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.freedesktop.org%2Fmailman%2Flistinfo%2Famd-gfx&amp;data=04%7C01%7Cphilip.yang%40amd.com%7C2c56b6451f56454af1ed08d9052e6395%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637546519067581184%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&amp;sdata=eMVIddYdHMgr4TKyeS1fsjQbYVKvzg5D2EgzreknCEI%3D&amp;reserved=0