Re: [Drizzle-discuss] Contribution In Drizzle
Hi, I already submitted the a merge proposal related to drizzle dump. Is there any specific module or plugin on which I can work ? -- Prachee On Tue, Feb 5, 2013 at 9:21 AM, Vijay Samuel vjsamuel1...@gmail.com wrote: Hey, Please submit a merge proposal if you feel good about your branch and we ll review it. Cheers , -Vijay On Feb 5, 2013 9:13 AM, Prachee Rai pracheer...@gmail.com wrote: Hi, I pushed the branch lp:~prachee/drizzle/drizzle-dumphttps://code.launchpad.net/~prachee/drizzle/drizzle-dump , review it please and tell me what can I do next? On Tue, Feb 5, 2013 at 4:58 AM, Stewart Smith stew...@flamingspork.comwrote: Prachee Rai pracheer...@gmail.com writes: I made the changes related to db_connection in drizzle_dump file. How can I test the functionality ? the drizzledump test should be sufficient, but running the full 'make check' is good to do. -- Stewart Smith ___ Mailing list: https://launchpad.net/~drizzle-discuss Post to : drizzle-discuss@lists.launchpad.net Unsubscribe : https://launchpad.net/~drizzle-discuss More help : https://help.launchpad.net/ListHelp ___ Mailing list: https://launchpad.net/~drizzle-discuss Post to : drizzle-discuss@lists.launchpad.net Unsubscribe : https://launchpad.net/~drizzle-discuss More help : https://help.launchpad.net/ListHelp
Re: [Drizzle-discuss] Contribution In Drizzle
Hi Stewart, I made the changes related to db_connection in drizzle_dump file. How can I test the functionality ? -- Prachee On Fri, Jan 25, 2013 at 10:22 AM, Stewart Smith stew...@flamingspork.comwrote: Prachee Rai pracheer...@gmail.com writes: I just took an overview of dizzledump.cc . I want to know , with word Re-factoring what does you actually mean. Is it convert the whole file in object oriented structure or something else? If we convert it into Class, the other file uses this will get affect with some kind linking problem. That would be for the future. I'm thinking initial step is to simply stop so many places using the global variables and instead have them passed to the functions as parameters. -- Stewart Smith ___ Mailing list: https://launchpad.net/~drizzle-discuss Post to : drizzle-discuss@lists.launchpad.net Unsubscribe : https://launchpad.net/~drizzle-discuss More help : https://help.launchpad.net/ListHelp
Re: [Drizzle-discuss] Contribution In Drizzle
Prachee Rai pracheer...@gmail.com writes: I made the changes related to db_connection in drizzle_dump file. How can I test the functionality ? the drizzledump test should be sufficient, but running the full 'make check' is good to do. -- Stewart Smith pgp41p6_f14TU.pgp Description: PGP signature ___ Mailing list: https://launchpad.net/~drizzle-discuss Post to : drizzle-discuss@lists.launchpad.net Unsubscribe : https://launchpad.net/~drizzle-discuss More help : https://help.launchpad.net/ListHelp
Re: [Drizzle-discuss] Contribution In Drizzle
Hi, I pushed the branch lp:~prachee/drizzle/drizzle-dumphttps://code.launchpad.net/~prachee/drizzle/drizzle-dump , review it please and tell me what can I do next? On Tue, Feb 5, 2013 at 4:58 AM, Stewart Smith stew...@flamingspork.comwrote: Prachee Rai pracheer...@gmail.com writes: I made the changes related to db_connection in drizzle_dump file. How can I test the functionality ? the drizzledump test should be sufficient, but running the full 'make check' is good to do. -- Stewart Smith ___ Mailing list: https://launchpad.net/~drizzle-discuss Post to : drizzle-discuss@lists.launchpad.net Unsubscribe : https://launchpad.net/~drizzle-discuss More help : https://help.launchpad.net/ListHelp
Re: [Drizzle-discuss] Contribution In Drizzle
Hey, Please submit a merge proposal if you feel good about your branch and we ll review it. Cheers , -Vijay On Feb 5, 2013 9:13 AM, Prachee Rai pracheer...@gmail.com wrote: Hi, I pushed the branch lp:~prachee/drizzle/drizzle-dumphttps://code.launchpad.net/~prachee/drizzle/drizzle-dump , review it please and tell me what can I do next? On Tue, Feb 5, 2013 at 4:58 AM, Stewart Smith stew...@flamingspork.comwrote: Prachee Rai pracheer...@gmail.com writes: I made the changes related to db_connection in drizzle_dump file. How can I test the functionality ? the drizzledump test should be sufficient, but running the full 'make check' is good to do. -- Stewart Smith ___ Mailing list: https://launchpad.net/~drizzle-discuss Post to : drizzle-discuss@lists.launchpad.net Unsubscribe : https://launchpad.net/~drizzle-discuss More help : https://help.launchpad.net/ListHelp ___ Mailing list: https://launchpad.net/~drizzle-discuss Post to : drizzle-discuss@lists.launchpad.net Unsubscribe : https://launchpad.net/~drizzle-discuss More help : https://help.launchpad.net/ListHelp
Re: [Drizzle-discuss] Contribution In Drizzle
Prachee Rai pracheer...@gmail.com writes: I am interested to work on databases and like to start contributing in drizzle. I already build the drizzle core on my system, I am unable to figure out a good start point to work. Please suggest me something from where I can start. Hi! We're actually a little devoid of low-hanging-fruit bugs at the moment (which is, of course, a shame and awesome at the same time). However, what could be done is some refactoring of the drizzledump tool (kept mostly in client/drizzledump.cc). It's currently ~1000 lines of code in the main source file, and some of the methods there really shouldn't just depend on global variables and instead take an argument (db_connection is a main one). This is a pretty nice trivial change to get started with. The same goes for drizzledump_data.cc, drizzledump_mysql.cc and drizzledump_drizzle.cc Essentially, the end goal would be to have the functionality of drizzledump be a shared library so we could use it elsewhere (e.g. to bootstrap replication). -- Stewart Smith pgpBI4LIUB803.pgp Description: PGP signature ___ Mailing list: https://launchpad.net/~drizzle-discuss Post to : drizzle-discuss@lists.launchpad.net Unsubscribe : https://launchpad.net/~drizzle-discuss More help : https://help.launchpad.net/ListHelp
Re: [Drizzle-discuss] Contribution In Drizzle
Hi Stewart, I just took an overview of dizzledump.cc . I want to know , with word Re-factoring what does you actually mean. Is it convert the whole file in object oriented structure or something else? If we convert it into Class, the other file uses this will get affect with some kind linking problem. -- Prachee Rai On Fri, Jan 25, 2013 at 9:49 AM, Stewart Smith stew...@flamingspork.comwrote: Prachee Rai pracheer...@gmail.com writes: I am interested to work on databases and like to start contributing in drizzle. I already build the drizzle core on my system, I am unable to figure out a good start point to work. Please suggest me something from where I can start. Hi! We're actually a little devoid of low-hanging-fruit bugs at the moment (which is, of course, a shame and awesome at the same time). However, what could be done is some refactoring of the drizzledump tool (kept mostly in client/drizzledump.cc). It's currently ~1000 lines of code in the main source file, and some of the methods there really shouldn't just depend on global variables and instead take an argument (db_connection is a main one). This is a pretty nice trivial change to get started with. The same goes for drizzledump_data.cc, drizzledump_mysql.cc and drizzledump_drizzle.cc Essentially, the end goal would be to have the functionality of drizzledump be a shared library so we could use it elsewhere (e.g. to bootstrap replication). -- Stewart Smith ___ Mailing list: https://launchpad.net/~drizzle-discuss Post to : drizzle-discuss@lists.launchpad.net Unsubscribe : https://launchpad.net/~drizzle-discuss More help : https://help.launchpad.net/ListHelp
Re: [Drizzle-discuss] Contribution In Drizzle
Prachee Rai pracheer...@gmail.com writes: I just took an overview of dizzledump.cc . I want to know , with word Re-factoring what does you actually mean. Is it convert the whole file in object oriented structure or something else? If we convert it into Class, the other file uses this will get affect with some kind linking problem. That would be for the future. I'm thinking initial step is to simply stop so many places using the global variables and instead have them passed to the functions as parameters. -- Stewart Smith pgpU7ZaXXUVuR.pgp Description: PGP signature ___ Mailing list: https://launchpad.net/~drizzle-discuss Post to : drizzle-discuss@lists.launchpad.net Unsubscribe : https://launchpad.net/~drizzle-discuss More help : https://help.launchpad.net/ListHelp
Re: [Drizzle-discuss] Contribution In Drizzle
Hi Stewart, Thanks for suggesting me some work. I am looking in it . -- Prachee Rai On Fri, Jan 25, 2013 at 10:22 AM, Stewart Smith stew...@flamingspork.comwrote: Prachee Rai pracheer...@gmail.com writes: I just took an overview of dizzledump.cc . I want to know , with word Re-factoring what does you actually mean. Is it convert the whole file in object oriented structure or something else? If we convert it into Class, the other file uses this will get affect with some kind linking problem. That would be for the future. I'm thinking initial step is to simply stop so many places using the global variables and instead have them passed to the functions as parameters. -- Stewart Smith ___ Mailing list: https://launchpad.net/~drizzle-discuss Post to : drizzle-discuss@lists.launchpad.net Unsubscribe : https://launchpad.net/~drizzle-discuss More help : https://help.launchpad.net/ListHelp ___ Mailing list: https://launchpad.net/~drizzle-discuss Post to : drizzle-discuss@lists.launchpad.net Unsubscribe : https://launchpad.net/~drizzle-discuss More help : https://help.launchpad.net/ListHelp
