Re: [Dspace-tech] Changes to ItemTag.java reverting to original code after partial build
Hi all, JSPUI and 1.8.0 I am having an issue with a code change that I have made. I edited ItemTag.java to change the way that certain items appeared in the full item record display. After a full rebuild, all of the changes that I made had taken effect and I considered the task complete, but then after I performed a partial rebuild (just the modules in [dspace-source]/dspace/) my changes were reverted. Upon investigating, I see that the JAR file dspace-api-1.8.0.jar has been recreated with the original code for ItemTag.java. For a partial rebuild I originally ran: D:\dspace-1.8.0-source\dspace mvn clean package D:\dspace-1.8.0-source\dspace\target\dspace-1.8.0-build ant update then I used XCOPY to copy the directories for JSPUI and XMLUI to Tomcat, and restart the server. (JSPUI is the official interface, but we keep both active.) I changed my method and now use ant build_wars instead, which solves the immediate problem, but leaves me confused— How is the JAR file being recreated with the original code? To my knowledge, ItemTag.java only exists in one place in the source code, and I have edited it to include my customizations... Can anyone explain this to me? Thanks for your time. Good-day and be well. Darren Arsenault Programmer Algonquin College 1385 Woodroffe Avenue Ottawa, ON, K2G 1V8 -- Don't let slow site performance ruin your business. Deploy New Relic APM Deploy New Relic app performance management and know exactly what is happening inside your Ruby, Python, PHP, Java, and .NET app Try New Relic at no cost today and get our sweet Data Nerd shirt too! http://p.sf.net/sfu/newrelic-dev2dev ___ DSpace-tech mailing list DSpace-tech@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/dspace-tech
Re: [Dspace-tech] Changes to ItemTag.java reverting to original code after partial build
Hi Darren, I think you're running into the same problem as Amira today: cd [dspace-source]/dspace/ I think this is the culprit - this doesn't do a full rebuild in 1.8.0 and above. Do it from here instead: cd [dspace-source] In short - in 1.8 running mvn package from [dspace-source]/dspace/ does a quick build (modules and somesuch), while running it from [dspace-source] does a full build. This is documented somewhere but I can't find it promptly. You shouldn't need to run the clean target, but it surely doesn't hurt. Regards, ~~helix84 -- Don't let slow site performance ruin your business. Deploy New Relic APM Deploy New Relic app performance management and know exactly what is happening inside your Ruby, Python, PHP, Java, and .NET app Try New Relic at no cost today and get our sweet Data Nerd shirt too! http://p.sf.net/sfu/newrelic-dev2dev ___ DSpace-tech mailing list DSpace-tech@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/dspace-tech
Re: [Dspace-tech] Changes to ItemTag.java reverting to original code after partial build
Here's the documentation that helix84 was looking for with regards to the differences between building DSpace from [dspace-source]/dspace versus building DSpace from [dspace-source] https://wiki.duraspace.org/display/DSDOC18/Advanced+Customisation#AdvancedCustomisation-DSpaceSourceRelease It's also linked to from the 1.7.x - 1.8.x Upgrade instructions: https://wiki.duraspace.org/display/DSDOC18/Upgrading+From+1.7.x+to+1.8.x However, I just realized the Upgrade instructions wrongly say to rebuild from [dspace-source]/dspace/ , when they should say to build from [dspace-source]. Sorry for any confusion, I'll get that corrected immediately! - Tim On 10/4/2012 8:53 AM, helix84 wrote: Hi Darren, I think you're running into the same problem as Amira today: cd [dspace-source]/dspace/ I think this is the culprit - this doesn't do a full rebuild in 1.8.0 and above. Do it from here instead: cd [dspace-source] In short - in 1.8 running mvn package from [dspace-source]/dspace/ does a quick build (modules and somesuch), while running it from [dspace-source] does a full build. This is documented somewhere but I can't find it promptly. You shouldn't need to run the clean target, but it surely doesn't hurt. Regards, ~~helix84 -- Don't let slow site performance ruin your business. Deploy New Relic APM Deploy New Relic app performance management and know exactly what is happening inside your Ruby, Python, PHP, Java, and .NET app Try New Relic at no cost today and get our sweet Data Nerd shirt too! http://p.sf.net/sfu/newrelic-dev2dev ___ DSpace-tech mailing list DSpace-tech@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/dspace-tech -- Don't let slow site performance ruin your business. Deploy New Relic APM Deploy New Relic app performance management and know exactly what is happening inside your Ruby, Python, PHP, Java, and .NET app Try New Relic at no cost today and get our sweet Data Nerd shirt too! http://p.sf.net/sfu/newrelic-dev2dev ___ DSpace-tech mailing list DSpace-tech@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/dspace-tech
Re: [Dspace-tech] Changes to ItemTag.java reverting to original code after partial build
Hi Helix, I think you misunderstood me, I apologize for my lack of clarity. I was describing the way that I do a partial build, that is to say: D:\dspace-1.8.0-source\dspace mvn clean package The full rebuild that I performed was completely successful. Run from D:\dspace-1.8.0-source mvn clean package. After the full rebuild the code worked perfectly—dates were formatted for my timezone, the approrpiate fields were displayed as links, etc. Then I made a change to a JSP (changing the order of menu items in navbar-default.jsp) and performed another partial rebuild to update the JSP. (D:\dspace-1.8.0-source\dspace mvn clean package) The changes to the navbar took effect, but I was surprised to see that the other changes, to the item display, had reverted. I looked at the JAR files in the DSpace directory using a Java decompiler, and my code changes are no longer there. Performing another full rebuild (D:\dspace-1.8.0-source mvn clean package) corrected the item display. Why does this happen? Darren Arsenault Programmer Algonquin College 1385 Woodroffe Avenue Ottawa, ON, K2G 1V8 From: ivan.ma...@gmail.com [ivan.ma...@gmail.com] On Behalf Of helix84 [heli...@centrum.sk] Sent: October-04-12 9:53 AM To: Darren Arsenault Cc: dspace-tech@lists.sourceforge.net Subject: Re: [Dspace-tech] Changes to ItemTag.java reverting to original code after partial build Hi Darren, I think you're running into the same problem as Amira today: cd [dspace-source]/dspace/ I think this is the culprit - this doesn't do a full rebuild in 1.8.0 and above. Do it from here instead: cd [dspace-source] In short - in 1.8 running mvn package from [dspace-source]/dspace/ does a quick build (modules and somesuch), while running it from [dspace-source] does a full build. This is documented somewhere but I can't find it promptly. You shouldn't need to run the clean target, but it surely doesn't hurt. Regards, ~~helix84 -- Don't let slow site performance ruin your business. Deploy New Relic APM Deploy New Relic app performance management and know exactly what is happening inside your Ruby, Python, PHP, Java, and .NET app Try New Relic at no cost today and get our sweet Data Nerd shirt too! http://p.sf.net/sfu/newrelic-dev2dev ___ DSpace-tech mailing list DSpace-tech@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/dspace-tech
