Re: [Dspace-tech] additions module dependency on dspace-api

2015-08-19 Thread Andrea Schweer
Hi Terry,

On 20/08/15 08:45, Terry Brady wrote:
 I am starting our upgrade from DSpace 4 to DSpace 5.

 Our code base contains only the dspace folder rather than the full 
 source distribution (dspace, dspace-api, etc).

 All of our custom code resides in dspace/modules including 
 dspace/modules/additions.

 Our additions module has a compile dependency on dspace-api and will 
 not compile unless dspace-api-5.4-SNAPSHOT.jar has already been 
 installed in the maven repository.

Is there a particular reason you're doing the upgrade work against 
(unreleased, may never happen) version 5.4? Your issue with having to 
build dspace-api separately would go away if you worked against DSpace 
5.3, since maven could then retrieve dspace-api, dspace-xmlui etc from 
maven central. With your code set-up, the DSpace version is set in 
dspace/pom.api.

cheers,
Andrea

-- 
Dr Andrea Schweer
IRR Technical Specialist, ITS Information Systems
The University of Waikato, Hamilton, New Zealand


--
___
DSpace-tech mailing list
DSpace-tech@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/dspace-tech
List Etiquette: https://wiki.duraspace.org/display/DSPACE/Mailing+List+Etiquette


Re: [Dspace-tech] additions module dependency on dspace-api

2015-08-19 Thread Terry Brady
Andrea,

Thank you for the reply.

I merged my code from the dspace-5_x branch rather than from the dspace-5.3
release tag.

I will update my references to version 5.3.

Terry

On Wed, Aug 19, 2015 at 2:28 PM, Andrea Schweer schw...@waikato.ac.nz
wrote:

 Hi Terry,

 On 20/08/15 08:45, Terry Brady wrote:

 I am starting our upgrade from DSpace 4 to DSpace 5.

 Our code base contains only the dspace folder rather than the full source
 distribution (dspace, dspace-api, etc).

 All of our custom code resides in dspace/modules including
 dspace/modules/additions.

 Our additions module has a compile dependency on dspace-api and will not
 compile unless dspace-api-5.4-SNAPSHOT.jar has already been installed in
 the maven repository.


 Is there a particular reason you're doing the upgrade work against
 (unreleased, may never happen) version 5.4? Your issue with having to build
 dspace-api separately would go away if you worked against DSpace 5.3, since
 maven could then retrieve dspace-api, dspace-xmlui etc from maven central.
 With your code set-up, the DSpace version is set in dspace/pom.api.

 cheers,
 Andrea

 --
 Dr Andrea Schweer
 IRR Technical Specialist, ITS Information Systems
 The University of Waikato, Hamilton, New Zealand




-- 
Terry Brady
Applications Programmer Analyst
Georgetown University Library Information Technology
https://www.library.georgetown.edu/lit/code
425-298-5498 (Seattle, WA)
--
___
DSpace-tech mailing list
DSpace-tech@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/dspace-tech
List Etiquette: https://wiki.duraspace.org/display/DSPACE/Mailing+List+Etiquette

[Dspace-tech] additions module dependency on dspace-api

2015-08-19 Thread Terry Brady
I am starting our upgrade from DSpace 4 to DSpace 5.

Our code base contains only the dspace folder rather than the full source
distribution (dspace, dspace-api, etc).

All of our custom code resides in dspace/modules including
dspace/modules/additions.

Our additions module has a compile dependency on dspace-api and will not
compile unless dspace-api-5.4-SNAPSHOT.jar has already been installed in
the maven repository.

I can work around this issue by building the full source instance of DSpace
with mvn install and then running mvn package on my code base.  I do not
remember encountering this issue on prior upgrades.

Here is an excerpt from my additions pom.xml file.  Should I convey this
dependency differently?

  dependency
 groupIdorg.dspace/groupId
 artifactIddspace-api/artifactId
  /dependency
  dependency
 groupIdorg.dspace/groupId
 artifactIddspace-api-lang/artifactId
  /dependency
  dependency
 groupIdjavax.servlet/groupId
 artifactIdservlet-api/artifactId
 scopeprovided/scope
  /dependency

Thanks, Terry

-- 
Terry Brady
Applications Programmer Analyst
Georgetown University Library Information Technology
https://www.library.georgetown.edu/lit/code
425-298-5498 (Seattle, WA)
--
___
DSpace-tech mailing list
DSpace-tech@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/dspace-tech
List Etiquette: https://wiki.duraspace.org/display/DSPACE/Mailing+List+Etiquette