Re: [elinks-dev] do_smb if auth-password contains '@' or '/'?
Kalle Olavi Niemitalo [EMAIL PROTECTED] writes: - Is it possible to have @ or '/' in auth-password, or would they have already been converted to %40 and %2F before do_smb runs? auth-password contains the string as typed by the user in the auth dialog; it is not converted. - If there are multiple @ signs, can libsmbclient parse the URL correctly anyway? No, libsmbclient will try to connect to the wrong server. - Should encode_uri_string be used here instead of add_to_string? Perhaps, but do_smb also calls decode_uri after this. That call should probably be entirely removed. pgpsxq4ZvtSyc.pgp Description: PGP signature ___ elinks-dev mailing list elinks-dev@linuxfromscratch.org http://linuxfromscratch.org/mailman/listinfo/elinks-dev
[elinks-dev] do_smb if auth-password contains '@' or '/'?
In do_smb, we have: add_to_string(string, smb://); add_to_string(string, auth-user); add_char_to_string(string, ':'); add_to_string(string, auth-password); add_char_to_string(string, '@'); add_to_string(string, uri_string); url = string.source; So if there is already '@' or '/' as part of auth-password, then the result seems to become ambiguous. - Is it possible to have @ or '/' in auth-password, or would they have already been converted to %40 and %2F before do_smb runs? - If there are multiple @ signs, can libsmbclient parse the URL correctly anyway? - Should encode_uri_string be used here instead of add_to_string? pgpH5u5tTLGu7.pgp Description: PGP signature ___ elinks-dev mailing list elinks-dev@linuxfromscratch.org http://linuxfromscratch.org/mailman/listinfo/elinks-dev
