Re: [Firebird-devel] CORE-782, CORE-742, Partial CORE-679

[Si Carter]

Hi Roman,

Thanks for the the input.  Whilst my intentions are good, my knowledge of
git is woefully bad, that being said, I have managed to create a pull
request for CORE-782, I will crack on with the rest now.

kind regards

Si

On 20 January 2017 at 05:37, Roman Simakov <roman.sima...@red-soft.ru>
wrote:

> 2017-01-20 2:12 GMT+03:00 Si Carter <s1car...@gmail.com>:
> > What is the best way to attempt to get these submitted into the current
> > build?
>
>
> I guess the best option to share your work is to make a fork of Fb git
> repo and prepare pull request (one per feature).
>
> --
> Roman Simakov
> Red Soft
>
> 
> --
> Check out the vibrant tech community on one of the world's most
> engaging tech sites, SlashDot.org! http://sdm.link/slashdot
> Firebird-Devel mailing list, web interface at
> https://lists.sourceforge.net/lists/listinfo/firebird-devel
>
--
Check out the vibrant tech community on one of the world's most
engaging tech sites, SlashDot.org! http://sdm.link/slashdotFirebird-Devel mailing list, web interface at 
https://lists.sourceforge.net/lists/listinfo/firebird-devel

[Firebird-devel] CORE-782, CORE-742, Partial CORE-679

[Si Carter]

Hi All,

Hopefully I have the right audience, apologies if not,

Some years ago I submitted the above suggestions.  I now have compiled and
tested a solution to most (excluding windows event log) which would still
satisfy my need in ISP for Firebird.

What is the best way to attempt to get these submitted into the current
build?

The easiest solution I have is minor change to gds__log and #define
FB_LOGFILENAME, coupled with changes to inline strings and some constants.

A more complex solutions, which I believe should have minimum impact, would
be to change inline strings, this involves changes to approximately 146
inline strings in multiple files.  But excludes debug string defined in the
following #ifdef's

VIO_trace
DEBUG
DEBUG_PROCS
DEBUG_VAL_VERBOSE
DEBUG_SIMILAR

The solution includes logging successful and unsuccessful login attempts,
which I also believe could be an option within the firebird.conf to prevent
any degradation of speed by adding a new option LogLevel (0 as is
currently, 1 includes login success and failure attempts).

any help appreciated.

regards

Si
--
Check out the vibrant tech community on one of the world's most
engaging tech sites, SlashDot.org! http://sdm.link/slashdotFirebird-Devel mailing list, web interface at 
https://lists.sourceforge.net/lists/listinfo/firebird-devel