Re: [Firebird-devel] Statement::verifyAccess of internal requests

2022-03-02 Thread Dmitry Yemanov

01.03.2022 21:33, Adriano dos Santos Fernandes wrote:


Do we have any good reason to make this method do for internal requests
everything it does for user's statement?

Or could we start it with this?

void Statement::verifyAccess(thread_db* tdbb)
{
if (flags & FLAG_INTERNAL)
return;

...
}


Honestly, I was sure we don't check access for internal requests ;-) As 
I see no need for doing that.



Dmitry


Firebird-Devel mailing list, web interface at 
https://lists.sourceforge.net/lists/listinfo/firebird-devel


Re: [Firebird-devel] Statement::verifyAccess of internal requests

2022-03-02 Thread Alex Peshkoff via Firebird-devel

On 3/1/22 21:33, Adriano dos Santos Fernandes wrote:

Hi!

Do we have any good reason to make this method do for internal requests
everything it does for user's statement?

Or could we start it with this?

void Statement::verifyAccess(thread_db* tdbb)
{
if (flags & FLAG_INTERNAL)
return;

...
}


I do not see usage of internal requests that contradict your suggestion 
in current codebase.





Firebird-Devel mailing list, web interface at 
https://lists.sourceforge.net/lists/listinfo/firebird-devel


[Firebird-devel] Statement::verifyAccess of internal requests

2022-03-01 Thread Adriano dos Santos Fernandes
Hi!

Do we have any good reason to make this method do for internal requests
everything it does for user's statement?

Or could we start it with this?

void Statement::verifyAccess(thread_db* tdbb)
{
if (flags & FLAG_INTERNAL)
return;

...
}


Adriano


Firebird-Devel mailing list, web interface at 
https://lists.sourceforge.net/lists/listinfo/firebird-devel